Author: dpolukhin
Date: Wed Jun 14 04:47:47 2017
New Revision: 305377
URL: http://llvm.org/viewvc/llvm-project?rev=305377&view=rev
Log:
Fix for Itanium mangler issue with templates
Patch by Serge Preis
Differential Revision: https://reviews.llvm.org/D32428
Modified:
cfe/trunk/lib/AST/Itaniu
Author: Dmitry Polukhin
Date: 2020-04-15T06:41:31-07:00
New Revision: cb1ee34e9d32fce84613827693a8ed3aff1d36cf
URL:
https://github.com/llvm/llvm-project/commit/cb1ee34e9d32fce84613827693a8ed3aff1d36cf
DIFF:
https://github.com/llvm/llvm-project/commit/cb1ee34e9d32fce84613827693a8ed3aff1d36cf.dif
Author: Dmitry Polukhin
Date: 2020-06-15T07:40:53-07:00
New Revision: c98c94d85f8591c22f369e8f35142379ba27bb33
URL:
https://github.com/llvm/llvm-project/commit/c98c94d85f8591c22f369e8f35142379ba27bb33
DIFF:
https://github.com/llvm/llvm-project/commit/c98c94d85f8591c22f369e8f35142379ba27bb33.dif
Author: Dmitry Polukhin
Date: 2020-07-09T02:41:58-07:00
New Revision: 9e7fddbd36f567217255c1df1cb816b79f0250af
URL:
https://github.com/llvm/llvm-project/commit/9e7fddbd36f567217255c1df1cb816b79f0250af
DIFF:
https://github.com/llvm/llvm-project/commit/9e7fddbd36f567217255c1df1cb816b79f0250af.dif
Author: Dmitry Polukhin
Date: 2020-04-16T07:27:43-07:00
New Revision: 30d5946db95fa465d7ee6caceb2b1ff191e3727c
URL:
https://github.com/llvm/llvm-project/commit/30d5946db95fa465d7ee6caceb2b1ff191e3727c
DIFF:
https://github.com/llvm/llvm-project/commit/30d5946db95fa465d7ee6caceb2b1ff191e3727c.dif
Author: Dmitry Polukhin
Date: 2020-04-16T09:09:38-07:00
New Revision: a8f85da9f538a400dfea00e4954e403bf5f3269c
URL:
https://github.com/llvm/llvm-project/commit/a8f85da9f538a400dfea00e4954e403bf5f3269c
DIFF:
https://github.com/llvm/llvm-project/commit/a8f85da9f538a400dfea00e4954e403bf5f3269c.dif
Author: Dmitry Polukhin
Date: 2020-04-17T06:17:33-07:00
New Revision: a7afb211dc460bd4cfb2542ad1f9b05876b57ba1
URL:
https://github.com/llvm/llvm-project/commit/a7afb211dc460bd4cfb2542ad1f9b05876b57ba1
DIFF:
https://github.com/llvm/llvm-project/commit/a7afb211dc460bd4cfb2542ad1f9b05876b57ba1.dif
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rsmith.
DmitryPolukhin added subscribers: cfe-commits, andreybokhanko.
Recursive mangling should use all existing substitutions and newly created
substitutions should be copied outer mangler.
This patch should fix PR30401 and
DmitryPolukhin added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:668
@@ -664,3 +667,3 @@
llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf);
CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream);
// Output name of the function
DmitryPolukhin added inline comments.
Comment at: lib/AST/ItaniumMangle.cpp:668
@@ -664,3 +667,3 @@
llvm::raw_svector_ostream FunctionEncodingStream(FunctionEncodingBuf);
CXXNameMangler FunctionEncodingMangler(*this, FunctionEncodingStream);
// Output name of the function
DmitryPolukhin updated this revision to Diff 71778.
DmitryPolukhin marked an inline comment as done.
https://reviews.llvm.org/D24704
Files:
lib/AST/ItaniumMangle.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
Index: test/CodeGenCXX/mangle-abi-tag.cpp
=
DmitryPolukhin added a comment.
Richard, please take another look.
https://reviews.llvm.org/D24704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: dpolukhin
Date: Wed Sep 21 03:27:03 2016
New Revision: 282059
URL: http://llvm.org/viewvc/llvm-project?rev=282059&view=rev
Log:
PR30401: Fix substitutions for functions with abi_tag
Modified:
cfe/trunk/lib/AST/ItaniumMangle.cpp
cfe/trunk/test/CodeGenCXX/mangle-abi-tag.cpp
Modifie
DmitryPolukhin closed this revision.
DmitryPolukhin added a comment.
Committed as https://reviews.llvm.org/rL282059
https://reviews.llvm.org/D24704
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinf
DmitryPolukhin added a comment.
LGTM, added Richard in case he has something to add.
Repository:
rL LLVM
https://reviews.llvm.org/D24932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
DmitryPolukhin accepted this revision.
DmitryPolukhin added a comment.
This revision is now accepted and ready to land.
I think we need to fix this regression.
Repository:
rL LLVM
https://reviews.llvm.org/D24932
___
cfe-commits mailing list
cfe-c
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/75753
Summary:
After https://reviews.llvm.org/D143436 response files stopped working with CDB
interpolation. It has happened because interpolation removes all unknwn flags
and extra input files. Response file is t
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/75753
>From 957951483dab19b0982a5dbe7d5370bd9061d931 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Sun, 17 Dec 2023 14:11:11 -0800
Subject: [PATCH 1/2] [clangd] Expand response files before CDB interpolation
dmpolukhin wrote:
@HighCommander4 PTAL
https://github.com/llvm/llvm-project/pull/75753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin edited
https://github.com/llvm/llvm-project/pull/75753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/75753
>From 957951483dab19b0982a5dbe7d5370bd9061d931 Mon Sep 17 00:00:00 2001
From: Dmitry Polukhin
Date: Sun, 17 Dec 2023 14:11:11 -0800
Subject: [PATCH 1/3] [clangd] Expand response files before CDB interpolation
dmpolukhin wrote:
@ldionne if downstream is catching upstream, I would love to discuss rationale
behind ignoring command line option. I asked this question several times and
haven't got answer. Original [diff](https://reviews.llvm.org/D89001) that
introduced this behavior also didn't explain w
dmpolukhin wrote:
> So the intent of the current ordering was to allow creating a toolchain by
> placing the libc++ headers alongside Clang, as is typically done (and
> exceptionally not done on Apple platforms). On Apple platforms, you basically
> always specify a sysroot, either explicitly o
dmpolukhin wrote:
I'm not an expert in Hungarian naming but from what I know changes looks good
to me. Just nit in release notes.
https://github.com/llvm/llvm-project/pull/84236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -229,7 +229,8 @@ Changes in existing checks
- Improved :doc:`readability-identifier-naming
` check in
`GetConfigPerFile`
- mode by resolving symbolic links to header files.
+ mode by resolving symbolic links to header files. Fixed handling of Hungarian
@@ -229,7 +229,8 @@ Changes in existing checks
- Improved :doc:`readability-identifier-naming
` check in
`GetConfigPerFile`
- mode by resolving symbolic links to header files.
+ mode by resolving symbolic links to header files. Fixed handling of Hungarian
@@ -229,7 +229,8 @@ Changes in existing checks
- Improved :doc:`readability-identifier-naming
` check in
`GetConfigPerFile`
- mode by resolving symbolic links to header files.
+ mode by resolving symbolic links to header files. Fixed handling of Hungarian
https://github.com/dmpolukhin approved this pull request.
https://github.com/llvm/llvm-project/pull/84236
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin updated
https://github.com/llvm/llvm-project/pull/79466
>From 67a266e7bc5682d5f674c0424858ba86f7c9a192 Mon Sep 17 00:00:00 2001
From: Kugan <34810920+kug...@users.noreply.github.com>
Date: Tue, 31 Oct 2023 12:12:10 +
Subject: [PATCH] Apply format only if --forma
dmpolukhin wrote:
@AaronBallman @bcardosolopes please take a look.
https://github.com/llvm/llvm-project/pull/79466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/79466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpolukhin closed
https://github.com/llvm/llvm-project/pull/70801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dmpolukhin wrote:
Pushed as https://github.com/llvm/llvm-project/pull/79466
https://github.com/llvm/llvm-project/pull/70801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dmpolukhin wrote:
@ldionne I also haven't see Apple compiler that matches upstream behavior. In
https://reviews.llvm.org/D157283#4648242, you mentioned that "Xcode 15 RC"
should be such compiler and checked it and couple version after that and none
of them matched upstream so I decided to wait
dmpolukhin wrote:
@ldionne what about fixing upstream behavior to match actual system compiler
behavior now and when/as soon as we have new behavior in Apple compiler fix it
again in newer clang versions? Moreover as I pointed out Apple compiler
behavior is problematic for clang-tools and clan
https://github.com/dmpolukhin created
https://github.com/llvm/llvm-project/pull/79466
clang-apply-replacements used to apply format even without --format is
specified. This because, methods like createReplacementsForHeaders only takes
the Spec.Style and would re-order the headers even when it
dmpolukhin wrote:
@kuganv do you have cycles to work on this issue? If not, I can commandeer this
pull requests and update release notes. Please let me know what is your
preference.
https://github.com/llvm/llvm-project/pull/70801
___
cfe-commits mail
Author: Dmitry Polukhin
Date: 2020-10-23T13:20:18+01:00
New Revision: 55a2deed075b87646db62abc7bcd476541eda403
URL:
https://github.com/llvm/llvm-project/commit/55a2deed075b87646db62abc7bcd476541eda403
DIFF:
https://github.com/llvm/llvm-project/commit/55a2deed075b87646db62abc7bcd476541eda403.dif
Author: Hiral Oza
Date: 2020-11-03T11:59:46Z
New Revision: d6a468d622b2d48c40c47290aa54d6d910c5a6bf
URL:
https://github.com/llvm/llvm-project/commit/d6a468d622b2d48c40c47290aa54d6d910c5a6bf
DIFF:
https://github.com/llvm/llvm-project/commit/d6a468d622b2d48c40c47290aa54d6d910c5a6bf.diff
LOG: [cl
Author: Dmitry Polukhin
Date: 2021-05-31T01:57:36-07:00
New Revision: 37b530a2ea8bdc28a22a3f8ca701455fb7febdea
URL:
https://github.com/llvm/llvm-project/commit/37b530a2ea8bdc28a22a3f8ca701455fb7febdea
DIFF:
https://github.com/llvm/llvm-project/commit/37b530a2ea8bdc28a22a3f8ca701455fb7febdea.dif
Author: Dmitry Polukhin
Date: 2021-06-03T01:37:55-07:00
New Revision: 178ad93e3f1f2381f05baea300873ee5998ac288
URL:
https://github.com/llvm/llvm-project/commit/178ad93e3f1f2381f05baea300873ee5998ac288
DIFF:
https://github.com/llvm/llvm-project/commit/178ad93e3f1f2381f05baea300873ee5998ac288.dif
Author: Dmitry Polukhin
Date: 2021-06-07T03:05:00-07:00
New Revision: aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8
URL:
https://github.com/llvm/llvm-project/commit/aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8
DIFF:
https://github.com/llvm/llvm-project/commit/aa0d7179bbb3fd24bc9eb1fd6203565dbd50e8d8.dif
Author: Ivan Murashko
Date: 2021-06-11T02:02:36-07:00
New Revision: 47d138c93992f779a5dd0810b0e7402e043df61d
URL:
https://github.com/llvm/llvm-project/commit/47d138c93992f779a5dd0810b0e7402e043df61d
DIFF:
https://github.com/llvm/llvm-project/commit/47d138c93992f779a5dd0810b0e7402e043df61d.diff
Author: Ivan Murashko
Date: 2021-07-30T12:40:38+03:00
New Revision: 8eaa05d06161db69e68ff2a5f4c8e3545a4e8080
URL:
https://github.com/llvm/llvm-project/commit/8eaa05d06161db69e68ff2a5f4c8e3545a4e8080
DIFF:
https://github.com/llvm/llvm-project/commit/8eaa05d06161db69e68ff2a5f4c8e3545a4e8080.diff
Author: Dmitry Polukhin
Date: 2021-06-30T01:07:47-07:00
New Revision: fceaf8621179aa758c44f3eaee02d789abfd455b
URL:
https://github.com/llvm/llvm-project/commit/fceaf8621179aa758c44f3eaee02d789abfd455b
DIFF:
https://github.com/llvm/llvm-project/commit/fceaf8621179aa758c44f3eaee02d789abfd455b.dif
Author: Dmitry Polukhin
Date: 2021-03-15T07:32:45-07:00
New Revision: da55af7f1d348c133774d8e8117d60462363fef5
URL:
https://github.com/llvm/llvm-project/commit/da55af7f1d348c133774d8e8117d60462363fef5
DIFF:
https://github.com/llvm/llvm-project/commit/da55af7f1d348c133774d8e8117d60462363fef5.dif
Author: Dmitry Polukhin
Date: 2022-09-17T07:37:19-07:00
New Revision: 133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d
URL:
https://github.com/llvm/llvm-project/commit/133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d
DIFF:
https://github.com/llvm/llvm-project/commit/133b6d7db90d9b52b01e8e09e1aa8fb8d2da0f9d.dif
Author: Dmitry Polukhin
Date: 2022-09-20T02:05:36-07:00
New Revision: 41dbee1e66937fe7d579b73d30dc790cd79b8738
URL:
https://github.com/llvm/llvm-project/commit/41dbee1e66937fe7d579b73d30dc790cd79b8738
DIFF:
https://github.com/llvm/llvm-project/commit/41dbee1e66937fe7d579b73d30dc790cd79b8738.dif
Author: Dmitry Polukhin
Date: 2022-10-12T02:03:56-07:00
New Revision: 5d12b13b0b26bc58b02ee23c369da8b83240cceb
URL:
https://github.com/llvm/llvm-project/commit/5d12b13b0b26bc58b02ee23c369da8b83240cceb
DIFF:
https://github.com/llvm/llvm-project/commit/5d12b13b0b26bc58b02ee23c369da8b83240cceb.dif
Author: Dmitry Polukhin
Date: 2023-08-23T18:10:18+01:00
New Revision: f24aa691aa4f25291db8f7c61c6e9007288859e7
URL:
https://github.com/llvm/llvm-project/commit/f24aa691aa4f25291db8f7c61c6e9007288859e7
DIFF:
https://github.com/llvm/llvm-project/commit/f24aa691aa4f25291db8f7c61c6e9007288859e7.dif
Author: Dmitry Polukhin
Date: 2023-07-12T00:57:41-07:00
New Revision: 6d9fcc2ad874e4ee9b94eef4b85ffece18e501b1
URL:
https://github.com/llvm/llvm-project/commit/6d9fcc2ad874e4ee9b94eef4b85ffece18e501b1
DIFF:
https://github.com/llvm/llvm-project/commit/6d9fcc2ad874e4ee9b94eef4b85ffece18e501b1.dif
Author: Dmitry Polukhin
Date: 2020-01-23T16:29:08-08:00
New Revision: 301a437250b03de021e6da12a8e4a927ef48881e
URL:
https://github.com/llvm/llvm-project/commit/301a437250b03de021e6da12a8e4a927ef48881e
DIFF:
https://github.com/llvm/llvm-project/commit/301a437250b03de021e6da12a8e4a927ef48881e.dif
Author: Dmitry Polukhin
Date: 2020-01-24T13:00:45-08:00
New Revision: 3f8b100e94b5c848843fa91c9782d9d4df4bb026
URL:
https://github.com/llvm/llvm-project/commit/3f8b100e94b5c848843fa91c9782d9d4df4bb026
DIFF:
https://github.com/llvm/llvm-project/commit/3f8b100e94b5c848843fa91c9782d9d4df4bb026.dif
Author: Dmitry Polukhin
Date: 2023-03-16T02:19:11-07:00
New Revision: b293c6280d06f49c5ca7290855911341ab0bdffa
URL:
https://github.com/llvm/llvm-project/commit/b293c6280d06f49c5ca7290855911341ab0bdffa
DIFF:
https://github.com/llvm/llvm-project/commit/b293c6280d06f49c5ca7290855911341ab0bdffa.dif
Author: Dmitry Polukhin
Date: 2023-03-17T03:10:36-07:00
New Revision: d60d3455eb2b375d026a4aa74c4ba0c38f5d323c
URL:
https://github.com/llvm/llvm-project/commit/d60d3455eb2b375d026a4aa74c4ba0c38f5d323c
DIFF:
https://github.com/llvm/llvm-project/commit/d60d3455eb2b375d026a4aa74c4ba0c38f5d323c.dif
Author: Dmitry Polukhin
Date: 2023-03-13T06:08:22-07:00
New Revision: 34de7da6246cdfa6ff6f3d3c514583cddc0a10ec
URL:
https://github.com/llvm/llvm-project/commit/34de7da6246cdfa6ff6f3d3c514583cddc0a10ec
DIFF:
https://github.com/llvm/llvm-project/commit/34de7da6246cdfa6ff6f3d3c514583cddc0a10ec.dif
Author: Dmitry Polukhin
Date: 2023-03-13T07:00:56-07:00
New Revision: 2a84c53ccdc015a7f53a144aa4f7c0dddf839604
URL:
https://github.com/llvm/llvm-project/commit/2a84c53ccdc015a7f53a144aa4f7c0dddf839604
DIFF:
https://github.com/llvm/llvm-project/commit/2a84c53ccdc015a7f53a144aa4f7c0dddf839604.dif
DmitryPolukhin added a comment.
Hi Hans, it seems that you've just created release branch for 3.9 and this
patch should go directly to the branch, right? If so could you please commit
this patch for me because I'm working with git-svn and there is no instruction
how to work with release LLVM br
DmitryPolukhin added inline comments.
Comment at: test/CodeGenCXX/dllimport-rtti.cpp:7
@@ -6,3 +6,1 @@
} s;
-// MSVC: [[VF_S:.*]] = private unnamed_addr constant [2 x i8*]
-// MSVC-DAG: @"\01??_SS@@6B@" = unnamed_addr alias i8*, getelementptr inbounds
([2 x i8*], [2 x i8*]* [[VF
Author: dpolukhin
Date: Tue Jul 19 06:29:16 2016
New Revision: 275970
URL: http://llvm.org/viewvc/llvm-project?rev=275970&view=rev
Log:
Deprecated (legacy) string literal conversion to 'char *' causes strange
overloading resolution
It's a patch for PR28050. Seems like overloading resolution wipe
DmitryPolukhin added a subscriber: DmitryPolukhin.
DmitryPolukhin closed this revision.
DmitryPolukhin added a comment.
Committed as https://reviews.llvm.org/rL275970
https://reviews.llvm.org/D21228
___
cfe-commits mailing list
cfe-commits@lists.llv
Author: dpolukhin
Date: Tue Jul 19 08:35:15 2016
New Revision: 275974
URL: http://llvm.org/viewvc/llvm-project?rev=275974&view=rev
Log:
Fix for failing bot sanitizer-x86_64-linux-fast after r275970
More info
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/14774/steps/check-c
DmitryPolukhin updated this revision to Diff 46644.
DmitryPolukhin added a comment.
Use EOF token instead of copy buffer. This approach looks a bit more fragile
but definitely more efficient, PTAL.
http://reviews.llvm.org/D16572
Files:
lib/Parse/ParseExprCXX.cpp
test/Parser/cxx-ambig-paren
DmitryPolukhin added a comment.
I think Sema part should be exacted to separate patch and committed first after
fixing Aaron's comments. Mangling part requires more work and much more tests.
I'm still looking what actually GCC does and how it can be re-implemented in
Clang without calling mangl
DmitryPolukhin added a comment.
Hi Stefan,
What are your plans about this patch? The patch has number of comments about
Sema part from Aaron and me but in general there are no major issues with Sema
for the attribute.
As for mangling part I think recursive approach looks reasonable because
al
DmitryPolukhin added a comment.
John, this patch extends check that I added recently and looks good to me but
could you please also take a look.
http://reviews.llvm.org/D17023
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: ABataev.
DmitryPolukhin added a subscriber: cfe-commits.
New implementation is easier to read and extend.
http://reviews.llvm.org/D17197
Files:
lib/Parse/ParseOpenMP.cpp
Index: lib/Parse/ParseOpenMP.cpp
===
Author: dpolukhin
Date: Sat Feb 13 00:53:38 2016
New Revision: 260811
URL: http://llvm.org/viewvc/llvm-project?rev=260811&view=rev
Log:
[OPENMP] NFC rewrite ParseOpenMPDirectiveKind
New implementation is easier to read and extend.
Differential Revision: http://reviews.llvm.org/D17197
Modified:
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: aaron.ballman.
DmitryPolukhin added subscribers: cfe-commits, stbuehler.
Original patch by Stefan Bühler http://reviews.llvm.org/D12834
Difference between original and this one:
- fixed all comments in original code review
- a
via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> As noted in PR27337, this only occurs in one WTL sample, and we have no
>>> evidence that it actually occurs in real code. Have you seen uses of this
>>> in the wild? We generally don't want
DmitryPolukhin added a comment.
In http://reviews.llvm.org/D18641#413277, @rsmith wrote:
> I'm a little concerned about the possibility of this breaking uses of this
> feature on platforms where Clang is the system compiler. For instance, this
> pattern would be broken by your change:
>
> //
So it seems that there is an agreement that Clang don't need this MSVC
"feature" so I'll revert my patch tomorrow when I get to the office.
On Wed, Apr 27, 2016 at 10:09 PM, Stephan T. Lavavej <
s...@exchange.microsoft.com> wrote:
> [Richard Smith]
> > You can find a description of the problem in
Author: dpolukhin
Date: Thu Apr 28 04:56:22 2016
New Revision: 267865
URL: http://llvm.org/viewvc/llvm-project?rev=267865&view=rev
Log:
Revert "[MSVC] PR27337: allow static_cast from private base to derived for WTL"
This reverts commit r267534.
Removed:
cfe/trunk/test/SemaCXX/ext_ms_downcast
Reverted in r267865.
On Wed, Apr 27, 2016 at 10:31 PM, Dmitry Polukhin wrote:
> So it seems that there is an agreement that Clang don't need this MSVC
> "feature" so I'll revert my patch tomorrow when I get to the office.
>
> On Wed, Apr 27, 2016 at 10:09 PM, Stephan T. Lavavej <
> s...@exchange
DmitryPolukhin added a comment.
Richard, could you please share your counterexample so I could test it on my
patch and GCC?
As for separate pass, it was my first reaction on the original patch from
Stefan but soon I realized that I'll have to copy parts of magnler to some
simplified mangler bu
On Wed, May 4, 2016 at 12:26 AM, Richard Smith
wrote:
> On Tue, May 3, 2016 at 12:51 PM, Dmitry Polukhin via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> DmitryPolukhin added a comment.
>>
>> Richard, could you please share your counterexample so I cou
DmitryPolukhin updated this revision to Diff 56116.
DmitryPolukhin added a comment.
+ rebase
+ added testcase with Richard's example
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/SemaCXX/attr-abi-tag-syn
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: ABataev.
DmitryPolukhin added a subscriber: cfe-commits.
Support OpenMP version 4.5 syntax for #pragma omp declare target.
Syntax:
#pragma omp declare target (extended-list) new-line
or
#pragma omp declare target clause[ [
DmitryPolukhin added a comment.
Thank you for reporting this issue, I'll take a look.
I'm mostly testing on x86_64 so I may not notice the problem.
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.l
DmitryPolukhin updated this revision to Diff 56581.
DmitryPolukhin added a comment.
- fixed tests for i686 when function may have hidden parameter
http://reviews.llvm.org/D18035
Files:
lib/AST/ItaniumMangle.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGenCXX/mangle-abi-tag.cpp
test/SemaCXX/at
Author: dpolukhin
Date: Mon May 9 09:59:13 2016
New Revision: 268925
URL: http://llvm.org/viewvc/llvm-project?rev=268925&view=rev
Log:
[OpenMP] Parse+Sema for '#pragma omp declare target' syntax version 4.5
Support OpenMP version 4.5 syntax for #pragma omp declare target.
Syntax:
#pragma omp
DmitryPolukhin added a comment.
Richard, friendly ping. It seems that your counterexample cause no issue with
this patch. I added tests to prove it. Could you please take another look?
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe
Author: dpolukhin
Date: Fri May 13 04:03:56 2016
New Revision: 269400
URL: http://llvm.org/viewvc/llvm-project?rev=269400&view=rev
Log:
[ms][dll] #27212: Generating of implicit special members should take into
account MSVC compatibility version
Clang creates implicit move constructor/assign oper
DmitryPolukhin closed this revision.
DmitryPolukhin added a comment.
Committed as http://reviews.llvm.org/rL269400
http://reviews.llvm.org/D19156
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
DmitryPolukhin added a comment.
One more friendly ping.. :(
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rnk.
DmitryPolukhin added a subscriber: cfe-commits.
Clang doesn't dllexport defaulted special member function defaulted inside
class but does it if they defaulted outside class. MSVC doesn't make any
distinction where they w
DmitryPolukhin updated this revision to Diff 57896.
DmitryPolukhin marked 2 inline comments as done.
DmitryPolukhin added a comment.
Comments resolved, PTAL.
http://reviews.llvm.org/D20422
Files:
lib/Sema/SemaDeclCXX.cpp
test/CodeGenCXX/dllexport-members.cpp
test/CodeGenCXX/dllexport.cpp
DmitryPolukhin added inline comments.
Comment at: lib/Sema/SemaDeclCXX.cpp:13111
@@ -13090,3 +13110,3 @@
llvm_unreachable("Invalid special member.");
}
} else {
rnk wrote:
> Can we add `if (InClassDef) ActOnFinishInlineFunctionDef(MD);` here instead
DmitryPolukhin added a comment.
Friendly ping, please take a look!
http://reviews.llvm.org/D18035
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DmitryPolukhin updated this revision to Diff 52070.
DmitryPolukhin added a comment.
- Added test for templates in declare target region
http://reviews.llvm.org/D18542
Files:
include/clang/AST/ASTMutationListener.h
include/clang/AST/Attr.h
include/clang/Basic/Attr.td
include/clang/Basic/
DmitryPolukhin added a comment.
Aaron,
Could you please take a look to OMPDeclareTargetDecl attribute implementation
and printPrettyEnd approach in general?
For post print mechanism alternative approach is to use ad hoc solution in
DeclPrinter.
Thanks,
Dmitry
Software Engineer
Intel Compiler
DmitryPolukhin created this revision.
DmitryPolukhin added a reviewer: rsmith.
DmitryPolukhin added a subscriber: cfe-commits.
GCC clears current search position in the include directories list used
for #include_next if current header was found using relative paths.
Before this patch Clang kept cu
Author: dpolukhin
Date: Fri Apr 1 04:52:30 2016
New Revision: 265123
URL: http://llvm.org/viewvc/llvm-project?rev=265123&view=rev
Log:
[OPENMP] Avoid useless recursive calls in getDSA if it is called in a loop, NFC
Modified:
cfe/trunk/lib/Sema/SemaOpenMP.cpp
Modified: cfe/trunk/lib/Sema/Sem
DmitryPolukhin updated this revision to Diff 52349.
DmitryPolukhin marked an inline comment as done.
DmitryPolukhin added a comment.
- implemented ad hoc solution for printing
- added documentation for the attrbute
- reabse
In http://reviews.llvm.org/D18542#388241, @aaron.ballman wrote:
> If you
DmitryPolukhin added a comment.
Alexey, please review OpenMP specific things.
Aaron, are you OK with the attribute implementation and printing approach?
http://reviews.llvm.org/D18542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
DmitryPolukhin updated this revision to Diff 52690.
DmitryPolukhin marked 8 inline comments as done.
DmitryPolukhin added a comment.
- fixed all comments
- rebase
Aaron and Alexey, thank you for the review!
http://reviews.llvm.org/D18542
Files:
include/clang/AST/ASTMutationListener.h
inclu
Author: dpolukhin
Date: Wed Apr 6 06:38:59 2016
New Revision: 265530
URL: http://llvm.org/viewvc/llvm-project?rev=265530&view=rev
Log:
[OPENMP] Parsing and Sema support for 'omp declare target' directive
Add parsing, sema analysis for 'declare target' construct for OpenMP 4.0
(4.5 support will b
DmitryPolukhin closed this revision.
DmitryPolukhin added a comment.
Committed as http://reviews.llvm.org/rL265530
http://reviews.llvm.org/D18542
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/
DmitryPolukhin updated this revision to Diff 52906.
DmitryPolukhin added a comment.
- rebase after committing llvm patch
http://reviews.llvm.org/D15524
Files:
include/clang/AST/DeclBase.h
include/clang/Basic/Attr.td
include/clang/Basic/AttrDocs.td
include/clang/Basic/DiagnosticSemaKinds
DmitryPolukhin added a comment.
Richard, Reid and David,
Friendly ping, please take a look to this patch. If there are no more
comments/suggestion, I think it is better to commit this patch iterate on GCC
abi_tag support based on users' feedback.
http://reviews.llvm.org/D18035
1 - 100 of 375 matches
Mail list logo
