[PATCH] D90835: [clang-tidy] Ignore diagnostics due to macro expansion from not-interested headers

DmitryPolukhin added a comment. In D90835#2808153 , @lebedev.ri wrote: > This needs to explain why the existing functionality isn't sufficient - if > the header is really not from this project, > then it should be included via `-isystem`, and that will na

[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

DmitryPolukhin accepted this revision. DmitryPolukhin added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104021/new/ https://reviews.llvm.org/D104021 _

[PATCH] D104021: [clang-tidy] LIT test fix for Remark diagnostic

This revision was automatically updated to reflect the committed changes. Closed by commit rG47d138c93992: [clang-tidy] LIT test fix for Remark diagnostic (authored by ivanmurashko, committed by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D106583: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8eaa05d06161: [clang] SIGSEGV at DeduceTemplateArgumentsByTypeMatch (authored by ivanmurashko, committed by DmitryPolukhin). Repository: rG LLVM

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: kadircet, lh123, sammccall, hokein, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added a subscriber: usaxena95. DmitryPolukhin requested review of this revision. Compilation database might have

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin updated this revision to Diff 355233. DmitryPolukhin added a comment. Replace tab with spaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105120/new/ https://reviews.llvm.org/D105120 Files: clang/lib/Tooling/ExpandResponseFilesC

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

DmitryPolukhin updated this revision to Diff 355261. DmitryPolukhin added a comment. Fix clang-tidy style warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105120/new/ https://reviews.llvm.org/D105120 Files: clang/lib/Tooling/ExpandResponseF

[PATCH] D105120: [clang] Fix UB when string.front() is used for the empty string

This revision was automatically updated to reflect the committed changes. Closed by commit rGfceaf8621179: [clang] Fix UB when string.front() is used for the empty string (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: hokein, aaron.ballman, alexfh, JonasToth, njames93. DmitryPolukhin added a project: clang. Herald added a subscriber: xazax.hun. DmitryPolukhin requested review of this revision. For some reason the initial implementation of th

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 326734. DmitryPolukhin added a comment. Comments resolved Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files: clang-tools-extra/clang-tidy/modernize/ConcatN

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. @njames93 thank you for quick response and good suggestion! Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-concat-nested-namespaces.cpp:4 +// RUN: FileCheck -input-file=%T/modern

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 326888. DmitryPolukhin added a comment. Use -DAG checks to make test stable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files: clang-tools-extra/clang-tidy

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin added a comment. @aaron.ballman @alexfh @njames93 - friendly ping, please take a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 ___ cfe-comm

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 330578. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files: clang-tools-extra/clang-tidy/modernize/ConcatNestedNamesp

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin added a comment. In D97563#2624680 , @njames93 wrote: > Is DAG required because the header file warnings are printed in a different > order depending on things like platform? @njames93 Thank you for review! Yes, on Windows build bot showed

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

DmitryPolukhin updated this revision to Diff 330596. DmitryPolukhin added a comment. Rebase again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97563/new/ https://reviews.llvm.org/D97563 Files: clang-tools-extra/clang-tidy/modernize/ConcatNested

[PATCH] D97563: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers

This revision was automatically updated to reflect the committed changes. Closed by commit rGda55af7f1d34: [clang-tidy] Enable modernize-concat-nested-namespaces also on headers (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

This revision was automatically updated to reflect the committed changes. Closed by commit rG133b6d7db90d: [clang][C++20] Fix clang/clangd assert/crash after compilation errors (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628)

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: aaron.ballman, Tyker. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a project: clang. Update ReleaseNotes about a crash fix (Issue 53628) Test Plan: none Repository: rG LLVM Git

[PATCH] D133948: [clang][C++20] Fix clang/clangd assert/crash after compilation errors

DmitryPolukhin added a comment. In D133948#3793085 , @aaron.ballman wrote: > LGTM! Please add a release note for the fix when you land the changes. Thank you for prompt review! Release notes update in D134112 . Also I

[PATCH] D134112: [clang] Update ReleaseNotes about a crash fix (Issue 53628)

This revision was automatically updated to reflect the committed changes. Closed by commit rG41dbee1e6693: [clang] Update ReleaseNotes about a crash fix (Issue 53628) (authored by DmitryPolukhin). Changed prior to commit: https://reviews.llvm.org/D134112?vs=461009&id=461514#toc Repository: r

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: njames93, klimek. DmitryPolukhin added a project: clang-tools-extra. Herald added subscribers: carlosgalvezp, xazax.hun. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber: cf

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin updated this revision to Diff 466037. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367/new/ https://reviews.llvm.org/D135367 Files: clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsume

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin updated this revision to Diff 466767. DmitryPolukhin added a comment. Added testcase for clang-tidy diagnostics as with --warnings-as-errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367/new/ https://reviews.llvm.org/D135367

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

DmitryPolukhin added a comment. In D135367#3842950 , @njames93 wrote: > LGTM, just maybe include a test case where a warning from a clang-tidy check > is promoted to an error as well. Thank you for the review! I've added a test case for clang-tidy check

[PATCH] D135367: [clang-tidy] Dump effective diagnostics level in YAML output

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d12b13b0b26: [clang-tidy] Dump effective diagnostics level in YAML output (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135367

[PATCH] D143436: [clangd] Apply standard adaptors to CDBs pushed from LSP

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: sammccall, ilya-biryukov. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: s.egerton, kadircet, arphaman, simoncook. Herald added a project: All. DmitryPolukhin requested review of this revision.

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. In D157283#4648242 , @ldionne wrote: > As explained in https://reviews.llvm.org/D89001#4648241, upstream Clang is > the way it should be right now. The intent is that we first look along the > `clang` binary for headers (

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne, @arphaman and @jroelofs, friendly ping, could you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283

[PATCH] D158519: [clangd] Move diagnostics from modules to main sources file

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: adamcz, sammccall, kadircet. DmitryPolukhin added a project: clang. Herald added subscribers: arphaman, javed.absar. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added subscribers: MaskRay

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rGf24aa691aa4f: [clang] Match -isysroot behaviour with system compiler on Darwin (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

DmitryPolukhin added a comment. Herald added a subscriber: MaskRay. Herald added a project: All. @ldionne and @dexonsmith, it seems that this diff breaks clang-tools like clang-tidy and clangd if `-isysroot` is specified in the compilation database. Moreover, clang from Xcode 14 and 15 uses path

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: ldionne, dexonsmith, MaskRay. DmitryPolukhin added a project: clang. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber: cfe-commits. See discussion in https://reviews.llvm.o

[PATCH] D89001: [clang] Don't look into for C++ headers if they are found alongside the toolchain

DmitryPolukhin added a comment. @dexonsmith thank you for quick response. I think we need to update upstream behaviour to match system compiler behaviour otherwise clang-tools that uses path to compiler binary form CDB will not work as expected and extra options won't help much because it is no

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin updated this revision to Diff 547825. DmitryPolukhin added a comment. Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157283/new/ https://reviews.llvm.org/D157283 Files: clang/lib/Driver/ToolChains/Darwin.cpp clang

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: yaxunl, tra, MaskRay. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. DmitryPolukhin published this revision for review. Herald added subscribers

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 537774. DmitryPolukhin added a comment. Rebase and uun clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang-tools-extra/clangd/unittests

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:1274 if (Arg *A = Args.getLastArg(options::OPT_gsplit_dwarf_EQ)) -if (StringRef(A->getValue()) == "single") +if (StringRef(A->getValue()) == "single" && Output.isFilename())

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539131. DmitryPolukhin added a comment. Moved test to clang/unittests/Driver/ToolChainTest.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/l

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added a comment. In D154602#4483600 , @MaskRay wrote: > Thanks for the patch! But I share the concern that the test is added to a > wrong layer > (https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer). >

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539223. DmitryPolukhin added a comment. Added -target arm-linux-gnueabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/lib/Driver/ToolChains/Co

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539281. DmitryPolukhin added a comment. Use --target=arm-linux-gnueabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/lib/Driver/ToolChains/Com

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin updated this revision to Diff 539283. DmitryPolukhin added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154602/new/ https://reviews.llvm.org/D154602 Files: clang/lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

DmitryPolukhin added inline comments. Comment at: clang/unittests/Driver/ToolChainTest.cpp:371 +TEST(CompilerInvocation, SplitSwarfSingleCrash) { + static constexpr const char *Args[] = {"clang", "-gdwarf-4", "-gsplit-dwarf=single", "-c", "foo.cpp"}; + CreateInvocationOptions

[PATCH] D154602: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6d9fcc2ad874: [clang][clangd] Don't crash/assert on -gsplit-dwarf=single without output (authored by DmitryPolukhin). Repository: rG LLVM Github M

[PATCH] D157283: [clang] Match -isysroot behaviour with system compiler on Darwin

DmitryPolukhin added a comment. @ldionne could you please upstream 9edb9a711503d540cf3126c0fde11ce9a0d9a7aa (I don't know what it is)? Alternatively I can figure out what to do with this test (it is just copies of the same te

[PATCH] D158519: [clangd] Move diagnostics from modules to the main source file

DmitryPolukhin added a comment. Friendly ping, any thoughts about this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158519/new/ https://reviews.llvm.org/D158519 ___ cfe-commits mailing list cfe-co

[PATCH] D76594: [clang][AST] User relative offsets inside AST file

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: rsmith, dexonsmith. DmitryPolukhin added a project: clang. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. Clang uses 32-bit integers for storing bit offsets from the beginning of the file that results in 512M limi

[PATCH] D76295: [clang][AST] Use 64 bit integers for bit offsets inside AST file

DmitryPolukhin abandoned this revision. DmitryPolukhin added a comment. Relative 32-bit offsets in https://reviews.llvm.org/D76594 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76295/new/ https://reviews.llvm.org/D76295 _

[PATCH] D76594: [clang][AST] User relative offsets inside AST file

DmitryPolukhin added a comment. In D76594#1937289 , @sammccall wrote: > This looks reasonable to me, though I'm not familiar enough with the code to > do a good review. > > Just wanted to confirm my understanding: the problematic offsets that are now > s

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 253368. DmitryPolukhin added a comment. Resolve merge conflict, revert clang-format for ASTBitCodes.h to avoid further conflicts, use C++ cast Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ ht

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin updated this revision to Diff 253417. DmitryPolukhin added a comment. Rebase, all tests passes locally Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76594/new/ https://reviews.llvm.org/D76594 Files: clang/include/clang/Serializati

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:220 /// Source range/offset of a preprocessed entity. struct DeclOffset { + /// Raw source location. The unsigned i.e.

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 254238. DmitryPolukhin added a comment. Use options priority instead of overriding local options by global Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files:

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh friendly ping I implemented solution with priorities to resolve your concerns about `get()` vs `getLocalOrGlobal()` Could you please take another look to this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D76594: [clang][AST] Support AST files larger than 512M

DmitryPolukhin added a comment. @rsmith, @dexonsmith, @jdoerfert could you please take a look to this diff? If you think that there are other reviewers who might have more context AST persistence, please add them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: alexfh, gribozavr2. DmitryPolukhin added projects: clang, clang-tools-extra. Herald added subscribers: aheejin, xazax.hun. Without this patch clang-tidy stops finding file configs on the nearest .clang-tidy file. In some cases i

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 246758. DmitryPolukhin added a comment. Rebase on top of master Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/clang-tidy/ClangTidyOp

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 246944. DmitryPolukhin added a comment. Fix issue with config inheritance and caching configs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tool

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. Friendly ping, please take a look. In large repos there is a significant problem with maintaining .clang-tidy configs in sync without some kind of inheritance with local overrides. If you have thoughts how to make it better, please speak up. Repository: rG LL

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 248457. DmitryPolukhin added a comment. Comments resolved, please take another look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/c

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh could you please take another look, I added more tests and updated the doc. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 ___

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 249065. DmitryPolukhin marked an inline comment as done. DmitryPolukhin added a comment. Herald added a subscriber: arphaman. Also updated rst file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 249380. DmitryPolukhin added a comment. Handle global options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/clang-tidy/ClangTidyOpti

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. In D75184#1912650 , @njames93 wrote: > How are local and global options handled. > From what I can gather it will read the value as `1` as the local option is > checked first no matter which file it was defined in. You

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin updated this revision to Diff 249423. DmitryPolukhin added a comment. Applied suggested changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 Files: clang-tools-extra/clang-tidy/ClangTidy

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. @alexfh could you please take another look to the diff? All comments resolved. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75184/new/ https://reviews.llvm.org/D75184 _

[PATCH] D76295: Use 64 bit integers for bit offsets inside AST file

DmitryPolukhin created this revision. DmitryPolukhin added a project: clang. Herald added subscribers: usaxena95, kadircet, ilya-biryukov. This diff is for discussion how to address problem with large preamble file. 32 bit offsets can be used for PCH/preamble files below 512M. This diff fixes cra

[PATCH] D76295: Use 64 bit integers for bit offsets inside AST file

DmitryPolukhin added a comment. In D76295#1927041 , @aganea wrote: > Hello Dmitry! Could we use varints > > instead of uint64_t if size on disk is a concern? Variants are very close

[PATCH] D75184: [clang-tidy] Optional inheritance of file configs from parent directories 

DmitryPolukhin added a comment. In D75184#1932764 , @alexfh wrote: > There's one more thing to consider: just by looking at the name of a local > option we don't know whether it will be read using `get()` or > `getLocalOrGlobal()`. By removing local opti

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin created this revision. DmitryPolukhin added a reviewer: smeenai. DmitryPolukhin added a project: clang-tools-extra. Herald added subscribers: xazax.hun, mgorny. Herald added a reviewer: jdoerfert. Herald added a project: clang. Clang releases include static libraries for clang-tidy

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin updated this revision to Diff 239741. DmitryPolukhin added a comment. Herald added a subscriber: mgehre. - moved header installation to clang-tidy cmake file Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llv

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin updated this revision to Diff 239746. DmitryPolukhin added a comment. - added clang-tidy-header component Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files: clang-tools-extra/clang-tidy/

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin updated this revision to Diff 239953. DmitryPolukhin added a comment. - removed DEPENDS Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files: clang-tools-extra/clang-tidy/CMakeLists.txt I

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: smeenai, gribozavr, stephanemoore. DmitryPolukhin added projects: clang-tools-extra, clang. Herald added subscribers: xazax.hun, mgorny. This library allows to create clang-tidy tools with custom checks outside of llvm repo usi

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin updated this revision to Diff 240025. DmitryPolukhin added a comment. Fix license text Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tools-extra/clang-tidy/tool/CMakeLists.tx

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin marked 2 inline comments as done. DmitryPolukhin added a comment. @Eugene.Zelenko thank you for the catch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 ___

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/CMakeLists.txt:104 +PATTERN "*.h" +PATTERN ".svn" EXCLUDE +) alexfh wrote: > Is this still relevant? Perhaps no, but I stil

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

DmitryPolukhin updated this revision to Diff 240037. DmitryPolukhin added a comment. remove `PATTERN ".svn" EXCLUDE` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new/ https://reviews.llvm.org/D73236 Files: clang-tools-extra/clang-tidy/CMa

[PATCH] D73236: [clang-tidy] Add clang-tidy headers to clang distribution

This revision was automatically updated to reflect the committed changes. Closed by commit rG301a437250b0: [clang-tidy] Add clang-tidy headers to clang distribution (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73236/new

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin updated this revision to Diff 240233. DmitryPolukhin added a comment. Updated comment per review suggestion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tools-extra/clang-t

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin updated this revision to Diff 240241. DmitryPolukhin added a comment. Added #include "ClangTidyMain.h" in ClangTidyMain.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ https://reviews.llvm.org/D73300 Files: clang-tool

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f8b100e94b5: [clang-tidy] Add library for clang-tidy main function (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73300/new/ h

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin marked an inline comment as done. DmitryPolukhin added inline comments. Comment at: clang-tools-extra/clang-tidy/tool/CMakeLists.txt:22 + clangToolingCore + ) + thakis wrote: > Normally we have a single cmake target per CMakeLists.txt. Maybe the

[PATCH] D73300: [clang-tidy] Add library for clang-tidy main function

DmitryPolukhin added a comment. @thakis I'm sorry sorry if it was not clear. Please let me know if you still prefer to have separate directory for clangTidyMain to have only one target per CMakeLists.txt. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet could you please take another look? I had to update diff to make it work when LLVM is configured without X86 targets so they are not valid and thus not injected into the command line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin created this revision. DmitryPolukhin added reviewers: bruno, troyj, arphaman, vsapsai, jansvoboda11. DmitryPolukhin added a project: clang. Herald added a subscriber: kadircet. Herald added a project: All. DmitryPolukhin requested review of this revision. Herald added a subscriber:

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin updated this revision to Diff 505642. DmitryPolukhin added a comment. Test added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146156/new/ https://reviews.llvm.org/D146156 Files: clang/lib/Lex/HeaderSearch.cpp clang/test/Preproc

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

DmitryPolukhin added a comment. In D146156#4197289 , @shafik wrote: > Is there a way to test this? It was easier to reproduce on small test case than I thought, test added. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D146156: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth

This revision was automatically updated to reflect the committed changes. Closed by commit rGb293c6280d06: [clang][Lexer] Fix crash/assert clang::HeaderSearch::search_dir_nth (authored by DmitryPolukhin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

This revision was automatically updated to reflect the committed changes. Closed by commit rGd60d3455eb2b: [clangd] Move standard options adaptor to CommandMangler (authored by DmitryPolukhin). Changed prior to commit: https://reviews.llvm.org/D143436?vs=505030&id=506030#toc Repository: rG L

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. In D143436#4203008 , @dyung wrote: > @DmitryPolukhin your change seems to be causing a crash in 2 ORC tests on a > bot (trivial-cxa-atexit.S and trivial-atexit.S), can you take a look or > revert if you need time to inves

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @dyung I cannot reproduce this issue on two different machines in both cases tests work fine. For clang and llvm-jitlink binaries (the only binaries used in the tests) my changes are non-functional and I didn't change anything in compiler-rt or ORC. Are you able

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 500449. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 500620. DmitryPolukhin added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet friendly ping, could you please take a look to this diff? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 ___ cfe-comm

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin updated this revision to Diff 502110. DmitryPolukhin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143436/new/ https://reviews.llvm.org/D143436 Files: clang-tools-extra/clangd/CompileCommands.cpp clang-to

[PATCH] D145228: [clangd] Add clangd headers to install targets

DmitryPolukhin added a comment. In D145228#4170792 , @sammccall wrote: >> The install target for clang distributes the clangd static libs > > I don't think this was ever intended, looks like an accidental side-effect of > using LLVM's many cmake macros.

[PATCH] D143436: [clangd] Move standard options adaptor to CommandMangler

DmitryPolukhin added a comment. @kadircet and @nridge friendly ping could you please accept this diff or let me know if you would like to change anything here? I moved `addTargetAndModeForProgramName` after `SystemIncludeExtractor` as was suggested. Repository: rG LLVM Github Monorepo CHANG

<    1   2   3   >