[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant requested changes to this revision. deansturtevant added a comment. This revision now requires changes to proceed. Aha! (I think). If the code to test "isExternalVisible" is executed *after* the code to test whether it's a C++ member function (the very next test), then the problem

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant added a comment. Thanks David. Is it possible to add a regression test for the problem that cropped up with the first try? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121328/new/ https://reviews.llvm.org/D121328 _

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant accepted this revision. deansturtevant added a comment. This revision is now accepted and ready to land. This looks good from my standpoint. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121328/new/ https://reviews.llvm.org/D121328

[PATCH] D121328: Disable -Wmissing-prototypes for internal linkage functions that aren't explicitly marked "static"""

deansturtevant added a comment. Note that some fix is important to make if we think that the -Wmissing-prototypes warning is valuable, because there are cases where it currently would fire where the function cannot explicitly be given internal linkage, e.g. namespace { struct Initialized {}; }