[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/4] [ci] Write test results to unique file names In this

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/3] [ci] Write test results to unique file names In this

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-28 Thread David Spickett via cfe-commits
DavidSpickett wrote: I tried a few more things, so I will summarise everything up until this point. There are two layers here: 1. Making test reports. 2. Producing the XML test results. Using the buildkite plugin is not an option (https://github.com/llvm/llvm-project/pull/113290) because we'd

[clang] [llvm] [ci] Run lit via a wrapper to produce unique result files to go into test reports (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/113896 None >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Bui

[clang] [llvm] Ci wrapper (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113896 >From 01d2c458fa35ed902dedde0022f39bc5806b61f5 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] [ci] Run lit via a wrapper to produce unique result files to go into test reports (PR #113896)

2024-10-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/8] [ci] Write test results to unique file names In this

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-23 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/4] [ci] Write test results to unique file names In this

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: Example failing build: https://buildkite.com/llvm-project/github-pull-requests/builds/113045#_ Another example: https://buildkite.com/llvm-project/github-pull-requests/builds/113055#_ The second example should not be failing but this modulemap test is for whatever reason,

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 7fa2d66f56af7b6ca6d6f36161825c1b71e8e29a Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Fix report script (PR #116017)

2024-11-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/116017 None >From 69a3030e61ab5d4483464cd912d78a4e5d24d644 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 13 Nov 2024 09:19:10 + Subject: [PATCH 1/2] Reland "[ci] New script to generate test report

[clang] [llvm] Fix report script (PR #116017)

2024-11-13 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/116017 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Improve warning message for target AVR (PR #114394)

2024-10-31 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: Maybe add " when no -mmcu option is used" to the commit title but otherwise LGTM. https://github.com/llvm/llvm-project/pull/114394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal( Name == getInstrProfSectionName(IPSK_covname, Triple::COFF, /*AddSegmentInfo=*/false)) Kind = SectionKind::getMetadata(); + + const Global

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal( Name == getInstrProfSectionName(IPSK_covname, Triple::COFF, /*AddSegmentInfo=*/false)) Kind = SectionKind::getMetadata(); + + const Global

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also I edited the title tags. They aren't an exact science but clang seems the most appropriate here. https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -fsyntax-only -verify %s -triple arm64-windows-msvc +// expected-no-diagnostics +#pragma clang section bss = "mybss.1" data = "mydata.1" rodata = "myrodata.1" text = "mytext.1" +#pragma clang section bss="" data="" rodata="" text="" +#pragma cl

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal( Name == getInstrProfSectionName(IPSK_covname, Triple::COFF, /*AddSegmentInfo=*/false)) Kind = SectionKind::getMetadata(); + + const Global

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
@@ -1677,6 +1677,22 @@ MCSection *TargetLoweringObjectFileCOFF::getExplicitSectionGlobal( Name == getInstrProfSectionName(IPSK_covname, Triple::COFF, /*AddSegmentInfo=*/false)) Kind = SectionKind::getMetadata(); + + const Global

[clang] [llvm] [PATCH] [COFF] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett commented: I'm not an expert here but added some generic comments for now. FYI with the llvm conference last week, many people are still away so review pace is slower right now. Since this is a Clang change it should have a release note, I think it can go in h

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-11-01 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] Run lit via a wrapper to produce unique result files to go into test reports (PR #113896)

2024-11-12 Thread David Spickett via cfe-commits
DavidSpickett wrote: Abandoning in favour of marking the unique filename option as hidden. https://github.com/llvm/llvm-project/pull/113896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] [llvm] [ci] Run lit via a wrapper to produce unique result files to go into test reports (PR #113896)

2024-11-12 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/113896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [flang][driver] rename flang-new to flang (PR #110023)

2024-09-26 Thread David Spickett via cfe-commits
DavidSpickett wrote: > Is there a symbolic link flang-new -> flang? We would like to have a > transitional period. Compiler Explorer would also appreciate this. Though I should be able to get it switched to the new name within a week or two. https://github.com/llvm/llvm-project/pull/110023 __

[clang] [llvm] Use %errc to get text for system errors (PR #109852)

2024-09-26 Thread David Spickett via cfe-commits
DavidSpickett wrote: Do you have merge permissions? I can merge it for you if not. https://github.com/llvm/llvm-project/pull/109852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Use %errc to get text for system errors (PR #109852)

2024-09-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: I think https://github.com/llvm/llvm-project/blob/5a191e3cd904b5fee202569e54fe04f91f1a697f/llvm/utils/lit/lit/llvm/config.py#L411 works such that if the messages cannot be found (cross compiling and such) we default to asking Python what it thinks they should be. I wonder

[clang] [llvm] Use %errc to get text for system errors (PR #109852)

2024-09-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: CI failure is: ``` _bk;t=1727216861348Timed Out Tests (1): _bk;t=1727216861348 lldb-api :: functionalities/fork/concurrent_vfork/TestConcurrentVFork.py ``` Ignore that it's due to https://github.com/llvm/llvm-project/issues/104609. https://github.com/llvm/llvm-project

[clang] [llvm] Use %errc to get text for system errors (PR #109852)

2024-09-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/109852 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [flang][driver] rename flang-new to flang (PR #110023)

2024-09-26 Thread David Spickett via cfe-commits
DavidSpickett wrote: Also buildbots reference flang-new. We can change the config files very quickly, but getting it into production will be a week or two. A symlink would help here. https://github.com/llvm/llvm-project/pull/110023 ___ cfe-commits ma

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-09-27 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/110239 >From 84946607fc58927b1b44da2b70566abca041bbfb Mon Sep 17 00:00:00 2001 From: David Spickett Date: Fri, 27 Sep 2024 10:19:19 + Subject: [PATCH] [clang][Sema] Bad register variable type error should poi

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-09-27 Thread David Spickett via cfe-commits
DavidSpickett wrote: I also think that "bad" is a confusing word to use here, "unsupported" would be better but I will address that in a follow up PR. https://github.com/llvm/llvm-project/pull/110239 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [clang][Sema] Bad register variable type error should point to the type (PR #110239)

2024-09-27 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/110239 ...not the register keyword. Fixes #109776. Until now the error was only tested in clang/test/Sema/asm.c, where you can't check for the "^" character. I've added a new caret test file as I see has been d

[clang] 737c414 - Revert "[clang][flang][mlir] Support -frecord-command-line option (#102975)"

2024-09-20 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-09-20T11:30:50Z New Revision: 737c414e1d9578e5037e68e3b3f6ddea507f8243 URL: https://github.com/llvm/llvm-project/commit/737c414e1d9578e5037e68e3b3f6ddea507f8243 DIFF: https://github.com/llvm/llvm-project/commit/737c414e1d9578e5037e68e3b3f6ddea507f8243.diff LOG

[clang] [flang] [mlir] [clang][flang][mlir] Support -frecord-command-line option (PR #102975)

2024-09-20 Thread David Spickett via cfe-commits
DavidSpickett wrote: I've had to revert this due to the failures listed above. To reproduce, configure with `-DBUILD_SHARED_LIBS=ON`. (the other 2 bots are not called shared libs but they do enable this setting too) ``` $ ./bin/bbc : CommandLine Error: Option 'fdynamic-heap-array' registered

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113447 >From ba99bed96bd69db7c86d43a2119255569872f41f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 21 Oct 2024 12:34:17 + Subject: [PATCH 1/3] [ci] Write test results to unique file names In this

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Ci report script testing! (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
DavidSpickett wrote: Notes to reviewers: * This is based on https://github.com/llvm/llvm-project/pull/113160. * The first commit is that previous PR. * The second commit is the new script. * The third commit is some example changes so I can show you what the reports look like, they will be remov

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
@@ -0,0 +1,328 @@ +# Script to parse many JUnit XML result files and send a report to the buildkite +# agent as an annotation. +# +# To run the unittests: +# python3 -m unittest discover -p generate_test_report.py + +import argparse +import unittest +from io import StringIO +from

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett ready_for_review https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ci] New script to generate test reports as Buildkite Annotations (PR #113447)

2024-10-24 Thread David Spickett via cfe-commits
DavidSpickett wrote: Example reports can be seen here - https://buildkite.com/llvm-project/github-pull-requests/builds/112660. https://github.com/llvm/llvm-project/pull/113447 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [llvm] Ci report bash (PR #113660)

2024-10-25 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/113660 >From 37886ec83bf246fb366ba2e1f14fa011891073df Mon Sep 17 00:00:00 2001 From: David Spickett Date: Wed, 23 Oct 2024 11:39:15 +0100 Subject: [PATCH 1/3] [ci] New script to generate test reports as Buildkite

[clang] [clang][AArch64] Avoid a crash when a non-reserved register is used (PR #117419)

2024-11-25 Thread David Spickett via cfe-commits
DavidSpickett wrote: Please check if this fixes https://github.com/llvm/llvm-project/issues/109778 too. Seems very similar. https://github.com/llvm/llvm-project/pull/117419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [llvm] [ci] Include a log download link when test report is truncated (PR #117985)

2024-11-28 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/117985 Now "Download" will be a link to the file so people don't have to know to open the build tab and find the download button. This is a URL from a real build: https://buildkite.com/organizations/llvm-project/

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-02 Thread David Spickett via cfe-commits
@@ -434,29 +433,17 @@ Others only have a lead maintainer listed here. [Flang maintainers](https://github.com/llvm/llvm-project/blob/main/flang/Maintainers.txt) -[LLD maintainers](https://github.com/llvm/llvm-project/blob/main/lld/CODE_OWNERS.TXT) - -[LLDB maintainers](http

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-02 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett created https://github.com/llvm/llvm-project/pull/118309 This adds Maintainers.md files to the sub-projects mentioned here, so that someone going directly to that sub-project will find them more easily. Recently I needed to find a libclc maintainer and I had no

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-02 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 9d279bcb1174e80e24ddac8755962cb65e20be91 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH 1/2] [llvm] Move sub-project lead maintainers into their ow

[clang] [clang][AArch64] Avoid a crash when a non-reserved register is used (PR #117419)

2024-11-26 Thread David Spickett via cfe-commits
DavidSpickett wrote: Thanks, I'll leave it open then, this PR is a welcome improvement regardless. https://github.com/llvm/llvm-project/pull/117419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-02 Thread David Spickett via cfe-commits
DavidSpickett wrote: @tobiasgrosser (because for some reason I can't add you as a reviewer directly) https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: It already landed, I'll rebase this PR. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [libcxx] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-04 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From fe59fcd2c14f7ff84857ad75bc3564cbe6752c9d Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH] [llvm] Move sub-project lead maintainers into their own fi

[libclc] [libcxx] [llvm] [openmp] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: OpenMP part pushed directly: https://github.com/llvm/llvm-project/commit/2137ded301adb430e0616cd835da9838e4fd79ce https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: > The relevant binaries build, but check-lldb currently hits unrelated errors > for me blocking any progress in checking those changes. `ninja check-lldb` passes on AArch64 Linux, and given the changes, it's unlikely to fail on other platforms. https://github.com/llvm/llv

[clang] [lld] [lldb] [llvm] Rework the `Option` library to reduce dynamic relocations (PR #119198)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: If you look for: ``` FAILED: tools/clang/tools/extra/clangd/CMakeFiles/obj.clangDaemon.dir/CompileCommands.cpp.o ``` In the build log that's the failure reason. All of the tests that reported JSON passed, that's why you have green test reports but failed builds. I wi

[clang] [llvm] [clang] Implement pragma clang section on COFF targets (PR #112714)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: My comments have been addressed. https://github.com/llvm/llvm-project/pull/112714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 64bfb1cd1bb7aa9e1597c0212dba7067c9f75d9f Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH] [libclc] Add Maintainers.md for libclc --- libclc/Mainta

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2024-12-09 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2024-12-09 Thread David Spickett via cfe-commits
DavidSpickett wrote: Polly pushed in https://github.com/llvm/llvm-project/commit/788d5a5f1e1263657f0a281545e095769f6b375b. Only libclc remains. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 409dd1184f1c4ff9f11e2d715b6e4a496c70c7e4 Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH 1/2] [libclc] Add Maintainers.md for libclc --- libclc/Ma

[libclc] [llvm] [libclc] Add Maintainers.md for libclc (PR #118309)

2025-01-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: Updated to list @frasercrmck and @tstellar for libclc. Tell me if that works for now, perhaps you can sort out any additions later. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] Revert "[clang] fix P3310 overload resolution flag propagation" (PR #125710)

2025-02-04 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/125710 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix P3310 overload resolution flag propagation (PR #125372)

2025-02-04 Thread David Spickett via cfe-commits
DavidSpickett wrote: Might be as simple as a constant true or false, but I'm nearing the end of my work day so I've reverted it for now. In the meantime, @Michael137 might know if this is something LLDB should actually be tracking. Or in other words, is https://github.com/llvm/llvm-project/is

[clang] [Clang] Make `-Xarch_` handling generic for all toolchains (PR #125421)

2025-02-05 Thread David Spickett via cfe-commits
DavidSpickett wrote: I've pushed a fix for one of the tests on 32 bit Arm, as it failed on our bot: https://lab.llvm.org/buildbot/#/builders/154/builds/11413/steps/5/logs/FAIL__Clang__offload-Xarch_c Maybe your intent was specifically to have a line that uses the host architecture, if that was

[clang] 9deafad - [Clang] Use x86 triple for offload-Xarch.c test

2025-02-05 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2025-02-05T17:17:37Z New Revision: 9deafad7ab00c81c9869d50bfde2aa47bdaa6dd7 URL: https://github.com/llvm/llvm-project/commit/9deafad7ab00c81c9869d50bfde2aa47bdaa6dd7 DIFF: https://github.com/llvm/llvm-project/commit/9deafad7ab00c81c9869d50bfde2aa47bdaa6dd7.diff LOG

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-10 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. https://github.com/llvm/llvm-project/pull/126352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][HIP] Do not specify explicit target cpu in host compilation run line (PR #126488)

2025-02-10 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/126488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Driver][HIP] Do not specify explicit target cpu in host compilation run line (PR #126488)

2025-02-10 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett approved this pull request. Just looking at this on Linaro's bots, thanks for the fix! https://github.com/llvm/llvm-project/pull/126488 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [libc] [libcxx] [lldb] [llvm] [doc] Add Discord invite link alongside channel links (PR #126352)

2025-02-10 Thread David Spickett via cfe-commits
DavidSpickett wrote: I also looked at this but got into a rabbit hole finding out whether you could have channel specific invites. I think you can, but I don't think it actually helps us. As the other problem we have had is invites expiring, so the fewer unique invite links the better. https:

[clang] [llvm] [clang-linker-wrapper] Add ELF packaging for spirv64-intel OpenMP images (PR #125737)

2025-02-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I have seen this before https://github.com/llvm/llvm-project/commit/a2bd5db00d07bc28fcfb3350b9d50e72e6350cba https://github.com/llvm/llvm-project/pull/125737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[clang] [llvm] [clang-linker-wrapper] Add ELF packaging for spirv64-intel OpenMP images (PR #125737)

2025-02-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: I wonder if it is only happening on a rebuild not a clean build. This one was clean: https://lab.llvm.org/buildbot/#/builders/65/builds/11869 But your test did not fail (I assume did not run). This one is a rebuild: https://lab.llvm.org/buildbot/#/builders/65/builds/11870

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > As for the cases mentioned, when I tried compile all projects (compile with > -DLLVM_ENABLE_PROJECTS=all), I did encounter such cases when compiling and > I've fixed them all. > Now all projects can be successfully built, so I think it should be fine? Just to explain why

[clang] [clang-tools-extra] [flang] [lldb] [llvm] [mlir] [polly] Add static to command line option (cl::opt) (PR #126243)

2025-02-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > You can check the CI logs for the exact command line it uses and replicate it > locally. Should be towards the start of the log, search for `cmake ` to find the command. https://github.com/llvm/llvm-project/pull/126243 ___ cfe-

[clang] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
@@ -71,7 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet, ->getCanonicalTypeUnqualified(); } } -} +} break; DavidSpickett wrote: Could put it inside the `case : { ...}` scope,

[clang] [clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett edited https://github.com/llvm/llvm-project/pull/120739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
@@ -71,7 +71,7 @@ bool hasSmartPointerClassShape(const CXXRecordDecl &RD, bool &HasGet, ->getCanonicalTypeUnqualified(); } } -} +} break; DavidSpickett wrote: On second thought, there are a ton of these in

[clang] [clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/120739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Fix a missing break from a switch case -Wimplicit-fallthrough (PR #120739)

2024-12-20 Thread David Spickett via cfe-commits
DavidSpickett wrote: Thanks for the fix! https://github.com/llvm/llvm-project/pull/120739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-06 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett updated https://github.com/llvm/llvm-project/pull/118309 >From 8398d47a413dfbabb9a4eb96809304c240f4e3ad Mon Sep 17 00:00:00 2001 From: David Spickett Date: Mon, 2 Dec 2024 15:22:50 + Subject: [PATCH] [llvm] Move sub-project lead maintainers into their own fi

[libclc] [llvm] [polly] [llvm] Move sub-project lead maintainers into their own Maintainers.md files (PR #118309)

2024-12-06 Thread David Spickett via cfe-commits
DavidSpickett wrote: Libcxx part pushed as https://github.com/llvm/llvm-project/commit/1bdb0a408f1e2e9f6d5f43b23b4f87f87b3950ab. https://github.com/llvm/llvm-project/pull/118309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Setting default features for a platform based on what we happened to choose (likely with a very thin justification) to be the default CPU sounds fragile to me, so I think this patch is a good step forward. Even if there weren't this downstream patch interacting with it, I

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: > In practice, when compiling C for Windows/ARMv7, NEON actually still is > available, but not when compiling assembly files. So the "bug" if we're going to call it that, is that C code can produce Neon but assembly files compiled in the same way cannot use Neon instructi

[clang] [clang] [ARM] Explicitly enable NEON for Windows/Darwin targets (PR #122095)

2025-01-08 Thread David Spickett via cfe-commits
DavidSpickett wrote: Or is it that this change allows other downstreams to patch the Linux issue in a way that does not break Windows and iOS in the process? If I'm using clang on Debian, that's where I would find this C can use Neon but assembly cannot problem. https://github.com/llvm/llvm-p

<    1   2   3   4   5   6   7   >