@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/66083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/66083:
```
$ ./bin/clang -target arm-linux-gnueabihf --print-supported-extensions
<...>
All available -march extensions for ARM
crc
crypto
sha2
aes
dotprod
<...>
```
This
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/66083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,548 @@
+Pointer Authentication
+==
+
+.. contents::
+ :local:
+
+Introduction
+
+
+Pointer authentication is a technology which offers strong probabilistic
protection against exploiting a broad class of memory bugs to take control of
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65996
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Maybe I just need to learn how to use Github, but did half the document
disappear?
I see a reference to the attacks section `See the section on `Attacks on
pointer authentication`_ for more information.` but the section is gone from
the diff even in a private window.
htt
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/66083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/66083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
I'm going to assume this is fine given that the test passes. We can always
revert it if that is not the case.
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.ll
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Thankyou for looking into this, if it can work it's much cleaner than an ever
expanding if.
I think that `getAllProcessorFeatures` my include things that are rejected by
`-march`. I will check that for Arm and AArch64. Since the list of features in
the target parser may b
DavidSpickett wrote:
One way to check the formats is to add checks for the column titles (if any)
and first extension listed in `clang/test/Driver/print-supported-extensions.c`,
to document the existing behaviour. RISC-V calls into it's own ABI info class
which only has unit tests so if you ch
DavidSpickett wrote:
Put `-mcpu` aside for now, that's nice, but it's only going to be viable in a
world where the backend (tablegen) and frontend (target parsers/ABI info) agree
on what is valid and can also be passed to clang.
> The file with the full log outputs is here:
> [sample-outputs.
DavidSpickett wrote:
> I was only able to check intel's one (w.r.t to -mcpu), without being aware on
> aarch64 / riscv world's detail.
Yes I wouldn't expect you to right away, that's why we all keep an eye out for
each other's changes :) . That's what I meant about starting by writing more
co
Author: David Spickett
Date: 2023-08-24T08:15:17Z
New Revision: 547bce36132ae0d92226599b6b8702051571461f
URL:
https://github.com/llvm/llvm-project/commit/547bce36132ae0d92226599b6b8702051571461f
DIFF:
https://github.com/llvm/llvm-project/commit/547bce36132ae0d92226599b6b8702051571461f.diff
LOG
Author: David Spickett
Date: 2023-09-01T14:53:41Z
New Revision: 7c6544333eba516c1b569fb74288bbfe9ca54c1f
URL:
https://github.com/llvm/llvm-project/commit/7c6544333eba516c1b569fb74288bbfe9ca54c1f
DIFF:
https://github.com/llvm/llvm-project/commit/7c6544333eba516c1b569fb74288bbfe9ca54c1f.diff
LOG
Author: David Spickett
Date: 2023-09-01T14:55:11Z
New Revision: ef5219c18b252ac36815d5f322acab704259df08
URL:
https://github.com/llvm/llvm-project/commit/ef5219c18b252ac36815d5f322acab704259df08
DIFF:
https://github.com/llvm/llvm-project/commit/ef5219c18b252ac36815d5f322acab704259df08.diff
LOG
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/65251:
2 of them were missing the ":" on the end.
Adding them broke the test so I had to add a new prefix just for the warning
runs only.
I manually checked the first RUNs and there is no warning emitted, as ex
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65251
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
With just the bitvector change this is fine.
I don't disagree with splitting the test files but it should be in its own
commit/PR.
https://github.com/llvm/llvm-project/pull/65423
___
cfe-commits mailing list
cfe-commits@lists.llv
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/65466:
This follows the RISC-V work done in 4b40ced4e5ba10b841516b3970e7699ba8ded572.
This uses AArch64's target parser instead. We just list the names, without the
"+" on them, which matches RISC-V's format.
`
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett review_requested
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
I've generalised this a bit but mostly kept to what RISC-V did. If we think
it's time to completely generalise it then I'll figure that out.
Mostly want to know people are on board with supporting this for AArch64 first.
https://github.com/llvm/llvm-project/pull/65466
@@ -12,6 +12,7 @@
//===--===//
#include "llvm/TargetParser/AArch64TargetParser.h"
+#include "llvm/Support/raw_ostream.h"
DavidSpickett wrote:
clang-format is putting the "main module" header
https://github.com/DavidSpickett resolved
https://github.com/llvm/llvm-project/pull/65466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/65466:
>From f0157ffb412fd2d6d4aa4a294b631f74e5638878 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 6 Sep 2023 10:15:27 +
Subject: [PATCH 1/2] [clang][AArch64] Add --print-supported-extensions supp
Author: David Spickett
Date: 2019-11-04T10:58:46Z
New Revision: 91167e22eca535025f093335acece573bf19c525
URL:
https://github.com/llvm/llvm-project/commit/91167e22eca535025f093335acece573bf19c525
DIFF:
https://github.com/llvm/llvm-project/commit/91167e22eca535025f093335acece573bf19c525.diff
LOG
Author: David Spickett
Date: 2023-06-26T15:20:35Z
New Revision: f3ca99a87c566fb5e910071f4cbb474ddb4e7f37
URL:
https://github.com/llvm/llvm-project/commit/f3ca99a87c566fb5e910071f4cbb474ddb4e7f37
DIFF:
https://github.com/llvm/llvm-project/commit/f3ca99a87c566fb5e910071f4cbb474ddb4e7f37.diff
LOG
Author: David Spickett
Date: 2023-04-05T08:07:19Z
New Revision: d5c428356f6ee107a97977eb9ef1aa4d5fa0c378
URL:
https://github.com/llvm/llvm-project/commit/d5c428356f6ee107a97977eb9ef1aa4d5fa0c378
DIFF:
https://github.com/llvm/llvm-project/commit/d5c428356f6ee107a97977eb9ef1aa4d5fa0c378.diff
LOG
Author: David Spickett
Date: 2023-04-17T15:33:06Z
New Revision: ee341373625163846f4ebc68e46aec6fb46c2c09
URL:
https://github.com/llvm/llvm-project/commit/ee341373625163846f4ebc68e46aec6fb46c2c09
DIFF:
https://github.com/llvm/llvm-project/commit/ee341373625163846f4ebc68e46aec6fb46c2c09.diff
LOG
Author: David Spickett
Date: 2023-02-24T16:37:14Z
New Revision: 8ae5e9edcdb394794d8c4d1ee286f1b500aaf826
URL:
https://github.com/llvm/llvm-project/commit/8ae5e9edcdb394794d8c4d1ee286f1b500aaf826
DIFF:
https://github.com/llvm/llvm-project/commit/8ae5e9edcdb394794d8c4d1ee286f1b500aaf826.diff
LOG
Author: Stoorx
Date: 2023-04-18T10:07:26Z
New Revision: 830b359d3ab1f96875582bf687f4542df0d3527a
URL:
https://github.com/llvm/llvm-project/commit/830b359d3ab1f96875582bf687f4542df0d3527a
DIFF:
https://github.com/llvm/llvm-project/commit/830b359d3ab1f96875582bf687f4542df0d3527a.diff
LOG: [clang
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/81726
Currently https://flang.llvm.org/docs/FlangCommandLineReference.html refers to
"Clang" in several of the group descriptions for example:
```
Compilation options
Flags controlling the behavior of Clang duri
DavidSpickett wrote:
To add program specific option help, my idea is to store mutliple strings in
the driver and select based on who's asking for the help.
I think that warrants its own change so I'm not attempting that here. Also,
there's only 2 flang options that refer to clang so it's not t
DavidSpickett wrote:
@llvm/pr-subscribers-flang-driver
https://github.com/llvm/llvm-project/pull/81726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Spickett
Date: 2024-02-14T12:51:30Z
New Revision: c5e13840fdc20adce51673a63d5703bf1ed02aba
URL:
https://github.com/llvm/llvm-project/commit/c5e13840fdc20adce51673a63d5703bf1ed02aba
DIFF:
https://github.com/llvm/llvm-project/commit/c5e13840fdc20adce51673a63d5703bf1ed02aba.diff
LOG
DavidSpickett wrote:
Yes I had to disable sphix -Werr for that, I will try to fix it.
https://github.com/llvm/llvm-project/pull/81726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/81726
>From 74fe9a47aecac7f7d16485d11781c9cc92229429 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 14 Feb 2024 11:20:51 +
Subject: [PATCH 1/2] [clang][flang][driver] Correct program names in option
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/81726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Fixed the warning.
https://github.com/llvm/llvm-project/pull/81726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/81726
>From 101fb01100873cb69e1d3bb4e7cadf6a45e42d83 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Wed, 14 Feb 2024 11:20:51 +
Subject: [PATCH 1/2] [clang][flang][driver] Correct program names in option
https://github.com/DavidSpickett closed
https://github.com/llvm/llvm-project/pull/81726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: David Spickett
Date: 2024-02-15T11:49:59Z
New Revision: 9f2d8cdf4209638973a0611fa2efd4e2fe38bfa5
URL:
https://github.com/llvm/llvm-project/commit/9f2d8cdf4209638973a0611fa2efd4e2fe38bfa5
DIFF:
https://github.com/llvm/llvm-project/commit/9f2d8cdf4209638973a0611fa2efd4e2fe38bfa5.diff
LOG
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/81869
And use it to print the correct default OpenMP version for flang.
This change adds an optional HelpTextForVisibility to options. This allows you
to change the help text (shown in documentation and --help)
DavidSpickett wrote:
This is a bit of an RFC given that there's only one flang option that requires
this that I know of. So this could be too much complication now. Since I was in
the area I figured I'd try it anyway, we can always attach this to an issue for
later use if necessary.
https://g
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/81869
>From a996499580066213c3437cbb96735b7404291c3d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 15 Feb 2024 09:52:22 +
Subject: [PATCH 1/2] [flang][clang] Add Visibility specific help text for
@@ -3391,7 +3391,10 @@ def fno_openmp : Flag<["-"], "fno-openmp">,
Group,
def fopenmp_version_EQ : Joined<["-"], "fopenmp-version=">, Group,
Flags<[NoArgumentUnused]>,
Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>,
- HelpText<"Set OpenMP version (e.g. 45 fo
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/81869
>From a996499580066213c3437cbb96735b7404291c3d Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 15 Feb 2024 09:52:22 +
Subject: [PATCH 1/3] [flang][clang] Add Visibility specific help text for
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/81869
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3391,7 +3391,10 @@ def fno_openmp : Flag<["-"], "fno-openmp">,
Group,
def fopenmp_version_EQ : Joined<["-"], "fopenmp-version=">, Group,
Flags<[NoArgumentUnused]>,
Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>,
- HelpText<"Set OpenMP version (e.g. 45 fo
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/81869
>From 72bbd9d38cb6e292d92391fcf04154cfbc336192 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Thu, 15 Feb 2024 09:52:22 +
Subject: [PATCH 1/3] [flang][clang] Add Visibility specific help text for
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/82624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett approved this pull request.
LGTM, thanks.
https://github.com/llvm/llvm-project/pull/82624
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
DavidSpickett wrote:
Also remove the comment that links to
https://github.com/llvm/llvm-project/issues/94994 and add `Fixes #94994` to the
commit message.
https://github.com/llvm/llvm-project/pull/97071
Stefan =?utf-8?q?Gr=C3=A4nitz?= ,
Stefan =?utf-8?q?Gr=C3=A4nitz?=
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett approved this pull request.
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.ll
Stefan =?utf-8?q?Gränitz?= ,
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97071
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97749
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DavidSpickett wrote:
Looks ok to me, X86 and ARM already do this.
> One point we noticed is that it could end up turning "aes+sha2" into "crypto"
> and "crypto" back into "sha2+aes+sha3+sm4", as it uses the old meaning of
> "crypto"
Then this needs to be fixed before this PR can go in, we don
https://github.com/DavidSpickett created
https://github.com/llvm/llvm-project/pull/97824
Previously this took a reference to a map and returned a bool to say whether it
succeeded. This is an optional but with more steps.
The only reason to keep it that way was if someone was appending to an ex
@@ -1710,15 +1710,17 @@ VendorSignatures getVendorSignature(unsigned *MaxLeaf) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
-bool sys::getHostCPUFeatures(StringMap &Features) {
+std::optional> sys::getHostCPUFeatures() {
unsign
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/97824
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/2] [llvm][TargetParser] Return optional from
getHostCPUFe
@@ -15,22 +15,23 @@
#include "llvm/Support/raw_ostream.h"
#include "llvm/TargetParser/Host.h"
+#include
+
using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- StringMap featu
@@ -22,13 +22,13 @@ using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- if (std::optional> features =
+ if (const std::optional> features =
sys::getHostCPUFeatures(featu
https://github.com/DavidSpickett updated
https://github.com/llvm/llvm-project/pull/97824
>From 7ebe4e487b763ff26fbab6d75aa7c8694d63e8b1 Mon Sep 17 00:00:00 2001
From: David Spickett
Date: Fri, 5 Jul 2024 08:42:22 +
Subject: [PATCH 1/3] [llvm][TargetParser] Return optional from
getHostCPUFe
@@ -22,13 +22,13 @@ using namespace llvm;
int main(int argc, char **argv) {
#if defined(__i386__) || defined(_M_IX86) || \
defined(__x86_64__) || defined(_M_X64)
- if (std::optional> features =
+ if (const std::optional> features =
sys::getHostCPUFeatures(featu
https://github.com/DavidSpickett edited
https://github.com/llvm/llvm-project/pull/102601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -38,6 +38,10 @@ endif()
include(LLDBConfig)
include(AddLLDB)
+if (UNIX AND ${CMAKE_SYSTEM_NAME} MATCHES "AIX")
+ add_definitions("-D__AIX__")
DavidSpickett wrote:
This looks like a macro that a compiler might set for you, is that not the case
here?
http
@@ -11,6 +11,11 @@
#include "lldb/Host/Config.h"
+#if defined(__AIX__)
+//FIXME for AIX
+#undef LLDB_ENABLE_LIBXML2
DavidSpickett wrote:
In theory if you configure with `-DLLDB_ENABLE_LIBXML2=OFF`, the libxml2 parts
will be removed. Was something else being
https://github.com/DavidSpickett commented:
It's worth putting the PR into draft mode just to be extra clear this is a
request for early feedback.
This PR will be later split up of course, so very general comments from me.
Very impressive effort overall.
https://github.com/llvm/llvm-project/p
@@ -40,6 +40,113 @@ add_custom_target(lldb-sbapi-dwarf-enums
DEPENDS ${sb_languages_file})
set_target_properties(lldb-sbapi-dwarf-enums PROPERTIES FOLDER
"LLDB/Tablegenning")
+if(CMAKE_SYSTEM_NAME MATCHES "AIX")
+add_lldb_library(liblldb STATIC ${option_framework}
-
@@ -1510,6 +1510,18 @@ bool Module::SetLoadAddress(Target &target, lldb::addr_t
value,
return false;
}
+bool Module::SetLoadAddressByType(Target &target, lldb::addr_t value,
+bool value_is_offset, bool &changed, int type_id) {
+ ObjectFile *obje
@@ -342,7 +342,7 @@ uint32_t SBBreakpoint::GetIgnoreCount() const {
return count;
}
-void SBBreakpoint::SetThreadID(tid_t tid) {
+void SBBreakpoint::SetThreadID(lldb::tid_t tid) {
DavidSpickett wrote:
If these lldb:: are fixing compilation errors they would
@@ -0,0 +1,62 @@
+//===-- Ptrace.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,7 @@
+
+This product contains small piece of code to support AIX, taken from netbsd.
+
+ * LICENSE:
+* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License)
DavidSpickett wrote:
We'll need to confirm license compatibility for this.
htt
@@ -67,6 +67,10 @@ class RegisterContextUnwind : public
lldb_private::RegisterContext {
bool ReadPC(lldb::addr_t &start_pc);
+#ifdef __AIX__
+ bool ReadLR(lldb::addr_t &lr);
+#endif
+
DavidSpickett wrote:
It's likely we'd ask you to make this a method on
@@ -0,0 +1,7 @@
+
+This product contains small piece of code to support AIX, taken from netbsd.
+
+ * LICENSE:
+* lldb/source/Host/common/LICENSE.aix-netbsd.txt (OpenSSL License)
DavidSpickett wrote:
And if there is a way not to pull in this code, we're like
201 - 300 of 633 matches
Mail list logo
