Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

davidsh updated this revision to Diff 64353. davidsh added a comment. Fix a typo in code and address test case issues. https://reviews.llvm.org/D22075 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_messages.cpp test/OpenMP/target_parallel_for_map_messages.cpp test/OpenMP/target_p

[PATCH] D22481: Allow negative lower bound in array sections based on pointers

davidsh created this revision. davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev. davidsh added a subscriber: cfe-commits. OpenMP 4.5 removed the restriction that array section lower bound must be non negative. This change is to allow negative values for array sectio

[PATCH] D22487: [OpenMP] Ignore parens in atomic capture

davidsh created this revision. davidsh added reviewers: carlo.bertolli, arpith-jacob, kkwli0, sfantao, ABataev. davidsh added a subscriber: cfe-commits. Clang misdiagnoses atomic captures cases that contains parens. ie. int v, int *p; #pragma omp atomic capture { v = (*p); (*p)++; } https://revie

[PATCH] D21617: [OpenMP] Diagnose missing cases of statements between target and teams directives

davidsh created this revision. davidsh added reviewers: kkwli0, hubert.reinterpretcast. davidsh added a subscriber: cfe-commits. Clang fails to diagnose cases such as #pragma omp target while(0) { #pragma omp teams {} } http://reviews.llvm.org/D21617 Files: lib/Sema/SemaOpenMP.cp

Re: [PATCH] D21617: [OpenMP] Diagnose missing cases of statements between target and teams directives

davidsh updated this revision to Diff 61612. http://reviews.llvm.org/D21617 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/nesting_of_regions.cpp Index: test/OpenMP/nesting_of_regions.cpp === --- test/OpenMP/nesting_of_regions.cpp +

Re: [PATCH] D21617: [OpenMP] Diagnose missing cases of statements between target and teams directives

davidsh updated this revision to Diff 61830. davidsh added a comment. Address a comment. http://reviews.llvm.org/D21617 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/nesting_of_regions.cpp Index: test/OpenMP/nesting_of_regions.cpp ==

[PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

davidsh created this revision. davidsh added reviewers: carlo.bertolli, arpith-jacob, sfantao, ABataev, kkwli0. davidsh added a subscriber: cfe-commits. Having the following code pattern will result in incorrect diagnostic int main() { int arr[10]; #pragma omp target data map(arr[:]) #pragma omp t

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

davidsh updated this revision to Diff 63090. davidsh added a comment. Address comments http://reviews.llvm.org/D22075 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_messages.cpp Index: test/OpenMP/target_map_messages.cpp ==

Re: [PATCH] D22075: [OpenMP] Fix incorrect diagnostics in map clause

davidsh updated this revision to Diff 63824. davidsh added a comment. Address formatting comment. http://reviews.llvm.org/D22075 Files: lib/Sema/SemaOpenMP.cpp test/OpenMP/target_map_messages.cpp Index: test/OpenMP/target_map_messages.cpp ===