dmajor added a comment.
> Anyway, I'm just venting. If rnk@ wants to lgtm this, I'm fine.
@rnk, any objection to this patch?
https://reviews.llvm.org/D39994
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
dmajor added a comment.
In https://reviews.llvm.org/D51204#1253230, @mgrang wrote:
> Will abandon this patch since I have implementations of these which I will
> upstream soon.
Just to link up the reviews: these landed in https://reviews.llvm.org/D52838
and https://reviews.llvm.org/D53115. (T
dmajor created this revision.
dmajor added reviewers: mgrang, efriedma, hans.
Herald added subscribers: kristina, jfb, kristof.beyls, javed.absar.
Herald added a project: clang.
In `CodeGenFunction::EmitAArch64BuiltinExpr()`, bulk move of all of the aarch64
MSVC-builtin cases to an earlier point
dmajor marked an inline comment as done.
dmajor added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:8182
switch (BuiltinID) {
default: return nullptr;
case NEON::BI__builtin_neon_vbsl_v:
efriedma wrote:
> I'm a little concerned about the overall
This revision was automatically updated to reflect the committed changes.
Closed by commit rL367323: [COFF][ARM64] Reorder handling of aarch64 MSVC
builtins (authored by dmajor, committed by ).
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https
dmajor added a comment.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: erik.pilkington.
While debugging something else, I noticed that with this patch, `Decl` now has
33 bits worth of bitfields, so it has gained an extra word. Is that ok? Just
want to make sure it wasn't unintent
dmajor created this revision.
Herald added subscribers: kristof.beyls, aemerson.
Mozilla's build machines are currently applying this patch locally, but I
thought I'd offer it upstream because it should be pretty harmless.
clang-cl has some sanity checks to make sure that the cl.exe it finds is
