Author: davidxl
Date: Wed Oct 28 23:04:07 2015
New Revision: 251611
URL: http://llvm.org/viewvc/llvm-project?rev=251611&view=rev
Log:
Fix a soon to be invalid test
Remove a check that won't be valid when LLVM stops
emitting runtime hook user function.
Modified:
cfe/trunk/test/Profile/gcc-fla
Author: davidxl
Date: Wed Nov 4 23:46:39 2015
New Revision: 252147
URL: http://llvm.org/viewvc/llvm-project?rev=252147&view=rev
Log:
Use profile data template file for covmap func record (NFC)
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMap
Author: davidxl
Date: Sun Nov 8 18:04:16 2015
New Revision: 252434
URL: http://llvm.org/viewvc/llvm-project?rev=252434&view=rev
Log:
[PGO] Code cleanup [NFC]
Use interfaces defined in LLVM to create FuncName
and FuncNameVar.
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
Modified: cfe/trun
The new behavior works really well. There is one follow up change I would
like to discuss.
The EQ form of the option -fprofile-generate= takes a directory name as the
argument instead of the filename. Currently the compiler will create a
default 'default.profraw' name for it, but this means, onlin
On Tue, Jul 19, 2016 at 5:06 PM, Vedant Kumar wrote:
>
> > On Jul 19, 2016, at 5:01 PM, Xinliang David Li
> wrote:
> >
> > The new behavior works really well. There is one follow up change I
> would like to discuss.
> >
> > The EQ form of the option -fprofile-generate= takes a directory name as
Author: davidxl
Date: Wed Jul 20 18:32:50 2016
New Revision: 276207
URL: http://llvm.org/viewvc/llvm-project?rev=276207&view=rev
Log:
[Profile] Document new profile file name modifiers
Differential Revision: http://reviews.llvm.org/D22593
Modified:
cfe/trunk/docs/UsersManual.rst
Modified:
ok
David
On Wed, Jul 20, 2016 at 4:32 PM, Sean Silva wrote:
> silvas accepted this revision.
> silvas added a comment.
> This revision is now accepted and ready to land.
>
> LGTM (also, another small suggestion).
>
>
>
> Comment at: docs/UsersManual.rst:1502
> @@ +1501,3 @@
> +
Author: davidxl
Date: Thu Jul 21 18:19:39 2016
New Revision: 276356
URL: http://llvm.org/viewvc/llvm-project?rev=276356&view=rev
Log:
[profile] update test case with interface change.
See http://reviews.llvm.org/D22613, http://reviews.llvm.org/D22614
Modified:
cfe/trunk/test/Profile/c-genera
Author: davidxl
Date: Fri Jul 22 17:25:01 2016
New Revision: 276484
URL: http://llvm.org/viewvc/llvm-project?rev=276484&view=rev
Log:
[Profile] Enable profile merging with -fprofile-generat[=]
This patch enables raw profile merging for this option which is the
new intended behavior.
Modified:
Author: davidxl
Date: Fri Jul 22 23:28:59 2016
New Revision: 276517
URL: http://llvm.org/viewvc/llvm-project?rev=276517&view=rev
Log:
[Profile] Use a flag to enable PGO rather than the profraw filename
Patch by Jake VanAdrighem
Differential Revision: http://reviews.llvm.org/D22608
Modified:
On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson wrote:
>
>> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits
>> wrote:
>>
>> silvas added a comment.
>>
>> In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
>>
>>> For the longer term, one possible solution is to make FE based
>>> instrum
On Wed, Feb 3, 2016 at 12:40 PM, Bob Wilson wrote:
>
> On Feb 3, 2016, at 12:23 PM, Xinliang David Li wrote:
>
> On Tue, Feb 2, 2016 at 1:31 PM, Bob Wilson wrote:
>
>
> On Jan 22, 2016, at 1:43 PM, Sean Silva via cfe-commits
> wrote:
>
> silvas added a comment.
>
> In http://reviews.llvm.org/D1
Author: davidxl
Date: Thu Feb 4 13:54:17 2016
New Revision: 259819
URL: http://llvm.org/viewvc/llvm-project?rev=259819&view=rev
Log:
[PGO] code simplification: use existing VP annotation API /NFC
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
U
Author: davidxl
Date: Fri Feb 5 17:36:08 2016
New Revision: 259955
URL: http://llvm.org/viewvc/llvm-project?rev=259955&view=rev
Log:
[PGO] Test case update
Temporarily relax check in test to avoid
breakage for format change in LLVM side. Once that is
done, the test case will be retighten
Author: davidxl
Date: Sun Feb 7 00:57:29 2016
New Revision: 260021
URL: http://llvm.org/viewvc/llvm-project?rev=260021&view=rev
Log:
[PGO] add profile/coverage test cases for defaulted ctor/ctors
Added:
cfe/trunk/test/Profile/def-ctors.cpp
cfe/trunk/test/Profile/def-dtors.cpp
Added: cfe
Author: davidxl
Date: Sun Feb 7 01:13:18 2016
New Revision: 260022
URL: http://llvm.org/viewvc/llvm-project?rev=260022&view=rev
Log:
Fix test case problem(caused by clang-format
Modified:
cfe/trunk/test/Profile/def-ctors.cpp
cfe/trunk/test/Profile/def-dtors.cpp
Modified: cfe/trunk/test/
Author: davidxl
Date: Mon Feb 8 13:14:14 2016
New Revision: 260126
URL: http://llvm.org/viewvc/llvm-project?rev=260126&view=rev
Log:
Simplify test cases
Modified:
cfe/trunk/test/Profile/def-ctors.cpp
cfe/trunk/test/Profile/def-dtors.cpp
Modified: cfe/trunk/test/Profile/def-ctors.cpp
URL
Both cfe-commits and llvm-commits are cc'ed.
David
On Mon, Feb 8, 2016 at 11:29 AM, David Blaikie wrote:
> This looks like a change to clang - could you test it in clang (& review it
> on cfe-commits instead of llvm-commits)?
>
> On Sat, Feb 6, 2016 at 11:57 AM, Dav
On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits
> wrote:
>>
>> davidxl updated this revision to Diff 47217.
>> davidxl added a comment.
>>
>> Simplified test case suggested by Vedant.
>>
>>
>> http://reviews.llvm.org/D16947
>>
Author: davidxl
Date: Mon Feb 8 16:41:37 2016
New Revision: 260161
URL: http://llvm.org/viewvc/llvm-project?rev=260161&view=rev
Log:
[PGO] Cover more cases of implicitly generated C++ methods
Modified:
cfe/trunk/test/Profile/cxx-implicit.cpp
Modified: cfe/trunk/test/Profile/cxx-implicit.cpp
On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li
> wrote:
>>
>> On Mon, Feb 8, 2016 at 11:39 AM, David Blaikie wrote:
>> >
>> >
>> > On Mon, Feb 8, 2016 at 9:25 AM, David Li via llvm-commits
>> > wrote:
>> >>
>> >> davidxl updated thi
On Mon, Feb 8, 2016 at 3:35 PM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 3:21 PM, Xinliang David Li
> wrote:
>>
>> On Mon, Feb 8, 2016 at 3:17 PM, David Blaikie wrote:
>> >
>> >
>> > On Mon, Feb 8, 2016 at 12:07 PM, Xinliang David Li
>> > wrote:
>> >>
>> >> On Mon, Feb 8, 2016 at 11:39
To be clear, you are suggesting breaking the test into two (one for
copy, and one for move) ? I am totally fine with that. I thought you
suggested removing the testing of move/op case because they might
share the same code path (clang's implementation) as the copy/op.
thanks,
David
On Mon, Feb
On Mon, Feb 8, 2016 at 4:05 PM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 3:58 PM, Xinliang David Li
> wrote:
>>
>> To be clear, you are suggesting breaking the test into two (one for
>> copy, and one for move) ? I am totally fine with that.
>
>
> Nah, no need to split the test case - we
ha! somehow I kept thinking you are referring to implicit declared ctors.
From your test case, it is seems that the implicit copy/move op is
also broken and is fixed by this patch too. That means a missing test
case to me. Will update the case when verified.
thanks,
David
On Mon, Feb 8, 2016
I took a look at the problem. The implicitly defaulted operators
should not be instrumented as specified -- I actually I just added the
new test case for that (checking profile counter not generated) right
after my previous reply and it still passes with this patch. The
reason is that those operato
On Mon, Feb 8, 2016 at 8:46 PM, David Blaikie wrote:
>
> On Mon, Feb 8, 2016 at 7:39 PM, Xinliang David Li
> wrote:
>>
>> I took a look at the problem. The implicitly defaulted operators
>> should not be instrumented as specified -- I actually I just added the
>> new test case for that (checking
Wrong in the sense the the coverage result for the default operators
(the line where they are declared) is marked as if they are not called
which can be confusing to the user.
David
On Mon, Feb 8, 2016 at 9:09 PM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 9:00 PM, Xinliang David Li
> wr
On Tue, Feb 9, 2016 at 11:14 AM, David Blaikie wrote:
>
>
> On Mon, Feb 8, 2016 at 9:23 PM, Xinliang David Li
> wrote:
>>
>> Wrong in the sense the the coverage result for the default operators
>> (the line where they are declared) is marked as if they are not called
>> which can be confusing to
On Tue, Feb 9, 2016 at 11:30 AM, David Blaikie wrote:
>
>
> On Tue, Feb 9, 2016 at 11:26 AM, Xinliang David Li
> wrote:
>>
>> On Tue, Feb 9, 2016 at 11:14 AM, David Blaikie wrote:
>> >
>> >
>> > On Mon, Feb 8, 2016 at 9:23 PM, Xinliang David Li
>> > wrote:
>> >>
>> >> Wrong in the sense the the
On Tue, Feb 9, 2016 at 11:44 AM, David Blaikie wrote:
>
>
> On Tue, Feb 9, 2016 at 11:41 AM, Xinliang David Li
> wrote:
>>
>> On Tue, Feb 9, 2016 at 11:30 AM, David Blaikie wrote:
>> >
>> >
>> > On Tue, Feb 9, 2016 at 11:26 AM, Xinliang David Li
>> > wrote:
>> >>
>> >> On Tue, Feb 9, 2016 at 11
Author: davidxl
Date: Tue Feb 9 14:02:59 2016
New Revision: 260270
URL: http://llvm.org/viewvc/llvm-project?rev=260270&view=rev
Log:
[PGO] Fix issue: explicitly defaulted assignop is not profiled
Differential Revision: http://reviews.llvm.org/D16947
Added:
cfe/trunk/test/Profile/def-as
Author: davidxl
Date: Tue Feb 16 18:58:13 2016
New Revision: 261046
URL: http://llvm.org/viewvc/llvm-project?rev=261046&view=rev
Log:
Restrengthen tests relaxed in r259955
Modified:
cfe/trunk/test/CoverageMapping/ir.c
cfe/trunk/test/CoverageMapping/unused_names.c
Modified: cfe/trunk/test
Author: davidxl
Date: Tue Feb 16 18:59:01 2016
New Revision: 261047
URL: http://llvm.org/viewvc/llvm-project?rev=261047&view=rev
Log:
Test simplification
Modified:
cfe/trunk/test/Profile/def-assignop.cpp
Modified: cfe/trunk/test/Profile/def-assignop.cpp
URL:
http://llvm.org/viewvc/llvm-proj
Author: davidxl
Date: Mon Apr 18 12:48:12 2016
New Revision: 266638
URL: http://llvm.org/viewvc/llvm-project?rev=266638&view=rev
Log:
Update InstrProf pass creator API reference
Modified:
cfe/trunk/lib/CodeGen/BackendUtil.cpp
Modified: cfe/trunk/lib/CodeGen/BackendUtil.cpp
URL:
http://llvm.
Can you also try IR based instrumentation? -fprofile-instr-generate
-Xclang=-fprofile-instrument=llvm
David
On Tue, Apr 19, 2016 at 9:40 AM, Adam Nemet wrote:
> anemet added a comment.
>
> As discussed under http://reviews.llvm.org/D17864, I did a run with this
> and I don't get the indirect c
Author: davidxl
Date: Wed May 25 12:25:57 2016
New Revision: 270728
URL: http://llvm.org/viewvc/llvm-project?rev=270728&view=rev
Log:
Use new triple API to check comdat /NFC
Modified:
cfe/trunk/lib/CodeGen/TargetInfo.cpp
Modified: cfe/trunk/lib/CodeGen/TargetInfo.cpp
URL:
http://llvm.org/vi
On Fri, Jul 1, 2016 at 4:32 PM, Sean Silva wrote:
> silvas added inline comments.
>
>
> Comment at: lib/Driver/Tools.cpp:3560
> @@ +3559,3 @@
> +if (PGOTrainArg->getOption().matches(options::OPT_fpgo_train_EQ)) {
> + if (StringRef(PGOTrainArg->getValue()) == "source-cfg"
Sanitizers are different IMO. Different santizers are rather independent,
and there is no such thing as -fsantize to mean -fsantize=all
For PGO, in most of the cases, users do not need to care about the
sub-options implied -- by default they should just get the best profiling
(whatever that is). F
On Sun, Jul 3, 2016 at 1:50 PM, Sean Silva wrote:
>
>
> On Sat, Jul 2, 2016 at 7:38 PM, Xinliang David Li
> wrote:
>
>> Sanitizers are different IMO. Different santizers are rather independent,
>> and there is no such thing as -fsantize to mean -fsantize=all
>>
>> For PGO, in most of the cases,
On Mon, Mar 28, 2016 at 10:40 AM, Adam Nemet wrote:
> anemet added inline comments.
>
>
> Comment at: lib/CodeGen/CodeGenPGO.cpp:758
> @@ -757,1 +757,3 @@
>
> + // During instrumentation, function pointers are collected for the
> different
> + // indirect call targets. Then as
On Mon, Mar 28, 2016 at 12:31 PM, Adam Nemet wrote:
> anemet added inline comments.
>
>
> Comment at: lib/CodeGen/CodeGenPGO.cpp:758
> @@ -757,1 +757,3 @@
>
> + // During instrumentation, function pointers are collected for the
> different
> + // indirect call targets. Then as
What I meant is that putting the comments in InstrProfData.inc file, and
update the one in CodeGenPGO.cpp to reference that.
David
On Mon, Mar 28, 2016 at 12:35 PM, Xinliang David Li
wrote:
>
>
> On Mon, Mar 28, 2016 at 12:31 PM, Adam Nemet wrote:
>
>> anemet added inline comments.
>>
>> =
Sure.
thanks,
David
On Mon, Mar 28, 2016 at 12:41 PM, Adam Nemet wrote:
> anemet added a comment.
>
> In http://reviews.llvm.org/D18489#384851, @davidxl wrote:
>
> > What I meant is that putting the comments in InstrProfData.inc file, and
> > update the one in CodeGenPGO.cpp to reference that
Author: davidxl
Date: Sun Jan 3 13:25:54 2016
New Revision: 256714
URL: http://llvm.org/viewvc/llvm-project?rev=256714&view=rev
Log:
[PGO] Cleanup: Use covmap header definition in the template file
This is one last remaining instrumentatation related structure
that needs to be migrate to use the
Author: davidxl
Date: Mon Jan 18 18:49:06 2016
New Revision: 258106
URL: http://llvm.org/viewvc/llvm-project?rev=258106&view=rev
Log:
Fix local variable name /NFC
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
cfe/trunk/lib/CodeGen/CoverageMappingGen.h
Modified: cfe/trunk/lib/Cod
Author: davidxl
Date: Tue Jan 19 18:24:52 2016
New Revision: 258261
URL: http://llvm.org/viewvc/llvm-project?rev=258261&view=rev
Log:
Reference the updated function name /NFC
Modified:
cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
Modified: cfe/trunk/lib/CodeGen/CoverageMappingGen.cpp
URL:
h
For the longer term, one possible solution is to make FE based
instrumentation only used for coverage testing which can be turned on
with -fcoverage-mapping option (currently, -fcoverage-mapping can not
be used alone and must be used together with
-fprofile-instr-generate). To summarize:
A. Curren
On Fri, Jan 22, 2016 at 1:43 PM, Sean Silva wrote:
> silvas added a comment.
>
> In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
>
>> For the longer term, one possible solution is to make FE based
>> instrumentation only used for coverage testing which can be turned on
>> with -fcovera
We first need to nail the use model of the option, and then talk about
implementation. To clarify, I think the following should be the way:
(assuming the current clang instrumetnation is the default):
1) To turn on clang based instrumentation:
-fprofile-instr-generate[=]
2) To turn on clang bas
Author: davidxl
Date: Thu Jan 28 12:25:53 2016
New Revision: 259067
URL: http://llvm.org/viewvc/llvm-project?rev=259067&view=rev
Log:
[PGO] test case cleanups
1. Make test case more focused and robust by focusing on what to be tested
(linkage, icall) -- make it easier to validate
2. Testing link
On Thu, Jan 28, 2016 at 2:34 PM, Rong Xu wrote:
> The previous patch was not good as it failed 58 tests that use
> -fprofile-instr-generate as a cc1 option.
>
> I can see two methods to solve this:
> (1) we change all the 58 tests to use -fprofile-instrument=Clang option.
My vote is on (1) -- get
Author: davidxl
Date: Sun Nov 22 23:09:10 2015
New Revision: 253846
URL: http://llvm.org/viewvc/llvm-project?rev=253846&view=rev
Log:
Disable frame pointer elimination when using -pg
This diff makes sure that the driver does not pass
-fomit-frame-pointer or -momit-leaf-frame-pointer to
the fronte
Author: davidxl
Date: Sun Nov 22 23:41:05 2015
New Revision: 253851
URL: http://llvm.org/viewvc/llvm-project?rev=253851&view=rev
Log:
Revert r253846 (build bot failure))
Removed:
cfe/trunk/test/CodeGen/x86_64-profiling-keep-fp.c
Modified:
cfe/trunk/lib/Driver/Tools.cpp
cfe/trunk/lib/F
Author: davidxl
Date: Mon Nov 23 11:30:31 2015
New Revision: 253886
URL: http://llvm.org/viewvc/llvm-project?rev=253886&view=rev
Log:
Disable frame pointer elimination when using -pg
(Re-apply patch after bug fixing)
This diff makes sure that the driver does not pass
-fomit-frame-pointer or -mo
Author: davidxl
Date: Fri Dec 4 23:37:15 2015
New Revision: 254839
URL: http://llvm.org/viewvc/llvm-project?rev=254839&view=rev
Log:
Pass profile version info to name API (NFC)
Modified:
cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
Modified: cfe/trunk/lib/CodeGen/CodeGenPGO.cpp
URL:
http://llvm.or
Author: davidxl
Date: Thu Dec 10 22:02:57 2015
New Revision: 255326
URL: http://llvm.org/viewvc/llvm-project?rev=255326&view=rev
Log:
[PGO] Add a test case to cover version-3 format
Added:
cfe/trunk/test/Profile/Inputs/c-general.profdata.v3 (with props)
Modified:
cfe/trunk/test/Profile/
Author: davidxl
Date: Fri Dec 11 13:53:35 2015
New Revision: 255366
URL: http://llvm.org/viewvc/llvm-project?rev=255366&view=rev
Log:
[PGO] Stop using invalid char in instr variable names.
(This is part-2 of the patch -- fixing test cases)
Before the patch, -fprofile-instr-generate compile will
Author: davidxl
Date: Fri Dec 11 14:23:12 2015
New Revision: 255368
URL: http://llvm.org/viewvc/llvm-project?rev=255368&view=rev
Log:
[PGO] Revert r255366: solution incomplete, not handling lambda yet
Modified:
cfe/trunk/test/CoverageMapping/unused_names.c
cfe/trunk/test/Profile/Inputs/c-
Author: davidxl
Date: Sat Dec 12 11:28:37 2015
New Revision: 255435
URL: http://llvm.org/viewvc/llvm-project?rev=255435&view=rev
Log:
[PGO] Stop using invalid char in instr variable names.
(This is part-2 of the patch of r255434 --
fixing test cases, second try)
Modified:
cfe/trunk/test/Co
Author: davidxl
Date: Sat Dec 12 11:39:38 2015
New Revision: 255436
URL: http://llvm.org/viewvc/llvm-project?rev=255436&view=rev
Log:
[PGO] add a test case with -no-integrated-as
Added:
cfe/trunk/test/Profile/cxx-static.cpp
Added: cfe/trunk/test/Profile/cxx-static.cpp
URL:
http://llvm.org/v
Author: davidxl
Date: Sat Dec 12 12:49:37 2015
New Revision: 255437
URL: http://llvm.org/viewvc/llvm-project?rev=255437&view=rev
Log:
Revert 255436 : remove test that needs to be refined
Removed:
cfe/trunk/test/Profile/cxx-static.cpp
Removed: cfe/trunk/test/Profile/cxx-static.cpp
URL:
http:
Author: davidxl
Date: Sat Dec 12 21:03:35 2015
New Revision: 255445
URL: http://llvm.org/viewvc/llvm-project?rev=255445&view=rev
Log:
Resubmit new test case after adding more constraint
Added:
cfe/trunk/test/Profile/cxx-static.cpp
Added: cfe/trunk/test/Profile/cxx-static.cpp
URL:
http://llv
Author: davidxl
Date: Sat Dec 12 22:45:49 2015
New Revision: 255447
URL: http://llvm.org/viewvc/llvm-project?rev=255447&view=rev
Log:
Revert r255445: adding a new test case
Removed:
cfe/trunk/test/Profile/cxx-static.cpp
Removed: cfe/trunk/test/Profile/cxx-static.cpp
URL:
http://llvm.org/vie
On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner wrote:
> Easwaran Raman writes:
>> eraman updated this revision to Diff 42549.
>> eraman added a comment.
>>
>> Added a test case.
>>
>>
>> Repository:
>> rL LLVM
>>
>> http://reviews.llvm.org/D15163
>>
>> Files:
>> lib/CodeGen/CodeGenModule.cpp
On Fri, Dec 11, 2015 at 6:19 PM, Justin Bogner wrote:
> Easwaran Raman writes:
>> eraman updated this revision to Diff 42549.
>> eraman added a comment.
>>
>> Added a test case.
>>
>>
>> Repository:
>> rL LLVM
>>
>> http://reviews.llvm.org/D15163
>>
>> Files:
>> lib/CodeGen/CodeGenModule.cpp
Author: davidxl
Date: Mon Dec 14 17:26:46 2015
New Revision: 255576
URL: http://llvm.org/viewvc/llvm-project?rev=255576&view=rev
Log:
[PGO] Shorten profile symbol prefixes
(test case update)
Profile symbols have long prefixes which waste space and creating pressure for
linker.
This patch shorten
Author: davidxl
Date: Mon Dec 14 18:33:12 2015
New Revision: 255587
URL: http://llvm.org/viewvc/llvm-project?rev=255587&view=rev
Log:
[PGO] make profile prefix even shorter and more readable
Modified:
cfe/trunk/test/CoverageMapping/ir.c
cfe/trunk/test/CoverageMapping/unused_names.c
cf
301 - 368 of 368 matches
Mail list logo
