[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 408970. dgoldman marked 4 inline comments as done. dgoldman added a comment. Template and variable casing fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. In D119363#3323778 , @sammccall wrote: > I'm a bit concerned about the parent map vs ASTMatchFinder's view being out > of sync: we'll have a ProtocolLoc node that has a parent but the parent > doesn't have the child. > > I'm no

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman updated this revision to Diff 409005. dgoldman marked 3 inline comments as done. dgoldman added a comment. Template fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119363/new/ https://reviews.llvm.org/D119363 Files: clang/include/cl

[PATCH] D119363: [clang] Add `ObjCProtocolLoc` to represent protocol references

dgoldman added a comment. In D119363#3324024 , @sammccall wrote: > In D119363#3323867 , @dgoldman > wrote: > >> In D119363#3323778 , @sammccall >> wrote: >> >>> I'm a bi

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Use the expression's type fo

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425354. dgoldman added a comment. Minor formatting fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https://reviews.llvm.org/D124486 Files: clang-tools-extra/clangd/refactor/tweaks/ExtractVaria

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425644. dgoldman marked 5 inline comments as done. dgoldman added a comment. - Don't use a method for computing the type - Compute the type using printType - Support MemberExprs and add a test for function pointers Repository: rG LLVM Github Monorepo CHA

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSetter()) { sammccall wrote:

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425650. dgoldman added a comment. - Remove extraneous computeExprType declaration Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https://reviews.llvm.org/D124486 Files: clang-tools-extra/clangd/r

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added projects: clang, clang-

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman updated this revision to Diff 425914. dgoldman marked 6 inline comments as done. dgoldman added a comment. - Extract var type handling to a function - Other fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https:/

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSe

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman added inline comments. Comment at: llvm/include/llvm/Support/Threading.h:239 }; /// If priority is Background tries to lower current threads priority such /// that it does not affect foreground tasks significantly. Can be used for Should be "Low

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman accepted this revision. dgoldman added a comment. This revision is now accepted and ready to land. In D124715#3484058 , @stefanhaller wrote: > Fix documentation of ThreadPriority::Low (was: Background), and move it up > from > set_thread_priori

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

dgoldman added a comment. In D124715#3490364 , @stefanhaller wrote: > In D124715#3488447 , @sammccall > wrote: > >> (How) does this interact with battery vs mains power on laptops? >> It seems like there's a com

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124637/new/ https://reviews.llvm.org/D124637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman marked an inline comment as done. dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124486/new/ https://reviews.llvm.org/D124486 ___ cfe-commits mailing list

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman created this revision. dgoldman added reviewers: kadircet, sammccall. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-e

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman updated this revision to Diff 445618. dgoldman added a comment. Revert unintended change in symbol-info.test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 Files: clang-tools-extra/clangd/AST.

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added a comment. For more context see the discussion on b/187405187 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130041/new/ https://reviews.llvm.org/D130041 ___ cfe-commits mailing list cfe-co

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman created this revision. dgoldman added a reviewer: kadircet. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - C

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman updated this revision to Diff 445873. dgoldman added a comment. Run clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/clan

[PATCH] D130041: [clangd] Add decl/def support to SymbolDetails

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:174 auto L = D.getLocation(); + // Use the start of the first selector fragment instead of the -/+ location. + if (const auto *MD = dyn_cast(&D)) kadircet wrote: > can we do this in

[PATCH] D130095: [clangd] Improve XRefs support for ObjCMethodDecl

dgoldman updated this revision to Diff 445951. dgoldman added a comment. Minor grammar update to comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D130095/new/ https://reviews.llvm.org/D130095 Files: clang-tools-extra/clangd/AST.cpp clang-t

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

dgoldman updated this revision to Diff 430974. dgoldman marked an inline comment as done. dgoldman added a comment. Go through chunks in getName and add missed FilterText place Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124637/new/ https://revie

[PATCH] D124637: [clangd][ObjC] Filter ObjC method completions on the remaining selector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG322e2a3b40fa: [clangd][ObjC] Filter ObjC method completions on the remaining selector (authored by dgoldman). Repository: rG LLVM Github Monorepo

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:170 + if (E->hasPlaceholderType(BuiltinType::PseudoObject)) { +if (const auto *PR = dyn_cast(E)) { + if (PR->isMessagingSetter()) { dgoldman wrote:

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > oops, I forgot one

[PATCH] D124486: [clangd] ExtractVariable support for C and Objective-C

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp:418 + if (const auto *ME = dyn_cast(E)) +if (const auto *TE = dyn_cast(ME->getBase())) + if (TE->isImplicit()) sammccall wrote: > dgoldman wrote: >

[PATCH] D62648: [Sema][Typo] Fix assertion failure for expressions with multiple typos

This revision was automatically updated to reflect the committed changes. Closed by commit rL369427: [Sema][Typo] Fix assertion failure for expressions with multiple typos (authored by dgoldman, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: r

[PATCH] D72415: [clangd] Respect `--sysroot` argument if it is set

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. - Since `--sysroot` is a superset of the `-isysroot` argument, we shouldn't add the `-isysro

[PATCH] D72415: [clangd] Respect `--sysroot` argument if it is set

This revision was automatically updated to reflect the committed changes. Closed by commit rGea9888b8f6f2: [clangd] Respect `--sysroot` argument if it is set (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72415/new/ https://re

[PATCH] D72508: [clangd] Support pseudo-obj expr, opaque values, and property references in findExplicitReferences()

dgoldman requested changes to this revision. dgoldman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/FindTarget.cpp:624 + /*IsDecl=*/false, + // Select the getter, setter, or @property depending on the

[PATCH] D72494: [clangd] Fix targetDecl() on certain usage of ObjC properties.

dgoldman accepted this revision. dgoldman added a comment. LGMT, thanks for fixing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72494/new/ https://reviews.llvm.org/D72494 ___ cfe-commits mailing list

[PATCH] D72634: [clangd] Improve ObjC property handling in SelectionTree.

dgoldman requested changes to this revision. dgoldman added inline comments. This revision now requires changes to proceed. Comment at: clang-tools-extra/clangd/unittests/SelectionTests.cpp:347 + )cpp", + "ObjCPropertyRefExpr"}, + Please add a t

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman, jkorous, MaskRay, ilya-biryukov. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72647 Files: clang-tools-

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman updated this revision to Diff 237791. dgoldman added a comment. - Fix broken did-change-configuration test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72647/new/ https://reviews.llvm.org/D72647 Files: clang-tools-extra/clangd/ClangdLS

[PATCH] D72647: [clangd] Only re-open files if their flags changed

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/ClangdLSPServer.cpp:1126 + std::set ModifiedFiles; + auto Sub = + CDB->watch([&ModifiedFiles](const std::vector Changes) { sammccall wrote: > this is a clever technique. (Why not just use

[PATCH] D68590: [clangd] Improve hover support for Objective-C

dgoldman updated this revision to Diff 309611. dgoldman added a comment. - Rebase + refactor, sorry for the long delay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I think there's still some more work to be done after this which might move some of this around: - DocumentSymbol support: Currently categories show up as (anonymous) or (see here

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309983. dgoldman added a comment. Swap to isa Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/clangd/un

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 309987. dgoldman added a comment. Add protocol test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/Hover.cpp clang-tools-extra/cla

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. I messed around with qualified name changes - lots of things internally rely upon the qualified names so that will be best for a separate change. I could potentially handle `DocumentSymbol` fixes in here though - LMK if you think it makes sense to move some of this log

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman created this revision. Herald added subscribers: cfe-commits, usaxena95, kadircet, arphaman. Herald added a project: clang. dgoldman requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Nullability annotations are implmented using attributes; previusly clan

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:621-623 + if (auto AT = TL->getAs()) +S = AT.getModifiedLoc() +.getSourceRange(); // should we just return false? Let me know if you think it would be

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 298757. dgoldman added a comment. Lint fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clangd

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 298759. dgoldman added a comment. Fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selection.cpp clang-tools-extra/clangd/

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 299038. dgoldman marked 5 inline comments as done. dgoldman added a comment. Update with changes requested - Looking into extract failure Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://revie

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added a comment. With that change, somehow this extract test is now failing: - TEST 'Clangd Unit Tests :: ./ClangdTests/ExtractFunctionTest.FunctionTest' FAILED Note: Google Test filter = ExtractFunctionTest.FunctionTest [==] Running 1 test from 1 test case

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:611 + // robust. + return false; if (!SelChecker.mayHit(S)) { sammccall wrote: > I'm not sure we actually want to *do it* at this point, as you're seeing we > may h

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman added a comment. In D89579#2341513 , @sammccall wrote: > Yep, let's revert to the previous state and land that, and I'll puzzle over > the examples you give (because always returning false shouldn't affect > behavior, just performance). > > I ha

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

dgoldman updated this revision to Diff 299356. dgoldman added a comment. Revert to previous AttributedTypeLoc behavior Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://reviews.llvm.org/D89579 Files: clang-tools-extra/clangd/Selec

[PATCH] D89579: [clangd][ObjC] Support nullability annotations

This revision was automatically updated to reflect the committed changes. Closed by commit rGd5c022d84699: [clangd][ObjC] Support nullability annotations (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89579/new/ https://review

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

dgoldman added a comment. Friendly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101645/new/ https://reviews.llvm.org/D101645 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman updated this revision to Diff 349014. dgoldman added a comment. Add another test for a simple method decl (no arg selector) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100798/new/ https://reviews.llvm.org/D100798 Files: clang-tools-ex

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeCompletionStrings.cpp:160 + // + // e.g. to complete `- (void)doSomething:(id)argument`: + // - Completion name: `doSomething:` -

[PATCH] D100798: [clangd][ObjC] Fix issue completing a method decl by name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG2a030e680e08: [clangd][ObjC] Fix issue completing a method decl by name (authored by dgoldman). Repositor

[PATCH] D101645: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver

This revision was automatically updated to reflect the committed changes. Closed by commit rG13a8aa3ee15a: [clang] RecursiveASTVisitor visits ObjCPropertyRefExpr's class receiver (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman updated this revision to Diff 349259. dgoldman marked an inline comment as done. dgoldman added a comment. Add `isDefaultLibrary(const Type *)` and support auto/decl types Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101554/new/ https://r

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/SemanticHighlighting.cpp:436 + if (HB.inDefaultLibrary(D->getLocation())) +return HighlightingModifier::DefaultLibrary; const DeclContext *DC = D->getDeclContex

[PATCH] D101554: [clangd] Add support for the `defaultLibrary` semantic token modifier

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dgoldman marked an inline comment as done. Closed by commit rG2f951ca98b7a: [clangd] Add support for the `defaultLibrary` semantic token modifier (authored by dgoldman)

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/unittests/SymbolCollectorTests.cpp:1807-1811 +@interface Foo +- (void)fun:(bool)foo + bar:(bool)bar, + baz:(bool)baz; +@end It's hard to tell what Clang makes of this, I t

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman requested changes to this revision. dgoldman added a comment. This revision now requires changes to proceed. Looks good but I think for posterity we should add a similar test to clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp for the exact intended code complete behavior (or in

[PATCH] D94919: [clangd] Fix a crash when indexing invalid ObjC method declaration

dgoldman accepted this revision. dgoldman added a comment. This revision is now accepted and ready to land. In D94919#2515987 , @adamcz wrote: > The crash happens while indexing the file, not during code completion. The > code completion tests generally s

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

This revision was automatically updated to reflect the committed changes. Closed by commit rGd75fb1ee794e: [clangd] Support `#pragma mark` in the outline (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://revie

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. - Support enums in C

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

dgoldman updated this revision to Diff 376635. dgoldman marked an inline comment as done. dgoldman added a comment. Minor fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110954/new/ https://reviews.llvm.org/D110954 Files: clang-to

[PATCH] D110954: [clangd] Improve PopulateSwitch tweak

This revision was automatically updated to reflect the committed changes. Closed by commit rGa90d57b6cc5f: [clangd] Improve PopulateSwitch tweak (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110954/new/ https://reviews.llvm.o

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added a comment. Friendly ping, I think this is still worth merging in even without the QName changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 __

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323141. dgoldman marked 7 inline comments as done. dgoldman added a comment. - Address review comments Will move over to AST.cpp in next update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https:/

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/Hover.cpp:64 +static llvm::StringRef getNameForObjCInterface(const ObjCInterfaceDecl *ID) { + return ID ? ID->getName() : "<>"; sammccall wrote: > this function's name doesn't really describe

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323151. dgoldman added a comment. - Move over to AST.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-extra/clangd/AST.cpp clang-tools-extra/

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

dgoldman updated this revision to Diff 323156. dgoldman marked an inline comment as done. dgoldman added a comment. - Support protocols Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llvm.org/D68590 Files: clang-tools-e

[PATCH] D68590: [clangd] Improve hover scopes for Objective-C code

This revision was automatically updated to reflect the committed changes. Closed by commit rG07c5a800dc17: Improve hover scopes for Objective-C code (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68590/new/ https://reviews.llv

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman created this revision. dgoldman added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang. - Categories will now be printed

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman updated this revision to Diff 323443. dgoldman added a comment. - Add class method test case + swap to auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96612/new/ https://reviews.llvm.org/D96612 Files: clang-tools-extra/clangd/AST.cpp

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:224 + if (const auto *C = dyn_cast(&ND)) +return printObjCContainer(*C); sammccall wrote: > I'm not sure this fits with the contract of

[PATCH] D96612: [clangd] Improve printing of Objective-C categories and methods

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/AST.cpp:228 +Out << (Method->isInstanceMethod() ? '-' : '+'); +Method->getSelector().print(Out); +return Out.str(); sammccall wrote: > in t

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman created this revision. dgoldman added reviewers: sammccall, kadircet. Herald added subscribers: usaxena95, arphaman. dgoldman requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Objective-C lets you u

[PATCH] D104540: [clangd] Dont index ObjCCategoryDecls for completion

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CodeComplete.cpp:1918 + // from the index, we reduce the noise in all the other completion scopes. + if (llvm::isa(&ND)) +return false; Seems like we should also ignore ObjCCategoryImplDec

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman added a comment. In D104117#2835599 , @sammccall wrote: > Drive by from vacation, sorry - can this be tackled "upstream" in > findExplicitReferences rather than special cased in syntax highlighting? > > That would help with xrefs, rename etc. Fe

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman updated this revision to Diff 353987. dgoldman added a comment. Minor comment fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ https://reviews.llvm.org/D104117 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp cl

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, kadircet wrote: > dgoldman wrote: > > kadircet wr

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 363562. dgoldman marked 4 inline comments as done. dgoldman added a comment. More fixes for review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-to

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:13 +namespace { +class CollectPragmaMarks : public clang::PPCallbacks { kadircet wrote: > can you nest this inside `clang::clangd` and drop the qualifiers ? Done, had to keep

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, kadirc

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked 2 inline comments as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:664 + } + // NextPragma is after us but before the next symbol. Our reign is over. + break; kadircet wrote: > I suppose

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked an inline comment as done. dgoldman added inline comments. Comment at: clang-tools-extra/clangd/FindSymbols.cpp:535 +/// by range. +std::vector mergePragmas(std::vector &Syms, + std::vector &Pragmas, dgoldm

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 364263. dgoldman added a comment. the third time is the charm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp c

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added a comment. Okay I think this is what you had in mind. LMK, if it's good I'll go ahead and delete the other ones Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 364840. dgoldman marked an inline comment as done. dgoldman added a comment. Simplify children moving Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman marked an inline comment as done. dgoldman added a comment. PTAL, also updated the test to no longer check the children's order Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 ___

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365196. dgoldman marked 9 inline comments as done. dgoldman added a comment. Address nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman added inline comments. Comment at: clang-tools-extra/clangd/CollectMacros.cpp:42 +if (isInsideMainFile(Loc, SM)) { + Position Start = sourceLocToPosition(SM, Loc); + Position End = {Start.line + 1, 0}; kadircet wrote: > are we fine with the

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365273. dgoldman marked 2 inline comments as done. dgoldman added a comment. Remove unnecessary AllOf Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365277. dgoldman added a comment. Remove more AllOfs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tool

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

dgoldman updated this revision to Diff 365279. dgoldman added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105904/new/ https://reviews.llvm.org/D105904 Files: clang-tools-extra/clangd/CollectMacros.cpp clang-tools-extra/clan

[PATCH] D105904: [clangd] Support `#pragma mark` in the outline

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGba06ac8b45ca: [clangd] Support `#pragma mark` in the outline (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

dgoldman updated this revision to Diff 355035. dgoldman added a comment. Fix clang-tidy warning Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ https://reviews.llvm.org/D104117 Files: clang-tools-extra/clangd/SemanticHighlighting.cpp

[PATCH] D104117: [clangd] Fix highlighting for implicit ObjC property refs

This revision was automatically updated to reflect the committed changes. Closed by commit rG570984204f24: [clangd] Fix highlighting for implicit ObjC property refs (authored by dgoldman). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104117/new/ ht

<    1   2   3   4   5   6   >