[PATCH] D65917: Added clang-tidy module for the Google style guide's category method naming rule.

dgatwood created this revision. dgatwood added a reviewer: stephanemoore. Herald added subscribers: cfe-commits, mgorny. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt clang-tools-

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 220123. dgatwood added a comment. Switched to objcMethodDecl(hasDeclContext(objcCategoryDecl())). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 221128. dgatwood marked 5 inline comments as done. dgatwood added a comment. Renamed to ExemptClassPrefixes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMak

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:23 + Finder->addMatcher(objcMethodDecl(hasDeclContext( + objcCategoryDecl())).bind(CustomCategoryMethodIdentifier), this); +} stephanemoo

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 221142. dgatwood added a comment. Updated the configuration key in the test file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt clang-tools-ex

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood marked an inline comment as done. dgatwood added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:23 + Finder->addMatcher(objcMethodDecl(hasDeclContext( + objcCategoryDecl())).bind(CustomCategoryMethodIdentifi

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood added a comment. Whoops. I was expecting to get emailed about review comments and never got anything, so I thought it was just not getting reviewed. I'll work on this again. Sorry about that. :-) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 218478. dgatwood added a comment. Incorporated feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/CMakeLists.txt clang-tools-extra/clang-tidy/google/Goo

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood marked 17 inline comments as done. dgatwood added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:57 + } + std::string method_name = method_declaration->getNameAsString(); + auto owning_objc_class_interface = me

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 218812. dgatwood marked 22 inline comments as done. dgatwood added a comment. Incorporated additional feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65917 Files: clang-tools-extra/clang-tidy/google/C

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 218953. dgatwood marked 7 inline comments as done. dgatwood added a comment. Fixed a couple of variable names in the .h file, renamed kCustomCategoryMethodIdentifier to CustomCategoryMethodIdentifier, and switched to llvm::any_of. CHANGES SINCE LAST ACTIO

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood added a comment. Ah. I expected my comments to be submitted as part of uploading a new revision. Still learning this UI. :-/ Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:57 + } + std::string method_name = method_declarat

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood updated this revision to Diff 219151. dgatwood marked 9 inline comments as done. dgatwood added a comment. Tweaked documentation, and replaced the one remaining instance of getNameAsString(). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65917/new/ https://reviews.llvm.org/D65

[PATCH] D65917: [clang-tidy] Added check for the Google style guide's category method naming rule.

dgatwood added inline comments. Comment at: clang-tools-extra/clang-tidy/google/RequireCategoryMethodPrefixesCheck.cpp:57 + } + std::string method_name = method_declaration->getNameAsString(); + auto owning_objc_class_interface = method_declaration->getClassInterface(); -