[clang] bd2bdad - void cast to suppress -Wunused-variable in non-asserts build

Author: David Blaikie Date: 2021-03-11T17:51:31-08:00 New Revision: bd2bdad19e5a3bf910da7c2d1936a7e18b47c084 URL: https://github.com/llvm/llvm-project/commit/bd2bdad19e5a3bf910da7c2d1936a7e18b47c084 DIFF: https://github.com/llvm/llvm-project/commit/bd2bdad19e5a3bf910da7c2d1936a7e18b47c084.diff

[clang] 5de3690 - Follow-up to D77598: Simplify API by passing template parameters only when used/to imply "TemplOverloaded/overloadable"

Author: David Blaikie Date: 2021-11-14T13:35:22-08:00 New Revision: 5de369056dee2c4de81625cb05a5c212a0bdc053 URL: https://github.com/llvm/llvm-project/commit/5de369056dee2c4de81625cb05a5c212a0bdc053 DIFF: https://github.com/llvm/llvm-project/commit/5de369056dee2c4de81625cb05a5c212a0bdc053.diff

[clang] 400eb59 - Add test for a case in D77598

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: 400eb59adf43b29af3117c163cf770e6d6e514f7 URL: https://github.com/llvm/llvm-project/commit/400eb59adf43b29af3117c163cf770e6d6e514f7 DIFF: https://github.com/llvm/llvm-project/commit/400eb59adf43b29af3117c163cf770e6d6e514f7.diff

[clang] 604446a - ast-dump: Add missing identation of class template specializations

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: 604446aa6b41461e2691c9f4253e9ef70a5d68e4 URL: https://github.com/llvm/llvm-project/commit/604446aa6b41461e2691c9f4253e9ef70a5d68e4 DIFF: https://github.com/llvm/llvm-project/commit/604446aa6b41461e2691c9f4253e9ef70a5d68e4.diff

[clang] b2589e3 - ast-print: Avoid extra whitespace before function opening brace

Author: David Blaikie Date: 2021-11-14T20:45:16-08:00 New Revision: b2589e326ba4407d8314938a4f7498086e2203ea URL: https://github.com/llvm/llvm-project/commit/b2589e326ba4407d8314938a4f7498086e2203ea DIFF: https://github.com/llvm/llvm-project/commit/b2589e326ba4407d8314938a4f7498086e2203ea.diff

[clang] 50fdd7d - Add more test coverage for D77598

Author: David Blaikie Date: 2021-11-14T21:09:11-08:00 New Revision: 50fdd7df827137c8465abafa82a6bae7c87096c5 URL: https://github.com/llvm/llvm-project/commit/50fdd7df827137c8465abafa82a6bae7c87096c5 DIFF: https://github.com/llvm/llvm-project/commit/50fdd7df827137c8465abafa82a6bae7c87096c5.diff

[clang] 5b773dc - Fix incorrect check for running out of source locations.

Author: Paul Pluzhnikov Date: 2022-10-18T20:48:00Z New Revision: 5b773dcd2de0c4844814266a90dac14c349b8f18 URL: https://github.com/llvm/llvm-project/commit/5b773dcd2de0c4844814266a90dac14c349b8f18 DIFF: https://github.com/llvm/llvm-project/commit/5b773dcd2de0c4844814266a90dac14c349b8f18.diff LO

[clang] 7846d59 - Extend the C++03 definition of POD to include defaulted functions

Author: David Blaikie Date: 2022-10-26T22:00:49Z New Revision: 7846d590033e8d661198f4c00f56f46a4993c526 URL: https://github.com/llvm/llvm-project/commit/7846d590033e8d661198f4c00f56f46a4993c526 DIFF: https://github.com/llvm/llvm-project/commit/7846d590033e8d661198f4c00f56f46a4993c526.diff LOG:

[clang] ec273d3 - Add a warning for not packing non-POD members in packed structs

Author: David Blaikie Date: 2022-10-26T22:18:51Z New Revision: ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af URL: https://github.com/llvm/llvm-project/commit/ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af DIFF: https://github.com/llvm/llvm-project/commit/ec273d3e3a8c3bcb2cf98f893f28bee5bf9b30af.diff LOG:

[clang] e4ec6ce - Clang: Add release note for defaulted-special-members-POD GCC ABI fix

Author: David Blaikie Date: 2022-10-27T20:41:22Z New Revision: e4ec6ce8a75c208b49b163c81cda90dc7373c791 URL: https://github.com/llvm/llvm-project/commit/e4ec6ce8a75c208b49b163c81cda90dc7373c791 DIFF: https://github.com/llvm/llvm-project/commit/e4ec6ce8a75c208b49b163c81cda90dc7373c791.diff LOG:

Re: [Diffusion] rGe4ec6ce8a75c: Clang: Add release note for defaulted-special-members-POD GCC ABI fix

Posted, awaiting approval. On Fri, Oct 28, 2022 at 5:23 AM Aaron Ballman wrote: > > Also, please be sure to post something to > https://discourse.llvm.org/c/announce/46 with the potentially-breaking > tag applied to it. > > ~Aaron > > On Thu, Oct 27, 2022 at 8:19 PM Hubert Tong via Phabricator vi

[clang] 97c1b00 - Follow-up to Itanium ABI POD patchnotes

Author: David Blaikie Date: 2022-10-28T22:29:50Z New Revision: 97c1b0094ad6f628927223b53300c9296ae72f44 URL: https://github.com/llvm/llvm-project/commit/97c1b0094ad6f628927223b53300c9296ae72f44 DIFF: https://github.com/llvm/llvm-project/commit/97c1b0094ad6f628927223b53300c9296ae72f44.diff LOG:

Re: [clang] a88ebd4 - Revert "[clang] Instantiate NTTPs and template default arguments with sugar"

Please include some details about the reason for a revert in the revert commit message in addition to the precanned revision/subject quoting On Wed, Oct 26, 2022 at 1:16 AM Matheus Izvekov via cfe-commits wrote: > > > Author: Matheus Izvekov > Date: 2022-10-26T10:14:27+02:00 > New Revision: a88eb

[clang] 06c70e9 - DebugInfo: Remove auto return type representation support

Author: David Blaikie Date: 2022-08-17T00:35:05Z New Revision: 06c70e9b998ca289630ee1629ec09b6dd51b29b9 URL: https://github.com/llvm/llvm-project/commit/06c70e9b998ca289630ee1629ec09b6dd51b29b9 DIFF: https://github.com/llvm/llvm-project/commit/06c70e9b998ca289630ee1629ec09b6dd51b29b9.diff LOG:

[clang] d4e0fe6 - Simplify RAV isSameMethod with constexpr if

Author: David Blaikie Date: 2022-08-19T04:00:21Z New Revision: d4e0fe62b1aa090527c0cc289cdf3eef0370f064 URL: https://github.com/llvm/llvm-project/commit/d4e0fe62b1aa090527c0cc289cdf3eef0370f064 DIFF: https://github.com/llvm/llvm-project/commit/d4e0fe62b1aa090527c0cc289cdf3eef0370f064.diff LOG:

Re: [clang] acaf6b9 - [NFC] Add [[maybe_unused]] to avoid warning in gcc9

Seems like a bug in the GCC9 warning - any chance we can disable it? (is it fixed in later versions of GCC?) I can't seem to reproduce this with godbolt at least with basic examples - it'd be good to know how bad the thing is we're working around so we know if we want to keep working around it, or

Re: [clang] acaf6b9 - [NFC] Add [[maybe_unused]] to avoid warning in gcc9

Thanks for the link - fair enough. We'll see how ubiquitous the constexpr-creating-sort-of-unused-variables situation is. If it comes up a lot we might want to disable the warning for GCC 9. On Mon, Aug 22, 2022 at 7:58 PM chuanqi.xcq wrote: > > Hi David, > > This is the reproduce link from god

[clang] 4cd7529 - [clang][DebugInfo] Emit access specifiers for typedefs

Author: Jonathan Camilleri Date: 2022-09-22T17:08:41Z New Revision: 4cd7529e4caa00fa7ba27d9de18adea3c702ad8f URL: https://github.com/llvm/llvm-project/commit/4cd7529e4caa00fa7ba27d9de18adea3c702ad8f DIFF: https://github.com/llvm/llvm-project/commit/4cd7529e4caa00fa7ba27d9de18adea3c702ad8f.diff

[clang] 1651289 - [clang] fix generation of .debug_aranges with LTO

Author: Azat Khuzhin Date: 2022-10-04T20:03:36Z New Revision: 16512898956857b13e566165ba9a195be81d325f URL: https://github.com/llvm/llvm-project/commit/16512898956857b13e566165ba9a195be81d325f DIFF: https://github.com/llvm/llvm-project/commit/16512898956857b13e566165ba9a195be81d325f.diff LOG:

[clang] 2e1c1d6 - MSVC AArch64 ABI: Homogeneous aggregates

Author: David Blaikie Date: 2022-10-04T20:17:29Z New Revision: 2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130 URL: https://github.com/llvm/llvm-project/commit/2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130 DIFF: https://github.com/llvm/llvm-project/commit/2e1c1d6d72879cafc339ad035b1b5a6d1c8cc130.diff LOG:

[clang] 4769976 - MSVC ABI: Looks like even non-aarch64 uses the MSVC/14 definition for pod/aggregate passing

Author: David Blaikie Date: 2022-10-04T20:19:17Z New Revision: 4769976c49be468d7629d513080e6959a25adcfe URL: https://github.com/llvm/llvm-project/commit/4769976c49be468d7629d513080e6959a25adcfe DIFF: https://github.com/llvm/llvm-project/commit/4769976c49be468d7629d513080e6959a25adcfe.diff LOG:

[clang] b61860e - Use inheriting ctors for OSTargetInfo

Author: David Blaikie Date: 2022-10-05T20:22:19Z New Revision: b61860e63e34d955a9841389583978af93c2b97a URL: https://github.com/llvm/llvm-project/commit/b61860e63e34d955a9841389583978af93c2b97a DIFF: https://github.com/llvm/llvm-project/commit/b61860e63e34d955a9841389583978af93c2b97a.diff LOG:

Re: [clang-tools-extra] 5d2d527 - [clangd] Avoid scanning up to end of file on each comment!

Could the underlying API be made more robust to handle StringRefs rather than null terminated char* in the first place? (like SourceManager::getCharacterData could return StringRef? Presumably at some layer it already knows how long the file is - the underlying MemoryBuffer, in this case) On Thu,

Re: [clang-tools-extra] 5d2d527 - [clangd] Avoid scanning up to end of file on each comment!

On Mon, Oct 10, 2022 at 11:13 AM Sam McCall wrote: > > On Mon, 10 Oct 2022, 19:57 David Blaikie, wrote: >> >> Could the underlying API be made more robust to handle StringRefs >> rather than null terminated char* in the first place? (like >> SourceManager::getCharacterData could return StringRef?

[clang] 9363071 - Move GCC-compatible pod-packing change to v16/old behavior available at v15 and below

Author: David Blaikie Date: 2022-10-13T21:13:19Z New Revision: 9363071303ec59bc9e0d9b989f08390b37e3f5e4 URL: https://github.com/llvm/llvm-project/commit/9363071303ec59bc9e0d9b989f08390b37e3f5e4 DIFF: https://github.com/llvm/llvm-project/commit/9363071303ec59bc9e0d9b989f08390b37e3f5e4.diff LOG:

[clang] 037f856 - Itanium ABI: Pack non-pod members of packed types

Author: David Blaikie Date: 2022-10-14T19:32:57Z New Revision: 037f856681268c793c660389b4d6407367e68190 URL: https://github.com/llvm/llvm-project/commit/037f856681268c793c660389b4d6407367e68190 DIFF: https://github.com/llvm/llvm-project/commit/037f856681268c793c660389b4d6407367e68190.diff LOG:

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

If the switch is exhaustive (covers all the enumerators in an enumeration), we usually use an llvm_unreachable at the end, rather than a return. Could you change this to an llvm_unreachable? On Mon, Oct 17, 2022 at 3:52 PM Xiang Li via cfe-commits wrote: > > > Author: Xiang Li > Date: 2022-10-17T

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

Also the static_assert is probably not needed - Clang builds with -Wswitch-enum, which will warn if a switch over an enum doesn't cover all the enumerators. We have lots of other switches over enums that depend on this warning to detect code that needs to be updated when an enum is modified. On Mo

Re: [clang] 0674f2e - [NFC] Fix warning on no return after switch.

On Mon, Oct 17, 2022 at 5:52 PM stan li wrote: > > Thanks for the suggestion. > > > > Updated llvm_unreachable. > > > > The static_cast not only check the switch cases all covered, also make sure 2 > enums not out of sync. Ah, OK - thanks for explaining! > > > > > > > > Sent from Mail for Win

[clang] a72d8d7 - Update lambda mangling test to C++17

Author: David Blaikie Date: 2022-11-18T00:24:40Z New Revision: a72d8d704178118b254d9ff84a78afb18813b888 URL: https://github.com/llvm/llvm-project/commit/a72d8d704178118b254d9ff84a78afb18813b888 DIFF: https://github.com/llvm/llvm-project/commit/a72d8d704178118b254d9ff84a78afb18813b888.diff LOG:

Re: [clang] 931d04b - [ADT] Make StringRef::compare like std::string_view::compare

Nice! On Sun, Jan 15, 2023 at 12:10 PM Benjamin Kramer via cfe-commits wrote: > > > Author: Benjamin Kramer > Date: 2023-01-15T20:59:21+01:00 > New Revision: 931d04be2fc8f3f0505b43e64297f75d526cb42a > > URL: > https://github.com/llvm/llvm-project/commit/931d04be2fc8f3f0505b43e64297f75d526cb42a >

Re: [clang] f13019f - [clang] Use any_of and none_of (NFC)

On Sun, Jun 12, 2022 at 10:17 AM Kazu Hirata via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Kazu Hirata > Date: 2022-06-12T10:17:12-07:00 > New Revision: f13019f8367a417075e70effb13dcf58024090b2 > > URL: > https://github.com/llvm/llvm-project/commit/f13019f8367a417075e70effb13dcf

Re: [clang] d941d59 - Revert "[MC] Omit DWARF unwind info if compact unwind is present where eligible"

Please include details about the reason for a revert in the revert commit message - helpful for folks following along/looking to see if a given revert addresses an issue they're seeing, etc. On Sun, Jun 12, 2022 at 7:47 AM Jez Ng via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Je

Re: [clang] d4bcb45 - [MC][re-land] Omit DWARF unwind info if compact unwind is present where eligible

Please include details of what changed between one commit and a recommit of a patch - helpful for reviewers checking what's changed since the last commit, double-checking that the patch fully addresses the issues, etc. On Sun, Jun 12, 2022 at 2:24 PM Jez Ng via cfe-commits < cfe-commits@lists.llvm

[clang] 517bbc6 - DebugInfo: Fully integrate ctor type homing into 'limited' debug info

Author: David Blaikie Date: 2022-06-23T20:15:00Z New Revision: 517bbc64dbe493644eff8d55fd9566435e930520 URL: https://github.com/llvm/llvm-project/commit/517bbc64dbe493644eff8d55fd9566435e930520 DIFF: https://github.com/llvm/llvm-project/commit/517bbc64dbe493644eff8d55fd9566435e930520.diff LOG:

[clang] 4821508 - Revert "DebugInfo: Fully integrate ctor type homing into 'limited' debug info"

Author: David Blaikie Date: 2022-06-24T17:07:47Z New Revision: 4821508d4db75a535d02b8938f81fac6de66cc26 URL: https://github.com/llvm/llvm-project/commit/4821508d4db75a535d02b8938f81fac6de66cc26 DIFF: https://github.com/llvm/llvm-project/commit/4821508d4db75a535d02b8938f81fac6de66cc26.diff LOG:

[clang] e59f648 - Move GCC-compatible pod-packing change to v15/old behavior available at v14 and below

Author: David Blaikie Date: 2022-05-25T03:03:27Z New Revision: e59f648d698efe58b96e9b6224449b2b8cfa872a URL: https://github.com/llvm/llvm-project/commit/e59f648d698efe58b96e9b6224449b2b8cfa872a DIFF: https://github.com/llvm/llvm-project/commit/e59f648d698efe58b96e9b6224449b2b8cfa872a.diff LOG:

Re: Call for an assistance pushing patch review forward

Beyond that it may be useful to look at who's been contributing to the code you're trying to change and consider cc'ing them on the review. (if they can't help, maybe they can point you to someone who can) On Fri, May 27, 2022 at 2:23 PM stryku_t via cfe-commits wrote: > > Hi Paul, > > Thank you

[clang] cb08f4a - Support warn_unused_result on typedefs

Author: David Blaikie Date: 2022-06-02T20:57:31Z New Revision: cb08f4aa4467cf562b62e542725f5351c5482495 URL: https://github.com/llvm/llvm-project/commit/cb08f4aa4467cf562b62e542725f5351c5482495 DIFF: https://github.com/llvm/llvm-project/commit/cb08f4aa4467cf562b62e542725f5351c5482495.diff LOG:

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -7944,9 +7944,13 @@ void ASTReader::PrintStats() { std::fprintf(stderr, "*** AST File Statistics:\n"); unsigned NumTypesLoaded = - TypesLoaded.size() - llvm::count(TypesLoaded, QualType()); + TypesLoaded.size() - std::count(TypesLoaded.materialisedBegin(), ---

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] Introduce paged vector (PR #66430)

@@ -0,0 +1,301 @@ +//===- llvm/ADT/PagedVector.h - 'Lazyly allocated' vectors *- C++ +//-*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

@@ -2325,6 +2325,7 @@ void CodeGenModule::SetLLVMFunctionAttributesForDefinition(const Decl *D, B.addAttribute(llvm::Attribute::Naked); // OptimizeNone wins over OptimizeForSize and MinSize. +F->removeFnAttr(llvm::Attribute::OptimizeForDebugging); --

[clang] [C++20] [Modules] Don't generate call to an imported module that dont init anything (PR #67638)

@@ -1245,6 +1245,27 @@ void Sema::ActOnEndOfTranslationUnit() { } } +// Now we can decide whether the modules we're building need an initializer. +if (Module *CurrentModule = getCurrentModule(); +CurrentModule && CurrentModule->isInterfaceOrPartition

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: (aside: I was confused why there was only one commit in this PR, since there'd been so many updates to it - but I see they've been force pushed, which my vague understanding is that force pushing can complicate tracking previous comments and the LLVM convention is not to do so

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: Oh, no worries at all. LLVM 's still figuring out this whole GitHub transition anyway. I mention it only for future reference and because it might help reviewers/you if comments are getting missplaced/there's trouble tracking unaddressed feedback, etc. Thanks for sticking wit

[clang] [clang][Modules] Make `Module::Requirement` a struct (PR #67900)

https://github.com/dwblaikie approved this pull request. Awesome - love a good readability improvement. Thanks! https://github.com/llvm/llvm-project/pull/67900 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailm

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?Gálvez?= , Carlos =?utf-8?q?Gálvez?= Message-ID: In-Reply-To: dwblaikie wrote: > It seems checks are broken on trunk, I see commits merged with failing > pre-merge tests. They seem to be unrelated to this patch though. > > Is there anything else you'd like fixed before mergi

[clang] Introduce paged vector (PR #66430)

dwblaikie wrote: > This only affects builds with GCC. My understanding was that we basically only cared about performance of clang on clang - that we expect people who want an efficient clang to bootstrap? Could `always_inline` the function, but those sort of annotations would get out of date

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang-tools-extra] [IPSCCP] Variable not visible at Og. (PR #66745)

@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] [IPSCCP] Variable not visible at Og. (PR #66745)

@@ -106,14 +107,71 @@ static void findReturnsToZap(Function &F, } } -static bool runIPSCCP( -Module &M, const DataLayout &DL, FunctionAnalysisManager *FAM, -std::function GetTLI, -std::function GetTTI, -std::function GetAC, -std::function GetDT, -std:

[clang] b43df5b - PseudoObjectExpr: Prefer ArrayRef over iterator_range when iterating with pointers

Author: David Blaikie Date: 2023-07-18T23:43:41Z New Revision: b43df5bfe7e7ef358e135b515b0651ec51f635d8 URL: https://github.com/llvm/llvm-project/commit/b43df5bfe7e7ef358e135b515b0651ec51f635d8 DIFF: https://github.com/llvm/llvm-project/commit/b43df5bfe7e7ef358e135b515b0651ec51f635d8.diff LOG:

[clang] 19f2b68 - Make globals with mutable members non-constant, even in custom sections

Author: David Blaikie Date: 2023-08-14T22:25:42Z New Revision: 19f2b68095fe727e40079b7c6380b36b6462e691 URL: https://github.com/llvm/llvm-project/commit/19f2b68095fe727e40079b7c6380b36b6462e691 DIFF: https://github.com/llvm/llvm-project/commit/19f2b68095fe727e40079b7c6380b36b6462e691.diff LOG:

[clang] 2993243 - Fix misdiagnosed writability for __attribute__((section()))

Author: David Blaikie Date: 2023-08-17T05:35:40Z New Revision: 2993243c45abdb4f2bc3979336d054be165b1134 URL: https://github.com/llvm/llvm-project/commit/2993243c45abdb4f2bc3979336d054be165b1134 DIFF: https://github.com/llvm/llvm-project/commit/2993243c45abdb4f2bc3979336d054be165b1134.diff LOG:

[clang] [C++20] [Modules] Don't emit function bodies which is noinline and av… (PR #68501)

dwblaikie wrote: This doesn't seem all that useful/important to me - a user can move the body of the function into an implementation unit rather than putting it in the interface unit and marking it noinline, right? This is the same recommendation we'd make if someone wrote a complex function d

[clang] [C++20] [Modules] Don't emit function bodies which is noinline and av… (PR #68501)

dwblaikie wrote: *shrug* I guess it's OK. https://github.com/llvm/llvm-project/pull/68501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C++20] [Modules] Don't emit function bodies which is noinline and av… (PR #68501)

https://github.com/dwblaikie approved this pull request. https://github.com/llvm/llvm-project/pull/68501 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Support] Add VirtualOutputBackends to virtualize the output from tools (PR #68447)

@@ -0,0 +1,158 @@ +//===- raw_ostream_proxy.h - Proxies for raw output streams -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

https://github.com/dwblaikie edited https://github.com/llvm/llvm-project/pull/66632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

https://github.com/dwblaikie approved this pull request. looks good - a few bits should be committed separately from this change, so please do those first and then commit this change https://github.com/llvm/llvm-project/pull/66632 ___ cfe-commits mail

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

@@ -1085,6 +1085,7 @@ The integer codes are mapped to well-known attributes as follows. * code 77: ``elementtype`` * code 78: ``disable_sanitizer_instrumentation`` * code 79: ``nosanitize_bounds`` +* code 88: ``optdebug`` dwblaikie wrote: This could/should be

[clang] [LLVM] Add new attribute `optdebug` to optimize for debugging (PR #66632)

@@ -2028,6 +2030,8 @@ example: This attribute suggests that optimization passes and code generator passes should make choices that try to preserve debug info without significantly degrading runtime performance. +This attribute is incompatible with the ``minsize`

[clang] [DebugMetadata][DwarfDebug] Clone uniqued function-local types after metadata loading (PR #68986)

dwblaikie wrote: FWIW, I think we also saw, internally at Google, some significant and surprising (growth in sections, like .debug_loclists and .debug_gnu_pubnames/types) that were a bit surprising/not what I'd have expected of the original committed/reverted patch. Could you run a clang buil

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

dwblaikie wrote: > This is useful when user is forced to use the same type for all bitfields in > a class to get better [layout](https://godbolt.org/z/ovWqzqv9x) and > [codegen](https://godbolt.org/z/bdoqvz9e6) from MSVC Does this issue not apply to other platforms? (I didn't think you could

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

dwblaikie wrote: Seems a bit unfortunate/bit of a heavyweight workaround - but I don't fundamentally object if @AaronBallman or co are OK with the new attribute for this. https://github.com/llvm/llvm-project/pull/69104 ___ cfe-commits mailing list cf

[clang] [clang] Add clang::debug_info_type attribute for bitfields (PR #69104)

dwblaikie wrote: > Wouldn't it be better to go the other way around? i.e. have a > `[[clang::compressed_bitfield]]` (or whatever) which influences the ABI, so > it's possible to do stuff like > > ```c++ > [[clang::compressed_bitfield]] bool IsSomething : 1; > [[clang::compressed_bitfield]] MyE

[clang] 3a100ea - Fix test to not write temporary files, use -fsyntax-only instead

Author: David Blaikie Date: 2023-07-31T19:01:44Z New Revision: 3a100ea901ed79d6a06a5f018be2b4d3bbca51e8 URL: https://github.com/llvm/llvm-project/commit/3a100ea901ed79d6a06a5f018be2b4d3bbca51e8 DIFF: https://github.com/llvm/llvm-project/commit/3a100ea901ed79d6a06a5f018be2b4d3bbca51e8.diff LOG:

Re: [clang] 3b34d69 - Revert "For #64088: mark vtable as used if we might emit a reference to it."

Ping on this - please always include details on the reason for a revert. On Tue, Aug 1, 2023 at 10:09 AM Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > This revert reintroduces a wrong-code bug, can you explain what the > purpose of the revert is? > > On Fri, 28 Jul 2023 at

[clang] 9df8ba6 - pr59000: Clarify packed-non-pod warning that it's pod-for-the-purposes-of-layout

Author: David Blaikie Date: 2022-11-22T00:02:09Z New Revision: 9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af URL: https://github.com/llvm/llvm-project/commit/9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af DIFF: https://github.com/llvm/llvm-project/commit/9df8ba631d4612eb8f930c9fe7c6cf39e5deb3af.diff LOG:

[clang] 2cea4c2 - Do not suggest taking the address of a const pointer to get void*

Author: Alexey Kreshchuk Date: 2022-11-23T18:43:06Z New Revision: 2cea4c239570c37f46ad0003b3d41d9473aca60f URL: https://github.com/llvm/llvm-project/commit/2cea4c239570c37f46ad0003b3d41d9473aca60f DIFF: https://github.com/llvm/llvm-project/commit/2cea4c239570c37f46ad0003b3d41d9473aca60f.diff L

Re: [clang] bde15de - Revert "Allow remapping the sysroot with -fdebug-prefix-map."

Please include the reason for the revert in the revert message (including links/quotes from buildbots, etc) On Fri, Mar 20, 2020 at 4:28 PM Adrian Prantl via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Adrian Prantl > Date: 2020-03-20T16:27:23-07:00 > New Revision: bde15de3cabff6

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Please include the "Differential Revision" line so that Phab picks up commits like this and ties them into the review (& also makes it conveniently clickable to jump from the commit mail to the review) On Thu, Mar 19, 2020 at 5:58 AM Djordje Todorovic via cfe-commits < cfe-commits@lists.llvm.org>

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Why the change? this seems counter to LLVM's style which pretty consistently uses unreachable rather than assert(false), so far as I know? On Tue, Mar 10, 2020 at 11:22 AM Aaron Ballman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Aaron Ballman > Date: 2020-03-10T14:22:21-04:0

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Does "isIntegerConstantExpr" have side effects that are desired/necessary? Otherwise please change this to roll the isIntegerConstantExpr into the assert (so that it is only executed when asserts are enabled) On Tue, Mar 10, 2020 at 10:11 AM Mikhail Maltsev via cfe-commits < cfe-commits@lists.llvm

[clang] b5eafda - Revert "EHScopeStack::Cleanup has virtual functions so the destructor should be too."

Author: David Blaikie Date: 2020-03-21T21:17:33-07:00 New Revision: b5eafda8d3ef02f9f78e090725564dd28e573322 URL: https://github.com/llvm/llvm-project/commit/b5eafda8d3ef02f9f78e090725564dd28e573322 DIFF: https://github.com/llvm/llvm-project/commit/b5eafda8d3ef02f9f78e090725564dd28e573322.diff

Re: [clang] 736385c - EHScopeStack::Cleanup has virtual functions so the destructor should be too.

I've reverted this in b5eafda8d3ef02f9f78e090725564dd28e573322 - the warning isn't accurate/appropriate - this type is safe as it was previously written (having a protected non-virtual dtor and derived classes being final with a non-virtual dtor - so there's no way (well, inside the base class you

Re: [clang] abd0905 - Revert "Revert "Change clang option -ffp-model=precise to select ffp-contract=on""

Probably worth a bit more detail when recommitting a patch that was reverted - in the future please include more detail about the reason for the original revert and the specific changes to the previous version that address that (so someone who might've reviewed the previous patch can more quickly e

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

"a problem" seems a smidge vague - was there a specific explanation for the kind of problem that was signalled? Or was this fix a bit of a shot in the dark? On Sat, Feb 15, 2020 at 10:55 PM Johannes Doerfert via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > Author: Johannes Doerfert > Date

Re: [clang] d9b9621 - Reland D73534: [DebugInfo] Enable the debug entry values feature by default

Also, this patch was reverted and recommitted several times (more than I think would be ideal) - please include more details in the commit message about what went wrong, what was fixed, what testing was missed in the first place and done in subsequent precommit validation (& is there anything more

Re: [clang] 7a42bab - Reland "[DebugInfo][clang][DWARF5]: Added support for debuginfo generation for defaulted parameters

In the future, please include more detail in the commit message of a recommit about how the patch addresses the problems that lead to the previous revert. This makes it easier for someone reviewing the code to examine the new changes & ensure they're correct/appropriate. On Mon, Mar 2, 2020 at 3:1

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballman wrote: > On Sat, Mar 21, 2020 at 11:31 PM David Blaikie wrote: > > > > Why the change? this seems counter to LLVM's style which pretty > consistently uses unreachable rather than assert(false), so far as I know? > > We're not super consistent (at lea

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Sun, Mar 22, 2020 at 10:40 AM Johannes Doerfert wrote: > Some buildbots, I think only Windows buildbots for some reason, crashed > in this function. > > The reason, as described, is that an `llvm::function_ref` cannot be > copied and then reused. It just happened to work on almost all > config

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Sun, Mar 22, 2020 at 9:34 AM Aaron Ballman wrote: > On Sun, Mar 22, 2020 at 12:19 PM David Blaikie wrote: > > > > On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballman > wrote: > >> > >> On Sat, Mar 21, 2020 at 11:31 PM David Blaikie > wrote: > >> > > >> > Why the change? this seems counter to LLVM

[clang] 0d0b901 - Revert "[FIX] Do not copy an llvm::function_ref if it has to be reused"

Author: David Blaikie Date: 2020-03-22T18:43:39-07:00 New Revision: 0d0b90105f92f6cd9cc7004d565834f4429183fb URL: https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb DIFF: https://github.com/llvm/llvm-project/commit/0d0b90105f92f6cd9cc7004d565834f4429183fb.diff

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

ones) don't like it we need to > investigate why. As mentioned, I had a problem recreating the problem > locally before. > > Cheers, >Johannes > > > On 3/22/20 1:37 PM, Arthur O'Dwyer wrote: > > On Sun, Mar 22, 2020 at 1:48 PM David Blaikie via cfe-commits &

[clang] 2ec59a0 - Buildbot debugging of 0d0b90105f92f6cd9cc7004d565834f4429183fb (lambda/function_ref lifetime issues)

Author: David Blaikie Date: 2020-03-22T22:43:44-07:00 New Revision: 2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9 URL: https://github.com/llvm/llvm-project/commit/2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9 DIFF: https://github.com/llvm/llvm-project/commit/2ec59a0a40f4ec02e6b2dbe5f12261959c191aa9.diff

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Ah, thanks. (I'm going to see about renaming/restructuring that API - to return Optional and be called 'get' rather than 'is' to make this more clear) On Mon, Mar 23, 2020 at 5:04 AM Mikhail Maltsev wrote: > Yes, it does. isIntegerConstantExpr assigns a value to CoprocNoAP. > > -- > Regards, >

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

On Mon, Mar 23, 2020 at 5:24 AM Aaron Ballman wrote: > On Sun, Mar 22, 2020 at 3:31 PM David Blaikie wrote: > > > > On Sun, Mar 22, 2020 at 9:34 AM Aaron Ballman > wrote: > >> > >> On Sun, Mar 22, 2020 at 12:19 PM David Blaikie > wrote: > >> > > >> > On Sun, Mar 22, 2020 at 6:34 AM Aaron Ballm

Re: [clang] 43606ef - Suppress an "unused variable" warning in release build

Sent https://reviews.llvm.org/D76646 to hopefully make this a bit more legible On Mon, Mar 23, 2020 at 2:38 PM David Blaikie wrote: > Ah, thanks. (I'm going to see about renaming/restructuring that API - to > return Optional and be called 'get' rather than 'is' to make this > more clear) > > On

Re: [clang] 4a0267e - Convert a reachable llvm_unreachable into an assert.

Thanks again for talking it through & the documentation update - it's a great reference point to keep in mind for future reviews, etc. On Tue, Mar 24, 2020 at 1:08 PM Aaron Ballman wrote: > Thank you for the discussion on IRC about this topic. For reference, > this generated https://reviews.llvm

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

logies for the confusion. >> >> I wrote the commit message after looking into this and I though the >> issue was related to the capture by copy in the inner llvm::any_of and >> the reuse in the outer. Looking back at the code I cannot say anymore >> how I

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

>> (/home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/bin/clang+0x109674cc) >> #23 0x109635b8 ExecuteCC1Tool(llvm::SmallVectorImpl> const*>&) >> (/home/buildbots/ppc64be-clang-multistage-test/clang-ppc64be-multistage/stage1/bin/clang+0x

[clang] 819e540 - Use llvm_unreachable after a fully covered/always-returning switch

Author: David Blaikie Date: 2020-03-26T20:09:57-07:00 New Revision: 819e540208d5d62e7841d0dbdef3580eecc2c2b6 URL: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6 DIFF: https://github.com/llvm/llvm-project/commit/819e540208d5d62e7841d0dbdef3580eecc2c2b6.diff

Re: [clang] d264f02 - Fix `-Wreturn-type` warning. NFC.

Usually this sort of thing is addressed with llvm_unreachable, rather than a return statement that's not expected to be reached by any valid execution of LLVM (it'd require a carefully hand-crafted CPU kind to reach that return (since all the actual enumerators result in returns earlier, in the swi

Re: [clang] 857bf5d - [FIX] Do not copy an llvm::function_ref if it has to be reused

On Thu, Mar 26, 2020 at 8:49 PM Richard Smith wrote: > On Thu, 26 Mar 2020 at 17:07, David Blaikie via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Thu, Mar 26, 2020 at 3:12 PM Arthur O'Dwyer >> wrote: >> >>> I'm not sure,

<    1   2   3   4   5   6   7   8   9   10   >