[PATCH] D109898: [clang][NFC] refactor GlobalMethodPool to encapsulate its map

2021-09-16 Thread Daniel Rodríguez Troitiño via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe6020b2a4224: [clang][NFC] refactor GlobalMethodPool to encapsulate its map (authored by rmaz, committed by drodriguez). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

2022-10-11 Thread Daniel Rodríguez Troitiño via Phabricator via cfe-commits
drodriguez created this revision. drodriguez added reviewers: bc-lee, MaskRay, arphaman. Herald added a subscriber: StephenFan. Herald added a project: All. drodriguez requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. D121868

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

2022-10-13 Thread Daniel Rodríguez Troitiño via Phabricator via cfe-commits
drodriguez updated this revision to Diff 467617. drodriguez added a comment. >From internal review: use virtual method in ToolChain instead of static_cast. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135729/new/ https://reviews.llvm.org/D135729

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

2022-10-13 Thread Daniel Rodríguez Troitiño via Phabricator via cfe-commits
drodriguez updated this revision to Diff 467644. drodriguez added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135729/new/ https://reviews.llvm.org/D135729 Files: clang/include/clang/Driver/ToolChain.h clang/lib/Driver

[PATCH] D135729: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as

2022-10-14 Thread Daniel Rodríguez Troitiño via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd11b9fa3bfb9: [clang][macho] Add support for -darwin-target-variant-sdk-version in cc1as (authored by drodriguez). Changed prior to commit: https:

[PATCH] D148262: [clang][cmake] Add options to pass in vcs repo and revision info

2023-04-14 Thread Daniel Rodríguez Troitiño via Phabricator via cfe-commits
drodriguez requested changes to this revision. drodriguez added inline comments. This revision now requires changes to proceed. Comment at: clang/lib/Basic/CMakeLists.txt:16 set(llvm_source_dir ${LLVM_MAIN_SRC_DIR}) endif() if(clang_vc AND LLVM_APPEND_VC_REV) ---