https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/98437
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielKristofKiss wrote:
in some build config `TargetInfo.cpp` is built without dependency to
`LLVM-Core`.
https://github.com/llvm/llvm-project/pull/98329
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
DanielKristofKiss wrote:
> > in some build config `TargetInfo.cpp` is built without dependency to
> > `LLVM-Core`.
>
> Okay, that means that putting this code inside Basic/ is a layering
> violation. You need to move it into CodeGen/. Probably best to revert the
> whole change in the meantime
https://github.com/DanielKristofKiss created
https://github.com/llvm/llvm-project/pull/98451
To reduce build times move them to TargetCodeGenInfo.
Refactor of #98329
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98451
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
Subject: [PATCH 1/2] [NFC][Clang] Move setfunctions of BranchProtectionInf
@@ -413,6 +414,12 @@ class TargetCodeGenInfo {
return nullptr;
}
+ void setFnAttributes(const TargetInfo::BranchProtectionInfo &BPI,
DanielKristofKiss wrote:
agree, added.
https://github.com/llvm/llvm-project/pull/98451
___
@@ -133,7 +133,7 @@ class AArch64TargetCodeGenInfo : public TargetCodeGenInfo {
}
}
auto *Fn = cast(GV);
-BPI.setFnAttributes(*Fn);
+CGM.getTargetCodeGenInfo().setFnAttributes(BPI, *Fn);
DanielKristofKiss wrote:
oh right.
https://github.
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98451
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
Subject: [PATCH 1/3] [NFC][Clang] Move setfunctions of BranchProtectionInf
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98451
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
Subject: [PATCH 1/4] [NFC][Clang] Move setfunctions of BranchProtectionInf
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98451
>From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 11 Jul 2024 10:29:24 +0200
Subject: [PATCH 1/5] [NFC][Clang] Move setfunctions of BranchProtectionInf
DanielKristofKiss wrote:
#83277 needs the `setBranchProtectionFnAttributes` function but that call is
from a static function so let's make it static.
https://github.com/llvm/llvm-project/pull/98451
___
cfe-commits mailing list
cfe-commits@lists.llvm.
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/98451
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/83277
>From 0c3118713387246dc1c503f3792ba5af82e6b5eb Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Wed, 28 Feb 2024 15:18:31 +0100
Subject: [PATCH 1/8] Add branch protection attributes to the defaults.
Th
https://github.com/DanielKristofKiss created
https://github.com/llvm/llvm-project/pull/98648
Fixes #91144
>From 240add341b2c0a1be3d1ebf21938e70e51669126 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Fri, 12 Jul 2024 15:56:40 +0200
Subject: [PATCH] [libunwind] Fix ubsan issue
---
libunwind
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/83277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/98648
>From 240add341b2c0a1be3d1ebf21938e70e51669126 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Fri, 12 Jul 2024 15:56:40 +0200
Subject: [PATCH 1/2] [libunwind] Fix ubsan issue
---
libunwind/src/Unwin
@@ -230,8 +230,13 @@ void DwarfFDECache::iterateCacheEntries(void (*func)(
}
#endif // defined(_LIBUNWIND_SUPPORT_DWARF_UNWIND)
-
-#define arrayoffsetof(type, index, field) ((size_t)(&((type *)0)[index].field))
+template
+__attribute__((no_sanitize("undefined"))) static inlin
https://github.com/DanielKristofKiss approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90928
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22,4 +22,9 @@ attributes #1 = {
; CHECK: invalid value for 'sign-return-address-key' attribute: B_Key
"sign-return-address-key"="B_Key"
; CHECK: invalid value for 'branch-target-enforcement' attribute: True
- "branch-target-enforcement"="True" }
+ "branch-target-enfor
@@ -0,0 +1,22 @@
+// REQUIRES: arm-registered-target
+
+// RUN: %clang_cc1 -triple=thumbv7m-unknown-unknown-eabi
-msign-return-address=non-leaf %s -S -emit-llvm -o - 2>&1 | FileCheck %s
--check-prefix=CHECK --check-prefix=SIGN
+// RUN: %clang_cc1 -triple=thumbv7m-unknown-unknown
@@ -2323,15 +2323,33 @@ void Verifier::verifyFunctionAttrs(FunctionType *FT,
AttributeList Attrs,
if (S != "a_key" && S != "b_key")
CheckFailed("invalid value for 'sign-return-address-key' attribute: " +
S,
V);
+if (auto AA = Attrs.getFnAttr("s
@@ -2323,15 +2323,33 @@ void Verifier::verifyFunctionAttrs(FunctionType *FT,
AttributeList Attrs,
if (S != "a_key" && S != "b_key")
CheckFailed("invalid value for 'sign-return-address-key' attribute: " +
S,
V);
+if (auto AA = Attrs.getFnAttr("s
@@ -58,8 +58,8 @@ entry:
;; CHECK-NEXT: .cfi_negate_ra_state
attributes #0 = { norecurse nounwind readnone "sign-return-address"="all"
"sign-return-address-key"="b_key" }
-attributes #1 = { noinline }
-attributes #2 = { nofree noinline norecurse nounwind writeonly }
+attribut
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/82819
>From b6e063f335b41a5fd924d0c630c615cec32bd528 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Mon, 22 Jan 2024 11:33:15 +0100
Subject: [PATCH] Emit attributes for functions always.
Branch protection,
https://github.com/DanielKristofKiss edited
https://github.com/llvm/llvm-project/pull/82819
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/82819
>From f459bf1714936e008f548b767cf099872a570260 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Mon, 22 Jan 2024 11:33:15 +0100
Subject: [PATCH] Emit attributes for functions always.
Branch protection,
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/86212
>From f2f3356da08d68dab4431f49d0921515560e4927 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Fri, 8 Mar 2024 15:06:28 +0100
Subject: [PATCH] BTI,GCS,PAC Module flag update.
Module flag is used to in
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/98648
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss created
https://github.com/llvm/llvm-project/pull/101978
Default attributes assigned to all functions according to the command line
parameters. Some functions might have their own attributes and we need to set
or remove attributes accordingly.
Tests are upd
@@ -680,7 +680,7 @@
DEFINE_LIBUNWIND_FUNCTION(__libunwind_Registers_arm64_jumpto)
ldrx16, [x0, #0x0F8]
ldpx0, x1, [x0, #0x000] // restore x0,x1
movsp,x16 // restore sp
- retx30// jump to pc
Danie
https://github.com/DanielKristofKiss approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/96478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/101978
>From 4afadb9122c982c63f2b067661548a2c063590a5 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Mon, 5 Aug 2024 13:01:06 +0200
Subject: [PATCH] [Arm][AArch64][Clang] Respect function's branch protectio
https://github.com/DanielKristofKiss edited
https://github.com/llvm/llvm-project/pull/102322
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -82,7 +82,22 @@
#define PPC64_OPD2
#endif
-#if defined(__aarch64__) && defined(__ARM_FEATURE_BTI_DEFAULT)
+#if defined(__aarch64__)
+#if defined(__ARM_FEATURE_GCS_DEFAULT) && defined(__ARM_FEATURE_BTI_DEFAULT)
+// Set BTI, PAC, and GCS gnu property bits
+#define GNU_PROPERT
https://github.com/DanielKristofKiss approved this pull request.
Thanks!
LGTM with a NIT.
Please wait for someone from the unwind group to ack it too.
https://github.com/llvm/llvm-project/pull/102322
___
cfe-commits mailing list
cfe-commits@lists.llvm.
@@ -680,7 +684,17 @@
DEFINE_LIBUNWIND_FUNCTION(__libunwind_Registers_arm64_jumpto)
ldrx16, [x0, #0x0F8]
ldpx0, x1, [x0, #0x000] // restore x0,x1
movsp,x16 // restore sp
- br x30// jump to pc
+#if defined(__ARM_FE
@@ -0,0 +1,35 @@
+; This file contains the new semantic of the branch-target-enforcement,
sign-return-address.
+; Used for test mixing a mixed link case and also verify the import too in llc.
+
+; RUN: llc %s -o - | FileCheck %s
+
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64
@@ -0,0 +1,35 @@
+; This file contains the new semantic of the branch-target-enforcement,
sign-return-address.
+; Used for test mixing a mixed link case and also verify the import too in llc.
+
+; RUN: llc %s -o - | FileCheck %s
+
+target datalayout = "e-m:e-i8:8:32-i16:16:32-i64
@@ -0,0 +1,35 @@
+; This file contains the new semantic of the branch-target-enforcement,
sign-return-address.
DanielKristofKiss wrote:
done.
https://github.com/llvm/llvm-project/pull/86212
___
cfe-commits mailing lis
@@ -0,0 +1,35 @@
+; This file contains the new semantic of the branch-target-enforcement,
sign-return-address.
+; Used for test mixing a mixed link case and also verify the import too in llc.
+
+; RUN: llc %s -o - | FileCheck %s
DanielKristofKiss wrote:
ack.
ht
@@ -0,0 +1,86 @@
+;; Test verifies inlining happens cross module when module flags are upgraded.
+;; `foo` and `main` are both old semantic while bar is the new semantic.
+;; Regression test for #82763
+
+; RUN: split-file %s %t
+; RUN: opt -module-summary %t/foo.s -o %t/foo.o
+;
@@ -5278,6 +5278,106 @@ void llvm::UpgradeFunctionAttributes(Function &F) {
}
}
+// Check if the module attribute is present and set to one.
+static bool isModuleAttributeOne(Module &M, const StringRef &ModAttr) {
+ const auto *Attr =
+ mdconst::extract_or_null(M.getMo
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/86212
>From f2f3356da08d68dab4431f49d0921515560e4927 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Fri, 8 Mar 2024 15:06:28 +0100
Subject: [PATCH 1/2] BTI,GCS,PAC Module flag update.
Module flag is used t
Author: Daniel Kiss
Date: 2021-09-02T11:31:03+02:00
New Revision: f5b997e6b7061323fff13fafcc0c311d9e78e848
URL:
https://github.com/llvm/llvm-project/commit/f5b997e6b7061323fff13fafcc0c311d9e78e848
DIFF:
https://github.com/llvm/llvm-project/commit/f5b997e6b7061323fff13fafcc0c311d9e78e848.diff
L
Author: Daniel Kiss
Date: 2021-09-02T11:43:20+02:00
New Revision: d212bdf82883c8880da5a2ee67ce6b7b9a239f88
URL:
https://github.com/llvm/llvm-project/commit/d212bdf82883c8880da5a2ee67ce6b7b9a239f88
DIFF:
https://github.com/llvm/llvm-project/commit/d212bdf82883c8880da5a2ee67ce6b7b9a239f88.diff
L
DanielKristofKiss wrote:
> For return-address signing, each function can make its own choice about
> whether to sign; the function that's doing the signing is the same function
> that does the auth, so it doesn't directly impact any other function. For
> branch target enforcement, though, ever
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/82819
>From df64bb1a12ea2b2a89151fa034a16cd641129347 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Mon, 22 Jan 2024 11:33:15 +0100
Subject: [PATCH] Emit attributes for functions always.
Branch protection,
DanielKristofKiss wrote:
> I think this is OK but do you know if the dsp side works with cortex-m?
> Target attributes are less likely to be used there, but it's worth testing if
> the command line args are still all happy.
This seems works fine:
```c
#include
int dsp() {
return __smlabb(
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/107417
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -399,7 +399,14 @@ void AArch64TargetInfo::getTargetDefines(const LangOptions
&Opts,
Builder.defineMacro("__AARCH64_CMODEL_" + CodeModel + "__");
// ACLE predefines. Many can only have one possible value on v8 AArch64.
- Builder.defineMacro("__ARM_ACLE", "200");
+ Bui
@@ -399,7 +399,14 @@ void AArch64TargetInfo::getTargetDefines(const LangOptions
&Opts,
Builder.defineMacro("__AARCH64_CMODEL_" + CodeModel + "__");
// ACLE predefines. Many can only have one possible value on v8 AArch64.
- Builder.defineMacro("__ARM_ACLE", "200");
+ Bui
https://github.com/DanielKristofKiss requested changes to this pull request.
otherwise looks reasonable to me.
https://github.com/llvm/llvm-project/pull/108857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailm
https://github.com/DanielKristofKiss approved this pull request.
Thanks!
LGTM
https://github.com/llvm/llvm-project/pull/108857
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/111962
>From 122864160f098392c4afd1728eb924e7e26e70d9 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Tue, 8 Oct 2024 22:58:37 +0200
Subject: [PATCH 1/3] Add ifuncs support for Windows.
---
clang/include/c
https://github.com/DanielKristofKiss edited
https://github.com/llvm/llvm-project/pull/111962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,65 @@
+// RUN: %clang_cc1 -triple aarch64-pc-windows-msvc -emit-llvm -o - %s |
FileCheck %s
DanielKristofKiss wrote:
So far, but other targets could be added here later without too much change to
the test.
https://github.com/llvm/llvm-project/pull/1
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/111962
>From 122864160f098392c4afd1728eb924e7e26e70d9 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Tue, 8 Oct 2024 22:58:37 +0200
Subject: [PATCH 1/4] Add ifuncs support for Windows.
---
clang/include/c
https://github.com/DanielKristofKiss created
https://github.com/llvm/llvm-project/pull/111962
On Windows there is no platform support for ifunc but we could lower them to
global function pointers.
This also enables FMV for Windows with Clang and Compiler-rt.
Depends on #111961 and #111960
>Fr
https://github.com/DanielKristofKiss created
https://github.com/llvm/llvm-project/pull/113368
Libunwind manages the registers/context including the program counter which is
used effectively as a return address.
__libunwind_Registers_arm64_jumpto can go anywhere where the given buffer 's PC
poi
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/113368
>From 3dd2f4da57eb164e67fd54b66c09cc8b771ee24f Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Wed, 16 Oct 2024 14:48:25 -0700
Subject: [PATCH 1/2] [libunwind][AArch64] Protect PC within libunwind's
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/113368
>From 3dd2f4da57eb164e67fd54b66c09cc8b771ee24f Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Wed, 16 Oct 2024 14:48:25 -0700
Subject: [PATCH 1/3] [libunwind][AArch64] Protect PC within libunwind's
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/113368
>From 3dd2f4da57eb164e67fd54b66c09cc8b771ee24f Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Wed, 16 Oct 2024 14:48:25 -0700
Subject: [PATCH 1/6] [libunwind][AArch64] Protect PC within libunwind's
DanielKristofKiss wrote:
ping
https://github.com/llvm/llvm-project/pull/111962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss approved this pull request.
https://github.com/llvm/llvm-project/pull/109247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/113368
>From 3dd2f4da57eb164e67fd54b66c09cc8b771ee24f Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Wed, 16 Oct 2024 14:48:25 -0700
Subject: [PATCH 1/4] [libunwind][AArch64] Protect PC within libunwind's
DanielKristofKiss wrote:
sorry for the debug here, locally I can't reproduce the test failure( macos m1,
same toolchain, same build steps )
https://github.com/llvm/llvm-project/pull/113368
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/113368
>From 3dd2f4da57eb164e67fd54b66c09cc8b771ee24f Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Wed, 16 Oct 2024 14:48:25 -0700
Subject: [PATCH 1/5] [libunwind][AArch64] Protect PC within libunwind's
@@ -1845,8 +1884,14 @@ class _LIBUNWIND_HIDDEN Registers_arm64 {
uint64_t getSP() const { return _registers.__sp; }
void setSP(uint64_t value) { _registers.__sp = value; }
- uint64_t getIP() const { return _registers.__pc; }
- void setIP(uint6
@@ -5796,12 +5796,18 @@ declared entity. The entity must not have weak linkage;
for example, in C++,
it cannot be applied to a declaration if a definition at that location would be
considered inline.
-Not all targets support this attribute. ELF target support depends on both
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/111962
>From 122864160f098392c4afd1728eb924e7e26e70d9 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Tue, 8 Oct 2024 22:58:37 +0200
Subject: [PATCH 1/6] Add ifuncs support for Windows.
---
clang/include/c
https://github.com/DanielKristofKiss edited
https://github.com/llvm/llvm-project/pull/116244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/116244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss edited
https://github.com/llvm/llvm-project/pull/116244
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss created
https://github.com/llvm/llvm-project/pull/116244
None
>From 4946fe15a6fba4bc069154b4520fb7021ca3ae35 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Thu, 14 Nov 2024 16:04:14 +0100
Subject: [PATCH] Filter test based on backed support.
---
clang/t
DanielKristofKiss wrote:
test depends on the aarch64 backend in llvm.
// REQUIRES: aarch64-registered-target to be add to the test.
https://github.com/llvm/llvm-project/pull/116244
https://github.com/llvm/llvm-project/pull/111962
___
cfe-commits maili
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/111962
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,28 @@
+// REQUIRES: aarch64-registered-target
+
+// RUN: %clang -target aarch64-linux-pauthtest %s -S -emit-llvm -o - 2>&1 |
FileCheck --implicit-check-not=warning: %s
+// RUN: %clang -target aarch64 -fptrauth-returns %s -S -emit-llvm -o - 2>&1 |
FileCheck --implici
https://github.com/DanielKristofKiss edited
https://github.com/llvm/llvm-project/pull/125280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/125280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss approved this pull request.
just left a NIT.
https://github.com/llvm/llvm-project/pull/120022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/DanielKristofKiss edited
https://github.com/llvm/llvm-project/pull/120022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11799,6 +11792,12 @@ static bool CheckMultiVersionAdditionalDecl(
static bool CheckMultiVersionFunction(Sema &S, FunctionDecl *NewFD,
bool &Redeclaration, NamedDecl *&OldDecl,
LookupResult &Previous
@@ -232,13 +232,23 @@ bool AArch64TargetInfo::validateTarget(DiagnosticsEngine
&Diags) const {
bool AArch64TargetInfo::validateGlobalRegisterVariable(
StringRef RegName, unsigned RegSize, bool &HasSizeMismatch) const {
- if ((RegName == "sp") || RegName.starts_with("x"))
https://github.com/DanielKristofKiss approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/124266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielKristofKiss wrote:
I don't think that is yet published for Windows.
https://github.com/llvm/llvm-project/pull/132727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 185 of 185 matches
Mail list logo
