[PATCH] D119479: [clang][extract-api] Add global record support

dang requested changes to this revision. dang added a comment. This revision now requires changes to proceed. You should fix the test to take into account the serializer feedback I left behind Comment at: clang/include/clang/SymbolGraph/API.h:33 + +struct APIRecord { + String

[PATCH] D119479: [clang][extract-api] Add global record support

dang added inline comments. Comment at: clang/lib/SymbolGraph/Serialization.cpp:237 +case GVKind::Variable: + Kind["identifier"] = (getLanguageName(LangOpts) + ".variable").str(); + Kind["displayName"] = "Variable"; dang wrote: > ".variable" ".var"

[PATCH] D119479: [clang][extract-api] Add global record support

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Looks mostly good now. Comment at: clang/include/clang/SymbolGraph/API.h:99 + + GlobalRecord *addGlobal(GVKind Kind, StringRef Name, SmallString<128> &USR, +

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang created this revision. dang added reviewers: ributzka, zixuw, QuietMisdreavus, arphaman. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. clang -extract-api should accept multiple headers and forward th

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416261. dang added a comment. Get rid of spurious clang-format changes due to reverted modifications Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936 Files: clang/inclu

[PATCH] D121873: [clang][extract-api] Add enum support

dang added inline comments. Comment at: clang/lib/SymbolGraph/ExtractAPIConsumer.cpp:197 + void recordEnumConstants(EnumRecord *EnumRecord, + const EnumDecl::enumerator_range Constants) { Should this be static or in an anonymous names

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. If people thing it would be preferable to add a new phase and change phase scheduling a little I am happy to do that too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936 ___

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added inline comments. Comment at: clang/include/clang/Driver/Phases.h:17 /// compilation process which interact with user options. - enum ID { -Preprocess, ributzka wrote: > Is this an unrelated formatting change? Fixed it in the latest diff. I had

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. In D121936#3389991 , @ributzka wrote: > Nice! Thank you for adding support for multiple headers. Is this a step > towards the json input file list? My understanding was that for this iteration at least we were going with just feed

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416359. dang added a comment. Add test to check that command line with different header kinds gets diagnosed appropriately. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D12193

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang added a comment. In D121936#3391001 , @zixuw wrote: > In D121936#3390920 , @dang wrote: > >> In D121936#3389991 , @ributzka >> wrote: >> >>> Nice! Thank you for addi

[PATCH] D121873: [clang][extract-api] Add enum support

dang added inline comments. Comment at: clang/lib/SymbolGraph/Serialization.cpp:343 + if (!Enum) +return; + zixuw wrote: > dang wrote: > > Quick design question: Do we want to be silently failing in these > > situations (especially since this shouldn't be h

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

dang updated this revision to Diff 416942. dang added a comment. Rebase on top of main to bring latest fixes to ExtractAPIAction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://reviews.llvm.org/D121936 Files: clang/include/clan

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds `--product-name=` flag to the clang driver. This gets forwarded to cc

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:34 +/// Documentation comment is a vector of RawComment::CommentLine. +/// You should use the actual name of the type or "This" Comment at: clang/include/clang/Extra

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang created this revision. dang added reviewers: ributzka, zixuw, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Before actually executing the ExtractAPIAction, clear the CompilationInsta

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang added a comment. This is up as a "draft" right now. I am waiting on https://reviews.llvm.org/D122160 to land before doing a final rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175

[PATCH] D121936: Ensure -extract-api handles multiple headers correctly

This revision was automatically updated to reflect the committed changes. Closed by commit rGedbb99a7edc6: Ensure -extract-api handles multiple headers correctly (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121936/new/ https://r

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM once the last few bits of feedback I left are considered. Comment at: clang/include/clang/ExtractAPI/API.h:139 + /// Create and add a global variable record into the API

[PATCH] D121873: [clang][extract-api] Add enum support

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:33 +namespace { + I still think this belongs in `APISet`. It belongs there because it defines unique pointers that are specifically tied to the lifetime of `APISet`. Any other thing

[PATCH] D122202: [clang][extract-api] Add struct support

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:375 + case APIRecord::RK_StructField: +Kind["identifier"] = AddLangPrefix("struct.field"); +Kind["displayName"] = "Struct Field"; "property" instead of "

[PATCH] D122160: [clang][extract-api] Refactor ExtractAPI and improve docs

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122160/new/ https://reviews.llvm.org/D122160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang added a comment. In D122141#3400578 , @zixuw wrote: > LGTM. Need to rebase. Do you think `ProductName` should be a general property > of `APISerializer` or something specific to the `SymbolGraphSerializer`? Good question! I think I am going to make

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417551. dang added a comment. Rebasing on top of latest main which includes https://reviews.llvm.org/rG89f6b26f1beb2c1344f5cfeb34e405128544c76b Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/ https://re

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417570. dang added a comment. Missed some stuff in the previous rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/ https://reviews.llvm.org/D122141 Files: clang/include/clang/Driver/Options.td

[PATCH] D122141: [clang][extract-api] Suppprt for the module name property in SymbolGraph

dang updated this revision to Diff 417572. dang added a comment. Accidentally re-added some of the old files in SymbolGraph/ during the rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122141/new/ https://reviews.llvm.org/D122141 Files: clan

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang updated this revision to Diff 417593. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175 Files: clang/include/clang/ExtractAPI/FrontendActions.h

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang updated this revision to Diff 417596. dang added a comment. Clarify doc comment for ExtractAPIAction::PrepareToExecuteAction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122175/new/ https://reviews.llvm.org/D122175 Files: clang/include/cla

[PATCH] D122175: [clang][extract-api] Enable processing of multiple headers

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/SymbolGraph/FrontendActions.h:35 + /// This is called before executing the action on any inputs. This merges all + /// the provided headers into a single header for processing. +

[PATCH] D123259: [clang][ExtractAPI] Fix appendSpace in DeclarationFragments

dang accepted this revision. dang added a comment. LGTM thanks for spotting this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123259/new/ https://reviews.llvm.org/D123259 ___ cfe-commits mailing list c

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

dang updated this revision to Diff 421143. dang added a comment. Rebase on top of latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123148/new/ https://reviews.llvm.org/D123148 Files: clang/include/clang/ExtractAPI/FrontendActions.h

[PATCH] D123295: [clang][extract-api] Use dedicated API to check for macro equality

dang created this revision. dang added reviewers: zixuw, ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123295 Files: clang/lib

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123304 Files: cl

[PATCH] D123261: [clang][ExtractAPI] Fix declaration fragments for ObjC methods

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123261/new/ https://reviews.llvm.org/D123261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123148: [clang][extract-api] Process only APIs declared in inputs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaebe5fc6e7d8: [clang][extract-api] Process only APIs declared in inputs (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D123295: [clang][extract-api] Use dedicated API to check for macro equality

This revision was automatically updated to reflect the committed changes. Closed by commit rG101559225189: [clang][extract-api][NFC] Use dedicated API to check for macro equality (authored by dang). Changed prior to commit: https://reviews.llvm.org/D123295?vs=421147&id=421290#toc Repository:

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D123391 Files: cl

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

dang updated this revision to Diff 421537. dang added a comment. Add test to check that ObjC methods with multiple external parameters get the correct name in subHeadings and navigator. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123391/new/ http

[PATCH] D123391: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80ae36659292: [clang][extract-api] Emit "navigator" property of "name" in SymbolGraph (authored by dang). Repository: rG LLVM Github Monorepo CH

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang updated this revision to Diff 421932. dang added a comment. Address code review feedback. Introduce `has_function_signature` type trait to distinguish records that have a function signatures. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D12330

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", zixuw wrote: > I'd prefer not to use `dyn_c

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:495 +if (const auto *Method = dyn_cast(Member.get())) + serializeObject(*MemberRecord, "functionSignature", zixu

[PATCH] D123304: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. dang marked an inline comment as done. Closed by commit rG236b6a0eb41a: [clang][extract-api] Emit "functionSignature" in SGF for ObjC methods. (authored by dang). Repo

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Anonymous enums without a typedef should have a "(anonymous)" identifier.

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang updated this revision to Diff 422160. dang added a comment. Address code review feedback: - Normalize test file URIs - Key RecordMaps by USR instead of by Name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123533/new/ https://reviews.llvm.org

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang marked 3 inline comments as done. dang added inline comments. Comment at: clang/test/ExtractAPI/enum.c:693 +], +"title": "(anonymous)" + }, zixuw wrote: > So the `Name` of the record is literally `(anonymous)`? I think this might > crea

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

dang updated this revision to Diff 422296. dang marked an inline comment as done. dang added a comment. Add a second anonymous enum to the test case to make sure that distinct symbols are generated for both of them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D123533: [clang][extract-api] Add support for true anonymous enums

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7443a504bf6c: [clang][extract-api] Add support for true anonymous enums (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:65 + // Matches framework include patterns + const llvm::Regex Rule("/(.+)\\.framework/(.+)?Headers/(.+)"); + StringRef WorkingDir = CI.getFileSystemOpts().WorkingDir; This doe

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

dang added a comment. In D123831#3455048 , @cishida wrote: >> we might not always want to transform an absolute path because the resulting >> relative include name might get remapped in a headermap, for example in test >> known_files_only_hmap.c. But ho

[PATCH] D123831: [POC][WIP] Use relative include in extract-api

dang added a comment. In D123831#3459368 , @ributzka wrote: > In D123831#3458774 , @dang wrote: > >> In D123831#3455048 , @cishida >> wrote: >> we might not always w

[PATCH] D123831: [clang][extract-api] Use relative includes

dang added inline comments. Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:134 +if (!SpelledFilename.empty()) + return SpelledFilename.str(); + zixuw wrote: > zixuw wrote: > > zixuw wrote: > > > One problem I can see in this right now is

[PATCH] D124634: ExtractAPI: Use %clang_cc1 and -verify in enum.c

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124634/new/ https://reviews.llvm.org/D124634 ___ cf

[PATCH] D123831: [clang][extract-api] Use relative includes

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Minor comment LGTM otherwise Comment at: clang/lib/ExtractAPI/ExtractAPIConsumer.cpp:203 +// Try to reduce the include name the same way we tried to include it. +if (auto

[PATCH] D123831: [clang][extract-api] Use relative includes

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D123831: [clang][extract-api] Use relative includes

dang added a comment. Since this is a new test can we use the approach in https://reviews.llvm.org/D124634 to check for diagnostics output. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123831/new/ https://reviews.llvm.org/D123831 ___

[PATCH] D124964: Revert "Revert "[clang][extract-api] Use relative includes""

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! If I understand the issue correctly we gave `llvm::Regex::match` a string temporary to match against before and now we store it for long enough to process the match results? Repository:

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These symbols are understood to not be used for client API consumption by

[PATCH] D86290: Move all fields of '-cc1' option related classes into def file databases

dang added a comment. Yes of course. This is a prerequisite for some other changes that are waiting to land and need polishing. Thanks for doing the revert. I will investigate the failures and recommit it when appropriate. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D136450: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Adds a `--extract-api-ignores=` command l

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

dang created this revision. dang added reviewers: zixuw, QuietMisdreavus, ributzka. Herald added a subscriber: yaxunl. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Adds a 'targetFallback' field to relati

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

dang added a comment. In D136455#3879849 , @zixuw wrote: > Is it easy to/worth checking if the target is actually outside of the current > module to keep the output smaller and concise? I think it can be done, since we ignore symbols that don't come fro

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

dang added a comment. However, I am not sure it's worthwhile and we might run into edge cases doing it this way with explicitly ignored symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136455/new/ https://reviews.llvm.org/D136455 __

[PATCH] D136450: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore

This revision was automatically updated to reflect the committed changes. Closed by commit rG791fe26d7581: [clang][ExtractAPI] Allow users to specify a list of symbols to ignore (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136450

[PATCH] D130918: [clang][ExtractAPI] Record availability information on all platforms

This revision was automatically updated to reflect the committed changes. Closed by commit rG57c9780d60b1: [clang][ExtractAPI] Record availability information on all platforms (authored by dang). Changed prior to commit: https://reviews.llvm.org/D130918?vs=449228&id=454111#toc Repository: rG

[PATCH] D134813: Properly print unnamed TagDecl objects in diagnostics

dang accepted this revision. dang added a comment. In D134813#3838069 , @zixuw wrote: > With the PrintingPolicy fix in https://reviews.llvm.org/D135295 and landed > USR fix, the diff within ExtractAPI tests is only the wording with anonymous > enums, an

[PATCH] D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls

dang created this revision. dang added reviewers: zixuw, ributzka, QuietMisdreavus. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ExtractAPI was emitting a separate symbol for anonymous record declaration

[PATCH] D135804: [clang][ExtractAPI] Ignore fully anonymous RecordDecls

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6da16ffb9d5: [clang][ExtractAPI] Ignore fully anonymous RecordDecls (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135804/new/ https://r

[PATCH] D136455: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph

This revision was automatically updated to reflect the committed changes. Closed by commit rG671709f0e7d4: [clang][ExtractAPI] Add targetFallback to relationships in symbol graph (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13645

[PATCH] D141961: [clang][lex] Pass hash location to more PPCallbacks methods

dang added a comment. LGTM for the ExtractAPI changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141961/new/ https://reviews.llvm.org/D141961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D142101: [clang] [extract-api] Don't crash for category in libclang APIs

dang created this revision. dang added a reviewer: zixuw. Herald added a subscriber: arphaman. Herald added a reviewer: ributzka. Herald added a project: All. dang requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Remove failure conditions fo

[PATCH] D142101: [clang] [extract-api] Don't crash for category in libclang APIs

dang updated this revision to Diff 490447. dang added a comment. Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142101/new/ https://reviews.llvm.org/D142101 Files: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp cl

[PATCH] D142101: [clang] [extract-api] Don't crash for category in libclang APIs

dang added inline comments. Comment at: clang/lib/ExtractAPI/Serialization/SymbolGraphSerializer.cpp:537-544 + generatePathComponents(Record, API, + [Lang, &ParentContexts](const PathComponent &PC) { + ParentContexts.push_back( +

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

dang added a comment. In D125678#3517174 , @zixuw wrote: > In D125678#3517168 , > @QuietMisdreavus wrote: > >> clang-format failed: >> >> --- clang-format >> >> changed files: >> >> clang/test/Ex

[PATCH] D125678: [clang][extract-api] Don't emit symbols prefixed with an underscore

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG504736cedff3: [clang][extract-api] Don't emit symbols prefixed with an underscore (authored by dang). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang added inline comments. Comment at: clang/test/ExtractAPI/objc_various_categories.m:8 +// RUN: %t/myclass_1.h \ +// RUN: %t/input.h -o %t/output.json | FileCheck -allow-empty %s + I don't think you need to have MyClass2 and the associated myclass2.h. It's fi

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang accepted this revision. dang added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152770/new/ https://reviews.llvm.org/D152770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

dang added a comment. Looks mostly good. Quick Question how do we handle inheritance to a template parameter? Comment at: clang/include/clang/ExtractAPI/API.h:665 + +struct ClassTemplateSpecRecord : CXXClassRecord { + ClassTemplateSpecRecord(StringRef USR, StringRef Name, Pre

[PATCH] D157076: [clang][ExtractAPI] Add support for C++ class templates and concepts

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157076/new/ https://reviews.llvm.org/D157076 ___ cfe

[PATCH] D157350: [clang][ExtractAPI] Add support for C++ variable templates

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157350/new/ https://reviews.llvm.org/D157350 ___ cfe

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:1129 template <> -struct has_function_signature : public std::true_type {}; +struct has_function_signature : public std::true_type { +}; Can we get rid of these types of changes to ke

[PATCH] D157579: [clang][ExtractAPI] Add support for C++ global function templates

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/ExtractAPI/API.h:1077 : public std::true_type {}; +template <> +struct has_template : public std::true_type {}; Mega ni

[PATCH] D158027: [clang][ExtractAPI] Visit method templates with better scheme

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158027/new/ https://reviews.llvm.org/D158027 ___ cfe

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:182-189 DocComment Comment; if (auto *RawComment = - getDerivedExtractAPIVisitor().fetchRawCommentForDecl(Decl)) -Comment = RawComment->getFormattedLines(Context.getSourc

[PATCH] D158029: [clang][ExtractAPI] Add support for C++ member templates

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158029/new/ https://reviews.llvm.org/D158029 ___ cf

[PATCH] D158031: [clang][ExtractAPI] Refactor C++ method and field visitation

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Did this change not affect ordering of the symbols in the generated JSON? Looks pretty good to me otherwise! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:38 +namespace { +inline SmallString<128> DetermineParentDecl(const DeclContext *Context) { + SmallString<128> ParentUSR; I think this should compute both the parent decl a

[PATCH] D158239: [clang][ExtractAPI] Add support for namespaces

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158239/new/ https://reviews.llvm.org/D158239 ___ cfe

[PATCH] D158474: [clang][ExtractAPI] Fix bool spelling coming from the macro definition.

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. Nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158474/new/ https://reviews.llvm.org/D158474 ___ cf

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang added a comment. Looking pretty good, if you can address the last few bits of feedback I am happy to merge this. Comment at: clang/include/clang/ExtractAPI/API.h:770 +template <> +struct has_function_signature : public std::true_type {}; + Does `CXXInstan

[PATCH] D154038: [clang][ExtractAPI] Add semicolons to vars and fields and to test reference JSON

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154038/new/ https://reviews.llvm.org/D154038 ___ cf

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang added inline comments. Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:488 + bool IsFromExternalModule = true; + for (const auto &Interface : API.getObjCInterfaces()) { +if (InterfaceDecl->getName() == Interface.second.get()->Name) { I t

[PATCH] D153557: [clang][ExtractAPI] Add support for C++ classes

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153557/new/ https://reviews.llvm.org/D153557 ___ cfe

[PATCH] D157007: [clang][ExtractAPI] Add support for C++ classes with fix

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157007/new/ https://reviews.llvm.org/D157007 ___ cfe

[PATCH] D152770: [clang][ExtractAPI] Add support for Objective-C categories

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152770/new/ https://reviews.llvm.org/D152770 ___ cfe

[PATCH] D152356: [clang][ExtractAPI] Add --emit-symbol-graph option

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM thanks for working on this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152356/new/ https://reviews.llvm.org/D152356 ___

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

dang added a comment. LGTM Comment at: clang/include/clang/ExtractAPI/API.h:137 -/// DocComment is a vector of RawComment::CommentLine. +/// Slightly cut down version of PresumedLoc to suite the needs of +/// ExtractAPI. s/suite/suit CHANGES SINCE LAST ACTI

[PATCH] D158671: [NFC][Clang] Fix static analyzer concerns

dang accepted this revision. dang added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h:195 SymbolReference Context; -auto Record = dyn_cast(Decl->getDeclContext()); +auto Record = cast

[PATCH] D157810: [clang][ExtractAPI] Create extractapi::RecordLocation

dang added a comment. As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we should move this review to GitHub to make sure we don't lose track of it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157810/new/ https://reviews.

[PATCH] D158646: [clang-tools-extra][ExtractAPI] create clang-symbolgraph-merger

dang added a comment. As per https://discourse.llvm.org/t/pull-request-migration-schedule/71595 we should move this review to GitHub to make sure we don't lose track of it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158646/new/ https://reviews.llvm.org/D158646 _

<    1   2   3   4   >