[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

dang updated this revision to Diff 265262. dang added a comment. Herald added a subscriber: ormris. Add a small bug fix and test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998 Files: clang/test/Modu

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

dang updated this revision to Diff 265263. dang added a comment. Uploaded the wrong diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998 Files: clang/include/clang/Serialization/ASTBitCodes.h clang/incl

[PATCH] D79993: Place control block after AST block in PCM files (Patch series 1/3)

dang abandoned this revision. dang added a comment. Herald added a subscriber: sstefan1. After some further discussion offline with @Bigcheese the cleaner course of action is to make the AST block relocatable see revision D80383 Repository: rG LLVM Github Mo

[PATCH] D79998: Add AST_SIGNATURE record to unhashed control block of pcm files (Patch series 2/3)

dang abandoned this revision. dang added a comment. This revision is superseded by D80383 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79998/new/ https://reviews.llvm.org/D79998

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. This record is constructed by hashing the bytes of the AST block in a similiar fashion to the SIGNATURE record. This new signature only means anything if

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 265530. dang added a comment. Herald added a reviewer: jdoerfert. Herald added subscribers: sstefan1, ormris. Formatting fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ https://reviews.llvm.org/D803

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 265535. dang added a comment. Accidently deleted a line in the previous update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ https://reviews.llvm.org/D80383 Files: clang/include/clang/Serialization/A

[PATCH] D80003: [clang][clang-scan-deps] Add a mode that can compute overhead in duplicated module builds

dang updated this revision to Diff 265676. dang added a comment. Rebase this on top of the new AST Signature patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80003/new/ https://reviews.llvm.org/D80003 Files: clang/include/clang/Frontend/Compi

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 265848. dang added a comment. This should address the Windows test failure as well as some offline feedback - Ensure that DeclOffset instances can only be read by providing an offset to the AST block - Simplify ASTSignature test by using -fdisable-module-hash

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 266195. dang added a comment. Address some code review comments and sketch support for options that take a single value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 F

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 5 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:156 /// \param [out] Res - The resulting invocation. + /// \param [in] CommandLineArgs - Array of argument strings, this should not + /// contain

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang added a comment. I made the decision to make all relative offsets relative to the start of the AST block rather than their own sub-block or a neighboring block, in order to prevent adding complexity in `ASTReader`. My reasoning that it would be best if the reader didn't have to keep track

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang marked 4 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:396-400 /// Record code for the signature that identifiers this AST file. SIGNATURE = 1, + /// Record code for the signature of the

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 267914. dang added a comment. Address some of the code review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ https://reviews.llvm.org/D80383 Files: clang/include/clang/Basic/Module.h clang/

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/Serialization/ASTWriter.cpp:1084 PP.getHeaderSearchInfo().getHeaderSearchOpts().ModulesHashContent) { -Signature = createSignature(StringRef(Buffer.begin(), StartOfUnhashedControl

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:396-400 /// Record code for the signature that identifiers this AST file. SIGNATURE = 1, + /// Record code for the signature of the

[PATCH] D83940: Port HeaderSearch option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83892 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83940 Files: clang/include/clang

[PATCH] D83979: Port LangOpts option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, sstefan1, dexonsmith, aheejin, dschuff. Herald added a reviewer: jdoerfert. Herald added a project: clang. Depends on D83940 Repository: rG LLVM Github Monorep

[PATCH] D83979: Port LangOpts option flags to new option parsing system

dang updated this revision to Diff 278729. dang added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83979/new/ https://reviews.llvm.org/D83979 Files: clang/include/clang/Basic/LangOptions.h clang/include/clang/Driver/

[PATCH] D84018: Port Preprocessor and PreprocessorOutput option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83979 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84018 Files: clang/include/clang

[PATCH] D84185: Better defaults for MarshallingInfoString

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Depends on D84018 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84185 Files:

[PATCH] D84186: Convert Analyzer option string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, dexonsmith, a.sidorin, baloghadamsoftware. Herald added projects: clang, LLVM. Depends on D84185 Rep

[PATCH] D84187: Port DependencyOutput string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84186 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84187 Files: clang/include/clang

[PATCH] D84188: Port FileSystem options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84187 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84188 Files: clang/include/clang

[PATCH] D84190: Port FrontendOpts simple string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, aaron.ballman, dexonsmith. Herald added a project: clang. Depends on D84189 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84190 Files: clan

[PATCH] D84189: Let denormalizer decide how to render the option based on the option class

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Depends on D84188 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84189 Files:

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 280945. dang added a comment. Update with latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td clang/lib/Fronten

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

dang updated this revision to Diff 280946. dang added a comment. Update with latest changes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83298/new/ https://reviews.llvm.org/D83298 Files: clang/include/clang/Driver/Options.td clang/lib/Fronte

[PATCH] D84186: Convert Analyzer option string based options to new option parsing system

dang updated this revision to Diff 280948. dang added a comment. Update with latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84186/new/ https://reviews.llvm.org/D84186 Files: clang/include/clang/Driver/Options.td clang/lib/Fronten

[PATCH] D84668: Port TargetOpts simple string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84190 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84668 Files: clang/include/clang

[PATCH] D84669: Port CodeGenOpts simple string flags to new option parsing system

dang created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84668 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84669 Files: clang/include/clang/Basic/CodeGenOptions.h clang/in

[PATCH] D84670: Port HeaderSearch simple string options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84669 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84670 Files: clang/include/clang

[PATCH] D84671: Port LangOpts simple string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith, mgrang. Herald added projects: clang, LLVM. Depends on D84670 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84671 F

[PATCH] D84672: Port PreprocessorOpts simple string based options to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D84671 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84672 Files: clang/include/clang

[PATCH] D84673: Port DiagnosticOpts to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. DiagnosticOpts are special because the parsing is code is shared with the driver. To ensure the code can still be shared this commit le

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Depends on D84673 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D84674 Files:

[PATCH] D84675: Streamline MarhsallingInfoFlag description

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, sstefan1, dexonsmith, aheejin. Herald added a reviewer: jdoerfert. Herald added projects: clang, LLVM. This replaces the existing `MarshallingInfoFlag` and `IsNegative` with simpler

[PATCH] D84676: Add new diagnostic for invalid value provided for enum-based option

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This adds a more precise diagnostics for options that have a well defined set of acceptable values. Depends on D84675

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang marked an inline comment as done. dang added inline comments. Comment at: clang/test/CodeGen/fp-function-attrs.cpp:2 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -ffast-math -ffinite-math-only -menable-unsafe-fp-math \ +// RUN: -menable-no-infs -menable-no-nans -fno-signe

[PATCH] D84674: Allow users to specify a conditional to prevent parsing options with MarshallingInfo

dang updated this revision to Diff 281614. dang added a comment. Ensure that the default value is assigned even if the option should not get parsed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84674/new/ https://reviews.llvm.org/D84674 Files:

[PATCH] D84671: Port LangOpts simple string based options to new option parsing system

dang updated this revision to Diff 281820. dang added a comment. Remove accidental addition Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84671/new/ https://reviews.llvm.org/D84671 Files: clang/include/clang/Driver/Options.td clang/lib/Fronten

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 268746. dang marked 3 inline comments as done. dang added a comment. Address some code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/inclu

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 4 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Frontend/CompilerInvocation.h:248 + /// \returns - True if parsing was successful, false otherwise + bool parseSimpleArgs(const llvm::opt::ArgList &Args, + D

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 268869. dang marked an inline comment as done. dang added a comment. Updating the patch with the correct merge base CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 268872. dang added a comment. This is the good diff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/include/clang/Frontend/CompilerInvocation.h clang/

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:70 + + static ASTFileSignature createDISentinel() { +ASTFileSignature Sentinel; I couldn't find anywhere in the code base that checks the bit-pa

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang created this revision. dang added reviewers: aprantl, dexonsmith, Bigcheese. Herald added subscribers: cfe-commits, arphaman. Herald added a project: clang. dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:70 +

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 269155. dang marked an inline comment as done. dang added a comment. Address some code review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ https://reviews.llvm.org/D80383 Files: clang/inclu

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang marked an inline comment as done. dang added a comment. See D81347 for the parent revision that makes ASTFileSignature a `std::array`. Adding the abbreviation doesn't make that much sense at the moment because of how the `IMPORTS` record is structured as d

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 3 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:137-142 +.Case("static", llvm::Reloc::Static) +.Case("pic", llvm::Reloc::PIC_) +.Case("ropi", llvm::Reloc::ROPI

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269468. dang marked an inline comment as done. dang added a comment. Address @aprantl's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: clang/include/cla

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269473. dang marked 3 inline comments as done. dang added a comment. Fix bug Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: clang/include/clang/Basic/Module.h

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang added inline comments. Comment at: clang/include/clang/Basic/Module.h:29 #include "llvm/ADT/iterator_range.h" +#include #include aprantl wrote: > Can you move the code that depends on algorithm into a .cpp file? That code is the call to `std::copy` in th

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

dang updated this revision to Diff 269845. dang added a comment. Missed a case where an ASTFileSignature was created using an explicit `std::copy` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/ https://reviews.llvm.org/D81347 Files: c

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 269854. dang marked an inline comment as done. dang added a comment. Address @dexonsmith feedback about making the relative offsets in the AST block relative to the nearest relevant subblock. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang added inline comments. Comment at: clang/include/clang/Serialization/ASTBitCodes.h:396-400 /// Record code for the signature that identifiers this AST file. SIGNATURE = 1, + /// Record code for the signature of the AST block. + AST_SIGNATURE, --

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 269926. dang added a comment. This address a bunch of existing feedback and makes the TableGen definitions of the additional information significantly nicer to write. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D81347: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t

This revision was automatically updated to reflect the committed changes. Closed by commit rGe87e55edbc79: Make ASTFileSignature an array of 20 uint8_t instead of 5 uint32_t (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81347/new/

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang updated this revision to Diff 270077. dang marked 3 inline comments as done. dang added a comment. Rebase on top of latest master that has needed NFC changes to calm down clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

dang added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:3706 unsigned LocalBaseMacroID = Record[1]; - F.MacroOffsetsBase = Record[2]; + F.MacroOffsetsBase = Record[2] + F.ASTBlockStartOffset; F.BaseMacroID = getTotalNumMacros(); -

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 270117. dang added a comment. This addresses the usability concern with having to specify fully scoped definitions for normalized values in the TableGen files. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/n

[PATCH] D80383: Add AST_SIGNATURE record to unhashed control block of PCM files

This revision was automatically updated to reflect the committed changes. Closed by commit rGbb8c7e756c51: Add AST_SIGNATURE record to unhashed control block of PCM files (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80383/new/ h

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 270445. dang edited the summary of this revision. dang added a comment. Implemented a draft of normalizer generation for simple enum based options Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://r

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 270802. dang marked an inline comment as done. dang added a comment. Implement constant table based marshaling for simple enum based options. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://review

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang marked 2 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3845 + IS_POSITIVE != DEFAULT_VALUE && this->KEYPATH != DEFAULT_VALUE) \ +Args.push_back(StringAllocator(Twine(PREFIX_TYPE[0]) + NAME)); +#i

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 271006. dang marked 5 inline comments as done and an inline comment as not done. dang added a comment. Implement suffix merging to avoid allocations for option spelling when generating the command line. This update also removes unnecessary allocation for `std::

[PATCH] D79796: Sketch support for generating CC1 command line from CompilerInvocation

dang updated this revision to Diff 271392. dang added a comment. Fixed a couple of bugs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79796/new/ https://reviews.llvm.org/D79796 Files: clang/include/clang/Driver/CC1Options.td clang/include/cla

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang updated this revision to Diff 275171. dang added a comment. Ensure that `mergeForwardValue` can accept default values whose type doesn't quite match the associated keypath. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://revi

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

dang updated this revision to Diff 275187. dang added a comment. Make the tablegen description of the new option more consistent with other flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https://reviews.llvm.org/D82874 Files: c

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This enables automatically parsing and generating CC1 arguments for options where two flags control the same field, e.g. -fexperimenta

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 275586. dang added a comment. Revert accidental namespace removal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td clang/l

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang marked 5 inline comments as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:150 -static llvm::Optional normalizeSimpleEnum(OptSpecifier Opt, -unsigned TableIndex, d

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 275591. dang marked an inline comment as done. dang added a comment. Address some code review feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/incl

[PATCH] D83209: Factor out call to EXTRACTOR in generateCC1CommandLine

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83209 Files: clang/include/clang/Driver/Options.td clang/lib/Fron

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: clang/lib/Frontend/Com

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang marked an inline comment as done. dang added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:3931-3932 if (((FLAGS)&options::CC1Option) && \ (ALWAYS_EMIT || EXTRACTOR(this->KEYPATH) != DEFAULT_VALUE))

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83211 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83298 Files: clang/include/clang

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 276007. dang added a comment. Make mergers use values directly instead of constant references Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/

[PATCH] D82860: Port ObjCMTAction to new option parsing system

dang updated this revision to Diff 276008. dang added a comment. Make mergers use values directly instead of constant references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82860/new/ https://reviews.llvm.org/D82860 Files: clang/include/clang

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 276009. dang added a comment. Rebase on top of some changes to parent patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.

[PATCH] D83298: Add ability to make fixups to CompilerInvocation after option parsing

dang updated this revision to Diff 276010. dang added a comment. Move the UseANSIEscapeCodes fixup to the correct place. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83298/new/ https://reviews.llvm.org/D83298 Files: clang/include/clang/Driver/O

[PATCH] D83315: Turn arcmt-* options into a single option

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. - The new option, -arcmt-action, is a simple enum based option. - The driver is modified to translate the existing -ccc-acmt-* options

[PATCH] D83071: Add support for options with two flags for controlling the same field.

dang updated this revision to Diff 276400. dang added a comment. Split into two macro kinds. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83071/new/ https://reviews.llvm.org/D83071 Files: clang/include/clang/Driver/Options.td clang/lib/Fronte

[PATCH] D83315: Turn arcmt-* options into a single option

dang updated this revision to Diff 276438. dang added a comment. Instead of using a Separate option kind (-arcmt-action action) use a Joined kind (-arcmt-action=*) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83315/new/ https://reviews.llvm.org/D

[PATCH] D83405: Factor out EXTRACTOR call

dang created this revision. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83071 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83405 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: cl

[PATCH] D83211: Factor out call to EXTRACTOR in generateCC1CommandLine

dang updated this revision to Diff 276466. dang added a comment. Rebase on top of latest changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83211/new/ https://reviews.llvm.org/D83211 Files: clang/lib/Frontend/CompilerInvocation.cpp Index: c

[PATCH] D83406: Remove NormalizerRetTy and use the decltype of the KeyPath instead

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. Depends on D83315 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83406 Files:

[PATCH] D82756: Port some floating point options to new option marshalling infrastructure

dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:1176 +defm reciprocal_math : OptInFFlag< "reciprocal-math", "Allow division operations to be reassociated", "", "", [], "LangOpts->AllowRecip">; +def fapprox_func : Flag<["-"], "fapprox-func">, Group,

[PATCH] D83474: Add support for specifying only a denormalizer

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: llvm-commits, cfe-commits, dexonsmith. Herald added projects: clang, LLVM. This commit adds a denormalyzer for optimization level. Depends on D83406 Repository: rG LLVM Git

[PATCH] D82574: Merge TableGen files used for clang options

This revision was automatically updated to reflect the committed changes. Closed by commit rGfccd29dddee9: Merge TableGen files used for clang options (authored by dang). Changed prior to commit: https://reviews.llvm.org/D82574?vs=273407&id=276775#toc Repository: rG LLVM Github Monorepo CHA

[PATCH] D82574: Merge TableGen files used for clang options

dang added a comment. Yes I committed this a while ago, I duplicated all the functionality in Options.td. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574 ___ c

[PATCH] D82874: Add diagnostic option backing field for -fansi-escape-codes

This revision was automatically updated to reflect the committed changes. Closed by commit rG50f24331fd91: Add diagnostic option backing field for -fansi-escape-codes (authored by dang). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82874/new/ https

[PATCH] D82574: Merge TableGen files used for clang options

dang marked an inline comment as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:3455 + HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, + MarshallingInfoString<"TargetOpts->Triple", "llvm::sys::getDefaultTargetTriple()", "std::s

[PATCH] D82574: Merge TableGen files used for clang options

dang marked 2 inline comments as done. dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:3455 + HelpText<"Specify target triple (e.g. i686-apple-darwin9)">, + MarshallingInfoString<"TargetOpts->Triple", "llvm::sys::getDefaultTargetTriple()", "std::s

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

dang added inline comments. Herald added a subscriber: dexonsmith. Comment at: clang/include/clang/Driver/Options.td:1246 HelpText<"Enables an experimental new pass manager in LLVM.">; +def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point

[PATCH] D80952: [FPEnv][Clang][Driver] Disable constrained floating point on targets lacking support.

dang added inline comments. Comment at: clang/include/clang/Driver/Options.td:1246 HelpText<"Enables an experimental new pass manager in LLVM.">; +def fexperimental_strict_floating_point : Flag<["-"], "fexperimental-strict-floating-point">, + Group, Flags<[CC1Option]>, -

[PATCH] D82574: Merge TableGen files used for clang options

dang added a comment. In D82574#2144140 , @jeroen.dobbelaere wrote: > I think that 'clang/include/clang/Driver/CC1Options.td' should also be > removed ? Yes must have missed it when rebasing. Done now in 3607aacc5981

[PATCH] D82574: Merge TableGen files used for clang options

dang added a comment. Sorry again, removed the offending options in a2cffb11e287 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82574/new/ https://reviews.llvm.org/D82574

[PATCH] D83690: Port Migator option flags to new option parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83406 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83690 Files: clang/include/clang

[PATCH] D83691: Port Comment option flags to new parsing system

dang created this revision. dang added a reviewer: Bigcheese. Herald added subscribers: cfe-commits, dexonsmith. Herald added a project: clang. Depends on D83690 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83691 Files: clang/include/clang

  1   2   3   4   >