[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert created this revision. This doesn't only happen for incorrectly built apps, it also happens for libraries loaded with dlopen. Repository: rL LLVM https://reviews.llvm.org/D38599 Files: src/private_typeinfo.cpp Index: src/private_typeinfo.cpp

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#889842, @smeenai wrote: > Does dlopen cause issues even with `RTLD_GLOBAL`? From my testing, yes. Regardless, `RTLD_LOCAL` is how JNI libraries get loaded when `System.loadLibrary` is used, so the `strcmp` fallback is a requirement

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. > Are you 100% sure that you're not just a person with broken code? Absolutely, since it isn't my code ;) I maintain the toolchain and this is a behavioral change when switching from libstdc++ to libc++. > In other words, what did this guy from 2013 get wrong? -- or,

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#893903, @jroelofs wrote: > That reminds me... this does need a testcase or two. Didn't realize I could do multi binary test cases with this test runner. It'll be a little messy, but I'll try adding one. Repository: rL LLVM http

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#893903, @jroelofs wrote: > That reminds me... this does need a testcase or two. Oh, also, any test I add is going to fail, since the case I'm trying to account for here is not the default behavior. I could make the more invasive ch

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert updated this revision to Diff 118502. danalbert edited the summary of this revision. danalbert added a comment. Added a (failing) test case. The test case will fail unless the default value of `_LIBCXX_DYNAMIC_FALLBACK` is changed. https://reviews.llvm.org/D38599 Files: src/private

[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

danalbert created this revision. Herald added a subscriber: mgorny. libc++ doesn't yet have the code for this, but libc++abi does. Adding the switch to libc++ since the flag in libc++abi is `_LIBCXX_DYNAMIC_FALLBACK`, not `_LIBCXXABI_DYNAMIC_FALLBACK`, and it will be needed here as well. Reposit

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert updated this revision to Diff 118711. danalbert added a comment. Herald added a subscriber: mgorny. Update the test with an XFAIL when _LIBCXX_DYNAMIC_FALLBACK is not set. https://reviews.llvm.org/D38827 adds this cmake option to libc++. https://reviews.llvm.org/D38599 Files: CMake

[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

danalbert planned changes to this revision. danalbert added a comment. Actually, I was wrong. This is implemented. Will update to set the flag the configures this and add a test. Repository: rL LLVM https://reviews.llvm.org/D38827 ___ cfe-commit

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert planned changes to this revision. danalbert added a comment. In https://reviews.llvm.org/D38599#894041, @jroelofs wrote: > (possibly renamed to _LIBCXXABI_DYNAMIC_FALLBACK) I opted for adding this switch to libc++ instead. Like @rprichard points out, we'll need to do this in `std::ty

[PATCH] D38827: Add a cmake option for using strcmp for type_infos.

danalbert abandoned this revision. danalbert added a comment. zygoloid and nbjoerg got me pointed in the right direction on this. Looks like the user didn't have a key function defined for one of their classes, which was actually the root of the problem. Repository: rL LLVM https://reviews.

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert abandoned this revision. danalbert added a comment. nbjoerg and zygoloid got me pointed in the right direction. Both `Base` and `BaseImpl` are missing their key functions, and that's the problem here. Patch should be unnecessary. https://reviews.llvm.org/D38599 ___

[PATCH] D38599: Remove warnings for dynamic_cast fallback.

danalbert added a comment. In https://reviews.llvm.org/D38599#899196, @howard.hinnant wrote: > Fwiw, I wrote this code. All of that "fallback" stuff was written to make > customer code that was incorrect, but working on OS X > -version-that-used-libsupc++ continue to work. I.e. to be a crutch

[PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

danalbert created this revision. danalbert added a reviewer: srhines. libgcc won't unwind without an .eh_frame_hdr section. Repository: rC Clang https://reviews.llvm.org/D43203 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/linux-ld.c Index: test/Driver/linux-ld.c ===

[PATCH] D43203: [Driver] Generate .eh_frame_hdr for static executables too.

This revision was automatically updated to reflect the committed changes. Closed by commit rC325733: [Driver] Generate .eh_frame_hdr for static executables too. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D43203?vs=133907&id=135336#toc Repository:

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX322031: Make rehash(0) work with ubsan's unsigned-integer-overflow. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D40743?vs=125193&id=128979#toc Repository

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

danalbert added inline comments. Comment at: include/__hash_table:2141 __n = 2; else if (__n & (__n - 1)) __n = __next_prime(__n); mclow.lists wrote: > danalbert wrote: > > With `rehash(0)` this is `0 & (0 - 1)`, which triggers > > unsigne

[PATCH] D53109: [Driver] Default Android toolchains to libc++.

danalbert created this revision. danalbert added reviewers: srhines, pirama. Herald added a reviewer: EricWF. Repository: rC Clang https://reviews.llvm.org/D53109 Files: lib/Driver/ToolChains/Linux.cpp lib/Driver/ToolChains/Linux.h test/Driver/android-ndk-standalone.cpp Index: test/Driv

[PATCH] D53109: [Driver] Default Android toolchains to libc++.

danalbert planned changes to this revision. danalbert added a comment. Oops, ignore this for a moment. Accidentally ran `check-cxx` instead of `check-clang`. Repository: rC Clang https://reviews.llvm.org/D53109 ___ cfe-commits mailing list cfe-c

[PATCH] D53109: [Driver] Default Android toolchains to libc++.

danalbert updated this revision to Diff 169097. danalbert added a comment. Fixed bad merge conflict resolution. Repository: rC Clang https://reviews.llvm.org/D53109 Files: lib/Driver/ToolChains/Linux.cpp lib/Driver/ToolChains/Linux.h test/Driver/android-ndk-standalone.cpp Index: test/

[PATCH] D53117: [Driver] Default to `-z now` and `-z relro` on Android.

danalbert created this revision. danalbert added reviewers: srhines, pirama. RTLD_LAZY is not supported on Android (though failing to use `-z now` will work since it is assumed by the loader). RelRO is required. Repository: rC Clang https://reviews.llvm.org/D53117 Files: lib/Drive

[PATCH] D53118: [Driver] Fix --hash-style choice for Android.

danalbert created this revision. danalbert added reviewers: srhines, pirama. Android supports GNU style hashes as of Marshmallow, so we should be generating both styles for pre-M targets and GNU hashes for newer targets. Repository: rC Clang https://reviews.llvm.org/D53118 Files: lib/Drive

[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

danalbert created this revision. danalbert added reviewers: srhines, pirama. Herald added a reviewer: javed.absar. Herald added subscribers: chrib, kristof.beyls. Android mandates that devices have at least vfpv3-d16 until Marshmallow and NEON after that. Still honor the user's decision, but raise

[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

danalbert added a comment. Related to this but something I was less sure we should do: Android no longer supports ARMv5. Should we make `arm-linux-androideabi` targets auto pull up to armv7 if there's no `-march` flag? Repository: rC Clang https://reviews.llvm.org/D53121

[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

danalbert added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:360 + unsigned ArchVersion; + if (ArchName.empty()) peter.smith wrote: > Do you need to parse the arch version here? I would expect the -march=armv7 > to be reflected in getARMSu

[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

danalbert updated this revision to Diff 169291. danalbert added a comment. Addressed review comments. Repository: rC Clang https://reviews.llvm.org/D53121 Files: lib/Driver/ToolChains/Arch/ARM.cpp test/Driver/arm-mfpu.c Index: test/Driver/arm-mfpu.c

[PATCH] D53118: [Driver] Fix --hash-style choice for Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rL344293: [Driver] Fix --hash-style choice for Android. (authored by danalbert, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53118 Files: cfe/

[PATCH] D53117: [Driver] Default to `-z now` and `-z relro` on Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rC344295: [Driver] Default to `-z now` and `-z relro` on Android. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D53117?vs=169133&id=169300#toc Repository: rC

[PATCH] D53109: [Driver] Default Android toolchains to libc++.

This revision was automatically updated to reflect the committed changes. Closed by commit rL344296: [Driver] Default Android toolchains to libc++. (authored by danalbert, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D53109 Files: cfe

[PATCH] D53121: [Driver] Add defaults for Android ARM FPUs.

This revision was automatically updated to reflect the committed changes. Closed by commit rC344367: [Driver] Add defaults for Android ARM FPUs. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D53121?vs=169291&id=169450#toc Repository: rC Clang http

[PATCH] D53343: [Driver] Default Android toolchains to noexecstack.

danalbert created this revision. danalbert added a reviewer: srhines. Android does not support executable stacks. Repository: rC Clang https://reviews.llvm.org/D53343 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChain.cpp lib/Driver/ToolChains/Clang.cpp lib/Driver/ToolChain

[PATCH] D53344: [Driver] Use --warn-shared-textrel for Android.

danalbert created this revision. danalbert added a reviewer: srhines. Android does not allow shared text relocations. Enable the linker warning to detect them by default. Repository: rC Clang https://reviews.llvm.org/D53344 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/linux-ld.c In

[PATCH] D53463: [Driver] allow Android triples to alias for non Android targets

danalbert accepted this revision. danalbert added a comment. LGTM Repository: rC Clang https://reviews.llvm.org/D53463 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38430: Enable -pie and --enable-new-dtags by default on Android.

danalbert added inline comments. Comment at: cfe/trunk/lib/Driver/ToolChains/Linux.cpp:814 +bool Linux::isPIEDefault() const { + return (getTriple().isAndroid() && !getTriple().isAndroidVersionLT(16)) || + getSanitizerArgs().requiresPIE(); pcc wrote: > e

[PATCH] D53956: Fix test assumption that Linux implies glibc.

danalbert created this revision. danalbert added a reviewer: EricWF. Herald added subscribers: libcxx-commits, ldionne, christof. This fixes an regression when using bionic introduced in r345173. I need to follow up and figure out what exactly is implied by TEST_HAS_C11_FEATURES and see what the

[PATCH] D53956: Fix test assumption that Linux implies glibc.

This revision was automatically updated to reflect the committed changes. Closed by commit rCXX345900: Fix test assumption that Linux implies glibc. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D53956?vs=172038&id=172255#toc Repository: rCXX libc+

[PATCH] D53343: [Driver] Default Android toolchains to noexecstack.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357197: [Driver] Default Android toolchains to noexecstack. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D53343?vs=169901&id=192686#toc Repository: rC Cla

[PATCH] D53344: [Driver] Use --warn-shared-textrel for Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rC357296: [Driver] Use --warn-shared-textrel for Android. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D53344?vs=169903&id=192874#toc Repository: rC Clang

[PATCH] D58153: [Driver] Default all Android ARM targets to NEON.

danalbert created this revision. danalbert added reviewers: srhines, pirama, kristof.beyls. danalbert added a project: clang. Herald added a subscriber: javed.absar. There are an insignificant number of ARM Android devices that don't support NEON. Default to using NEON since that will improve perf

[PATCH] D58153: [Driver] Default all Android ARM targets to NEON.

danalbert added a comment. In D58153#1395601 , @efriedma wrote: > The official documentation still says "Your app must perform runtime > detection to confirm that NEON-capable machine code can be run on the target > device" > (https://developer.android.

[PATCH] D58153: [Driver] Default all Android ARM targets to NEON.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354166: [Driver] Default all Android ARM targets to NEON. (authored by danalbert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert created this revision. danalbert added reviewers: peter.smith, kristof.beyls, srhines, pirama. Herald added a subscriber: javed.absar. Herald added a project: clang. The ARM gas driver previously enabled NEON for ARMv7 and up, and a handful of other extensions for ARMv8 and up (although

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert updated this revision to Diff 187670. danalbert marked 6 inline comments as done. danalbert added a comment. Updated to address some review comments: - Additional tests for gnueabi/gnueabihf - Fixed behavior for `-mfpu=neon -mfloat-abi=soft`, added test. Repository: rG LLVM Github M

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:277 + } + return ""; +} peter.smith wrote: > I'm a bit worried that we've changed the default behaviour for gnueabi[hf] > targets here. > For example with: > ``` > .text > v

[PATCH] D58477: [Driver] Fix float ABI default for Android ARMv8.

danalbert created this revision. danalbert added reviewers: srhines, pirama. Herald added subscribers: kristof.beyls, javed.absar. Herald added a project: clang. Android doesn't regress back to soft float after ARMv7 :) Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D58477 File

[PATCH] D58314: [Driver] Sync ARM behavior between clang-as and gas.

danalbert marked 3 inline comments as done. danalbert added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:389 +std::string DefaultFPU = getDefaultFPUName(Triple); +if (DefaultFPU != "") { + if (!llvm::ARM::getFPUFeatures(llvm::ARM::parseFPU(De

[PATCH] D58477: [Driver] Fix float ABI default for Android ARMv8.

This revision was automatically updated to reflect the committed changes. Closed by commit rL354622: [Driver] Fix float ABI default for Android ARMv8. (authored by danalbert, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://

[PATCH] D64089: [Driver] Introduce -stdlib++-isystem

danalbert added a comment. > For example, when we're building against the Android NDK, we might want to > use the NDK's C++ headers (which have a custom inline namespace) even if we > have C++ headers installed next to the driver. Since NDK r19 the NDK libc++ headers are already installed along

[PATCH] D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++.

danalbert created this revision. danalbert added a reviewer: pirama. Repository: rC Clang https://reviews.llvm.org/D55856 Files: lib/Driver/Driver.cpp test/Driver/nostdlibxx.cpp Index: test/Driver/nostdlibxx.cpp === --- test

[PATCH] D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++.

danalbert updated this revision to Diff 178805. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55856/new/ https://reviews.llvm.org/D55856 Files: lib/Driver/Driver.cpp test/Driver/nostdlibxx.cpp Index: test/Driver/nostdlibxx.cpp ===

[PATCH] D55856: [Driver] Also obey -nostdlib++ when rewriting -lstdc++.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349570: [Driver] Also obey -nostdlib++ when rewriting -lstdc++. (authored by danalbert, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://

[PATCH] D55953: Android is not GNU, so don't claim that it is.

danalbert created this revision. danalbert added reviewers: pirama, srhines. Repository: rC Clang https://reviews.llvm.org/D55953 Files: lib/Basic/Targets/OSTargets.h test/Preprocessor/init.c Index: test/Preprocessor/init.c

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

danalbert created this revision. danalbert added reviewers: srhines, pirama. The Android NDK still uses GNU binutils by default. Repository: rC Clang https://reviews.llvm.org/D56456 Files: lib/Driver/ToolChains/Clang.cpp test/Driver/addrsig.c Index: test/Driver/addrsig.c ==

[PATCH] D55953: Android is not GNU, so don't claim that it is.

This revision was automatically updated to reflect the committed changes. Closed by commit rC350664: Android is not GNU, so don't claim that it is. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D55953?vs=179140&id=180741#toc Repository: rC Clang C

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

This revision was automatically updated to reflect the committed changes. Closed by commit rL350668: [Driver] Default to -fno-addrsig on Android. (authored by danalbert, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D45597: [Driver] Android triples are not aliases for other triples.

danalbert created this revision. danalbert added a reviewer: srhines. Android targets should never use tools/libraries for non-Android targets or vice versa. Repository: rC Clang https://reviews.llvm.org/D45597 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/android-ndk-standalone.cpp

[PATCH] D45290: [Driver] Use the per-API level Android library directories.

danalbert marked an inline comment as done. danalbert added inline comments. Comment at: lib/Driver/ToolChains/Linux.cpp:25 #include "llvm/Support/Path.h" +#include "llvm/Support/ScopedPrinter.h" #include eugenis wrote: > I don't see why this include is necess

[PATCH] D45290: [Driver] Use the per-API level Android library directories.

This revision was automatically updated to reflect the committed changes. Closed by commit rL330213: [Driver] Use the per-API level Android library directories. (authored by danalbert, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D45290

[PATCH] D45292: [Driver] Obey computed sysroot when finding libc++ headers.

danalbert added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D45292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45291: [Driver] Infer Android sysroot location.

danalbert added a comment. Ping? Repository: rC Clang https://reviews.llvm.org/D45291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45291: [Driver] Infer Android sysroot location.

danalbert added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45597: [Driver] Android triples are not aliases for other triples.

danalbert added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45597 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45292: [Driver] Obey computed sysroot when finding libc++ headers.

danalbert added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45597: [Driver] Android triples are not aliases for other triples.

This revision was automatically updated to reflect the committed changes. Closed by commit rC330770: [Driver] Android triples are not aliases for other triples. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D45597?vs=142281&id=143807#toc Repository:

[PATCH] D45291: [Driver] Infer Android sysroot location.

danalbert added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45292: [Driver] Obey computed sysroot when finding libc++ headers.

danalbert added a comment. Ping. Repository: rC Clang https://reviews.llvm.org/D45292 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45292: [Driver] Obey computed sysroot when finding libc++ headers.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331389: [Driver] Obey computed sysroot when finding libc++ headers. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D45292?vs=141069&id=144915#toc Repository:

[PATCH] D45291: [Driver] Infer Android sysroot location.

This revision was automatically updated to reflect the committed changes. Closed by commit rC331390: [Driver] Infer Android sysroot location. (authored by danalbert, committed by ). Changed prior to commit: https://reviews.llvm.org/D45291?vs=141067&id=144916#toc Repository: rC Clang https:/

[PATCH] D56456: [Driver] Default to -fno-addrsig on Android.

danalbert added a comment. The NDK still supports linkers other than LLD, but we are changing the default to LLD in the next release. I'd prefer to keep this for the time being, but don't feel strongly about it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56456

[PATCH] D81622: [Clang] Search computed sysroot for libc++ header paths

danalbert accepted this revision. danalbert added a comment. In D81622#2094409 , @ldionne wrote: > While this doesn't look wrong to me -- and the correctness of this depends > entirely on where vendors decide to put their headers so it's hard for me to >

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. @MaskRay Any other ideas, or should I submit this? Reviewing all our options: 1. Installing LLD as simply "ld" Rejected: Causes LLD to act in mach-o mode for Darwin 2. `-DCLANG_DEFAULT_LINKER=lld` Rejected: Our host Darwin toolchain still uses the system's linker, no

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. Option 4 was (at least on the surface) super easy: https://reviews.llvm.org/D78328. lmk if you'd prefer that approach. I'm slightly less confident in it since it affects non-Android platforms as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#2000812 , @nickdesaulniers wrote: > Can we use `-DCLANG_DEFAULT_LINKER=lld` to configure AOSP's distribution of > LLD, then require the use of `-fuse-ld= that is currently used>` when targeting OSX host tools? It'd

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#2002620 , @int3 wrote: > I don't think I have enough context here to answer the question, but I'm > pretty sure that change wouldn't affect what I'm working on Sorry, wasn't referring to that question specifically, b

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#2002856 , @int3 wrote: > Yes, I was referring to that question too :) I'm working on the new lld-macho > implementation, under the `DarwinNew` flavor. I'm not sure if anything > depends on the old `Darwin` flavor, whi

[PATCH] D76452: Use LLD by default for Android.

danalbert abandoned this revision. danalbert added a comment. In D76452#2002917 , @MaskRay wrote: > In D76452#2002875 , @danalbert wrote: > > > In D76452#2002856 , @int3 wrot

[PATCH] D76452: Use LLD by default for Android.

danalbert added a comment. In D76452#2002981 , @danalbert wrote: > In D76452#2002917 , @MaskRay wrote: > > > In D76452#2002875 , @danalbert > > wrote: > > > > > In D76452#20

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

danalbert created this revision. Repository: rCXX libc++ https://reviews.llvm.org/D40743 Files: include/__hash_table Index: include/__hash_table === --- include/__hash_table +++ include/__hash_table @@ -2136,7 +2136,7 @@ void

[PATCH] D40743: Make rehash(0) work with ubsan's unsigned-integer-overflow.

danalbert added inline comments. Comment at: include/__hash_table:2141 __n = 2; else if (__n & (__n - 1)) __n = __next_prime(__n); With `rehash(0)` this is `0 & (0 - 1)`, which triggers unsigned-integer-overflow. Repository: rCXX libc+

[PATCH] D67200: Add -static-openmp driver option

danalbert added a comment. Otherwise LGTM Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:503 bool tools::addOpenMPRuntime(ArgStringList &CmdArgs, const ToolChain &TC, - const ArgList &Args, bool IsOffloadingHost, -

[PATCH] D35739: Fix LLVMgold plugin name/path for non-Linux.

This revision was automatically updated to reflect the committed changes. Closed by commit rL310895: Fix LLVMgold plugin name/path for non-Linux. (authored by danalbert). Repository: rL LLVM https://reviews.llvm.org/D35739 Files: cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp Index: cfe/t

[PATCH] D36769: Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""

danalbert created this revision. Herald added subscribers: eraman, mehdi_amini, emaste. Relanding https://reviews.llvm.org/D35739 which was reverted because it broke the tests on non-Linux. The tests have been fixed to be platform agnostic, and additional tests have been added to make sure that th

[PATCH] D36769: Revert "Revert "Fix LLVMgold plugin name/path for non-Linux.""

This revision was automatically updated to reflect the committed changes. Closed by commit rL310960: Revert "Revert "Fix LLVMgold plugin name/path for non-Linux."" (authored by danalbert). Repository: rL LLVM https://reviews.llvm.org/D36769 Files: cfe/trunk/lib/Driver/ToolChains/CommonArgs.

[PATCH] D71848: Allow the discovery of Android NDK's triple-prefixed binaries.

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. Just to clarify, this is needed for the triple-prefixed tools, but the triple-specific directory worked fine before this patch? If I'm understanding that correctly then LGTM, otherwise I

[PATCH] D91664: Add a less ambiguous macro for Android version.

danalbert closed this revision. danalbert added a comment. https://github.com/llvm/llvm-project/commit/0849047860a343d8bcf1f828a82d585e89079943 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91664/new/ https://reviews.llvm.org/D91664 __

[PATCH] D91664: Add a less ambiguous macro for Android version.

danalbert created this revision. danalbert added reviewers: enh, srhines, jiyong. Herald added a project: clang. danalbert requested review of this revision. Android has a handful of API levels relevant to developers described here: https://developer.android.com/studio/build#module-level. `__ANDRO

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert created this revision. danalbert added a reviewer: srhines. danalbert added a project: clang. danalbert requested review of this revision. The unwinder used by the crash handler on versions of Android prior to API 29 did not correctly handle binaries built with rosegment, which is enable

[PATCH] D95166: Disable rosegment for old Android versions.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfae16fc0eed7: Disable rosegment for old Android versions. (authored by danalbert). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95166/new/ https://reviews.

[PATCH] D95492: Pack relocations for Android when possible.

danalbert created this revision. danalbert added reviewers: rprichard, srhines, rahulchaudhry. danalbert added a project: clang. danalbert requested review of this revision. First supported by API 28. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D95492 Files: clang/lib/Driv

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2525131 , @dmajor wrote: > Firefox has a build break from this change. In certain Android configurations > we use bfd or gold. The statement in the commit message "Android only > supports LLD" is news to me, could you

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2527437 , @vitalybuka wrote: > Our Android build bot is broken after this patch > http://lab.llvm.org:8011/#/builders/77/builds/3234 Shouldn't that build be using lld? In D95166#2526839

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2529412 , @dmajor wrote: > It does feel kind of awkward to me that _this_ is the patch that ends up > breaking the builds, versus something at the cmake level that says "you are > explicitly unsupported". If you're u

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2530791 , @thakis wrote: > Landed revert in 1608ba09462d877111230e9461b895f696f8fcb1 > . > Someone should file a PR to make sure that gets merged to

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. > We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're > likely set on our end. https://reviews.llvm.org/D76452 not being accepted means that Android toolchains must have LLD installed as `ld`. I'm guessing this thread has shown that the patch i

[PATCH] D95166: Disable rosegment for old Android versions.

danalbert added a comment. In D95166#2540705 , @thakis wrote: > In D95166#2540399 , @danalbert wrote: > >>> We've since added -fuse-ld=lld to the three CMAKE_*_FLAGS so I think we're >>> likely set on our end. >> >

[PATCH] D93003: [libunwind] unw_* alias fixes for ELF and Mach-O

danalbert added a comment. It sounds like everyone is happy here but the tools. Could we get a libunwind reviewer (preferably @compnerd, since his review is the red one) to LGTM this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93003/new/ https:

[PATCH] D97993: [Driver] Suppress GCC detection under -B for non-Android

danalbert added inline comments. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1911 + SmallVector Prefixes; + if (TargetTriple.isAndroid()) +Prefixes.assign(D.PrefixDirs.begin(), D.PrefixDirs.end()); I'm not entirely sure what `D.PrefixDirs` represents so

[PATCH] D113840: [Driver][Android] Remove unneeded isNoExecStackDefault

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. Fine by me if this is the default for LLD. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113840/new/ https://reviews.llvm.org/D113840 ___

[PATCH] D114163: Use VersionTuple for parsing versions in Triple. This makes it possible to distinguish between "16" and "16.0" after parsing, which previously was not possible.

danalbert accepted this revision. danalbert added a comment. This revision is now accepted and ready to land. Nice, that's a lot of code cleaned up! LGTM, but probably should wait for someone from Apple to weigh in. I think the new formatting for those error messages is better for them too but t

[PATCH] D76452: Use LLD by default for Android.

danalbert abandoned this revision. danalbert added a comment. Looks like we don't actually need this. Can achieve the same effect by installing `ld.lld` to the same directory as Clang as `ld` and it'll be preferred over the other locations. Repository: rG LLVM Github Monorepo CHANGES SINCE

  1   2   >