https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/139087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/138610
Rate limit · GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,sa
@@ -709,7 +711,7 @@ static AvailabilityResult CheckAvailability(ASTContext
&Context,
<< EnvName << HintMessage;
cyndyishida wrote:
no 😅
https://github.com/llvm/llvm-project/pull/138610
___
cfe-commits ma
@@ -0,0 +1,178 @@
+// Test that modifications to a common header (imported from both a PCH and a
TU)
+// cause rebuilds of dependent modules imported from the TU on incremental
build.
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+//--- module.modulemap
+module mod_common { h
@@ -0,0 +1,178 @@
+// Test that modifications to a common header (imported from both a PCH and a
TU)
+// cause rebuilds of dependent modules imported from the TU on incremental
build.
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+
+//--- module.modulemap
+module mod_common { h
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/139318
>From 9a733c05d8ab18c1a7c45fc159718994a544f722 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Fri, 9 May 2025 12:16:14 -0700
Subject: [PATCH 1/2] [llvm][Support] Avoid setting minor/subminor/build in
Ver
https://github.com/cyndyishida approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/138920
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/139318
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/139087
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/138610
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida approved this pull request.
https://github.com/llvm/llvm-project/pull/140820
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida approved this pull request.
LGTM, thanks!
>not all platforms support -F, which is a g++ extension.
It indeed looks unecessary for this test but what is the correct way enable
support for `-F` in clang tests? I would actally expect it to show up often in
our te
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/141170
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/141170
None
>From 845121fefce0243426d640989f6fdc7008f0b2ef Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 22 May 2025 17:58:00 -0700
Subject: [PATCH] [clang][Darwin] Add test checking for tls support on xr
cyndyishida wrote:
> And, in the end, the folks debugging this (Ilya & co) are busy working on
> clang header module reproduction and reduction tools:
> https://github.com/emaxx-google/cvise/branches @emaxx-google
Interestingly enough, @vsapsai is also working on reproducers for explicitly
bu
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/142452
Sometimes, when a user writes invalid code, the minimization used for scanning
can create a stream of tokens that is invalid at lex time. This patch protects
against the case where there are valid (non-c++2
@@ -2313,12 +2340,12 @@ void Darwin::AddDeploymentTarget(DerivedArgList &Args)
const {
SDKInfo = parseSDKSettings(getVFS(), Args, getDriver());
// The OS and the version can be specified using the -target argument.
- std::optional OSTarget =
+ std::optional DP =
---
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/142013
To be able to handle all of the ways the platform & deployment version can be
represented in command line flags, the Darwin toolchain holds a type
`DarwinPlatform` to help represent them. This patch simplif
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/142013
>From a12e45e0b3025126dc112c6f8dd552b2670e88f9 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 29 May 2025 12:19:09 -0700
Subject: [PATCH] [clang][Darwin] Simply deployment version assignment in the
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/142013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
> I think that, in general, silently ignoring options that are not supported is
> a disservice to the user in that it misleads them into thinking that some
> functionality is there when it is not.
> -F is a darwin specific option in g++ so unless a target platform chooses to
https://github.com/cyndyishida approved this pull request.
Makes sense to me.
https://github.com/llvm/llvm-project/pull/141966
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
Seems like we're ok with "precompiled file" in terms of a generalization of
both precompiled headers & module files, when it's applicable, in diagnostic
messages. I am going to merge this and handle aligning the rest of the
diagnostics in a follow-up pr.
https://github.com/
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/142161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -503,6 +503,10 @@ bool Scanner::lexModuleDirectiveBody(DirectiveKind Kind,
const char *&First,
diag::err_dep_source_scanner_missing_semi_after_at_import);
if (Tok.is(tok::semi))
break;
+if (Tok.is(tok::hash) || Tok.is(tok::at))
+ return reportEr
@@ -503,6 +503,10 @@ bool Scanner::lexModuleDirectiveBody(DirectiveKind Kind,
const char *&First,
diag::err_dep_source_scanner_missing_semi_after_at_import);
if (Tok.is(tok::semi))
break;
+if (Tok.is(tok::hash) || Tok.is(tok::at))
+ return reportEr
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/142013
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/142452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/142452
>From 6b403ac7fab68feef8f1a72d8e4ab67ee2ef3c57 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 5 Jun 2025 17:51:53 -0700
Subject: [PATCH] [clang][dep-scan] Resolve lexer crash from a permutation of
i
@@ -503,6 +503,10 @@ bool Scanner::lexModuleDirectiveBody(DirectiveKind Kind,
const char *&First,
diag::err_dep_source_scanner_missing_semi_after_at_import);
if (Tok.is(tok::semi))
break;
+if (Tok.is(tok::hash) || Tok.is(tok::at))
+ return reportEr
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/142635
As follow up to:
https://github.com/llvm/llvm-project/commit/883130e33325282cfd31b68f5db52891442c20b7
>From f91e978a380ab3455843c120c4df66aa20ca8807 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon,
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/142635
>From f91e978a380ab3455843c120c4df66aa20ca8807 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Mon, 2 Jun 2025 19:38:28 -0700
Subject: [PATCH 1/2] [clang][modules] rename "AST" to precompiled in
diagnosti
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/142013
>From a12e45e0b3025126dc112c6f8dd552b2670e88f9 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 29 May 2025 12:19:09 -0700
Subject: [PATCH 1/3] [clang][Darwin] Simply deployment version assignment in
@@ -1938,11 +1942,22 @@ struct DarwinPlatform {
SourceKind Kind;
DarwinPlatformKind Platform;
DarwinEnvironmentKind Environment = DarwinEnvironmentKind::NativeEnvironment;
- VersionTuple NativeTargetVersion;
- std::string OSVersion;
- bool HasOSVersion = true, InferSim
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/142013
>From a12e45e0b3025126dc112c6f8dd552b2670e88f9 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 29 May 2025 12:19:09 -0700
Subject: [PATCH 1/3] [clang][Darwin] Simply deployment version assignment in
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/142013
>From a12e45e0b3025126dc112c6f8dd552b2670e88f9 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 29 May 2025 12:19:09 -0700
Subject: [PATCH 1/3] [clang][Darwin] Simply deployment version assignment in
cyndyishida wrote:
> How natural is it to assume that "precompiled file" is the same-ish as
> "compiled file" aka "object file"?
I have the same concern about terminology ending up being more confusing than
helpful. Personally, I've gotten used to the "pc" in pcm or pch meaning
precompiled.
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/142161
None
>From fbd695a22e88f977c8512b4cdc298dbbed7e2534 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 29 May 2025 20:39:19 -0700
Subject: [PATCH] [clang] Rename diagnostic notes that assumed precompile
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/142161
>From 6229f515af60a2b04e8599a66f036217fbc98f20 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Fri, 30 May 2025 07:53:51 -0700
Subject: [PATCH] [clang] Rename diag notes that assumed precompiled
dependenc
@@ -24,8 +24,9 @@ def err_fe_ast_file_modified : Error<
DefaultFatal;
def err_fe_pch_file_overridden : Error<
"file '%0' from the precompiled header has been overridden">;
-def note_pch_required_by : Note<"'%0' required by '%1'">;
-def note_pch_rebuild_required : Note<"
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/142161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
> what is the correct way to enable support for -F in clang tests?
@jamieschmeiser can you please answer my question?
https://github.com/llvm/llvm-project/pull/141614
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://
cyndyishida wrote:
Firstly, thank you for your responsiveness @ilya-biryukov, and for helping us
understand how this bug fix impacts Google's build.
For all individuals involved in this discussion, I would like to remind that
our [code of conduct](https://llvm.org/docs/CodeOfConduct.html) doe
cyndyishida wrote:
@jamieschmeiser I apologize if this is obvious, but is it a requirement that
clang options follow the same conventions as gcc? If so, where is that
documented?
https://github.com/llvm/llvm-project/pull/141614
___
cfe-commits mailin
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/142452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/118543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cyndyishida wrote:
https://github.com/llvm/llvm-project/pull/138234 superseded this patch, closing
this one out.
https://github.com/llvm/llvm-project/pull/118543
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/143548
* Translate the following versions to 26.
* watchOS 12 -> 26
* visionOS 3 -> 26
* macos 16 -> 26
* iOS 19 -> 26
* tvOS 19 -> 26
* Emit diagnostics, but allow conversion when clients attempt to use
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/143548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -17,7 +17,7 @@ void a(void) __attribute__((availability(macos,
introduced=12.0)));
// A-NEXT: ]
// RUN: FileCheck %s --input-file %t/output.symbols.json --check-prefix B
-void b(void) __attribute__((availability(macos, introduced=11.0,
deprecated=12.0, obsoleted=20.0)));
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/143548
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/143817
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/143817
>From 11b78ef3b9464aba1e54dcf9c18fceea359d16eb Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 11 Jun 2025 17:20:20 -0700
Subject: [PATCH] [clang][darwin] Fix assertion failure when reporting fatal
e
@@ -993,6 +1000,28 @@ bool ModuleDepCollector::isPrebuiltModule(const Module
*M) {
return true;
}
+void ModuleDepCollector::addVisibleModules() {
+ llvm::DenseSet ImportedModules;
+ auto InsertVisibleModules = [&](const Module *M) {
+if (ImportedModules.contains(M))
+
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/147969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/147969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida created
https://github.com/llvm/llvm-project/pull/147969
Clients of the dependency scanning service may need to add dependencies based
on the visibility of top-level modules, for example, when determining whether a
Swift overlay dependency should be brought in ba
cyndyishida wrote:
> In my local performance testing, there was no observable performance impact.
To expand on what I tested, `clang-scan-dep` wall time for:
* scanning a TU that includes every clang module under `/S/L/F` in the macOS 26
sdk.
* scanning a real Objective-C-based project, that
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/147969
>From 87900ca81b552c9d7718c8a38a21f53260534c6e Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 9 Jul 2025 21:50:44 -0700
Subject: [PATCH] [clang][scan-deps] Report a scanned TU's visible modules
---
@@ -57,6 +57,10 @@ struct TranslationUnitDeps {
/// determined that the differences are benign for this compilation.
std::vector ClangModuleDeps;
+ /// A list of module names that are visible to this translation unit. This
+ /// includes both direct and transitive module
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/147969
>From b72bf3e6bf1319594aa0243ed8f32a61f2436d58 Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 9 Jul 2025 21:50:44 -0700
Subject: [PATCH] [clang][scan-deps] Report a scanned TU's visible modules
---
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/147969
>From 87900ca81b552c9d7718c8a38a21f53260534c6e Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 9 Jul 2025 21:50:44 -0700
Subject: [PATCH 1/2] [clang][scan-deps] Report a scanned TU's visible modules
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/147969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida edited
https://github.com/llvm/llvm-project/pull/147969
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/147969
>From 87900ca81b552c9d7718c8a38a21f53260534c6e Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Wed, 9 Jul 2025 21:50:44 -0700
Subject: [PATCH 1/2] [clang][scan-deps] Report a scanned TU's visible modules
401 - 465 of 465 matches
Mail list logo
