[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492275. craig.topper edited the summary of this revision. craig.topper added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/tes

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492276. craig.topper added a comment. Add back the new files Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-featur

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492295. craig.topper added a comment. Add CSZN format as named in the spec. Reuse CLoad_ri/CStore_rri classes instead of creating new ones that were almost the same. Use CS_ALU class for c.mul. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492298. craig.topper added a comment. Update for rename CS_ALU to CA_ALU Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-t

[PATCH] D142596: [RISCV] Bump Zca version to 1.0.

craig.topper created this revision. craig.topper added reviewers: VincentWu, asb, luismarques, reames, jrtc27. Herald added subscribers: luke, vkmr, frasercrmck, jdoerfert, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, e

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492310. craig.topper added a comment. Merge uimm32_zc into uimm2. Add RISCVOp::OPERAND_TYPE_UIMM2_LSB0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: c

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492311. craig.topper added a comment. Fix typo in RISCVBaseInfo.h Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-f

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492315. craig.topper added a comment. Fix RUN line that was duplicate testing riscv64 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preproc

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. @VincentWu are you ok with the changes I made? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___ cfe-commits mailing list cfe-co

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492325. craig.topper added a comment. Update RISCVUsage.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-feature

[PATCH] D142596: [RISCV] Bump Zca version to 1.0.

craig.topper updated this revision to Diff 492331. craig.topper added a comment. Add Zcf and Zcd too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 Files: clang/test/Driver/riscv-arch.c llvm/docs/RIS

[PATCH] D142596: [RISCV] Bump Zca, Zcd, Zcf version to 1.0.

craig.topper updated this revision to Diff 492337. craig.topper added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 Files: clang/test/Driver/riscv-arch.c clang/test/Preproces

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper added a comment. In D131141#4082469 , @VincentWu wrote: > should I update zcb to v1.0 in this patch? > or create a new one Let's go ahead and commit this as is. I'll add Zcb to my version bump patch D142596

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 ___

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492494. craig.topper added a comment. Address @luismarques comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492501. craig.topper added a comment. Update tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c llv

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

craig.topper updated this revision to Diff 492503. craig.topper added a comment. Update file header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131141/new/ https://reviews.llvm.org/D131141 Files: clang/test/Preprocessor/riscv-target-features.c

[PATCH] D131141: [RISCV] Add MC support of RISCV Zcb Extension

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG42c36da9c99b: [RISCV] Add MC support of RISCV Zcb Extension (authored by VincentWu, committed by craig.topper). Repository: rG LLVM Github Monorep

[PATCH] D142596: [RISCV] Bump Zca, Zcd, Zcf version to 1.0.

craig.topper updated this revision to Diff 492810. craig.topper added a comment. Add Zcb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142596/new/ https://reviews.llvm.org/D142596 Files: clang/test/Driver/riscv-arch.c clang/test/Preprocessor/r

[PATCH] D142596: [RISCV] Bump Zca, Zcb, Zcd, Zcf version to 1.0.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d7a59bdc085: [RISCV] Bump Zca, Zcb, Zcd, Zcf version to 1.0. (aut

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

craig.topper added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142144/new/ https://reviews.llvm.org/D142144 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D142144: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits=

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG089bfedfb828: [RISCV][Driver] Add -mrvv-vector-bits= option similar to -msve-vector-bits= (authored by craig.topper). Changed prior to commit: htt

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added a comment. In D141672#4100940 , @reames wrote: > This was brought up in today's RISCV sync call; I want to summarize the major > points of discussion. > > This patch is now behind the current most recent revision on the > vector-crypt

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

craig.topper added a comment. We have a couple bugs that show (freeze (poison)) doesn't work past SelectionDAG. Is that a concern here? The most recent https://github.com/llvm/llvm-project/issues/60429 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

craig.topper added a comment. In D143287#4107439 , @ManuelJBrito wrote: > In D143287#4103597 , @craig.topper > wrote: > >> We have a couple bugs that show (freeze (poison)) doesn't work past >> SelectionDAG. Is

[PATCH] D137517: [TargetParser] Generate the defs for RISCV CPUs using llvm-tblgen.

craig.topper added inline comments. Comment at: llvm/include/llvm/TargetParser/CMakeLists.txt:3 +tablegen(LLVM RISCVTargetParserDef.inc -gen-riscv-target-def -I ${CMAKE_SOURCE_DIR}/lib/Target/RISCV/) +add_public_tablegen_target(RISCVTargetParserTableGen) + fpetr

[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140895/new/ https://reviews.llvm.org/D140895 ___

[PATCH] D140936: [2/7][Clang][RISCV] Remove default tail-undisturbed for vslideup intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140936/new/ https://reviews.llvm.org/D140936 ___

[PATCH] D140693: [Driver][RISCV] Adjust the priority between -mcpu, -mtune and -march

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140693/new/ https://reviews.llvm.org/D140693 ___

[PATCH] D140686: [Clang][RISCV] Update operand order for vmerge and vcompress

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140686/new/ https://reviews.llvm.org/D140686 ___

[PATCH] D140937: [3/7][Clang][RISCV] Remove default tail-undisturbed for vslidedown intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140937/new/ https://reviews.llvm.org/D140937 ___

[PATCH] D140895: [1/7][Clang][RISCV] Remove default tail-undisturbed for vector reduction intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2091 MaskedPolicyScheme = HasPassthruOperand, -IsPrototypeDefaultTU = true, +IsPrototypeDefaultTU = false, HasMaskPolicy = false in { Can we remove the lin

[PATCH] D140941: [4/7][Clang][RISCV] Remove default tail-undisturbed for multiply-add intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140941/new/ https://reviews.llvm.org/D140941 ___

[PATCH] D140942: [5/7][Clang][RISCV] Remove default tail-undisturbed for vcompress intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140942/new/ https://reviews.llvm.org/D140942 ___

[PATCH] D140947: [6/7][Clang][RISCV] Remove default tail-undisturbed for vmv_s_x and vfmv_s_f intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140947/new/ https://reviews.llvm.org/D140947 ___

[PATCH] D140954: [7/7][Clang][RISCV][NFC] Remove attribute `IsPrototypeDefaultTU`

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140954/new/ https://reviews.llvm.org/D140954 ___

[PATCH] D141798: Remove ZeroBehavior of countLeadingZeros and the like (NFC)

craig.topper added inline comments. Comment at: llvm/include/llvm/Support/MathExtras.h:212 /// Only unsigned integral types are allowed. -/// -/// \param ZB the behavior on an input of 0. Only ZB_Max and ZB_Undefined are -/// valid arguments. -template T findFirstSet(T Val, Z

[PATCH] D141459: [RISCV] Use Zvl*b as a lower bound for VScaleRange.

This revision was automatically updated to reflect the committed changes. Closed by commit rG226ceebfa232: [RISCV] Use Zvl*b as a lower bound for VScaleRange. (authored by craig.topper). Herald added a subscriber: luke. Changed prior to commit: https://reviews.llvm.org/D141459?vs=488078&id=4899

[PATCH] D141573: [1/15][Clang][RISCV][NFC] Extract common utility to RISCVVIntrinsicUtils

craig.topper accepted this revision. craig.topper added a comment. Herald added a subscriber: luke. LGTM Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:977 +llvm::SmallVector RVVIntrinsic::getSupportedUnMaskedPolicies() { + return { Possible improvem

[PATCH] D141574: [2/15][Clang][RISCV][NFC] Rename Policy::IsPolicyNone to IsUnspecifed

craig.topper added inline comments. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:96 struct Policy { - bool PolicyNone = false; + bool IsUnspecified = false; enum PolicyType { Maybe this should default to true, and the constructor that want

[PATCH] D140937: [3/7][Clang][RISCV] Remove default tail-undisturbed for vslidedown intrinsics

craig.topper accepted this revision. craig.topper added a comment. Herald added a subscriber: luke. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140937/new/ https://reviews.llvm.org/D140937 ___ cfe

[PATCH] D141577: [4/15][Clang][RISCV][NFC] Remove unnecessary logic under RVVIntrinsic::computeBuiltinTypes

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. Herald added a subscriber: luke. LGTM Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:921 PolicyAttrs.TailPolicy = Policy::PolicyType::Agnostic; // TA

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 ___

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

craig.topper requested changes to this revision. craig.topper added a comment. This revision now requires changes to proceed. Oops I didn't mean to approve this with Kito's comments outstanding. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/n

[PATCH] D141756: [6/15][Clang][RISCV][NFC] Instructions with a mask destination register is always tail agnostic

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141756/new/ https://reviews.llvm.org/D141756 ___ cfe-commits mailing list cfe-commits

[PATCH] D141759: [7/15][Clang][RISCV][NFC] Correct the default value for Policy to TAMU

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141759/new/ https://reviews.llvm.org/D141759 ___ cfe-commits mailing list cfe-commits

[PATCH] D141764: [9/15][Clang][RISCV][NFC] Use correct type for `RVVTypeCache::computeTypes` under RISCVVEmitter.cpp

craig.topper added a comment. Description repeats a slightly different version of the same statement. The existing codebase works correctly upon this bug because the default policy for unmasked intrinsics is set to TAMU. The existing code works because the default policy for unmasked

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

craig.topper added inline comments. Comment at: clang/lib/Support/RISCVVIntrinsicUtils.cpp:1032 +if (IsMasked) { + if (PolicyAttrs.isTUMAPolicy() && !HasMaskPolicy) +appendPolicySuffix("_tum"); If you hadn't just removed Omit, it somewhat feels l

[PATCH] D141768: [11/15][Clang][RISCV][NFC] Remove Policy::PolicyType::Omit

craig.topper accepted this revision. craig.topper added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141768/new/ https://reviews.llvm.org/D141768 ___ cfe-commits mailing list cfe-commits

[PATCH] D141789: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

craig.topper added inline comments. Herald added a subscriber: luke. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:428 +// The 0th bit simulates the `vta` of RVV +// The 1st bit simultaes the `vma` of RVV +// constexpr unsigned RVV_VTA = 0x1;

[PATCH] D141792: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics-autogenerated

craig.topper added a comment. Herald added a subscriber: luke. Does this really depend on the earlier patches in the series? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141792/new/ https://reviews.llvm.org/D141792 ___

[PATCH] D141792: [13/15][Clang][RISCV][NFC] Remove repeating test cases under rvv-intrinsics-autogenerated

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141792/new/ https://reviews.llvm.org/D141792 ___

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

craig.topper added a comment. In D141798#4064142 , @MaskRay wrote: > `ZB_Max` is the strange mode that should be dropped, perhaps also > `ZB_Undefined`. > > In D141798#4064114 , @arsenm wrote: > >>> If you care a

[PATCH] D141789: [12/15][Clang][RISCV][NFC] Refine the way to check for Policy in riscv_vector_builtin_cg.inc

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141789/new/ https://reviews.llvm.org/D141789 ___

[PATCH] D141793: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA

craig.topper added inline comments. Herald added a subscriber: luke. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/overloaded/vmsgt.c:10 -// CHECK-RV64-LABEL: @test_vmsgt_vv_i8mf8_b64( -// CHECK-RV64-NEXT: entry: Why does this t

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

craig.topper added inline comments. Herald added a subscriber: luke. Comment at: clang/include/clang/Support/RISCVVIntrinsicUtils.h:96 struct Policy { - bool IsUnspecified = false; + const bool IsUnspecified = false; enum PolicyType { Should this be a class

[PATCH] D142016: [Clang][RISCV] Simplify RVV intrinsic policy suffix

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142016/new/ https://reviews.llvm.org/D142016 ___

[PATCH] D141793: [14/15][Clang][RISCV] Change default policy from TAMU to TAMA

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141793/new/ https://reviews.llvm.org/D141793 ___

[PATCH] D141672: [RISCV] Support vector crypto extension ISA string and assembly

craig.topper added inline comments. Herald added a subscriber: luke. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:765 + if ((Exts.count("zvkb") || Exts.count("zvkg") || Exts.count("zvknha") || Exts.count("zvkns") || + Exts.count("zvksed") || Exts.count("zvksh")) && !Ha

[PATCH] D142144: [RISCV][Driver] Add -rvv-vector-bits= option similar to -sve-vector-bits=

craig.topper created this revision. craig.topper added reviewers: reames, kito-cheng, frasercrmck, rogfer01. Herald added subscribers: luke, VincentWu, ctetreau, vkmr, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, edw

[PATCH] D141796: [15/15][Clang][RISCV][NFC] Set data member under Policy as constants

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141796/new/ https://reviews.llvm.org/D141796 ___

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vaadd.c:5-14 // RUN: FileCheck --check-prefix=CHECK-RV64 %s #include -// CHECK-RV64-LABEL: @test_vaadd_vv_i8mf8( +// CHECK-RV64-LABEL: @test__

[PATCH] D142085: [Clang][RISCV] Add `__riscv_` prefix for all RVV intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:1535 enum RVV_CSR { RVV_VSTART = 0, RVV_VXSAT, Not related to this patch, but this enum should probably be using double underscores for its names. Repository: rG

[PATCH] D142144: [RISCV][Driver] Add -rvv-vector-bits= option similar to -sve-vector-bits=

craig.topper added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2150 + Args.MakeArgString("-mvscale-min=" + llvm::Twine(VScaleMin))); +} else if (!Val.equals("scalable")) { + // Handle the unsupported values passed to mrvv-vector-bits.

[PATCH] D141754: [5/15][Clang][RISCV][NFC] Remove extra attribute Policy::IntrinsicWithoutMU by reusing HasTailPolicy and HasMaskPolicy

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141754/new/ https://reviews.llvm.org/D141754 ___

[PATCH] D125875: [RISCV] Add vread_csr and vwrite_csr to riscv_vector.h

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125875/new/ https://reviews.llvm.org/D125875 ___

[PATCH] D128235: [RISCV] Add support for the Zawrs extension

craig.topper added inline comments. Comment at: clang/test/Driver/riscv-arch.c:585 +// RUN: -fsyntax-only 2>&1 | FileCheck -check-prefix=RV32-ZAWRS-GOOD %s +// RV32-ZHINX-GOOD: "-target-feature" "+zawrs" + This doesn't match the RUN line Commen

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

craig.topper added a comment. In D126461#3596761 , @reames wrote: > Despite the comments above, the purpose of this patch remains unclear. > > Per the draft spec, the relevant wording is: > "These instructions execute as a regular load except that they wi

[PATCH] D127976: [IR] Move vector.insert/vector.extract out of experimental namespace

craig.topper added inline comments. Comment at: llvm/docs/LangRef.rst:17289 insert into. Conceptually, this can be used to build a scalable vector out of -non-scalable vectors. +non-scalable vectors, however this intrinsic can also be used on purely fixed +types. ---

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff destination isn't null

craig.topper added a comment. In D126461#3599122 , @reames wrote: > In D126461#3597862 , @craig.topper > wrote: > >> `dst` in the patch description is not the pointer being loaded, it's the >> pointer of where t

[PATCH] D126461: [RISCV] Extract and store new vl of vleff/vlsegff iff new_vl output pointer isn't null

craig.topper added a comment. I have attempted to revise the title and description. Please take a look @pcwang-thead and @reames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/ https://reviews.llvm.org/D126461 __

[PATCH] D128461: [X86] Simplify __cpuid_count

craig.topper added a comment. I think it's still relevant. We had the same issue on Windows as recently as https://github.com/llvm/llvm-project/issues/49477 see also https://github.com/llvm/llvm-project/issues/17204 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D103313: [RISCV][Clang] Add support for Zmmul extension

craig.topper added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:25 + "'M' (Integer Multiplication and Division)", + [FeatureStdExtZmmul]>; def HasStdExtM : Predicate<"Subtarget->hasStdExtM()">, This will

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

craig.topper added a comment. What is it isn't known to be null at compile time but gets optimized to it. Are we trying to make passing a null pointer defined behavior for these intrinsics? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126461/new/

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:650 + cast(NewVL->getType(; +BasicBlock *IsNotNull = createBasicBlock("newvl.isNotNull", this->CurFn); +BasicBlock *IsNull = createBasic

[PATCH] D126461: [RISCV] Extract and store new vl of vleff iff destination isn't null

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:651 +BasicBlock *IsNotNull = createBasicBlock("newvl.isNotNull", this->CurFn); +BasicBlock *IsNull = createBasicBlock("newvl.isNull", this->CurFn); +Builder.CreateCo

[PATCH] D155414: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:5336 + // least zve64x + if ((Ty->isRVVType(/* Bitwidth */ 64, /* IsFloat */ false) && + !TI.hasFeature("zve64x")) || Can we do ``` if ((Ty->isRVVType(/* Bitwidth */ 64, /* I

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); eopXD wrote: > V

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/include/clang/Basic/riscv_vector.td:2405 + defvar suffix = !if(IsVV, "vv", "vi"); + defvar prototype = !if(IsVV, "UvUvUvUv", "UvUvUvKz"); + defm "" : RVVBuiltinSet; Can we split this into two classes and ge

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/test/CodeGen/RISCV/rvv-intrinsics-autogenerated/non-policy/non-overloaded/vwsll.c:12 +// +vint16mf4_t test_vwsll_vv_i16mf4(vint8mf8_t op1, vint8mf8_t op2, size_t vl) { + return __riscv_vwsll_vv_i16mf4(op1, op2, vl);

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); craig.topper wro

[PATCH] D155222: [RISCV][AArch64][IRGen] Add scalable->fixed as a special case in CreateCoercedStore.

craig.topper abandoned this revision. craig.topper added a comment. Abandoning in favor of D155495 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155222/new/ https://reviews.llvm.org/D155222 __

[PATCH] D155495: [RISCV][AArch64][IRGen] Add a special case to CodeGenFunction::EmitCall for scalable vector return being coerced to fixed vector.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd53d842d12ce: [RISCV][AArch64][IRGen] Add a special case to CodeGenFunction::EmitCall for… (authored by craig.topper). Changed prior to commit: ht

[PATCH] D155416: [Clang][RISCV] Improve diagnostic message for full multiply intrinsics

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM for now, but long term I think we need a mechanism to do this builtins that require extensions like vector crypto. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D155414: [Clang][RISCV] Guard RVV intrinsics types that is not available when ELEN < 64

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155414/new/ https://reviews.llvm.org/D155414 ___

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper created this revision. craig.topper added reviewers: asb, VincentWu, wangpc, kito-cheng. Herald added subscribers: jobnoorman, luke, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edwar

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper updated this revision to Diff 541751. craig.topper added a comment. git add the header Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 Files: clang/lib/Headers/CMakeLists.txt clang/lib/He

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper updated this revision to Diff 541752. craig.topper added a comment. Fix file description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 Files: clang/lib/Headers/CMakeLists.txt clang/lib/

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper updated this revision to Diff 541759. craig.topper added a comment. Fix name of zip/unzip builtin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ https://reviews.llvm.org/D155647 Files: clang/lib/Headers/CMakeLists.txt c

[PATCH] D138810: [RISCV] Support vector crypto extension C intrinsics

craig.topper added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:4576 + case RISCVVector::BI__builtin_rvv_vaeskf1_vi_ta: + case RISCVVector::BI__builtin_rvv_vsm4k_vi_ta: +return SemaBuiltinConstantArgRange(TheCall, 1, 0, 31); craig.topper wro

[PATCH] D155668: [RISCV] Upgrade Zvfh version to 1.0 and move out of experimental state.

craig.topper created this revision. craig.topper added reviewers: asb, reames, kito-cheng. Herald added subscribers: jobnoorman, luke, VincentWu, vkmr, frasercrmck, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, arphaman, the_o, brucehoult, MartinMosbeck, rogfe

[PATCH] D155674: [RISCV] Update zihintntl to 1p0

craig.topper added a comment. Looks like we have two patches for this now. D151547 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155674/new/ https://reviews.llvm.org/D155674 _

[PATCH] D155668: [RISCV] Upgrade Zvfh version to 1.0 and move out of experimental state.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3055c5815ac0: [RISCV] Upgrade Zvfh version to 1.0 and move out of experimental state. (authored by craig.topper). Changed prior to commit: https:/

[PATCH] D155647: [RISCV] Add C intrinsics for scalar crypto

craig.topper updated this revision to Diff 542121. craig.topper added a comment. Rebase after using mem2reg. Fix a couple copy/paste mistakes that were much easier to spot with mem2reg. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155647/new/ http

[PATCH] D156248: [Headers][doc] Add description of _mm256_movemask_epi8

craig.topper accepted this revision. craig.topper added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D156248/new/ https://reviews.llvm.org/D156248 ___ cfe-commits mailing list c

[PATCH] D152793: [RISCV] Add MC layer support for Zicfiss.

craig.topper added inline comments. Comment at: clang/test/Preprocessor/riscv-target-features.c:75 // CHECK-NOT: __riscv_zvfbfwma {{.*$}} +// CHECK-NOT: __riscv_zicfisslp {{.*$}} This needs to be renamed to remove lp Comment at: clang/test/P

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948 // Additional dependency checks. - // TODO: The 'q' extension requires rv64. - // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'. + // The 'q' extension requires rv64. + i

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948 // Additional dependency checks. - // TODO: The 'q' extension requires rv64. - // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'. + // The 'q' extension requires rv64. + i

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948 - // TODO: The 'q' extension requires rv64. - // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'. asb wrote: > imkiva wrote: > > wangpc wrote: > > > I think t

[PATCH] D156214: [LLVM][RISCV] Check more extension dependencies

craig.topper added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:948 - // TODO: The 'q' extension requires rv64. - // TODO: It is illegal to specify 'e' extensions with 'f' and 'd'. craig.topper wrote: > asb wrote: > > imkiva wrote: > > > wan

<    6   7   8   9   10   11   12   13   14   15   >