[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin updated this revision to Diff 481556. cor3ntin added a comment. Fix grammar in diagnostic. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. Thanks Tom. I'm adding more reviewers in case someone else wants to look at it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___ cfe

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:129-130 InGroup>; def warn_utf8_symbol_homoglyph : Warning< "treating Unicode character as identifier character rather than " "as '%1' symbol">, InGroup>; tahon

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. Thanks Tom, I replied to your comments Comment at: clang/lib/Lex/Lexer.cpp:3386 + + if (!Result || CurPtr - StartPtr == (ptrdiff_t)(Buffer.size() + 4)) StartPtr = CurPtr; cor3ntin wrote: > tahonermann wrote: > > This is a bit of

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. Thanks a lot for working on this. I will try to do a more detailed review later, but at least I think we might want more tests. Maybe codegen tests that do not rely on [[clang::lifetimebound]], and tests with more chaining (`a().b().c()`) . Repository: rG LLVM Gith

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3378-3379 - if (LooseMatch) + // If no diagnostic has been emitted yet we do not want to recover here + // to make sure this function will be called again and a diagnostic emitted then. + if (LooseMatch &&

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 481766. cor3ntin added a comment. - Rebase - Add/Improve comments - Add more trigrahs tests - Fix crash when a trigraph appears at the end of a named escape sequence and trigraphs are disabled - Fix when getAndAdvanceChar is called - alas there is no way to

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 481767. cor3ntin added a comment. Format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/lib/L

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added inline comments. Comment at: clang/lib/Lex/Lexer.cpp:3386 + + if (!Result || CurPtr - StartPtr == (ptrdiff_t)(Buffer.size() + 4)) StartPtr = CurPtr; tahonermann wrote: > cor3ntin wrote: > > tahonermann wrote: > > > cor3ntin wrote: > > > > cor

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. Thanks! Cleaned up version: struct string { constexpr string(const char*) {}; constexpr ~string(); }; struct AutocompleteParsingResult; struct optional { template constexpr optional(U &&) {} }; struct AutocompleteParsingResult { s

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 481850. cor3ntin added a comment. - Make sure cleanups expressions are created in the correct evaluation context. This simplifies and reduce the numbers of nested evaluation contexts we create, notably to make sure the creation of the initialier and cleanup

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. @aeubanks I think i got it. Were you having this issue with an open source project by any chance? Maybe i could try it locally before commiting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.ll

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3986713 , @aeubanks wrote: > yes, it was chrome > I went ahead and tried the latest patch, it successfully compiles the file > that crashed before. I built all of chrome, and now I'm getting one last > linker error,

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3986779 , @cor3ntin wrote: > In D136554#3986713 , @aeubanks > wrote: > >> yes, it was chrome >> I went ahead and tried the latest patch, it successfully compiles the file >>

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3987122 , @aeubanks wrote: > no, I got > > $ ninja -C out/MyClang/ content_unittests > ld.lld: error: undefined symbol: > mojo::Receiver mojo::RawPtrImplRefTraits>::Receiver(content::mojom::TestInterfaceForDefer*)

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 482051. cor3ntin added a comment. When a CXXDefaultInitExpr calls a Constructor, make sure that the fields default initialized by that constructor are also marked odr used. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. @aeubanks I just completed a compilation of all of chrome including tests. let me know if you want to run more tests on your side and thanks again for reporting these issues. I think we are getting there. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. Hey. Thanks a lot for working on this. I did a first pass, looking at mostly style issues, looking at conformance will probably take me a lot more time, but i think this looks pretty good overall Comment at: clang/include/clang/AST/DeclCXX.h:1911

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 482279. cor3ntin added a comment. Fix caret position Fix tests (defining a macro named 'a' caused issues) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: cl

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. In D138861#3988954 , @tahonermann wrote: > @cor3ntin, I suspect the answer is no, but do your changes perhaps address > this assertion failure? https://godbolt.org/z/1bPcPcWzv > > int \u1{234}; Interesting bug. No, it doesn

[PATCH] D139889: [Clang] Fix a crash when encountering an ill-formed delimited UCN.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. \u{...} was incorrectly parsed as a valid UCN instead of emitting a diagnostic, causing an assertion failure. Repository

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. https://reviews.llvm.org/D139889 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbfe446ef3b2: [Clang] Implement CWG2640 Allow more characters in an n-char sequence (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 482377. cor3ntin added a comment. remove llvm::None Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Ex

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1f1b60c7ba6: Implement CWG2631 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3993791 , @rupprecht wrote: > Looks like the latest reland still has some issue remaining. With asserts > enabled, I get: `assert.h assertion failed at > clang/include/clang/AST/Type.h:752 in const ExtQualsTypeCommon

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin updated this revision to Diff 482778. cor3ntin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagn

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#3996643 , @rupprecht wrote: > Here's a well-formed reproducer: Thanks a lot. We were transforming the initializer in a context where the this pointer was not set up properly, so if it was referring to this, explicitl

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 483133. cor3ntin added a comment. Properly transform the this pointer in member initializers that need to be rewritten. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D1365

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31f4859c3e4d: [Clang] Allow additional mathematical symbols in identifiers. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D136554: Implement CWG2631

cor3ntin added a comment. In D136554#4000363 , @rupprecht wrote: > I applied this version of the patch and the crash is now gone 🎉 > > However, now I get this inexplicable error -- I'm not entirely sure it's > related, maybe I'm holding it wrong: > > I

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin added a comment. In D124351#4001050 , @eandrews wrote: > I came across a strange error when capturing arguments in a lambda inside > another lambda. I filed an issue here - > https://github.com/llvm/llvm-project/issues/59549 > > Short reproduce

[PATCH] D124351: [Clang][WIP] Implement Change scope of lambda trailing-return-type - Take 2

cor3ntin updated this revision to Diff 483757. cor3ntin added a comment. Fix fix-it tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124351/new/ https://reviews.llvm.org/D124351 Files: clang/docs/ReleaseNotes.rst clang/include/clang/AST/Dec

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

cor3ntin added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179 +/// consteval int bar(); +/// void baz() { if consteval {} } +/// \endcode Izaron wrote: > aaron.ballman wrote: > > It'd be good to show an example of: > > ``` > >

[PATCH] D117613: [ASTMatchers] Add `isConsteval` matcher

cor3ntin added inline comments. Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:5179 +/// consteval int bar(); +/// void baz() { if consteval {} } +/// \endcode aaron.ballman wrote: > cor3ntin wrote: > > Izaron wrote: > > > aaron.ballman wrote: > >

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin created this revision. Herald added a subscriber: carlosgalvezp. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added projects: clang, clang-tools-extra. Implement P2128R6 in C++23 mode. Unlike GCC's

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402349. cor3ntin added a comment. Fix formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertUtils.cpp

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402353. cor3ntin added a comment. Fix typos in commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994 Files: clang-tools-extra/clang-tidy/modernize/LoopCon

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402610. cor3ntin added a comment. Fix another typo in the commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994 Files: clang-tools-extra/clang-tidy/modern

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402780. cor3ntin added a comment. Address Erich's feedback: A source range was only constructed from the first element Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117994/new/ https://reviews.llvm.org/D117994

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin updated this revision to Diff 402781. cor3ntin marked an inline comment as done. cor3ntin added a comment. Address Erich's feedback: A source range was only constructed from the first element Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D117994: [Clang] Implement multidimentional subscript operator

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaAccess.cpp:1799 +R = SourceRange(ArgExprs.front()->getBeginLoc(), +ArgExprs.front()->getEndLoc()); + } erichkeane wrote: > So should the 'end' be `ArgExprs.back()->getEndLoc()

[PATCH] D112916: Confusable identifiers detection

cor3ntin added a comment. In D112916#3314184 , @cor3ntin wrote: > @aaron.ballman Thanks for the ping. > > One one hand, I agree with you, on the other hand, this tries to stick to > TR39, and I think we should stick with that. It might be worth checking

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added a comment. @hubert.reinterpretcast Gentle ping in case you didn't see Aaron's message - there isn't too much urgency though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400

[PATCH] D120333: [NFC][Lexer] Make access to LangOpts more consistent

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. This looks good to me, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120333/new/ https://reviews.llvm.org/D120333 _

[PATCH] D106577: [clang] Define __STDC_ISO_10646__

cor3ntin abandoned this revision. cor3ntin added a comment. Herald added subscribers: pcwang-thead, luke957. Based on feedback, I will not pursue this any further (unless WG14 decides to tackle the issue) Thanks for the comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

cor3ntin added a comment. I like this approach. it seems a lot easier to maintain as people don't have to remember to use LangOptionsBase to not degrade performance Comment at: clang/include/clang/Lex/Lexer.h:94 + // LangOpts enabled by this language. + const LangOptions &La

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin updated this revision to Diff 411100. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Adds more tests for calls inside std, inline namespaces and adl lookup - use llvm::find - rename the warning flag to unqualified-std-cast-call to leave room for future extensions

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin updated this revision to Diff 411101. cor3ntin added a comment. Fix comment to address Christopher's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119670/new/ https://reviews.llvm.org/D119670 Files: clang/include/clang/Basic/Di

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/warn-self-move.cpp:20-21 using std::move; - x = move(x); // expected-warning{{explicitly moving}} + x = move(x); // expected-warning{{explicitly moving}} \ + expected-warning {{unqualified call

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin updated this revision to Diff 41. cor3ntin added a comment. Fix comments punctuation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119670/new/ https://reviews.llvm.org/D119670 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6441 + // Only warn for some functions deemed more frequent or problematic + static constexpr llvm::StringRef SpecialFunctions[] = {"move", "forward"}; + auto it = llvm::find(SpecialFunctions, D->getName()

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added a comment. In D119670#3343076 , @erichkeane wrote: > I understand you still don't have commit-rights. If you'd like, I can push > this in a little bit. Just let me know the name/email you'd like me to use. I guess i should ask for thos

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:6441 + // Only warn for some functions deemed more frequent or problematic + static constexpr llvm::StringRef SpecialFunctions[] = {"move", "forward"}; + auto it = llvm::find(SpecialFunctions, D->getName()

[PATCH] D120456: [clang] Bump __cpp_concepts and __cpp_constexpr in accordance with P2493R0

cor3ntin added a comment. Thanks for the patch. However, wg21.link/P0848 need to be fully implemented before we can update `__cpp_concepts`. Could you only modify `__cpp_constexpr` ? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120456/new

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added a comment. In D119670#3343726 , @erichkeane wrote: > In D119670#3343718 , @rnk wrote: > >> This broke our libc++ -Werror build: >> >> llvm-project/libcxx/src/filesystem/directory_iterator.cpp:107

[PATCH] D119670: [clang] Warn on unqualified calls to std::move and std::forward

cor3ntin added a comment. > The issue is that for its own tests, libc++ headers are not considered system > headers. we should fix libc++. I can do that later today. I though > @Quuxplusone did. Patch here https://reviews.llvm.org/D120509 - I'm still running the test locally to double check

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

This revision was automatically updated to reflect the committed changes. Closed by commit rGc5e1b5e6a99f: [Clang][Sema] Do not evaluate value-dependent immediate invocations (authored by Izaron, committed by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D119375: [Clang][Sema] Do not evaluate value-dependent immediate invocations

cor3ntin added a comment. In D119375#3329014 , @Izaron wrote: > A friendly ping =) Seems like I don't have write access, so unfortunately I > have to ask people to merge commits on my behalf. Let me copy-paste the usual > comment of my reviews: I lande

[PATCH] D113393: [c++2b] Implement P0849R8 auto(x)

cor3ntin added a comment. > This option sounds quite sensible to me! I'd like that too! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113393/new/ https://reviews.llvm.org/D113393 ___ cfe-commits mailing

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes https://github.com/llvm/llvm-project/issues/54151 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin updated this revision to Diff 412654. cor3ntin added a comment. Fix Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120881/new/ https://reviews.llvm.org/D120881 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/l

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin updated this revision to Diff 412689. cor3ntin added a comment. - Fix redundant check - move test to p17.cpp which seems more approriate - add a couple of tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120881/new/ https://reviews.llvm

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

cor3ntin added a comment. In D120881#3357015 , @erichkeane wrote: > Do we have a test somewhere to check the variable template specialization > case to make sure that didn't break? Otherwise LGTM. Thanks for the review. It seems fairly well covered in

[PATCH] D120881: [Clang] Diagnose invalid member variable with template parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG942c03910aef: [Clang] Diagnose invalid member variable with template parameters (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D121211: Properly diagnose constant evaluation issues at TU scope

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. There is already an evaluation context created in Sema but it's never popped back. And because we rely heavily on there always being at least one evaluation context (`ExprEvalContexts.back

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 400317. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/Diagnost

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin added a comment. In D111400#3243826 , @aaron.ballman wrote: > In D111400#3172097 , @cor3ntin > wrote: > >> Regression compared to the status quo: >> This code no longer warns (as noted by Hubert above)

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 400325. cor3ntin added a comment. run clang-format. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Basic/

[PATCH] D115228: [Clang] Do not check if we are in a discared context in non-immediate contexts

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This fixes in a regression introduced by 6eeda06c1 . When deducing the return ty

[PATCH] D115228: [Clang] Do not check if we are in a discared context in non-immediate contexts

cor3ntin updated this revision to Diff 392319. cor3ntin added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115228/new/ https://reviews.llvm.org/D115228 Files: clang/include/clang/Sema/Sema.h clang/test/CXX/stmt.stmt/st

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expression

cor3ntin created this revision. Herald added subscribers: dexonsmith, martong. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99893 Files: clang/include/clang/AST

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

cor3ntin added a comment. > Treating a namespace-`std` function template as a builtin isn't entirely > novel; we already do this for MSVC's `std::_GetExceptionInfo` (though we > don't actually handle that properly: we're missing the "namespace `std`" > check, at least). Treating the builtin def

[PATCH] D99893: [WIP] Replace std::forward & std::move by cast expressions during Sema

cor3ntin added a comment. In D99893#2672258 , @rjmccall wrote: > Our builtin logic is capable of recognizing user declarations as builtins > without any sort of explicit annotation in source. That's how we recognize C > library builtins, for example. A

[PATCH] D93031: Enable fexec-charset option

cor3ntin added a comment. >> We should use the original source form of the string literal when >> pretty-printing a `StringLiteral` or `CharacterLiteral`; there are a bunch >> of UTF-8 assumptions baked into `StmtPrinter` that will need revisiting. And >> we'll need to modify the handful of pla

[PATCH] D93031: Enable fexec-charset option

cor3ntin added a comment. In D93031#2706988 , @joerg wrote: > "Keeping the original spelling around" would assume that the input is not > using a stateful encoding. That seems worse as assumption than giving the > canonical output in UTF-8 and shifting t

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin created this revision. Herald added a subscriber: jeroen.dobbelaere. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Implement P2360R0 in C++23 mode and as an extension in older languages mode. Repository: rG LLVM Gith

[PATCH] D111187: [Clang] Add information about partially implemented features

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Desccribe in cxx_status.html the missing parts of the partially implemented proposals described in cxx_status.html. Uses blocks so the information ap

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin planned changes to this revision. cor3ntin added inline comments. Comment at: clang/include/clang/Basic/DiagnosticParseKinds.td:553 +def err_expected_alias_after_using_in_init_statement : Error< + "expected alias declaration after using in init statement">; +def ext_ali

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377755. cor3ntin marked an inline comment as done. cor3ntin added a comment. - Modify ParseUsingDeclaration to only parse an alias in init statememts - Make the c++23 extebsion warning clearer - Nitpicks. The error is now 'expected '=', which seems good enou

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377756. cor3ntin added a comment. Update release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377921. cor3ntin marked 3 inline comments as done. cor3ntin added a comment. Add C++20 compat warning, fix style. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Fil

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377929. cor3ntin added a comment. fix diagnostic, nits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Bas

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin updated this revision to Diff 377930. cor3ntin added a comment. Fix version in diagnostics in the right direction (23 => 2b) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75/new/ https://reviews.llvm.org/D75 Files: clang/docs/Re

[PATCH] D111175: [Clang] Extend init-statement to allow alias-declaration

cor3ntin added inline comments. Comment at: clang/test/Parser/cxx2b-init-statement.cpp:19 + +if (using enum ns::e; false){} // expected-error {{expected '='}} + erichkeane wrote: > aaron.ballman wrote: > > erichkeane wrote: > > > Is there any way to have thi

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin created this revision. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Allow goto, label statements as well as static, thread_local and non-literal variables in constexpr functions. The proposal is implemented as a langua

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 378172. cor3ntin added a comment. Fix diagnostics formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D111400: [Clang] Implement P2242R3

cor3ntin updated this revision to Diff 378173. cor3ntin added a comment. Add missing test file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111400/new/ https://reviews.llvm.org/D111400 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Ba

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

cor3ntin added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:60-62 + // A naive individual might expect the following to all fail concept checking, + // but there does not seem to be any requirement to check these in the + // standard,

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

cor3ntin added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:60-62 + // A naive individual might expect the following to all fail concept checking, + // but there does not seem to be any requirement to check these in the + // standard,

[PATCH] D110641: Implement P0857R0 -Part B: requires clause for template-template params

cor3ntin added inline comments. Comment at: clang/test/CXX/temp/temp.arg/temp.arg.template/p3-2a.cpp:60-62 + // A naive individual might expect the following to all fail concept checking, + // but there does not seem to be any requirement to check these in the + // standard,

[PATCH] D112089: consteval if does not form a discarded statement

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Oups, Sorry I missed that in my earlier PR. This fix LGTM. Thanks Aaron Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112089/new/ https://re

[PATCH] D112089: consteval if does not form a discarded statement

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseStmt.cpp:1445-1450 Sema::ExpressionEvaluationContext Context = Sema::ExpressionEvaluationContext::DiscardedStatement; -if (NotLocation.isInvalid() && IsConsteval) +if (NotLocation.isInvalid() &

[PATCH] D108403: Fix assertion when generating diagnostic for inline namespaces

cor3ntin added inline comments. Comment at: clang/lib/AST/DeclBase.cpp:1222 + DeclContext *DC = this; + while (DC && DC->isTransparentContext()) +DC = DC->getParent(); Can getParent() be null? If it cam, then this function can return null which you don't c

[PATCH] D108469: Improve handling of static assert messages. Instead of dumping the string literal (which quotes it and escape every non-ascii symbol), we can use the content of the string (which we

cor3ntin created this revision. Herald added a subscriber: martong. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. ...g). `FormatDiagnostic` is modified to escape non printable characters and invalid UTF-8. This ensures that uni

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367802. cor3ntin retitled this revision from "Improve handling of static assert messages. Instead of dumping the string literal (which quotes it and escape every non-ascii symbol), we can use the content of the string (which we know is valid UTF-8 by virtue

[PATCH] D105759: [WIP] Implement P2361 Unevaluated string literals

cor3ntin updated this revision to Diff 367811. cor3ntin added a comment. Fix diagnostic for avaibility attributes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105759/new/ https://reviews.llvm.org/D105759 Files: clang-tools-extra/test/clang-tidy

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin updated this revision to Diff 367812. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108469/new/ https://reviews.llvm.org/D108469 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Basic/

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added a comment. In D108469#2957652 , @jfb wrote: > I worry that changing the general `static_assert` printing (adding a colon, > and dropping the quotes) will get @hwright's law to drop on us. We can try > and see if e.g. users of clang have a

[PATCH] D108469: Improve handling of static assert messages.

cor3ntin added inline comments. Comment at: clang/lib/Basic/Diagnostic.cpp:818 + llvm::raw_string_ostream stream(number); + stream << ""; + OutStr.append(number.begin(), number.end()); jfb wrote: > We don't have a better hex formatter? 😟 > Not a bi

<    11   12   13   14   15   16   17   >