[PATCH] D124351: [Clang] Implement Change scope of lambda trailing-return-type

cor3ntin added a comment. @rupprecht Great to hear! Sorry again for the disruption @shafik Thanks for the review! Comment at: clang/lib/Sema/SemaLambda.cpp:1010 + + // C++11 [expr.prim.lambda]p5: + // The closure type for a lambda-expression has a public inline function --

[PATCH] D129689: [limits.h] USHRT_MAX fix for 16 bit architectures

cor3ntin added a comment. @aaron.ballman I think we should close this change as it's superseeded by https://reviews.llvm.org/D144218 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129689/new/ https://reviews.llvm.org/D129689 ___ cfe-commits m

[PATCH] D144196: [C2x] Remove the ATOMIC_VAR_INIT macro from stdatomic.h

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Sorry it took me a while to reply to you. I think you convinced me this is fine as-is! Thanks Comment at: clang/lib/Headers/stdatomic.h:50 + in C2x mode; switch to the

[PATCH] D132398: Allow constant static members to be used with 'this'

cor3ntin added a comment. Herald added a subscriber: ChuanqiXu. Given this has not made progress in a while, I think we should try to implement https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p2280r4.html instead of this approach, as I'm not sure if that's strictly conforming, and a mor

[PATCH] D149904: Generic selection expressions that accept a type operand

cor3ntin added a comment. I observe there is no documentation or release notes yet :) Comment at: clang/include/clang/AST/Expr.h:5930 + /// argument. + bool isExprPredicate() const { return IsExprPredicate; } + /// Whether this generic selection uses a type as its controllin

[PATCH] D149904: Generic selection expressions that accept a type operand

cor3ntin added inline comments. Comment at: clang/include/clang/AST/Expr.h:5691 + unsigned getIndexOfControllingExpression() const { +// If controlled by an expression, the first offset into the Stmt * aaron.ballman wrote: > erichkeane wrote: > > What is t

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #62462 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.r

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The logic of whether an entity needs to be captured has become quite complex and the recent changes in https://reviews.llv

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520085. cor3ntin added a comment. Address @tbaeder feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/Expr

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520154. cor3ntin added a comment. Update commit message and add comment referencing the standard. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. @rZhBoYao are you still working on this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139586/new/ https://reviews.llvm.org/D139586 ___ cfe-commits mailing list cfe-comm

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520316. cor3ntin added a comment. Fix release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant

[PATCH] D150108: [clang] Evaluate non-type default template argument when it is required

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM. I love it when remove it code fixes a bug! Thanks for the PR Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150108/new/ https://reviews

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. @erichkeane @aaron.ballman I think we should determine how much works remains there and if the author is not responsive maybe one of us can push this up the finishing line. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D13

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

cor3ntin added a comment. In D150038#4326549 , @aaron.ballman wrote: > Do you have some performance measurement numbers for how much benefit we get > from the changes? Not really. The PR that changed the scope of trailing return type had a 0.35% regres

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

cor3ntin updated this revision to Diff 520356. cor3ntin added a comment. Formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150036/new/ https://reviews.llvm.org/D150036 Files: clang/docs/ReleaseNotes.rst clang/lib/AST/ExprConstant.cpp

[PATCH] D150036: [Clang] Correctly handle allocation in template arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9857caf9d14f: [Clang] Correctly handle allocation in template arguments (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D150122: [Clang] Fix status of P0960

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. P0960R3 and P1975R0 were marked not implemented because of #61145, This issue has been fixed and backported to LLVM 16, t

[PATCH] D150122: [Clang] Fix status of P0960

cor3ntin added subscribers: erichkeane, aaron.ballman. cor3ntin added a comment. @aaron.ballman @erichkeane I'll merge that later today unless you see a reason not to. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150122/new/ https://reviews.llvm.

[PATCH] D150122: [Clang] Fix status of P0960

cor3ntin added a comment. In D150122#4326935 , @erichkeane wrote: > I've got no problems with this. I'm a little suspicious of marking this done > in clang-16 if this was done only at the end of the branch though? And do we > know there is going to b

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

cor3ntin added a comment. In D150038#4326576 , @aaron.ballman wrote: > In D150038#4326554 , @cor3ntin > wrote: > >> In D150038#4326549 , >> @aaron.ballman wrote: >> >>>

[PATCH] D150038: [Clang] Improve compile times when forming a DeclRef outside of a capturing scope.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa7579b25df78: [Clang] Improve compile times when forming a DeclRef outside of a capturing… (authored by cor3ntin). Changed prior to commit: https:

[PATCH] D150450: Add C++26 compile flags.

cor3ntin added a comment. Similar PR here https://reviews.llvm.org/D149875 Comment at: clang/docs/ReleaseNotes.rst:114 +^ +- Compiler flags -std=c++2c and -std=gnu++2c have been added for experimental C++26 implementation work. + This shoul

[PATCH] D150450: Add C++26 compile flags.

cor3ntin added inline comments. Comment at: clang/lib/Frontend/InitPreprocessor.cpp:456 + // FIXME: Use correct value for C++26. + Builder.defineMacro("__cplusplus", "202102L"); +// FIXME: Use correct value for C++23, and update C++26 to be 'one more'. -

[PATCH] D150450: Add C++26 compile flags.

cor3ntin accepted this revision. cor3ntin added a comment. LGTM. I'm looking forward to start implementing upcoming proposals CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150450/new/ https://reviews.llvm.org/D150450 ___ cfe-commits mailing l

[PATCH] D150450: Add C++26 compile flags.

cor3ntin added inline comments. Comment at: clang/www/cxx_status.html:1568 +C++2c implementation status + h-vetinari wrote: > The longer this page gets, the more I feel it should be sorted in reverse > chronological order of the standard versions. It's bothers

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. I think this is starting to look good, My biggest question is the remaining fixme, how much work would it be to do in this PR? Comment at: clang/include/clang/Sema/TemplateDeduction.h:237 + // C++ [over.match.class.deduct]p5.2: + // During templ

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. @aaron.ballman this won;t get approve by core un In D149276#4302700 , @aaron.ballman wrote: > The changes generally LGTM, but: > >> in a way consistent with the proposed resolution to CWG1223. > > What are the chances that CWG

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 522180. cor3ntin added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Parser.h

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. In D139586#4342868 , @rZhBoYao wrote: > In D139586#4324857 , @cor3ntin > wrote: > >> @rZhBoYao are you still working on this? Thanks! > > No. Sorry that I don't have the capacity to work

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

This revision was automatically updated to reflect the committed changes. Closed by commit rGef47318ec361: [Clang] Fix parsing of `(auto(x))`. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin reopened this revision. cor3ntin added a comment. This revision is now accepted and ready to land. @kadircet thanks for letting me know, I'm investigating Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 522979. cor3ntin added a comment. - When tentative parse an abstract declarator whithout auto specifier, do not classify it as a declaration based on the presence of arrow - When tentative parse a declarion vs member access, do not annotate the token after

[PATCH] D150843: [clang][Diagnostics] Refactor printableTextForNextCharacter

cor3ntin added a comment. This generally looks good to me but i have a couple remarks Comment at: clang/lib/Frontend/TextDiagnostic.cpp:124-128 + if (CharSize == 1 && llvm::isLegalUTF8Sequence(Begin, End) && + llvm::sys::locale::isPrint(*Begin)) { +++(*I); +return

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 523729. cor3ntin added a comment. Address Aaron's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaLambda.cpp:1368 + // C++: expr.prim.lambda.capture p5: + // If an identifier in a capture appears as the declarator-id of a parameter Comment at: clang/test/CXX/expr/expr.prim

[PATCH] D148712: [clang] Diagnose shadowing of lambda's template parameter by a capture

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. Thanks, this looks good to me now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148712/new/ https://reviews.llvm.org/D148712 _

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

cor3ntin updated this revision to Diff 516387. cor3ntin added a comment. Address comments, implement Aaron's clever solution, Rebase and add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142401/new/ https://reviews.llvm.org/D142401 Fi

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

cor3ntin updated this revision to Diff 516388. cor3ntin added a comment. Remove duplicated test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142401/new/ https://reviews.llvm.org/D142401 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaEx

[PATCH] D149098: [Clang] Add tests and mark as implemented WG14 N2728 (char16_t & char32_t string literals shall be UTF-16 & UTF-32)

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. LGTM (modulo nitpicking comment) Comment at: clang/test/Lexer/char-literal.cpp:49 +#ifndef __cplusplus +// expected-error@-2 {{universal character name refers to a contro

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

cor3ntin added a comment. I'm afraid I have been bitten by this very issue several more than once. I can only assume I'm not the only one. so this looks like a nice improvement. There are only a few changes in libc++ so it seems fairly low noise. Did you try to compile llvm with it? I'd be curio

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, jplehr, sstefan1. Herald added a project: clang. Allow auto(x) to appear in a parenthesis expression. The pattern (au

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517248. cor3ntin added a comment. Fix whitespace only changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/cl

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517488. cor3ntin marked 8 inline comments as done. cor3ntin added a comment. - Fix tests - Address aaron's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 F

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517491. cor3ntin added a comment. Do not parse auto( as an expression before C++23 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.r

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added inline comments. Comment at: clang/lib/Parse/ParseTentative.cpp:237 ConsumeAnnotationToken(); -if (Tok.is(tok::identifier)) +if (Tok.isOneOf(tok::identifier, tok::kw_auto)) ConsumeToken(); aaron.ballman wrote: > This smells a

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin updated this revision to Diff 517536. cor3ntin added a comment. Fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276 Files: clang/docs/ReleaseNotes.rst clang/include/clang/Parse/Parser.h

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. In D149276#4302700 , @aaron.ballman wrote: > The changes generally LGTM, but: > >> in a way consistent with the proposed resolution to CWG1223. > > What are the chances that CWG changes their mind and picks a different > direct

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a subscriber: rsmith. cor3ntin added a comment. @rsmith @hubert.reinterpretcast do you see any reason not to go ahead with this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149276/new/ https://reviews.llvm.org/D149276

[PATCH] D149276: [Clang] Fix parsing of `(auto(x))`.

cor3ntin added a comment. In D149276#4305780 , @shafik wrote: > I see that we do have an issue but so far the examples in the tests don't > feel very natural and so I would like to understand if there is a larger > motivation here. The context is that

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

cor3ntin updated this revision to Diff 518161. cor3ntin added a comment. I don't think this is actually testable, ultimately we may run out of stack any way, the warning (when emitted) even say so. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14240

[PATCH] D142401: [Clang] Fix a crash when recursively callig a default member initializer.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG771ad1691ac3: [Clang] Fix a crash when recursively callig a default member initializer. (authored by cor3ntin). Changed prior to commit: https://r

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When constructing an array expression where the index expression was a pack expansion, we would construct an ArraySubscrip

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2b-overloaded-operator.cpp:101 + int arr[] = {1, 2, 3}; + return arr[Is...]; // expected-error 2{{type 'int[3]' does not provide a subscript operator}} +} shafik wrote: > The diagnostic is not g

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

cor3ntin updated this revision to Diff 518776. cor3ntin added a comment. Add release note Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149637/new/ https://reviews.llvm.org/D149637 Files: clang/docs/ReleaseNotes.rst clang/lib/Sema/SemaExpr.cpp

[PATCH] D149637: [Clang] Correctly expand pack in binary subscript expression.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2528f1c84588: [Clang] Correctly expand pack in binary subscript expression. (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D149013: [clang][Interp] Check pointers when accessing base class

cor3ntin added inline comments. Comment at: clang/test/AST/Interp/records.cpp:509-512 + constexpr A *a2 = &b + 1; // expected-error {{must be initialized by a constant expression}} \ +// expected-note {{cannot access base class of pointer past the e

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cor3ntin added a comment. Works for me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147717/new/ https://reviews.llvm.org/D147717 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended consstructors parameters

cor3ntin created this revision. Herald added a project: All. cor3ntin requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Fixes #63119 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D152242 Files: clang/docs/ReleaseNotes.r

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended consstructors parameters

cor3ntin updated this revision to Diff 528811. cor3ntin added a comment. Add test for default parameters Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152242/new/ https://reviews.llvm.org/D152242 Files: clang/docs/ReleaseNotes.rst clang/lib/Pa

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended constructors parameters

cor3ntin added inline comments. Comment at: clang/test/CXX/temp/temp.res/p4.cpp:182-183 + friend X::X(T::type); + friend X::X(T::type = (int)(void(*)(typename T::type))(nullptr)); // expected-error {{friend declaration specifying a default argument must be a definition}} + f

[PATCH] D152242: [Clang] Allow omitting `typename` in befriended constructors parameters

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd9be8a8a990d: [Clang] Allow omitting `typename` in befriended constructors parameters (authored by cor3ntin). Repository: rG LLVM Github Monorepo

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:12002 + + UnresolvedSet<16> Functions; + if (ImplicitCastExpr *ICE = dyn_cast(Callee)) Can `Functions` ever held more than one element here? Repository: rG LLVM Github Monorepo CHAN

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaTemplateDeduction.cpp:5022 +SourceLocation Loc) { + assert(FD->isImmediateEscalating()); + aaron.ballman wrote: > I think I'm a bit surprised to se

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin marked 9 inline comments as done. cor3ntin added inline comments. Comment at: clang/test/SemaCXX/cxx2b-consteval-propagate.cpp:8 + +namespace examples { + aaron.ballman wrote: > Fznamznon wrote: > > cor3ntin wrote: > > > Fznamznon wrote: > > > > These ex

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin updated this revision to Diff 528919. cor3ntin added a comment. Address Aaron's feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094 Files: clang/docs/ReleaseNotes.rst clang/include/clang

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin updated this revision to Diff 528961. cor3ntin added a comment. Track immediate escalating construct expressions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https://reviews.llvm.org/D151094 Files: clang/docs/ReleaseNotes.r

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

cor3ntin added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:17980-17987 + if (auto *Call = dyn_cast(E->IgnoreImplicit()); + Call && Call->getCallee()) { +if (auto *DeclRef = +dyn_cast(Call->getCallee()->IgnoreImplicit())) + DeclRef->setIsImm

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

cor3ntin added inline comments. Comment at: clang/test/CXX/drs/dr6xx.cpp:707-708 // FIXME: The following examples demonstrate that we might be accepting the // above cases for the wrong reason. aaron.ballman wrote: > Is this fixme still accurate? Should

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

cor3ntin updated this revision to Diff 529045. cor3ntin marked 2 inline comments as done. cor3ntin added a comment. Address Aaron's comments. Initially these changes were tracked in https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p0929r2.html I fixed the specific github issue but more w

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added a comment. I think this looks good but I'll let @aaron.ballman do the final approval. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139837/new/ https://reviews.llvm.org/D139837 ___ cfe-com

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

cor3ntin updated this revision to Diff 529186. cor3ntin added a comment. Add tests for missing semi colons Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152009/new/ https://reviews.llvm.org/D152009 Files: clang/docs/ReleaseNotes.rst clang/lib/

[PATCH] D152009: [clang] Fix assertion while parsing an invalid for loop

This revision was automatically updated to reflect the committed changes. Closed by commit rG22e95e0bf375: [clang] Fix assertion while parsing an invalid for loop (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D152009?vs=529186&id=529212#toc Repository: rG LLVM Git

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:11988 - return getDerived().RebuildCXXOperatorCallExpr(E->getOperator(), - E->getOperatorLoc(), - Callee.g

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin added inline comments. Comment at: clang/lib/Sema/TreeTransform.h:15216-15217 - if (Op == OO_Subscript) { -SourceLocation LBrace; -SourceLocation RBrace; - -if (DeclRefExpr *DRE = dyn_cast(Callee)) { - DeclarationNameLoc NameLoc = DRE->getNameInfo().g

[PATCH] D151553: [clang] Fix consteval operators in template contexts

cor3ntin accepted this revision. cor3ntin added a comment. This revision is now accepted and ready to land. I think this looks good! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151553/new/ https://reviews.llvm.org/D151553

[PATCH] D152002: [clang][wip] Better handling of dependent lambda. This is an attempt to fix GH62916. However, it breaks GH57960 I seem unable to find something that works for both issues.

cor3ntin abandoned this revision. cor3ntin added a subscriber: Eric. cor3ntin added a comment. @eric suggested we should not try to transform the body of the lambda at all, which may be a better approach. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D152285: Add support for the NO_COLOR environment variable

cor3ntin added a comment. As I told Aaron, someone who disables color for accessibility reason is likely to have both variables(NO_COLOR/CLICOLOR) set. So supporting one is enough. Picking the one that is the simplest and most popular makes perfect sense. This is great. Repository: rG LLVM G

[PATCH] D146924: [clang] Add support for dollar sign in ud_suffix of numeric constants

cor3ntin added a comment. In D146924#4224237 , @tahonermann wrote: >> It's not in the range of any of the universal-character-names. > > I assume you mean that it isn't included in the range of UCNs that are > allowed in identifiers. If so, that is corr

[PATCH] D152285: Add support for the NO_COLOR environment variable

cor3ntin added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:2348 + llvm::sys::Process::GetEnv("NO_COLOR"); + NoColor && !NoColor->empty() && NoColor->at(0) != '\0') { +// If the user set the NO_COLOR environment variable, we'll honor th

[PATCH] D152285: Add support for the NO_COLOR environment variable

cor3ntin accepted this revision. cor3ntin added a comment. LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152285/new/ https://reviews.llvm.org/D152285 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[PATCH] D139586: [Clang][C++23] Lifetime extension in range-based for loops

cor3ntin added a comment. FYI, I'm not actively working on this, I did mess around with it a bit https://github.com/cor3ntin/llvm-project/commit/478ff7f1aa7a4046fa8b293dfb86489b930a but I'm extremely unfamiliar with that part of clang and i have no clue how to write tests. Feel free to take

[PATCH] D151094: [clang] Implement P2564 "consteval must propagate up"

This revision was automatically updated to reflect the committed changes. Closed by commit rG467688527017: [clang] Implement P2564 "consteval must propagate up" (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151094/new/ https:

[PATCH] D152096: [Clang] Check for abstract parameters only when functions are defined.

This revision was automatically updated to reflect the committed changes. Closed by commit rG6dc1636815cb: [Clang] Check for abstract parameters only when functions are defined. (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D152096?vs=529045&id=529408#toc Repository

[PATCH] D139837: [Clang] Implements CTAD for aggregates P1816R0 and P2082R1

cor3ntin added inline comments. Comment at: clang/include/clang/AST/DeclBase.h:1686 -/// [C++17] Only used by CXXDeductionGuideDecl. Indicates that -/// the Deduction Guide is the implicitly generated 'copy -/// deduction candidate' (is used during overload resoluti

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

cor3ntin updated this revision to Diff 479919. cor3ntin added a comment. Apply changes suggested in D138901 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139212/new/ https://reviews.llvm.org/D139212 Files: clan

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

cor3ntin added a comment. In D139212#3969179 , @h-vetinari wrote: > I've had a small nit/suggestion post-merge of > https://reviews.llvm.org/D138901; in case you feel it's worth picking up if > you're touching that file already. Nice simplification, t

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin updated this revision to Diff 480062. cor3ntin added a comment. Add comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 Files: clang/docs/ReleaseNotes.rst clang/lib/Lex/Lexer.cpp clang/

[PATCH] D139212: [Clang] make_cxx_dr_status download the issue list automatically

This revision was automatically updated to reflect the committed changes. Closed by commit rG2fbe3f9e7941: [Clang] make_cxx_dr_status download the issue list automatically (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139212/n

[PATCH] D139429: [clang] Add test for CWG418

cor3ntin added a comment. I'm not sure how I feel about this. Clang does not, implement correctly that paragraph at all, so I think the best course here is to create an issue on the llvm github and mark the dr resolved as part of fixing the bug in clang. The fact the previous wording was unclear

[PATCH] D139436: [C2x] Relaxing requirements for va_start

cor3ntin added inline comments. Comment at: clang/lib/Headers/stdarg.h:30 +/* C2x does not require the second parameter for va_start. */ +#define va_start(ap, ...) __builtin_va_start(ap, 0) +#else Yeah, i really think there should be some king of diagnostic here.

[PATCH] D139436: [C2x] Relaxing requirements for va_start

cor3ntin added inline comments. Comment at: clang/lib/Headers/stdarg.h:30 +/* C2x does not require the second parameter for va_start. */ +#define va_start(ap, ...) __builtin_va_start(ap, 0) +#else aaron.ballman wrote: > cor3ntin wrote: > > Yeah, i really think th

[PATCH] D136554: Implement CWG2631

This revision was automatically updated to reflect the committed changes. Closed by commit rGa96a6ed83230: Implement CWG2631 (authored by cor3ntin). Changed prior to commit: https://reviews.llvm.org/D136554?vs=479395&id=481194#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. @tahonermann Do you want to take a look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138861/new/ https://reviews.llvm.org/D138861 ___ cfe-commits mailing list cfe-comm

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. @tahonermann Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137051/new/ https://reviews.llvm.org/D137051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D136554: Implement CWG2631

cor3ntin reopened this revision. cor3ntin added a comment. This revision is now accepted and ready to land. In D136554#3982161 , @aeubanks wrote: > the following now produces a link error: > > $ cat /tmp/a.cc > #include > #include > > struct

[PATCH] D136554: Implement CWG2631

cor3ntin updated this revision to Diff 481411. cor3ntin added a comment. Correctly visit array filer when marking default member init as ODR-used Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136554/new/ https://reviews.llvm.org/D136554 Files:

[PATCH] D138861: [Clang] Implement CWG2640 Allow more characters in an n-char sequence

cor3ntin added a comment. Thanks Tom, I replied to your comments Comment at: clang/lib/Lex/Lexer.cpp:3378-3379 - if (LooseMatch) + // If no diagnostic has been emitted yet we do not want to recover here + // to make sure this function will be called again and a diagnostic

[PATCH] D137051: [Clang] Allow additional mathematical symbols in identifiers.

cor3ntin added a comment. In D137051#3982833 , @tahonermann wrote: > Oh, also, the review summary mentions "UAX32" (twice); those should be > "UAX31". Just please make sure the commit message is correct. > > Also, I'm terribly sorry for being so slow to

[PATCH] D136554: Implement CWG2631

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc9a6713b4788: Implement CWG2631 (authored by cor3ntin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

<    10   11   12   13   14   15   16   17   >