[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65431: >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 6 Sep 2023 09:55:20 +0800 Subject: [PATCH 1/2] [clang-tidy][misc-include-cleaner]Avoid fixes insert same

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65431: >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 6 Sep 2023 09:55:20 +0800 Subject: [PATCH 1/2] [clang-tidy][misc-include-cleaner]Avoid fixes insert same

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65431: >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 6 Sep 2023 09:55:20 +0800 Subject: [PATCH 1/2] [clang-tidy][misc-include-cleaner]Avoid fixes insert same

[clang] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65431: >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 6 Sep 2023 09:55:20 +0800 Subject: [PATCH 1/2] [clang-tidy][misc-include-cleaner]Avoid fixes insert same

[libunwind] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65431: >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 6 Sep 2023 09:55:20 +0800 Subject: [PATCH 1/2] [clang-tidy][misc-include-cleaner]Avoid fixes insert same

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65431: >From 2b727285edb91a4a88add118745eabc08da9c6fd Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Wed, 6 Sep 2023 09:55:20 +0800 Subject: [PATCH 1/3] [clang-tidy][misc-include-cleaner]Avoid fixes insert same

[clang-tools-extra] [clang-tidy][misc-include-cleaner]Avoid to insert same include header multiple times (PR #65431)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/65431 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

2023-09-06 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: explicit bit usage will not case false positive without this patch. Should we consider case of operator overloading? ```cpp bool explicitBitUsage1(EStatus value) { return (value & SUCCESS); } bool explicitBitUsage2(EStatus value) { return (value | SUCCESS); } ``` https:/

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/65558: Fixed #65055 >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH] [clang-tidy][modernize-use-using]fix function p

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
@@ -314,3 +314,10 @@ typedef struct { struct { int a; struct { struct { int b; } c; int d; } e; } f; typedef struct { struct { int a; } b; union { int c; float d; struct { int e; }; }; struct { double f; } g; } PR50990_siblings; // CHECK-MESSAGES: :[[@LINE-1]]:1: warning: use

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65558: >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH 1/2] [clang-tidy][modernize-use-using]fix function pointer typ

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65558: >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH 1/2] [clang-tidy][modernize-use-using]fix function pointer typ

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 review_requested https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-07 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > This is weird issues because it always happen when two typedefs are one after > other. ```c++ typedef void (*ISSUE_65055_1)(int); typedef bool (*ISSUE_65055_2)(int); typedef void VOID; ``` The typedef matcher will match following position: ``` TypedefDecl 0x1610ba960 col:

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/65558: >From f25a855ac2d3ec4b89f55a08e415596b3b65f142 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 7 Sep 2023 10:14:28 +0800 Subject: [PATCH 1/3] [clang-tidy][modernize-use-using]fix function pointer typ

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 resolved https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][modernize-use-using]fix function pointer typedef correctly (PR #65558)

2023-09-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/65558 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

2023-09-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/65498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

2023-09-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/65498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Exclude bitwise operators in bugprone-non-zero-enum-to-bool-conversion (PR #65498)

2023-09-07 Thread Congcong Cai via cfe-commits
@@ -49,6 +49,9 @@ bool NonZeroEnumToBoolConversionCheck::isLanguageVersionSupported( } void NonZeroEnumToBoolConversionCheck::registerMatchers(MatchFinder *Finder) { + auto ExcludedOperators = binaryOperation(hasAnyOperatorName( + "|", "&", "^", "<<", ">>", "~", "|=", "

[clang] e417f02 - [SemaCXX]use CorrectDelayedTyposInExpr in ActOnCXXFoldExpr only when Diag

2023-03-14 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-03-15T01:08:41+08:00 New Revision: e417f02b5159c13f011335636faaf8c6847b627f URL: https://github.com/llvm/llvm-project/commit/e417f02b5159c13f011335636faaf8c6847b627f DIFF: https://github.com/llvm/llvm-project/commit/e417f02b5159c13f011335636faaf8c6847b627f.diff

[clang-tools-extra] edd6a33 - [clang-tidy] support unscoped enumerations in readability-static-accessed-through-instance

2023-04-03 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-04-03T12:58:35+02:00 New Revision: edd6a33984eeb57bd4e8d3459878cc7a66825389 URL: https://github.com/llvm/llvm-project/commit/edd6a33984eeb57bd4e8d3459878cc7a66825389 DIFF: https://github.com/llvm/llvm-project/commit/edd6a33984eeb57bd4e8d3459878cc7a66825389.diff

[clang-tools-extra] 92910a5 - [clang-tidy] fix concat-nest-namespace fix hint remove the macro

2023-04-07 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-04-08T06:24:26+02:00 New Revision: 92910a51b9043550cec6c9e63a5b92a15d42c665 URL: https://github.com/llvm/llvm-project/commit/92910a51b9043550cec6c9e63a5b92a15d42c665 DIFF: https://github.com/llvm/llvm-project/commit/92910a51b9043550cec6c9e63a5b92a15d42c665.diff

[clang-tools-extra] 0f9b71d - [clang-tidy] fix hint use correct range to replace last NamespaceDecl

2023-04-08 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-04-08T21:03:59+02:00 New Revision: 0f9b71d11b91d6fb7fa678a12327bafbc43605b5 URL: https://github.com/llvm/llvm-project/commit/0f9b71d11b91d6fb7fa678a12327bafbc43605b5 DIFF: https://github.com/llvm/llvm-project/commit/0f9b71d11b91d6fb7fa678a12327bafbc43605b5.diff

[clang-tools-extra] bdf7fd8 - [clang-tidy] fix false positve for namespace with attrs in modernize-concat-nested-namespaces

2023-04-09 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-04-09T16:23:29+02:00 New Revision: bdf7fd8297bcbcddc9c184a40c954c1f1b0b8340 URL: https://github.com/llvm/llvm-project/commit/bdf7fd8297bcbcddc9c184a40c954c1f1b0b8340 DIFF: https://github.com/llvm/llvm-project/commit/bdf7fd8297bcbcddc9c184a40c954c1f1b0b8340.diff

[clang-tools-extra] 72777dc - [clang-tidy] avoid colon in namespace cause false positve

2023-04-10 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-04-10T13:42:33+02:00 New Revision: 72777dc000ac432a99cf5f591553127432bd0365 URL: https://github.com/llvm/llvm-project/commit/72777dc000ac432a99cf5f591553127432bd0365 DIFF: https://github.com/llvm/llvm-project/commit/72777dc000ac432a99cf5f591553127432bd0365.diff

[clang-tools-extra] 32aaacc - [clang-tidy] support nested inline namespace in c++20 for modernize-concat-nested-namespaces

2023-04-11 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-04-11T21:28:11+02:00 New Revision: 32aaacc609e7a0523d498b244e081ac6f3df532b URL: https://github.com/llvm/llvm-project/commit/32aaacc609e7a0523d498b244e081ac6f3df532b DIFF: https://github.com/llvm/llvm-project/commit/32aaacc609e7a0523d498b244e081ac6f3df532b.diff

[clang] ef107af - [Sema] avoid merge error type

2023-05-20 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-05-20T11:18:42+02:00 New Revision: ef107afd48a920e74167874a55e2afb6decb52c7 URL: https://github.com/llvm/llvm-project/commit/ef107afd48a920e74167874a55e2afb6decb52c7 DIFF: https://github.com/llvm/llvm-project/commit/ef107afd48a920e74167874a55e2afb6decb52c7.diff

[clang] e8cc0d3 - [NFC] improment release note word for #62447

2023-05-20 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-05-20T23:29:20+02:00 New Revision: e8cc0d310c4060b605dc293bff5d2bca95ff528b URL: https://github.com/llvm/llvm-project/commit/e8cc0d310c4060b605dc293bff5d2bca95ff528b DIFF: https://github.com/llvm/llvm-project/commit/e8cc0d310c4060b605dc293bff5d2bca95ff528b.diff

[clang] 8b1727f - [NFC] remove duplicated dash in release note for #62447

2023-05-21 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-05-21T11:26:16+02:00 New Revision: 8b1727f8d9104df5ced4bdfdc065dea85ff84baf URL: https://github.com/llvm/llvm-project/commit/8b1727f8d9104df5ced4bdfdc065dea85ff84baf DIFF: https://github.com/llvm/llvm-project/commit/8b1727f8d9104df5ced4bdfdc065dea85ff84baf.diff

[clang] eb5902f - [Sema] `setInvalidDecl` for error deduction declaration

2023-05-23 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-05-23T09:07:05+02:00 New Revision: eb5902ffc97163338bab95d2fd84a953ee76e96f URL: https://github.com/llvm/llvm-project/commit/eb5902ffc97163338bab95d2fd84a953ee76e96f DIFF: https://github.com/llvm/llvm-project/commit/eb5902ffc97163338bab95d2fd84a953ee76e96f.diff

[clang] ca96836 - [Sema] `setInvalidDecl` for error deduction declaration

2023-05-23 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-05-23T22:14:12+02:00 New Revision: ca9683651e52196f590bc244d9c506ed39fe1d92 URL: https://github.com/llvm/llvm-project/commit/ca9683651e52196f590bc244d9c506ed39fe1d92 DIFF: https://github.com/llvm/llvm-project/commit/ca9683651e52196f590bc244d9c506ed39fe1d92.diff

[clang] 5df593a - [Sema] cast to CXXRecordDecl correctly when diag a default comparison method

2023-05-25 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-05-25T22:07:50+02:00 New Revision: 5df593a354714e081ac441a74f89ad2a56334e28 URL: https://github.com/llvm/llvm-project/commit/5df593a354714e081ac441a74f89ad2a56334e28 DIFF: https://github.com/llvm/llvm-project/commit/5df593a354714e081ac441a74f89ad2a56334e28.diff

[clang] 3333e12 - [clang] add diagnose when member function contains invalid default argument

2023-04-25 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-04-25T23:08:30+02:00 New Revision: e12753ed9c27fc25c73858a990081b0ceb11 URL: https://github.com/llvm/llvm-project/commit/e12753ed9c27fc25c73858a990081b0ceb11 DIFF: https://github.com/llvm/llvm-project/commit/e12753ed9c27fc25c73858a990081b0ceb11.diff

[clang] 921b45a - [Sema]Select correct lexical context during template instantiate

2023-04-26 Thread Congcong Cai via cfe-commits
Author: Congcong Cai Date: 2023-04-27T00:29:13+02:00 New Revision: 921b45a855f09afe99ea9c0c173794ee4ccd5872 URL: https://github.com/llvm/llvm-project/commit/921b45a855f09afe99ea9c0c173794ee4ccd5872 DIFF: https://github.com/llvm/llvm-project/commit/921b45a855f09afe99ea9c0c173794ee4ccd5872.diff

[clang-tools-extra] [clang-tidy] fix incorrect hint for InitListExpr in prefer-member-initializer (PR #81560)

2024-02-14 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/81560 >From 35dba54b1d6d158118c34d0f1bd8038b64c9bda4 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 13 Feb 2024 09:11:06 +0800 Subject: [PATCH 1/2] [clang-tidy] fix incorrect hint for InitListExpr in prefe

[clang-tools-extra] [clang-tidy] fix incorrect hint for InitListExpr in prefer-member-initializer (PR #81560)

2024-02-15 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/81560 >From 35dba54b1d6d158118c34d0f1bd8038b64c9bda4 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Tue, 13 Feb 2024 09:11:06 +0800 Subject: [PATCH 1/3] [clang-tidy] fix incorrect hint for InitListExpr in prefe

[clang-tools-extra] [clang-tidy] fix incorrect hint for InitListExpr in prefer-member-initializer (PR #81560)

2024-02-15 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/81560 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][readability-identifier-naming] Resolve symlinks for checking style for file (PR #81985)

2024-02-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/81985 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fixes to readability-implicit-bool-conversion (PR #72050)

2024-02-17 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/72050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add fix-its to `avoid-return-with-void-value` check (PR #81420)

2024-02-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/81420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add fix-its to `avoid-return-with-void-value` check (PR #81420)

2024-02-18 Thread Congcong Cai via cfe-commits
@@ -42,10 +43,28 @@ void AvoidReturnWithVoidValueCheck::check( const auto *VoidReturn = Result.Nodes.getNodeAs("void_return"); if (IgnoreMacros && VoidReturn->getBeginLoc().isMacroID()) return; - if (!StrictMode && !Result.Nodes.getNodeAs("compound_parent")) + const a

[clang-tools-extra] [clang-tidy] Add fix-its to `avoid-return-with-void-value` check (PR #81420)

2024-02-18 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/81420 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-29 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/97080 >From b49737505ad3ad84e977787daf141b98fe3e6607 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 29 Jun 2024 00:24:30 +0800 Subject: [PATCH 1/2] [WebAssembly] support getVT from wasm externref and funcr

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-29 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/97080 >From b49737505ad3ad84e977787daf141b98fe3e6607 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Sat, 29 Jun 2024 00:24:30 +0800 Subject: [PATCH 1/2] [WebAssembly] support getVT from wasm externref and funcr

[clang] [llvm] [WebAssembly] support getVT from `externref` and `funcref` (PR #97080)

2024-06-29 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > What happens if you compile a file that really vectorizes reference types? > The attached test doesn't seem to actually end up getting vectorized after > all. Can you add a test that get vectorized? Is it possible to vectorize external reference types? I don't think there

[clang-tools-extra] [clang-tidy] Do not warn on const variables in misc-use-internal-linkage (PR #97969)

2024-07-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request. There are some other limitation for const variable to be internal linkage. Please follow standard to exclude this case https://eel.is/c++draft/basic.link#3.2. https://github.com/llvm/llvm-project/pull/97969 __

[clang-tools-extra] [clang-tidy] Do not warn on const variables in misc-use-internal-linkage (PR #97969)

2024-07-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. re-think about this case. LGTM https://github.com/llvm/llvm-project/pull/97969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang-tools-extra] [clang-tidy] In C++17, callee is guaranteed to be sequenced before arguments. (PR #93623)

2024-07-07 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: Normally PR can be merged if someone approved PR. You can merge it by yourself. If you don't have access, I'm glad to help you. https://github.com/llvm/llvm-project/pull/93623 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang-tools-extra] [clang-tidy] fix misc-unconventional-assign-operator false positive for deducing this (PR #107409)

2024-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/107409 Fixes: #107119 When meeting c++23 deducing this, we should skip the first parameter >From b845ad06929470d9b20ce9170c49939ebe8a901c Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 5 Sep 2024 22:21:57

[clang-tools-extra] [clang-tidy][NFC] remove autosar link in documents (PR #107412)

2024-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/107412 None >From e88b1b916b5babf2a55ad3c14d2e4ba30d110014 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 5 Sep 2024 23:05:42 +0800 Subject: [PATCH] [clang-tidy][NFC] remove autosar link in documents ---

[clang-tools-extra] [clang-tidy][NFC] remove autosar link in documents (PR #107412)

2024-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/107412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] remove autosar link in documents (PR #107412)

2024-09-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/107412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] fix misc-unconventional-assign-operator false positive for deducing this (PR #107409)

2024-09-06 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/107409 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/107867 use ::std::endl as default message when matched expr does not have valid source text >From 31b01c0cd3fc809e5451853b820d021dd43d16c7 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 22:32:

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Congcong Cai via cfe-commits
@@ -511,7 +511,7 @@ def has_auto_fix(check_name: str) -> str: return "" -def process_doc(doc_file: Tuple[str, str]) -> Tuple[str, Optional[re.Match[str]]]: +def process_doc(doc_file: Tuple[str, str]) -> Tuple[str, Optional[Any]]: HerrCai0907

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 deleted https://github.com/llvm/llvm-project/pull/107850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/107867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-09 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: I think the reason is python3.8 don't support re.Match. see #107871 https://github.com/llvm/llvm-project/pull/107850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/107871 Fixes: #107846 >From ffc8fb76d35d4cc7d90efeb0346259060fcaa218 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 23:04:10 +0800 Subject: [PATCH] [clang-tidy][NFC] fix add_new_check python3.8

[clang-tools-extra] [NFC][clang-tidy] fix tests of deleted functions for missing-std-forward (PR #106861)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/106861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-09 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: actually both are fine. since 3.8 will stop maintain soon. It just a temp solution and may be alive only in half year. https://github.com/llvm/llvm-project/pull/107871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
@@ -225,3 +225,14 @@ void bad_custom_stream() { // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl] // CHECK-FIXES: logger << '\n'; } + +namespace gh107859 { + +#define ENDL std::endl; + +void bad_macr

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
@@ -225,3 +225,14 @@ void bad_custom_stream() { // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl] // CHECK-FIXES: logger << '\n'; } + +namespace gh107859 { + +#define ENDL std::endl; + +void bad_macr

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/107867 >From 31b01c0cd3fc809e5451853b820d021dd43d16c7 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 22:32:48 +0800 Subject: [PATCH 1/2] [clang-tidy] add default error message for performance-av

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/107867 >From 31b01c0cd3fc809e5451853b820d021dd43d16c7 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 22:32:48 +0800 Subject: [PATCH 1/3] [clang-tidy] add default error message for performance-av

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-09 Thread Congcong Cai via cfe-commits
@@ -46,14 +46,13 @@ void AvoidEndlCheck::check(const MatchFinder::MatchResult &Result) { // Handle the more common streaming '... << std::endl' case const CharSourceRange TokenRange = CharSourceRange::getTokenRange(Expression->getSourceRange()); -const Stri

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-10 Thread Congcong Cai via cfe-commits
@@ -225,3 +225,14 @@ void bad_custom_stream() { // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: do not use 'std::endl' with streams; use '\n' instead [performance-avoid-endl] // CHECK-FIXES: logger << '\n'; } + +namespace gh107859 { + +#define ENDL std::endl; + +void bad_macr

[clang-tools-extra] [clang-tidy] Create bugprone-bit-cast-pointers check (PR #108083)

2024-09-10 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 commented: Should we forbidden bit cast pointer to number and number to pointer? or we should only forbidden bit cast pointer to pointer. https://github.com/llvm/llvm-project/pull/108083 ___ cfe-commits mailing list cfe-

[clang-tools-extra] [clang-tidy] Fix modernize-use-std-format lit test signature (PR #102759)

2024-08-10 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/102759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix modernize-use-std-format lit test signature (PR #102759)

2024-08-11 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/102759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 requested changes to this pull request. Is it possible to check other enabled check? If not, I would like add an option to control the way to fix instead of change the behavior directly. https://github.com/llvm/llvm-project/pull/102831

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/102831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] use upper case letters for bool conversion suffix (PR #102831)

2024-08-14 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/102831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] hicpp-ignored-remove-result ignore functions with same prefixes as the target (PR #87587)

2024-04-04 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 closed https://github.com/llvm/llvm-project/pull/87587 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix readability-duplicate-include for includes with macro (PR #87433)

2024-04-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/87433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add fix-its to `avoid-return-with-void-value` check (PR #81420)

2024-04-06 Thread Congcong Cai via cfe-commits
Danny =?utf-8?q?M=C3=B6sch?= , Danny =?utf-8?q?M=C3=B6sch?= , Danny =?utf-8?q?M=C3=B6sch?= , Danny =?utf-8?q?M=C3=B6sch?= Message-ID: In-Reply-To: https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/81420 ___

[clang] [clang analysis] ExprMutationAnalyzer support recursive forwarding reference (PR #87954)

2024-04-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/87954 Partialy fixes: #60895 >From 19f66851204547232d586288fba79d8770837350 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 8 Apr 2024 09:20:58 +0800 Subject: [PATCH] [clang analysis] ExprMutationAnalyzer

[clang] [clang-tools-extra] [clang analysis] ExprMutationAnalyzer support recursive forwarding reference (PR #87954)

2024-04-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/87954 >From 19f66851204547232d586288fba79d8770837350 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 8 Apr 2024 09:20:58 +0800 Subject: [PATCH 1/2] [clang analysis] ExprMutationAnalyzer support recursive fo

[clang] [clang-tools-extra] [clang analysis] ExprMutationAnalyzer avoid infinite recursion for recursive forwarding reference (PR #87954)

2024-04-07 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 edited https://github.com/llvm/llvm-project/pull/87954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Ignore non-forwarded arguments if they are unnamed (PR #87832)

2024-04-07 Thread Congcong Cai via cfe-commits
Danny =?utf-8?q?M=C3=B6sch?= , Danny =?utf-8?q?M=C3=B6sch?= , Danny =?utf-8?q?M=C3=B6sch?= , Danny =?utf-8?q?M=C3=B6sch?= Message-ID: In-Reply-To: https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/87832 ___

[clang] [clang-tools-extra] [clang analysis] ExprMutationAnalyzer avoid infinite recursion for recursive forwarding reference (PR #87954)

2024-04-09 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/87954 >From 19f66851204547232d586288fba79d8770837350 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 8 Apr 2024 09:20:58 +0800 Subject: [PATCH 1/3] [clang analysis] ExprMutationAnalyzer support recursive fo

[clang-tools-extra] [clang-tidy] Simplify RenamerClangTidyCheck API (PR #88268)

2024-04-10 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/88268 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Fix crash in readability-container-size-empty (PR #94527)

2024-06-05 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/94527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] new check misc-use-internal-linkage (PR #90830)

2024-06-06 Thread Congcong Cai via cfe-commits
@@ -0,0 +1,78 @@ +//===--- UseInternalLinkageCheck.cpp - clang-tidy--===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] new check misc-use-internal-linkage (PR #90830)

2024-06-06 Thread Congcong Cai via cfe-commits
@@ -24,12 +24,28 @@ namespace { AST_MATCHER(Decl, isFirstDecl) { return Node.isFirstDecl(); } -AST_MATCHER_P(Decl, isInMainFile, FileExtensionsSet, HeaderFileExtensions) { +static bool isInMainFile(SourceLocation L, SourceManager &SM, + const FileExten

<    1   2   3   4   5   6   7   8   9   10   >