Author: courbet
Date: Wed May 16 23:46:15 2018
New Revision: 332576
URL: http://llvm.org/viewvc/llvm-project?rev=332576&view=rev
Log:
Fix rL332458: [AST] Added a helper to extract a user-friendly text of a comment.
Older gcc versions do not support raw string literals within macros.
Modified:
I should have fixed it in r332576.
On Wed, May 16, 2018 at 11:49 PM, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Also few other builders are affected:
>
> http://lab.llvm.org:8011/builders/clang-x86_64-linux-abi-test
> http://lab.llvm.org:8011/builders/clang-lld-x86_64
Author: courbet
Date: Wed May 23 00:58:41 2018
New Revision: 333066
URL: http://llvm.org/viewvc/llvm-project?rev=333066&view=rev
Log:
[clang-tidy] new cppcoreguidelines-narrowing-conversions check.
Summary:
Checks for narrowing conversions, e.g.
int i = 0;
i += 0.1;
This has what some might con
Author: courbet
Date: Wed Jan 16 00:36:23 2019
New Revision: 351308
URL: http://llvm.org/viewvc/llvm-project?rev=351308&view=rev
Log:
[clang-tidy] bugprone-string-constructor: Catch string from nullptr.
Summary: Context: https://twitter.com/willkirkby/status/1084219580799741953
Subscribers: xaza
Author: courbet
Date: Thu Nov 22 02:44:36 2018
New Revision: 347453
URL: http://llvm.org/viewvc/llvm-project?rev=347453&view=rev
Log:
[ASTMatchers] Re-generate ast matchers doc after rL346455.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
Modified: cfe/trunk/docs/LibASTMatchersRefere
Author: courbet
Date: Thu Nov 22 06:00:56 2018
New Revision: 347462
URL: http://llvm.org/viewvc/llvm-project?rev=347462&view=rev
Log:
[ASTMatchers] Add hasSideEffect() matcher.
Summary: Exposes Expr::HasSideEffects.
Reviewers: aaron.ballman
Subscribers: cfe-commits
Differential Revision: https
Author: courbet
Date: Thu Nov 22 06:26:33 2018
New Revision: 347463
URL: http://llvm.org/viewvc/llvm-project?rev=347463&view=rev
Log:
Revert rL347462 "[ASTMatchers] Add hasSideEffect() matcher."
Breaks some buildbots.
Modified:
cfe/trunk/docs/LibASTMatchersReference.html
cfe/trunk/includ
Author: courbet
Date: Mon Dec 3 23:59:57 2018
New Revision: 348239
URL: http://llvm.org/viewvc/llvm-project?rev=348239&view=rev
Log:
[WIP][Sema] Improve static_assert diagnostics for type traits.
Summary:
In our codebase, `static_assert(std::some_type_trait::value, "msg")`
(where `some_type_trai
Author: courbet
Date: Mon Dec 10 00:19:38 2018
New Revision: 348741
URL: http://llvm.org/viewvc/llvm-project?rev=348741&view=rev
Log:
[Sema] Further improvements to to static_assert diagnostics.
Summary:
We're now handling cases like `static_assert(!expr)` and
static_assert(!(expr))`.
Reviewers:
Author: courbet
Date: Mon Dec 10 00:53:17 2018
New Revision: 348742
URL: http://llvm.org/viewvc/llvm-project?rev=348742&view=rev
Log:
Revert r348741 "[Sema] Further improvements to to static_assert diagnostics."
Seems to break build bots.
Modified:
cfe/trunk/include/clang/Sema/Sema.h
cfe
Author: courbet
Date: Mon Dec 10 23:04:49 2018
New Revision: 348830
URL: http://llvm.org/viewvc/llvm-project?rev=348830&view=rev
Log:
[Sema]improve static_assert(!expr)
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
cfe/trunk/test/SemaCXX/static-assert.cpp
Modified: cfe/trunk/lib/Sema/Sem
Author: courbet
Date: Mon Dec 10 23:28:00 2018
New Revision: 348831
URL: http://llvm.org/viewvc/llvm-project?rev=348831&view=rev
Log:
Revert r348830 "[Sema]improve static_assert(!expr)"
Submitted the wrong change.
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
cfe/trunk/test/SemaCXX/stati
Author: courbet
Date: Tue Dec 11 00:39:11 2018
New Revision: 348834
URL: http://llvm.org/viewvc/llvm-project?rev=348834&view=rev
Log:
Reland r348741 "[Sema] Further improvements to to static_assert diagnostics."
Fix a dangling reference to temporary, never return nullptr.
Modified:
cfe/trunk
Author: courbet
Date: Thu Feb 28 02:33:32 2019
New Revision: 355076
URL: http://llvm.org/viewvc/llvm-project?rev=355076&view=rev
Log:
[clang-tidy] misc-string-integer-assignment: fix false positive
Summary:
using CodePoint = uint32_t;
CodePoint cp;
basic_string s;
s += cp;
See PR27723.
Reviewer
Author: courbet
Date: Thu Feb 28 05:39:01 2019
New Revision: 355089
URL: http://llvm.org/viewvc/llvm-project?rev=355089&view=rev
Log:
[clang-tidy] bugprone-string-integer-assignment: Reduce false positives.
Summary: Detect a few expressions as likely character expressions, see PR27723.
Reviewers
Author: courbet
Date: Mon Mar 25 01:18:00 2019
New Revision: 356871
URL: http://llvm.org/viewvc/llvm-project?rev=356871&view=rev
Log:
[clang-tidy] Fix more false positives for bugprone-string-integer-assignment
Summary:
And add various tests gleaned for our codebase.
See PR27723.
Reviewers: Jon
Author: courbet
Date: Thu Feb 14 04:00:34 2019
New Revision: 354023
URL: http://llvm.org/viewvc/llvm-project?rev=354023&view=rev
Log:
[Builtins] Treat `bcmp` as a builtin.
Summary:
This makes it consistent with `memcmp` and `__builtin_bcmp`.
Also see the discussion in https://reviews.llvm.org/D5
Author: courbet
Date: Mon Feb 25 05:09:02 2019
New Revision: 354780
URL: http://llvm.org/viewvc/llvm-project?rev=354780&view=rev
Log:
[clang-tidy] misc-string-integer-assignment: ignore toupper/tolower
Summary: Tis represents ~20% of false positives. See PR27723.
Reviewers: xazax.hun, alexfh
Su
Author: courbet
Date: Tue Jun 11 05:12:06 2019
New Revision: 363053
URL: http://llvm.org/viewvc/llvm-project?rev=363053&view=rev
Log:
[clang-tidy] Fix typo in bugprone-string-constructor.
s/bigger then/bigger than/
Modified:
clang-tools-extra/trunk/clang-tidy/bugprone/StringConstructorCheck.
Author: courbet
Date: Thu Dec 20 01:05:15 2018
New Revision: 349729
URL: http://llvm.org/viewvc/llvm-project?rev=349729&view=rev
Log:
[Sema] Better static assert diagnostics for expressions involving
temporaries/casts/
Summary:
Handles expressions such as:
- `std::is_const()`
- `std::is_co
Author: courbet
Date: Thu Dec 20 05:30:40 2018
New Revision: 349755
URL: http://llvm.org/viewvc/llvm-project?rev=349755&view=rev
Log:
[Sema][NFC] Add test for static_assert diagnistics with constexpr template
functions.
Modified:
cfe/trunk/test/SemaCXX/static-assert-cxx17.cpp
Modified: cfe/
Author: courbet
Date: Tue Sep 10 07:20:08 2019
New Revision: 371522
URL: http://llvm.org/viewvc/llvm-project?rev=371522&view=rev
Log:
[clang][codegen][NFC] Make test patterns more permissive.
See the discussion in:
http://lists.llvm.org/pipermail/llvm-commits/Week-of-Mon-20190909/692736.html
Mod
@@ -261,21 +262,27 @@ void
UnnecessaryCopyInitialization::registerMatchers(MatchFinder *Finder) {
this);
}
+UnnecessaryCopyInitialization::CheckContext::CheckContext(
legrosbuffle wrote:
Given that we are deriving `IssueFix`, `IsVarUnuse
@@ -290,69 +296,72 @@ void UnnecessaryCopyInitialization::check(
// instantiations where the types differ and rely on implicit conversion
would
// no longer compile if we switched to a reference.
if (differentReplacedTemplateParams(
- NewVar->getType(), construc
@@ -32,14 +32,34 @@ class UnnecessaryCopyInitialization : public ClangTidyCheck
{
void check(const ast_matchers::MatchFinder::MatchResult &Result) override;
void storeOptions(ClangTidyOptions::OptionMap &Opts) override;
+protected:
+ // A helper to manipulate the state c
https://github.com/legrosbuffle edited
https://github.com/llvm/llvm-project/pull/73921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From 851460af6526f175bc34b105a0f5f130a2f1c6b1 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH 1/3] [clang-tidy] performance-unnecessary-copy-init
Refact
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From 851460af6526f175bc34b105a0f5f130a2f1c6b1 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH 1/4] [clang-tidy] performance-unnecessary-copy-init
Refact
@@ -261,21 +262,27 @@ void
UnnecessaryCopyInitialization::registerMatchers(MatchFinder *Finder) {
this);
}
+UnnecessaryCopyInitialization::CheckContext::CheckContext(
legrosbuffle wrote:
I think it's a simple matter of preference, I thin
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From 851460af6526f175bc34b105a0f5f130a2f1c6b1 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH 1/5] [clang-tidy] performance-unnecessary-copy-init
Refact
@@ -289,74 +297,72 @@ void UnnecessaryCopyInitialization::check(
// instantiations where the types differ and rely on implicit conversion
would
// no longer compile if we switched to a reference.
if (differentReplacedTemplateParams(
- NewVar->getType(), construc
@@ -263,19 +264,26 @@ void
UnnecessaryCopyInitialization::registerMatchers(MatchFinder *Finder) {
void UnnecessaryCopyInitialization::check(
const MatchFinder::MatchResult &Result) {
- const auto *NewVar = Result.Nodes.getNodeAs("newVarDecl");
+ const auto &NewVar = *Re
legrosbuffle wrote:
Thanks
https://github.com/llvm/llvm-project/pull/73921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/73921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/73921
... so that derived checks can implement custom behaviour. Does nothing by
default, which makes this an NFC.
>From e251c440b42fe67dee4022d08d05e96d30d6aa02 Mon Sep 17 00:00:00 2001
From: Clement Courbet
D
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From e0d1f9741d0dba3286fd8043cf6d5c89ecc2d378 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init: Add a hook
legrosbuffle wrote:
> First what's a purpose of this change. Is there any other check that will
> need it or not ?
We have a downstream check that wants to do additional processing after this
one. We can't submit that check because it depends on a large piece of
downstream infrastructure.
>
https://github.com/legrosbuffle edited
https://github.com/llvm/llvm-project/pull/73921
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From 6050ba4784137bc20e58d553ea970e37237142ae Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init: Add a hook
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From a6bc3d7ef798f95fe6ae758e7a9502851e6d4b12 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init: Add a hook
legrosbuffle wrote:
> In theory changes that are required for "private" checks should be done by
> you on some own private fork instead of adding that "unused" code here. But
> only option I see is simply moving diagnostic to separate methods, and make
> those methods virtual.
I see, we don'
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From d729f95270aff076ff11ccb1ef12cfb6dc99a82d Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init: Add a hook
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From a072ae129b1ad928c96368a3208d35cc0705e260 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init
Refactor d
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From 0bf4d8335063c1403dc91d8fccca42e3f03bad35 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init
Refactor d
legrosbuffle wrote:
This is ready for another look. I took this as an opportunity to refactor the
duplicated parts of the code. Let me know what you think.
https://github.com/llvm/llvm-project/pull/73921
___
cfe-commits mailing list
cfe-commits@lists.
@@ -302,6 +303,20 @@ void UnnecessaryCopyInitialization::check(
}
}
+void UnnecessaryCopyInitialization::makeDiagnostic(
+DiagnosticBuilder Diagnostic, const VarDecl &Var, const Stmt &BlockStmt,
legrosbuffle wrote:
I can't really do that because each of
@@ -302,6 +303,20 @@ void UnnecessaryCopyInitialization::check(
}
}
+void UnnecessaryCopyInitialization::makeDiagnostic(
+DiagnosticBuilder Diagnostic, const VarDecl &Var, const Stmt &BlockStmt,
+const DeclStmt &Stmt, ASTContext &Context, bool IssueFix) {
+ const bo
@@ -302,6 +303,20 @@ void UnnecessaryCopyInitialization::check(
}
}
+void UnnecessaryCopyInitialization::makeDiagnostic(
+DiagnosticBuilder Diagnostic, const VarDecl &Var, const Stmt &BlockStmt,
+const DeclStmt &Stmt, ASTContext &Context, bool IssueFix) {
+ const bo
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From 851460af6526f175bc34b105a0f5f130a2f1c6b1 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH] [clang-tidy] performance-unnecessary-copy-init
Refactor d
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From 851460af6526f175bc34b105a0f5f130a2f1c6b1 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH 1/2] [clang-tidy] performance-unnecessary-copy-init
Refact
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/73921
>From 851460af6526f175bc34b105a0f5f130a2f1c6b1 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Thu, 30 Nov 2023 11:08:51 +0100
Subject: [PATCH 1/2] [clang-tidy] performance-unnecessary-copy-init
Refact
@@ -302,6 +303,20 @@ void UnnecessaryCopyInitialization::check(
}
}
+void UnnecessaryCopyInitialization::makeDiagnostic(
+DiagnosticBuilder Diagnostic, const VarDecl &Var, const Stmt &BlockStmt,
legrosbuffle wrote:
Done. I've kept the code common to the
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/77105
Right now we are not triggering on:
```
for (auto [x, y] : container) {
// const-only access
}
```
>From d5b83c7e8624ba6fde2ea9eb8c3589fe083067b8 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Fri,
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/77105
>From 7420ce9460fa0e07bc570087c39b8ee98775713a Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Fri, 5 Jan 2024 15:48:51 +0100
Subject: [PATCH] [clang-tidy] Handle C++ bindings in
`performance-for-range
@@ -234,6 +239,22 @@ void positiveOnlyAccessedFieldAsConst() {
}
}
+void positiveOnlyAccessedFieldAsConstBinding() {
+ for (auto [X, Y] : View>()) {
+// CHECK-MESSAGES: [[@LINE-1]]:13: warning: loop variable is copied but
+// CHECK-FIXES: for (const auto& [X, Y] : V
@@ -234,6 +239,22 @@ void positiveOnlyAccessedFieldAsConst() {
}
}
+void positiveOnlyAccessedFieldAsConstBinding() {
legrosbuffle wrote:
Done.
https://github.com/llvm/llvm-project/pull/77105
___
cfe-commits maili
@@ -112,9 +116,11 @@ class Counter {
PerfEvent Event;
int FileDescriptor = -1;
bool IsDummyEvent;
+ std::vector ValidationEvents;
legrosbuffle wrote:
OK, let's rename `Counter` to `CounterGroup`, but let's at least create a
(private) abstraction for an
Author: Clement Courbet
Date: 2022-08-10T09:08:05+02:00
New Revision: 5331e1229aa6d0d33b5ec9fab7c05310187746d9
URL:
https://github.com/llvm/llvm-project/commit/5331e1229aa6d0d33b5ec9fab7c05310187746d9
DIFF:
https://github.com/llvm/llvm-project/commit/5331e1229aa6d0d33b5ec9fab7c05310187746d9.dif
Author: Clement Courbet
Date: 2022-02-08T09:42:44+01:00
New Revision: 90d2291fbb4a382d8a36dfbb2bcfcc55f21b2bdc
URL:
https://github.com/llvm/llvm-project/commit/90d2291fbb4a382d8a36dfbb2bcfcc55f21b2bdc
DIFF:
https://github.com/llvm/llvm-project/commit/90d2291fbb4a382d8a36dfbb2bcfcc55f21b2bdc.dif
legrosbuffle wrote:
> LGTM, verify if some release notes shouldn't be updated.
This is very minor, I've only seen a few instances in the Google codebase, but
it was trivial enough to include.
https://github.com/llvm/llvm-project/pull/84005
___
cfe-co
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/82617
>From b2b98e9594b224f471f88924b8b060bee06de483 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Wed, 21 Feb 2024 09:15:22 +
Subject: [PATCH] [clang-tidy] Add support for determining constness of more
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/82617
>From b2b98e9594b224f471f88924b8b060bee06de483 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Wed, 21 Feb 2024 09:15:22 +
Subject: [PATCH 1/2] [clang-tidy] Add support for determining constness of
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/82617
>From b2b98e9594b224f471f88924b8b060bee06de483 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Wed, 21 Feb 2024 09:15:22 +
Subject: [PATCH 1/3] [clang-tidy] Add support for determining constness of
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/82617
>From 9b93c8bf0614e64352de8e210adf6ff316c0133e Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Mon, 19 Feb 2024 14:58:27 +
Subject: [PATCH 1/5] [llvm-exegesis][NFC] Refactor all `ValidationEvent` in
legrosbuffle wrote:
Thanks all. Comments addressed.
> Overall looking fine, but this check need to be run on bigger code-base to
> verify if there are no false positives or crashes.
Sorry, this was not very clear. By "our codebase" I meant the whole of Google
code :) This also ran on numerous
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/82617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle approved this pull request.
https://github.com/llvm/llvm-project/pull/77020
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
legrosbuffle wrote:
> I'm assuming at some point we'll want to deprecate this old option?
It's a single line of code so it probably can stay there for backwards
compatibility :)
https://github.com/llvm/llvm-project/pull/77153
___
cfe-commits mailing
https://github.com/legrosbuffle approved this pull request.
https://github.com/llvm/llvm-project/pull/77153
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/77105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -535,92 +472,178 @@ struct FPRep : public
FPRepBase {
// - Quiet Not a Number
// - Unnormal
// This can be reduced to the following logic:
-if (exp_bits() == encode(BiasedExponent::BITS_ALL_ONES()))
+if (exp_bits() == encode(BiasedExp::BITS_ALL_ONES()))
https://github.com/legrosbuffle approved this pull request.
https://github.com/llvm/llvm-project/pull/78588
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2278,7 +2303,7 @@ void
ThreadSafetyAnalyzer::runAnalysis(AnalysisDeclContext &AC) {
PostOrderCFGView::CFGBlockSet VisitedBlocks(CFGraph);
CFGBlockInfo &Initial = BlockInfo[CFGraph->getEntry().getBlockID()];
- CFGBlockInfo &Final = BlockInfo[CFGraph->getExit().getBl
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/68572
>From f3b0c9708bbf6fb0962fb82b605a7fc0b52d4a5b Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Mon, 9 Oct 2023 10:20:12 +0200
Subject: [PATCH] =?UTF-8?q?Reapply=20"[clang=20analysis][thread-safety]=20?=
@@ -1061,11 +1061,13 @@ def Most : DiagGroup<"most", [
]>;
// Thread Safety warnings
-def ThreadSafetyAttributes : DiagGroup<"thread-safety-attributes">;
-def ThreadSafetyAnalysis : DiagGroup<"thread-safety-analysis">;
-def ThreadSafetyPrecise: DiagGroup<"thread-safety-
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/68572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Clement Courbet
Date: 2021-10-29T08:41:03+02:00
New Revision: fc1b24d7360f59c8b89f1b6290fe849a6207dc44
URL:
https://github.com/llvm/llvm-project/commit/fc1b24d7360f59c8b89f1b6290fe849a6207dc44
DIFF:
https://github.com/llvm/llvm-project/commit/fc1b24d7360f59c8b89f1b6290fe849a6207dc44.dif
Author: Clement Courbet
Date: 2021-11-03T13:32:48+01:00
New Revision: 1427742750ed1fcd2ead639c4ec5178fc34c9257
URL:
https://github.com/llvm/llvm-project/commit/1427742750ed1fcd2ead639c4ec5178fc34c9257
DIFF:
https://github.com/llvm/llvm-project/commit/1427742750ed1fcd2ead639c4ec5178fc34c9257.dif
Author: Clement Courbet
Date: 2021-11-03T15:51:35+01:00
New Revision: 45b84a547efe8991b28883c73efa2de798dc2c30
URL:
https://github.com/llvm/llvm-project/commit/45b84a547efe8991b28883c73efa2de798dc2c30
DIFF:
https://github.com/llvm/llvm-project/commit/45b84a547efe8991b28883c73efa2de798dc2c30.dif
Author: Clement Courbet
Date: 2021-11-04T15:43:32+01:00
New Revision: d3dc7d077f1d9c9478813a34ed38abbcb4fc1ef5
URL:
https://github.com/llvm/llvm-project/commit/d3dc7d077f1d9c9478813a34ed38abbcb4fc1ef5
DIFF:
https://github.com/llvm/llvm-project/commit/d3dc7d077f1d9c9478813a34ed38abbcb4fc1ef5.dif
Author: Clement Courbet
Date: 2021-11-05T11:44:19+01:00
New Revision: 737f540abd578df094f04f690a9b5b52028374b4
URL:
https://github.com/llvm/llvm-project/commit/737f540abd578df094f04f690a9b5b52028374b4
DIFF:
https://github.com/llvm/llvm-project/commit/737f540abd578df094f04f690a9b5b52028374b4.dif
Author: Clement Courbet
Date: 2021-11-24T08:07:21+01:00
New Revision: ba4411e7c6a5879ce8acf246b0cd03ec738d9d6b
URL:
https://github.com/llvm/llvm-project/commit/ba4411e7c6a5879ce8acf246b0cd03ec738d9d6b
DIFF:
https://github.com/llvm/llvm-project/commit/ba4411e7c6a5879ce8acf246b0cd03ec738d9d6b.dif
Author: Clement Courbet
Date: 2021-11-24T16:47:55+01:00
New Revision: 3b72448084052785b79566fa5bd374feb8ae3907
URL:
https://github.com/llvm/llvm-project/commit/3b72448084052785b79566fa5bd374feb8ae3907
DIFF:
https://github.com/llvm/llvm-project/commit/3b72448084052785b79566fa5bd374feb8ae3907.dif
Author: Clement Courbet
Date: 2022-08-11T07:54:44+02:00
New Revision: 156c0754bc2ee0b7d198cfeff230374a1961ac04
URL:
https://github.com/llvm/llvm-project/commit/156c0754bc2ee0b7d198cfeff230374a1961ac04
DIFF:
https://github.com/llvm/llvm-project/commit/156c0754bc2ee0b7d198cfeff230374a1961ac04.dif
Author: Clement Courbet
Date: 2022-08-16T13:01:13+02:00
New Revision: 672311bd77c594888e2660c124d7eae01822fffa
URL:
https://github.com/llvm/llvm-project/commit/672311bd77c594888e2660c124d7eae01822fffa
DIFF:
https://github.com/llvm/llvm-project/commit/672311bd77c594888e2660c124d7eae01822fffa.dif
Author: Clement Courbet
Date: 2022-10-18T08:47:21+02:00
New Revision: dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b
URL:
https://github.com/llvm/llvm-project/commit/dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b
DIFF:
https://github.com/llvm/llvm-project/commit/dbfa97bd1108fe2a8e4fb13a16508f3dd0676a9b.dif
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/66750
None
>From 3679b5c95a8de88a5cabc9ecdacdbbfef9c68ea8 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Tue, 19 Sep 2023 10:19:49 +0200
Subject: [PATCH] [NFC] Preparatory work for D153131
---
clang/lib/A
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/66750
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/67420
This was ported over from phabricator.
Review https://reviews.llvm.org/D153131.
>From 3581fc00f690194ac4bac631311ecdb18593b7ba Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Tue, 26 Sep 2023 14:02:44
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/67420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/67428
...of guarded variables, when the function is not marked as requiring locks:
```
class Return {
Mutex mu;
Foo foo GUARDED_BY(mu);
Foo &returns_ref_locked() {
MutexLock lock(&mu);
return foo;
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/67523
There was a misunderstanding as to whether we wanted those base NFC changes or
not.
This reverts commit 166074eff2e9a5f79b791f1cc9b641a4e2968616.
>From c4904f5c3304d0117a21ec6650a260639901dcf9 Mon Sep 17 0
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/67523
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/67775
…" (#67523)
Discussion in https://reviews.llvm.org/D153132.
This reverts commit f70377471c990aa567584ae429e77adc9a55491b.
>From efc22cc97bbc0238f9ab066132ba434d41677599 Mon Sep 17 00:00:00 2001
From: Cleme
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/67775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/67776
...of guarded variables, when the function is not marked as requiring locks:
```
class Return {
Mutex mu;
Foo foo GUARDED_BY(mu);
Foo &returns_ref_locked() {
MutexLock lock(&mu);
return foo;
https://github.com/legrosbuffle updated
https://github.com/llvm/llvm-project/pull/67776
>From 7212f4cff29784f9b874a2c52586792f02158200 Mon Sep 17 00:00:00 2001
From: Clement Courbet
Date: Fri, 29 Sep 2023 10:39:58 +0200
Subject: [PATCH] [clang analysis][thread-safety] Handle return-by-reference
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/67776
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/legrosbuffle created
https://github.com/llvm/llvm-project/pull/67795
… (#67776)"
This detects issues in `scudo`. Reverting until these are fixed.
```
/b/sanitizer-x86_64-linux-autoconf/build/llvm-project/compiler-rt/lib/scudo/standalone/tsd.h:74:12:
error: returning variabl
https://github.com/legrosbuffle closed
https://github.com/llvm/llvm-project/pull/67795
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 289 matches
Mail list logo
