[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet updated this revision to Diff 147508. courbet marked 2 inline comments as done. courbet added a comment. - More explicit documentation. - Do not trigger in template and macro contexts. - More tests. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38455 Files: clang-tid

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet added a comment. Thanks. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:35 + hasSourceExpression(IsFloatExpr), + unless(hasParent(castExpr( + .b

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:35 + hasSourceExpression(IsFloatExpr), + unless(hasParent(castExpr( + .bind(

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet added a comment. Great, thanks for the review ! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

This revision was automatically updated to reflect the committed changes. Closed by commit rL333066: [clang-tidy] new cppcoreguidelines-narrowing-conversions check. (authored by courbet, committed by ). Repository: rL LLVM https://reviews.llvm.org/D38455 Files: clang-tools-extra/trunk/clan

[PATCH] D38455: [clang-tidy] new cppcoreguidelines-narrowing-conversions check.

courbet updated this revision to Diff 138910. courbet added a comment. Herald added a subscriber: cfe-commits. Do not trigger on `some_int += std::floor(some_float)`; Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D38455 Files: clang-tidy/cppcoreguidelines/CMakeLists.txt cla

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

courbet created this revision. Herald added subscribers: cfe-commits, xazax.hun. Context: https://twitter.com/willkirkby/status/1084219580799741953 Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D56657 Files: clang-tidy/bugprone/StringConstructorCheck.cpp test/clang-tidy/bug

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

courbet updated this revision to Diff 181519. courbet added a comment. Remove commented code. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56657/new/ https://reviews.llvm.org/D56657 Files: clang-tidy/bugprone/StringConstructorCheck.cpp test/cl

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

courbet updated this revision to Diff 181985. courbet marked 2 inline comments as done. courbet added a comment. clang-format + add test Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56657/new/ https://reviews.llvm.org/D56657 Files: clang-tidy/bu

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE351308: [clang-tidy] bugprone-string-constructor: Catch string from nullptr. (authored by courbet, committed by ). Changed prior to commit: https://reviews.llvm.org/D56657?vs=181985&id=181986#toc Rep

[PATCH] D56657: [clang-tidy] bugprone-string-constructor: Catch string from nullptr.

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56657/new/ https://reviews.llvm.org/D56657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cg

[PATCH] D53488: [clang-tidy] Catching narrowing from double to float.

courbet added inline comments. Comment at: clang-tidy/cppcoreguidelines/NarrowingConversionsCheck.cpp:155 + if (!LhsIntegerRange.Contains(IntegerConstant)) +diag(SourceLoc, "narrowing conversion from %0 to %1") << RhsType << LhsType; + return true; I think

[PATCH] D54830: [ASTMatchers] Add hasSideEffect() matcher.

courbet created this revision. courbet added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Exposes Expr::HasSideEffects. Repository: rC Clang https://reviews.llvm.org/D54830 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMat

[PATCH] D54830: [ASTMatchers] Add hasSideEffect() matcher.

courbet updated this revision to Diff 175031. courbet added a comment. rebase Repository: rC Clang https://reviews.llvm.org/D54830 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTMatchersNa

[PATCH] D54830: [ASTMatchers] Add hasSideEffect() matcher.

courbet marked an inline comment as done. courbet added a comment. Thanks. Repository: rC Clang https://reviews.llvm.org/D54830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D54830: [ASTMatchers] Add hasSideEffect() matcher.

courbet updated this revision to Diff 175044. courbet added a comment. address comment Repository: rC Clang https://reviews.llvm.org/D54830 Files: docs/LibASTMatchersReference.html include/clang/ASTMatchers/ASTMatchers.h lib/ASTMatchers/Dynamic/Registry.cpp unittests/ASTMatchers/ASTM

[PATCH] D54830: [ASTMatchers] Add hasSideEffect() matcher.

This revision was automatically updated to reflect the committed changes. Closed by commit rC347462: [ASTMatchers] Add hasSideEffect() matcher. (authored by courbet, committed by ). Changed prior to commit: https://reviews.llvm.org/D54830?vs=175044&id=175045#toc Repository: rC Clang https:/

[PATCH] D54903: [WIP][Sema] Improve static_assert diagnostics.

courbet created this revision. Herald added a subscriber: cfe-commits. `static_assert(std::is_same::value, "message")` now prints the value of U and V. Repository: rC Clang https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Index: test/SemaC

[PATCH] D54903: [WIP][Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175465. courbet added a comment. Handle all std type traits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Index

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175638. courbet marked 5 inline comments as done. courbet edited the summary of this revision. courbet added a comment. Address Aaron's comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.o

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked an inline comment as done. courbet added a comment. Thanks for the comments. Comment at: lib/Sema/SemaTemplate.cpp:3070 +// and returns true. +static bool prettyPrintTypeTrait(const NestedNameSpecifier *const NNS, + llvm::raw_strin

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175667. courbet added a comment. clang-formant patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Index: test/S

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175668. courbet marked 2 inline comments as done. courbet added a comment. harden against null getAsRecordDecl(). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/Sem

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3076 +return false; + const RecordDecl * Record = NNS->getAsRecordDecl(); + // In namespace "::std". aaron.ballman wrote: > Formatting is incorrect here; you should run the patch through c

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175669. courbet added a comment. fix variable name in comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Inde

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked an inline comment as done. courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:111 +static_assert(std::is_same::value, "message"); // expected-error{{static_assert failed due to requirement 'std::is_same::value' "message"}} +static_assert(st

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175673. courbet added a comment. Add unit test with dependent types. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cp

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175679. courbet added a comment. Replace custom printing code with clang helper. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/stat

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175710. courbet marked 2 inline comments as done. courbet added a comment. expand types in all qualifiers, not only type traits. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files:

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked 2 inline comments as done. courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3061 +#define TYPE_TRAIT_N(Spelling, Name, Key) RecordName == (#Spelling + 2) || +#include "clang/Basic/TokenKinds.def" +#undef TYPE_TRAIT_1 Quuxplusone

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 175855. courbet marked 5 inline comments as done. courbet added a comment. - add more tests - handle c++17 constructs - add c++17 tests in static-assert-cxx17.cpp Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet added a comment. Thanks Comment at: lib/Sema/SemaTemplate.cpp:3064 +// If this is a qualified name, expand the template arguments in nested +// qualifiers. +DR->getQualifier()->print(OS, PrintPolicy, true); Quuxplusone wrote: > I don't under

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked 4 inline comments as done. courbet added inline comments. Comment at: lib/AST/NestedNameSpecifier.cpp:308-310 +if (ResolveTemplateArguments && getAsRecordDecl()) { + if (const auto *Record = + dyn_cast(getAsRecordDecl())) { aa

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet updated this revision to Diff 176320. courbet added a comment. - Fix spurious formating changes - Add tests - Improve readability. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 Files: include/clang/AST/NestedN

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked an inline comment as done. courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3055 +// Print a diagnostic for the failing static_assert expression. Defaults to +// pretty-printing the expression. aaron.ballman wrote: > Comment i

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet marked an inline comment as done. courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3055 +// Print a diagnostic for the failing static_assert expression. Defaults to +// pretty-printing the expression. aaron.ballman wrote: > courbet w

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

courbet added a comment. Thank you both for the review ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54903/new/ https://reviews.llvm.org/D54903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D54903: [Sema] Improve static_assert diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348239: [WIP][Sema] Improve static_assert diagnostics for type traits. (authored by courbet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION htt

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. We're now handling cases like `static_assert(!expr)` and static_assert(!(expr))`. Repository: rC Clang https://reviews.llvm.org/D55270 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Ind

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet updated this revision to Diff 176771. courbet marked 2 inline comments as done. courbet added a comment. - Address comments - Add more tests - Remove AllowTopLevel and handle cases like `sizeof(T)` (-> `sizeof(int)`) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet marked 7 inline comments as done. courbet added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:3065 + + ~FailedBooleanConditionPrinterHelper() override {} + Quuxplusone wrote: > aaron.ballman wrote: > > Is this definition necessary? > Nit: I don'

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet updated this revision to Diff 176773. courbet added a comment. - Update PHC and C11 tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ https://reviews.llvm.org/D55270 Files: include/clang/Sema/Sema.h lib/Sema/SemaDeclCXX.cpp lib/Sema/S

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet marked an inline comment as done. courbet added inline comments. Comment at: test/PCH/cxx-static_assert.cpp:17 -// expected-error@12 {{static_assert failed "N is not 2!"}} +// expected-error@12 {{static_assert failed due to requirement '1 == 2' "N is not 2!"}} T<1> t1

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet added a comment. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ https://reviews.llvm.org/D55270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

This revision was automatically updated to reflect the committed changes. Closed by commit rL348741: [Sema] Further improvements to to static_assert diagnostics. (authored by courbet, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. Herald added a subscriber: cfe-commits. Handles expressions such as: - `std::is_const()` - `std::is_const()()`; - `std::is_same(decltype(U()), V>::value`; Repository: rC Clang https://reviews.llvm.org/D2

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 177681. courbet added a comment. cosmetics Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: lib/Sema/SemaTemplate.cpp test/SemaCXX/static-assert.cpp Index: test/SemaCXX/sta

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188316. courbet added a comment. - more tests Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files: clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp test/clang-

[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

courbet updated this revision to Diff 188318. courbet added a comment. - add more tests - Traverse using decls. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58606/new/ https://reviews.llvm.org/D58606 Files: clang-tidy/bugprone/StringIntegerAssig

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188367. courbet marked an inline comment as done. courbet added a comment. - cosmetics Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files: clang-tidy/bugprone/Strin

[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

courbet added a comment. Thanks ! > is there a bug or similar? If yes please mention it somewhere in the summary > or so and close it :) Yes, PR27723. Done. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58606/new/ https://reviews.llvm.org/D58606

[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

This revision was automatically updated to reflect the committed changes. Closed by commit rL355076: [clang-tidy] misc-string-integer-assignment: fix false positive (authored by courbet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LLVM

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188690. courbet marked an inline comment as done. courbet added a comment. - rebase - -more cosmetics Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files: clang-tidy

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE355089: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives. (authored by courbet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58609?vs=188690&id=188722#toc

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

courbet created this revision. courbet added reviewers: JonasToth, alexfh, xazax.hun. Herald added subscribers: jdoerfert, rnkovacs. Herald added a project: clang. And add various tests gleaned for our codebase. See PR27723. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D59360

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

courbet marked 3 inline comments as done. courbet added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp:115 +Expr::EvalResult EvalResult; +if (!E->EvaluateAsInt(EvalResult, Ctx, Expr::SE_AllowSideEffects)) + return

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

courbet updated this revision to Diff 190610. courbet added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59360/new/ https://reviews.llvm.org/D59360 Files: clang-tools-extra/clang-tidy/bugprone/StringIntegerAs

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

courbet marked 2 inline comments as done. courbet added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringIntegerAssignmentCheck.cpp:115 +Expr::EvalResult EvalResult; +if (!E->EvaluateAsInt(EvalResult, Ctx, Expr::SE_AllowSideEffects)) + return

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

courbet updated this revision to Diff 191885. courbet added a comment. Ignore template contexts and add a test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59360/new/ https://reviews.llvm.org/D59360 Files: clang-tools-extra/clang-tidy/bugprone

[PATCH] D59360: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment

This revision was automatically updated to reflect the committed changes. courbet marked an inline comment as done. Closed by commit rL356871: [clang-tidy] Fix more false positives for bugprone-string-integer-assignment (authored by courbet, committed by ). Herald added a project: LLVM. Herald add

[PATCH] D60719: Demonstrate how to fix freestanding for memcpy

courbet added a comment. As discussed offline, I think this should go through an RFC process. I guess the main reservation that people will have is that this might generate a very large number of load stores (because we don't have a good way to generate loops here). This is not an issue for X86

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet created this revision. courbet added a reviewer: jyknight. Herald added a subscriber: kristina. Herald added a project: clang. This makes it consistent with `memcmp` and `__builtin_bcmp`. Also see the discussion in https://reviews.llvm.org/D56593. Repository: rC Clang https://reviews

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet updated this revision to Diff 186644. courbet added a comment. Herald added a subscriber: jdoerfert. - Add tests for warnings. - Fix signature for intrinsic. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 Files:

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet updated this revision to Diff 186645. courbet added a comment. - add __builtin_bcmp constant evaluation tests. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 Files: include/clang/Basic/Builtins.def lib/AST/De

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet updated this revision to Diff 186651. courbet added a comment. Update tests after constness changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 Files: include/clang/Basic/Builtins.def lib/AST/Decl.cpp l

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

courbet added a comment. Thanks. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58120/new/ https://reviews.llvm.org/D58120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[PATCH] D58120: [Builtins] Treat `bcmp` as a builtin.

This revision was automatically updated to reflect the committed changes. Closed by commit rC354023: [Builtins] Treat `bcmp` as a builtin. (authored by courbet, committed by ). Changed prior to commit: https://reviews.llvm.org/D58120?vs=186651&id=186814#toc Repository: rC Clang CHANGES SINC

[PATCH] D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

courbet created this revision. courbet added reviewers: xazax.hun, alexfh. Herald added subscribers: cfe-commits, rnkovacs. Herald added a project: clang. Tis represents ~20% of false positives. See PR27723. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58604 Files: clang-ti

[PATCH] D58606: [clang-tidy] misc-string-integer-assignment: fix false positive

courbet created this revision. courbet added reviewers: xazax.hun, alexfh. Herald added subscribers: cfe-commits, rnkovacs. Herald added a project: clang. using CodePoint = uint32_t; CodePoint cp; casic_string s; s += cp; Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D58606 Fil

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet created this revision. courbet added reviewers: xazax.hun, alexfh. Herald added subscribers: cfe-commits, jdoerfert, rnkovacs. Herald added a project: clang. Detect a few expressions as likely character expressions, see PR27723. Repository: rCTE Clang Tools Extra https://reviews.llvm.

[PATCH] D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58604/new/ https://reviews.llvm.org/D58604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D58604: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower

This revision was automatically updated to reflect the committed changes. Closed by commit rL354780: [clang-tidy] misc-string-integer-assignment: ignore toupper/tolower (authored by courbet, committed by ). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rL LL

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet updated this revision to Diff 188165. courbet marked 3 inline comments as done. courbet added a comment. - address review comments Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 Files: clang-tidy/

[PATCH] D58609: [clang-tidy] bugprone-string-integer-assignment: Reduce false positives.

courbet added a comment. Thanks. Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58609/new/ https://reviews.llvm.org/D58609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[PATCH] D55270: [Sema] Further improvements to to static_assert diagnostics.

courbet added a comment. I agree. I'll have a look at it. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55270/new/ https://reviews.llvm.org/D55270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet planned changes to this revision. courbet marked an inline comment as done. courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:136 +static_assert(std::is_const::value, "message"); +// expected-error@-1{{static_assert failed due to requirement 'std:

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 178010. courbet added a comment. Handle remaining static_assert categories inside the prettyprinter. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: include/clang/AST/Stmt.h

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 178011. courbet added a comment. clang-format patch Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: include/clang/AST/Stmt.h lib/AST/StmtPrinter.cpp lib/Sema/SemaTemplate

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 178012. courbet added a comment. revert now unneeded changes. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: include/clang/AST/Stmt.h lib/AST/StmtPrinter.cpp lib/Sema/Se

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 178882. courbet marked 2 inline comments as done. courbet added a comment. move PrintQualifiedTypes to PrintingPolicy Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: include/

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet added inline comments. Comment at: include/clang/AST/Stmt.h:847 + const ASTContext *Context = nullptr, + bool PrintCanonicalTypes = false) const; aaron.ballman wrote: > I'm pretty wary of long lists of parameters that

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet marked 6 inline comments as done. courbet added inline comments. Comment at: lib/AST/TypePrinter.cpp:165 +static SplitQualType splitAccordingToPolicy(QualType t, +const PrintingPolicy &Policy) { aaron.ballman

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 178887. courbet marked 2 inline comments as done. courbet added a comment. address review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: include/clang/AST/PrettyPri

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 17. courbet added a comment. clang-format diff Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: include/clang/AST/PrettyPrinter.h include/clang/AST/Type.h lib/AST/Type

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet updated this revision to Diff 179018. courbet marked 3 inline comments as done. courbet added a comment. address review comments Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ https://reviews.llvm.org/D2 Files: include/clang/AST/PrettyPri

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

courbet added a comment. Thanks for the comments ! Comment at: include/clang/AST/Type.h:995 void getAsStringInternal(std::string &Str, - const PrintingPolicy &Policy) const { -return getAsStringInternal(split(), Str, Policy); - } +

[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

This revision was automatically updated to reflect the committed changes. Closed by commit rL349729: [Sema] Better static assert diagnostics for expressions involving… (authored by courbet, committed by ). Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D2/new/ ht

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. We can now remove the specific handling of NestedNameQualifiers as it's now handled by the type printer as of r349729. Repository: rC Clang https://reviews.llvm.org/D55932 Files: include/clang/AST/NestedNam

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet created this revision. courbet added reviewers: aaron.ballman, Quuxplusone. As a followup to D55270 . Repository: rC Clang https://reviews.llvm.org/D55933 Files: include/clang/AST/NestedNameSpecifier.h lib/AST/NestedNameSpecifier.cpp lib/AST/Typ

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet marked 6 inline comments as done. courbet added inline comments. Comment at: lib/AST/TypePrinter.cpp:173 + // information about whether default template parameters were actually + // written. + switch (QT.getTypePtr()->getTypeClass()) { Quuxplusone wro

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

courbet marked an inline comment as done. courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:130 static_assert(std::is_same()), int>::value, "message"); -// expected-error@-1{{static_assert failed due to requirement 'std::is_same, int>::value' "message"}

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:130 static_assert(std::is_same()), int>::value, "message"); -// expected-error@-1{{static_assert failed due to requirement 'std::is_same, int>::value' "message"}} +// expected-error@-1{{static_assert fai

[PATCH] D55932: [Sema] Simplfy static_assert diagnostic code.

courbet marked an inline comment as done. courbet added inline comments. Comment at: test/SemaCXX/static-assert.cpp:130 static_assert(std::is_same()), int>::value, "message"); -// expected-error@-1{{static_assert failed due to requirement 'std::is_same, int>::value' "message"}

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet updated this revision to Diff 180035. courbet marked 2 inline comments as done. courbet added a comment. Add more tests as suggested in the comments. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55933/new/ https://reviews.llvm.org/D55933 Files: includ

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet added inline comments. Comment at: test/SemaCXX/static-assert-cxx17.cpp:109 +template +void foo7() { + static_assert(X()); Quuxplusone wrote: > courbet wrote: > > Quuxplusone wrote: > > > None of these new test cases actually involve the default templat

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet updated this revision to Diff 180220. courbet marked 2 inline comments as done. courbet added a comment. Handle {L,R}Value references. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55933/new/ https://reviews.llvm.org/D55933 Files: include/clang/AST/Nes

[PATCH] D55933: [Sema] Do not print default template parameters.

courbet added inline comments. Comment at: lib/AST/TypePrinter.cpp:179 +// `X` gets canonicalized to `X`. We disable +// canonicalization so that `printTag()`` can see the template parameters as +// written. Quuxplusone wrote: > Nit: there's an extra

[PATCH] D67499: [Alignment] Move OffsetToAlignment to Alignment.h

courbet added inline comments. Comment at: llvm/lib/Target/ARM/ARMConstantIslandPass.cpp:1024 NextBlockOffset = BBInfo[Water->getNumber()].postOffset(); -NextBlockLogAlignment = 0; +NextBlockAlignment = llvm::Align(); } else { this statement is no

[PATCH] D68141: [Alignment][NFC] Remove AllocaInst::setAlignment(unsigned)

courbet added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64StackTagging.cpp:461 void AArch64StackTagging::alignAndPadAlloca(AllocaInfo &Info) { - unsigned NewAlignment = std::max(Info.AI->getAlignment(), kTagGranuleSize); + MaybeAlign NewAlignment(std::max(Info.

  1   2   3   >