[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. In D108696#3083081 , @Quuxplusone wrote: > In D108696#3082866 , @ChuanqiXu > wrote: > >> @Quuxplusone gentle ping~ > > I think this PR is mostly above my pay grade. :) Sorry for distu

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added inline comments. Comment at: clang/test/SemaCXX/coroutines-exp-namespace.cpp:2 +// This file is the same with coroutines.cpp except the coroutine components are defined in std::experimental namespace. +// This intention of this test is to make sure the legacy ime

[PATCH] D108615: [Coroutines] [libcxx] Move coroutine component out of experimental namespace

ChuanqiXu added a comment. In D108615#2962618 , @lxfind wrote: > I am not familiar with the process of when to move something out of > experimental, but I do wonder how this is normally done so that people who > uses coroutines can have a smooth migrati

[PATCH] D108615: [Coroutines] [libcxx] Move coroutine component out of experimental namespace

ChuanqiXu abandoned this revision. ChuanqiXu added a comment. Oh, I find why the CI still fails. Since the compiler used to compile libcxx in the CI doesn't contain the change in this patch! So it would still lookup coroutine components in std::experimental namespace. So here are the failures.

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch nounwind

ChuanqiXu added a comment. Thanks for looking into this! I am not familiar with exception handling. But from the comments, I worried that if it is a problem if there are exceptions whose destructor could throw (although it is not usual nor good). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

ChuanqiXu accepted this revision. ChuanqiXu added a comment. This revision is now accepted and ready to land. In D108905#2971773 , @MaskRay wrote: > In D108905#2971761 , @ChuanqiXu > wrote: > >> Thanks for lookin

[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

ChuanqiXu added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:4435-4448 struct CallEndCatch final : EHScopeStack::Cleanup { CallEndCatch(bool MightThrow) : MightThrow(MightThrow) {} bool MightThrow; void Emit(CodeGenFunction &CGF, Flags flag

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. @rjmccall @lxfind @junparser hi, do you feel comfortable with this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11015 + "coroutine_traits defined in std::experimental namespace is deprecated. " + "Considering update libcxx and include instead of .">, + InGroup; avogelsgesang

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu added a comment. In D108696#2983021 , @ldionne wrote: > Based on the commit description, I don't understand this change at all. Why > do we want to tweak the name lookup just for `std::coroutine`? Yes, we do > have an action item to finish cor

[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

ChuanqiXu planned changes to this revision. ChuanqiXu added a comment. We should proceed after D108697 accepted. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108696/new/ https://reviews.llvm.org/D108696 ___

[PATCH] D108905: [ItaniumCXXABI] Make __cxa_end_catch calls unconditionally nounwind

ChuanqiXu added a comment. In D108905#2975806 , @rjmccall wrote: > In D108905#2975712 , @rsmith wrote: > >> No decision as yet, but so far it looks very likely that we'll settle on the >> rule that exceptions can

<    9   10   11   12   13   14