@@ -0,0 +1,100 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -87,4 +89,15 @@ void test() {
std::ranges::unique(iter, iter); // expected-warning {{ignoring return value
of function declared with 'nodiscard' attribute}}
std::ranges::upper_bound(range, 1); // expected-warning {{ignoring return
value of function declared with 'nodisc
@@ -0,0 +1,93 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,93 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -83,6 +83,10 @@ static_assert(test(std::ranges::find_end, a, a));
static_assert(test(std::ranges::find_first_of, a, a));
cjdb wrote:
I'm a bit hesitant to use that test file, so `left_folds.pass.cpp` does checks
to ensure invocable robustness. I'll my concer
https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/75259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -89,9 +89,7 @@ struct __fold_left_with_iter {
}
};
-inline namespace __cpo {
inline constexpr auto fold_left_with_iter = __fold_left_with_iter();
cjdb wrote:
I've updated the description in this PR, which I _think_ becomes the main
message for a squash
@@ -0,0 +1,118 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,118 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
https://github.com/cjdb approved this pull request.
Thanks for making this change!
CC @ajordanr-google
https://github.com/llvm/llvm-project/pull/75986
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -0,0 +1,202 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
cjdb wrote:
Ah
cjdb wrote:
Merging, with the promise to diligently resolve post-commit feedback in early
January. Anything that's specific to this patch will be actioned before
starting work on the remaining fold algorithms, and anything that's generalised
to `std::ranges` will be actioned after finishing th
https://github.com/cjdb closed https://github.com/llvm/llvm-project/pull/75259
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cjdb closed https://github.com/llvm/llvm-project/pull/73560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cjdb created https://github.com/llvm/llvm-project/pull/73560
Writing directly to /dev/null has permission issues on some systems, so we've
changed this to a temporary file instead.
>From 786d368b9d4d315254df1b8631adead6f8c8e379 Mon Sep 17 00:00:00 2001
From: Christopher Di Be
cjdb wrote:
> > I see @var-const has "requested changes" set, but I feel we've addressed
> > the one unresolved comment of his.
>
> @EricWF In fact, this patch changed quite significantly since I last looked
> at it (based on your feedback, I believe), so I would have appreciated being
> able
@@ -0,0 +1,104 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,104 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,89 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,89 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,104 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,259 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,315 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,118 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,93 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,118 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
https://github.com/cjdb requested changes to this pull request.
Thanks for working on this! There's a fair bit that I've provided comments for,
but I think you're off to a great start, and I would like to see this merged in
January, if at all possible.
Some comments are short and repetitive: t
@@ -0,0 +1,129 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/73617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,138 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,96 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,101 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,114 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,129 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,107 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,107 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,75 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,95 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,77 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apac
@@ -0,0 +1,104 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
@@ -0,0 +1,333 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License
https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/73617
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -13,7 +13,7 @@
// Range algorithms should return `std::ranges::dangling` when given a
dangling range.
cjdb wrote:
Please revert and apply in a separate patch.
https://github.com/llvm/llvm-project/pull/68494
___
https://github.com/cjdb requested changes to this pull request.
Thanks for working on this, it's an important algorithm to have. I've left some
comments, but would like to see this merged by the end of January.
https://github.com/llvm/llvm-project/pull/68494
@@ -0,0 +1,171 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -1083,6 +1083,27 @@ rvalue_iterator(T*) -> rvalue_iterator;
static_assert(std::random_access_iterator>);
+// The ProxyDiffTBase allows us to conditionally specify
Proxy::difference_type
+// which we need in certain situations. For example when we want
+// std::weakly_incr
@@ -0,0 +1,71 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
@@ -1149,9 +1171,11 @@ struct Proxy {
// Calling swap(Proxy{}, Proxy{}) would fail (pass prvalues)
// Compare operators are defined for the convenience of the tests
- friend constexpr bool operator==(const Proxy&, const Proxy&)
-requires (std::equality_comparable && !
@@ -0,0 +1,71 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
@@ -0,0 +1,171 @@
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/cjdb edited https://github.com/llvm/llvm-project/pull/68494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1172,6 +1198,22 @@ struct Proxy {
requires std::three_way_comparable_with, std::decay_t> {
return lhs.data <=> rhs.data;
}
+
+ // Needed to allow certain types to be weakly_incremental
+ constexpr Proxy& operator++()
+requires(HasPreIncrementOp)
+ {
+++
@@ -1161,9 +1185,11 @@ struct Proxy {
return lhs.data == rhs.data;
}
- friend constexpr auto operator<=>(const Proxy&, const Proxy&)
-requires (std::three_way_comparable && !std::is_reference_v)
- = default;
+ friend constexpr auto operator<=>(const Proxy& lhs, co
@@ -0,0 +1,71 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
@@ -0,0 +1,54 @@
+// -*- C++ -*-
+//===--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-
@@ -1149,9 +1171,11 @@ struct Proxy {
// Calling swap(Proxy{}, Proxy{}) would fail (pass prvalues)
// Compare operators are defined for the convenience of the tests
- friend constexpr bool operator==(const Proxy&, const Proxy&)
-requires (std::equality_comparable && !
Author: Christopher Di Bella
Date: 2021-07-21T21:30:16Z
New Revision: 9a72580a548da8008dca479ec50e4eb75e56db71
URL:
https://github.com/llvm/llvm-project/commit/9a72580a548da8008dca479ec50e4eb75e56db71
DIFF:
https://github.com/llvm/llvm-project/commit/9a72580a548da8008dca479ec50e4eb75e56db71.dif
Author: Christopher Di Bella
Date: 2021-07-26T16:07:45Z
New Revision: e8a64e5491260714c79dab65d1aa73245931d314
URL:
https://github.com/llvm/llvm-project/commit/e8a64e5491260714c79dab65d1aa73245931d314
DIFF:
https://github.com/llvm/llvm-project/commit/e8a64e5491260714c79dab65d1aa73245931d314.dif
Author: Christopher Di Bella
Date: 2021-07-29T19:21:43Z
New Revision: 087195419719e908394081b4cc6f365170b9882c
URL:
https://github.com/llvm/llvm-project/commit/087195419719e908394081b4cc6f365170b9882c
DIFF:
https://github.com/llvm/llvm-project/commit/087195419719e908394081b4cc6f365170b9882c.dif
Author: Christopher Di Bella
Date: 2022-02-15T17:44:47Z
New Revision: d7b1c840ba4e1f8c04fe1c5455242629893c7e3a
URL:
https://github.com/llvm/llvm-project/commit/d7b1c840ba4e1f8c04fe1c5455242629893c7e3a
DIFF:
https://github.com/llvm/llvm-project/commit/d7b1c840ba4e1f8c04fe1c5455242629893c7e3a.dif
Author: Christopher Di Bella
Date: 2022-04-22T16:37:20Z
New Revision: e9a902c7f755a378e197c4b246a32859c0ee162d
URL:
https://github.com/llvm/llvm-project/commit/e9a902c7f755a378e197c4b246a32859c0ee162d
DIFF:
https://github.com/llvm/llvm-project/commit/e9a902c7f755a378e197c4b246a32859c0ee162d.dif
Author: Abraham Corea Diaz
Date: 2022-07-21T16:51:15Z
New Revision: 119d22310bd622d4b39e9760667b6fa58d15a8c5
URL:
https://github.com/llvm/llvm-project/commit/119d22310bd622d4b39e9760667b6fa58d15a8c5
DIFF:
https://github.com/llvm/llvm-project/commit/119d22310bd622d4b39e9760667b6fa58d15a8c5.diff
Author: Christopher Di Bella
Date: 2021-02-25T19:25:00Z
New Revision: 4f395db86b5cc11bb56853323d3cb1d4b6db5a0b
URL:
https://github.com/llvm/llvm-project/commit/4f395db86b5cc11bb56853323d3cb1d4b6db5a0b
DIFF:
https://github.com/llvm/llvm-project/commit/4f395db86b5cc11bb56853323d3cb1d4b6db5a0b.dif
Author: Christopher Di Bella
Date: 2021-08-11T02:48:53Z
New Revision: c874dd53628db8170d4c5ba3878817abc385a695
URL:
https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695
DIFF:
https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695.dif
Author: Christopher Di Bella
Date: 2021-08-11T02:48:53Z
New Revision: c874dd53628db8170d4c5ba3878817abc385a695
URL:
https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695
DIFF:
https://github.com/llvm/llvm-project/commit/c874dd53628db8170d4c5ba3878817abc385a695.dif
Author: Christopher Di Bella
Date: 2021-07-04T06:00:39Z
New Revision: 478092d33116ec01ad0b82f7eeedb1e1f07aef93
URL:
https://github.com/llvm/llvm-project/commit/478092d33116ec01ad0b82f7eeedb1e1f07aef93
DIFF:
https://github.com/llvm/llvm-project/commit/478092d33116ec01ad0b82f7eeedb1e1f07aef93.dif
Author: Christopher Di Bella
Date: 2021-03-04T17:00:54Z
New Revision: 9830901b341cfb884cdef00e0335c6e3e62d107a
URL:
https://github.com/llvm/llvm-project/commit/9830901b341cfb884cdef00e0335c6e3e62d107a
DIFF:
https://github.com/llvm/llvm-project/commit/9830901b341cfb884cdef00e0335c6e3e62d107a.dif
Author: Christopher Di Bella
Date: 2022-08-22T23:15:10Z
New Revision: e137fb6fb85b41978814e64eae652d05688bcca5
URL:
https://github.com/llvm/llvm-project/commit/e137fb6fb85b41978814e64eae652d05688bcca5
DIFF:
https://github.com/llvm/llvm-project/commit/e137fb6fb85b41978814e64eae652d05688bcca5.dif
Author: Abraham Corea Diaz
Date: 2022-08-26T18:49:29Z
New Revision: 82e893c47c77430ca59f92d7a814a336e3873a35
URL:
https://github.com/llvm/llvm-project/commit/82e893c47c77430ca59f92d7a814a336e3873a35
DIFF:
https://github.com/llvm/llvm-project/commit/82e893c47c77430ca59f92d7a814a336e3873a35.diff
Author: Abraham Corea Diaz
Date: 2022-08-26T21:09:39Z
New Revision: 0e5813b88e50576940070003e093d696390a6959
URL:
https://github.com/llvm/llvm-project/commit/0e5813b88e50576940070003e093d696390a6959
DIFF:
https://github.com/llvm/llvm-project/commit/0e5813b88e50576940070003e093d696390a6959.diff
Author: Christopher Di Bella
Date: 2022-10-11T00:13:58Z
New Revision: a089defa24dd4050192e1e8d7e704188d2214787
URL:
https://github.com/llvm/llvm-project/commit/a089defa24dd4050192e1e8d7e704188d2214787
DIFF:
https://github.com/llvm/llvm-project/commit/a089defa24dd4050192e1e8d7e704188d2214787.dif
Author: Christopher Di Bella
Date: 2022-10-11T00:13:58Z
New Revision: 14e64cb8d594c16c722da83d3e8af9fc0d013c4e
URL:
https://github.com/llvm/llvm-project/commit/14e64cb8d594c16c722da83d3e8af9fc0d013c4e
DIFF:
https://github.com/llvm/llvm-project/commit/14e64cb8d594c16c722da83d3e8af9fc0d013c4e.dif
Author: Christopher Di Bella
Date: 2022-10-11T00:13:58Z
New Revision: bd3f48eefc11c2f1ef6eb034418697e24e9a965d
URL:
https://github.com/llvm/llvm-project/commit/bd3f48eefc11c2f1ef6eb034418697e24e9a965d
DIFF:
https://github.com/llvm/llvm-project/commit/bd3f48eefc11c2f1ef6eb034418697e24e9a965d.dif
Author: Denis Nikitin
Date: 2023-01-25T20:06:41Z
New Revision: 716469b6139ab5ec5c5b5dac32891300260db8eb
URL:
https://github.com/llvm/llvm-project/commit/716469b6139ab5ec5c5b5dac32891300260db8eb
DIFF:
https://github.com/llvm/llvm-project/commit/716469b6139ab5ec5c5b5dac32891300260db8eb.diff
LOG:
Author: Adrian Dole
Date: 2023-01-12T18:25:12Z
New Revision: 8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b
URL:
https://github.com/llvm/llvm-project/commit/8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b
DIFF:
https://github.com/llvm/llvm-project/commit/8effeb44f4a8ae3da8c594fdc69ac46dd6ab6f1b.diff
LOG: A
Author: v1nh1shungry
Date: 2023-01-13T01:14:51Z
New Revision: 7910ee7d8c6dcb679200ba171fba5d8d5f237007
URL:
https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007
DIFF:
https://github.com/llvm/llvm-project/commit/7910ee7d8c6dcb679200ba171fba5d8d5f237007.diff
LOG:
Author: Christopher Di Bella
Date: 2022-06-10T17:23:00Z
New Revision: f21187eb2d943c1407ae764b87f73602177dcba8
URL:
https://github.com/llvm/llvm-project/commit/f21187eb2d943c1407ae764b87f73602177dcba8
DIFF:
https://github.com/llvm/llvm-project/commit/f21187eb2d943c1407ae764b87f73602177dcba8.dif
Author: Christopher Di Bella
Date: 2022-06-08T17:55:31Z
New Revision: 288c1bff96fc9042d01b7055dc6e1049d8b54b26
URL:
https://github.com/llvm/llvm-project/commit/288c1bff96fc9042d01b7055dc6e1049d8b54b26
DIFF:
https://github.com/llvm/llvm-project/commit/288c1bff96fc9042d01b7055dc6e1049d8b54b26.dif
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?= ,
Timm =?utf-8?q?B=C3=A4der?=
Message-ID:
In-Reply-To:
cjdb wrote:
I'm okay with the change in general.
https://github.com/llvm/llvm-project/pull/66514
___
cjdb wrote:
This doesn't really fix the problem, it just shuffles it around. I expect
people with blue(ish) terminals will experience the same issue after this is
applied, so we ought to try and detect what colours to print out, and then have
compatible themes.
https://github.com/llvm/llvm-pr
cjdb wrote:
> This is a one-liner that fixes the problem on terminals with a dark
> background and the solution also works on light backgrounds. So, basically
> all of them.
Before approving this change, I want confirmation that it doesn't adversely
impact popular themes. The Tomorrow Night B
cjdb wrote:
> Not really, CYAN is only cyan if that's what your terminal decides to render
> the color 6 as, you can configure it to be orange if you want.
Oh, interesting. In that case, I see no problems.
https://github.com/llvm/llvm-project/pull/66997
cjdb wrote:
Thanks @amykhuang! 🎉
https://github.com/llvm/llvm-project/pull/67199
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cjdb commented:
Thanks for working on this, it seems like an important fix. Would you mind
updating the release notes please? I'll approve afterwards.
https://github.com/llvm/llvm-project/pull/67378
___
cfe-commits mailing list
cfe-
https://github.com/cjdb approved this pull request.
LGTM, thanks! Do you require assistance committing?
https://github.com/llvm/llvm-project/pull/67378
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
https://github.com/cjdb approved this pull request.
https://github.com/llvm/llvm-project/pull/68312
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Christopher Di Bella
Date: 2023-07-20T23:33:46Z
New Revision: 38e1c597033de0c7655abb39335b364408865d2a
URL:
https://github.com/llvm/llvm-project/commit/38e1c597033de0c7655abb39335b364408865d2a
DIFF:
https://github.com/llvm/llvm-project/commit/38e1c597033de0c7655abb39335b364408865d2a.dif
=?utf-8?q?Félix?= Cloutier
Message-ID:
In-Reply-To:
https://github.com/cjdb commented:
Generally speaking, I'm in favour of this; thanks so much for identifying this
problem!
When C++20 is available, we ought to suggest using `std:: is_lt` and friends
instead. Possibly something like
```
n
Author: Christopher Di Bella
Date: 2023-09-11T23:14:08Z
New Revision: e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54
URL:
https://github.com/llvm/llvm-project/commit/e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54
DIFF:
https://github.com/llvm/llvm-project/commit/e1bfeb6bcc627a94c5ab3a5417d290c7dc516d54.dif
Author: Christopher Di Bella
Date: 2023-09-11T23:44:50Z
New Revision: dfd1d8d505d61c9b401a3cdd6a687848f1c37cc5
URL:
https://github.com/llvm/llvm-project/commit/dfd1d8d505d61c9b401a3cdd6a687848f1c37cc5
DIFF:
https://github.com/llvm/llvm-project/commit/dfd1d8d505d61c9b401a3cdd6a687848f1c37cc5.dif
1 - 100 of 127 matches
Mail list logo