[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

cjdb added a comment. I think this is a good diagnostic to add: it improves readability and eliminates ambiguities. My only request is that if there isn't already a FixIt hint, one be added, please. Comment at: clang/test/Sema/parentheses.c:94 (void)(x + y > 0 ? 1 : 2);

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

cjdb added a comment. In D147844#4293693 , @dblaikie wrote: >> I think some of the cases are ambiguous while others are not. > > Data would be good to have - if this assessment is true, we'd expect this to > bear out in terms of bug finding, yeah? (that

[PATCH] D147844: [clang][Sema]Print diagnostic warning about precedence when integer expression is used without parentheses in an conditional operator expression

cjdb added a comment. In D147844#4293988 , @dblaikie wrote: > In D147844#4293743 , @cjdb wrote: > >> In D147844#4293693 , @dblaikie >> wrote: >> I think some of the

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

cjdb added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x()) aaro

[PATCH] D141451: [clang] report inlining decisions with -Wattribute-{warning|error}

cjdb added inline comments. Comment at: clang/test/Frontend/backend-attribute-error-warning-optimize.c:12 foo(); // expected-error {{call to 'foo' declared with 'error' attribute: oh no foo}} + // expected-note@* {{In function 'baz'}} if (x()) aaro

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Gentle ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D146654: [clang] replaces numeric SARIF ids with heirarchical names

cjdb added inline comments. Comment at: clang/lib/Frontend/SARIFDiagnostic.cpp:51-52 + Diag->getDiags()->getDiagnosticIDs()->getStableName(Diag->getID()).str(); + std::replace(StableName.begin(), StableName.end(), '_', '.'); + SarifRule Rule = SarifRule::create().setRuleId

[PATCH] D149492: [clang] makes built-in traits match their stdlib counterparts' names

cjdb created this revision. cjdb added reviewers: rsmith, aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The original names apparently broke convention by not making them the same as the C++

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping (moving my pings from Thursday afternoon to Monday mornings) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing

[PATCH] D149618: [clang][NFC] documents recent type trait primitives

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Depends on D149492 . Repository: rG

[PATCH] D149492: [clang] makes built-in traits match their stdlib counterparts' names

cjdb added a comment. Looks like I need to special-case `__is_null_pointer` as a function for libstdc++. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149492/new/ https://reviews.llvm.org/D149492 ___ cf

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. In D147717#4312066 , @Fznamznon wrote: > In D147717#4275410 , @cjdb wrote: > >> I'm gonna get started on this today! > > @cjdb , how is this going? I've seen > https://github.com/llvm/llvm-p

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. Can the commit message have a description please? It's unclear to me why this is necessary (although I'm sure there's a good reason). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 __

[PATCH] D151575: [clang][diagnostics] Always show include stacks on errors

cjdb added subscribers: shafik, erichkeane, aaron.ballman. cjdb added a comment. @aaron.ballman @erichkeane @shafik any reservations? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151575/new/ https://reviews.llvm.org/D151575 __

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. In D151833#4396399 , @charmitro wrote: > In D151833#4396244 , @cjdb wrote: > >> Can the commit message have a description please? It's unclear to me why >> this is necessary (although I'm su

[PATCH] D147717: [C++20][NFC] Claim full support for consteval again

cjdb added a comment. In D147717#4395204 , @Fznamznon wrote: > In D147717#4393019 , @cor3ntin > wrote: > >> I think we should make sure to land this for clang 17. The rate of consteval >> bugs is no greater than

[PATCH] D151952: [clang] adds `__type_pack_index` so we can get a type's parameter pack index

cjdb added a comment. In D151952#4392329 , @rsmith wrote: > Taking a step back for a moment: what is the intended use case for this? My > concern is that most of the time you're going to want to make O(N) such > queries into a pack of N elements, result

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

cjdb added a comment. I already have another commit I plan to push, will do these together :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151833/new/ https://reviews.llvm.org/D151833 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D152034: [clang][NFC] refactors value type traits so we can have more than bools

This revision was automatically updated to reflect the committed changes. Closed by commit rG798c5ba770d3: [clang][NFC] refactors value type traits so we can have more than bools (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15203

[PATCH] D151833: Respect "-fdiagnostics-absolute-paths" on emit include location

This revision was automatically updated to reflect the committed changes. Closed by commit rG91be60b34715: Respect "-fdiagnostics-absolute-paths" on emit include location (authored by charmitro, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D152525: [clang][Diagnostics] Don't expand label fixit to the next line

cjdb accepted this revision. cjdb added a comment. Thanks for fixing this, it'll hopefully cause less frustration for devs :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152525/new/ https://reviews.llvm.org/D152525 __

[PATCH] D151720: [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. This patch seems like a win to me. Comment at: clang/docs/ReleaseNotes.rst:325 + invalid code. Furthermore, it also displays the object as written by the user. + (`#57081:

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139570/new/ https://reviews.llvm.org/D139570 ___ cfe

[PATCH] D128372: [Clang-Tidy] Empty Check

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGec3f8feddf81: [Clang-Tidy] Empty Check (authored by abrahamcd, committed by cjdb). Repository: rG LLVM Github Monorepo

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. In D128372#3991516 , @MyDeveloperDay wrote: > Ironically as an aside... looking back at the review because of the discource > article. > > The whole reason why I added the [[nodiscard]] checker to clang-tidy 4 years > ago was to c

[PATCH] D140125: [clang] splits diagnostic message into summary and reason

cjdb created this revision. cjdb added reviewers: dblaikie, erichkeane. Herald added subscribers: kadircet, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added projects: clang, libc++abi, clang-tools-extra. Herald added subscribers: cfe-commits, libcxx-commit

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added a comment. Gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[PATCH] D53847: [C++2a] P0634r3: Down with typename!

cjdb added a comment. What's the status of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D53847/new/ https://reviews.llvm.org/D53847 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D120774: [clang-format] Handle builtins in constraint expression

cjdb accepted this revision. cjdb added a comment. Thanks for working on this! Comment at: clang/lib/Format/UnwrappedLineParser.cpp:3163 +case tok::identifier: default: owenpan wrote: > Do we still need this line? I'd prefer to get rid of `default` i

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

cjdb created this revision. cjdb added reviewers: rsmith, gbiv, aaron.ballman, manojgupta. Herald added a reviewer: george.burgess.iv. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. [namespace.std]/p6 indicates that taking the address

[PATCH] D101598: [clang][Sema] adds `[[clang::no_address]]` attribute

cjdb abandoned this revision. cjdb added a comment. A different path forward was discussed with @ldionne and @zoecarver. Will experiment this other way. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101598/new/ https://reviews.llvm.org/D101598 __

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 396711. cjdb edited the summary of this revision. cjdb added a comment. rebases to activate CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/ https://reviews.llvm.org/D116280 Files: clang/include/cla

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb updated this revision to Diff 396748. cjdb edited the summary of this revision. cjdb added a comment. adds `__is_unbounded_array` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116280/new/ https://reviews.llvm.org/D116280 Files: clang/includ

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added inline comments. Comment at: clang/include/clang/AST/Type.h:6481 + // cv-qualifiers or a ref-qualifier, or a reference type + const Type &Self = **this; + if (Self.isObjectType() || Self.isReferenceType()) aaron.ballman wrote: > This is unsafe --

[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

cjdb added a comment. > That said, I think this particular check is more mature and closer to landing > than the other one. Based on the amount of effort in this patch already, > unless there are strong objections, I think we should base the "make this > const if it can be made so" checks on th

[PATCH] D116203: [clang] adds `__add_const` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116203 Files:

[PATCH] D116203: [clang] adds `__add_const` as a compiler built-in

cjdb added a comment. This patch is heavily based off D67052 , and I'll be listing @zoecarver as a co-author in my commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203

[PATCH] D116205: [clang] adds `__add_volatile` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116205 Files:

[PATCH] D116206: [clang] adds `__add_cv` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116206 Files:

[PATCH] D116226: [clang] adds `__remove_const` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116226 Files:

[PATCH] D116242: [clang] adds `__remove_volatile` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116242 Files:

[PATCH] D116260: [clang] adds `__remove_cv` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116260 Files:

[PATCH] D116262: [clang] adds `__remove_reference` as a compiler built-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116262 Files:

[PATCH] D116264: [clang] adds `__remove_cvref` as a compiler buiilt-in

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116264 Files:

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb updated this revision to Diff 396177. cjdb retitled this revision from "[clang] adds `__add_const` as a compiler built-in" to "[clang] adds unary type transformations as compiler built-ins". cjdb edited the summary of this revision. cjdb added a comment. merges D116205

[PATCH] D116205: [clang] adds `__add_volatile` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116205/new/ https://reviews.llvm.org/D116205 ___

[PATCH] D116206: [clang] adds `__add_cv` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116206/new/ https://reviews.llvm.org/D116206 ___

[PATCH] D116226: [clang] adds `__remove_const` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116226/new/ https://reviews.llvm.org/D116226 ___

[PATCH] D116242: [clang] adds `__remove_volatile` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116242/new/ https://reviews.llvm.org/D116242 ___

[PATCH] D116260: [clang] adds `__remove_cv` as a compiler built-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116260/new/ https://reviews.llvm.org/D116260 ___

[PATCH] D116262: [clang] adds `__remove_reference` as a compiler built-in

cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116262/new/ https://reviews.llvm.org/D116262 ___ cfe-commits mailing list cfe-c

[PATCH] D116264: [clang] adds `__remove_cvref` as a compiler buiilt-in

cjdb abandoned this revision. cjdb added a comment. Merged into D116203 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116264/new/ https://reviews.llvm.org/D116264 ___

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb updated this revision to Diff 396178. cjdb added a comment. minor fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203 Files: clang/include/clang/AST/Type.h clang/include/clang/Basic/Specifiers.h

[PATCH] D116280: [clang] adds unary type trait checks as compiler built-ins

cjdb created this revision. Herald added a subscriber: dexonsmith. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is information that the compiler already has, and should be exposed so that the library doesn't need to reimplement

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb updated this revision to Diff 396248. cjdb edited the summary of this revision. cjdb added a comment. adds more type traits Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116203/new/ https://reviews.llvm.org/D116203 Files: clang/include/clan

[PATCH] D100581: [Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable

cjdb added a comment. Overall LGTM, thank you for working on this :-) Comment at: clang/lib/Sema/SemaDecl.cpp:13761-13771 +bool VisitDeclRefExpr(const DeclRefExpr *DRE) { + auto iter = M->find(DRE->getFoundDecl()); + if (iter != M->end() && iter->second) { +

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb updated this revision to Diff 315470. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/Analysis/NewDelete-intersections.mm

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb updated this revision to Diff 315471. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269 Files: clang/include/clang/Basic/DiagnosticGroups.td clang/include/clang/Basic/DiagnosticSemaKinds.td clang/test/Analysis/NewDelete-intersections.mm

[PATCH] D94269: Adds -Wfree-nonheap-object to -Wmost

cjdb closed this revision. cjdb added a comment. Merged in 4a47da2cf440c2f2006d9b04acfef4292de1e263 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94269/new/ https://reviews.llvm.org/D94269 _

[PATCH] D107873: [clang-tidy] Add 'performance-const-parameter-value-or-ref' for checking const-qualified parameters

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.h:40 + static constexpr int DefaultSmallMaxSize = 16; + int SmallMaxSize = Options.get("SmallMaxSize", DefaultSmallMaxSize); + jmarrec wrote: > https://re

<    1   2   3   4   5