[PATCH] D135338: [clang] adds move-assignable type-trait builtins

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. - `__is_move_assignable` - `__is_nothrow_move_assignable` - `__is_trivial

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This makes it possible to be used in all modes, instead of just when `-fm

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb created this revision. cjdb added reviewers: aaron.ballman, shafik, erichkeane, tcanens. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This is information that the compiler already has, and should be

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb planned changes to this revision. cjdb added a comment. I learnt last night that this one is incredibly wrong and needs revising. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 _

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

cjdb added a comment. In D135339#3839876 , @erichkeane wrote: > This doesn't cause us to lose this in Microsoft C mode, does it? Otherwise, > LGTM. Why is destructibility necessary in C? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__referen

[PATCH] D135339: [clang] makes `__is_destructible` KEYCXX instead of KEYMS

cjdb added a comment. In D135339#3840406 , @erichkeane wrote: > In D135339#3840323 , @cjdb wrote: > >> In D135339#3839876 , @erichkeane >> wrote: >> >>> This doesn't cau

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__referen

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb added a comment. In D135341#3841126 , @ldionne wrote: > Interesting, I actually wasn't even aware of that C++23 feature in the > library. FWIW, libc++ will be more than happy to use that builtin instead of > trying to figure it out inside the libra

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added a subscriber: jwakely. cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb added inline comments. Comment at: clang/include/clang/Basic/TokenKinds.def:528 +TYPE_TRAIT_1(__is_nothrow_copy_constructible, IsNothrowCopyConstructible, KEYCXX) +TYPE_TRAIT_1(__is_trivially_copy_constructible, IsTriviallyCopyConstructible, KEYCXX) TYPE_TRAIT_2(__referen

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`

cjdb updated this revision to Diff 466088. cjdb added a comment. Gets `__reference_constructs_from_temporary` correct. Still WIP for the latter. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files: cl

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

cjdb updated this revision to Diff 466314. cjdb marked 4 inline comments as done. cjdb added a comment. applies requested changes, adds documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135175/new/ https://reviews.llvm.org/D135175 Files:

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb updated this revision to Diff 466315. cjdb marked 5 inline comments as done. cjdb added a comment. applies feedback, rebases, adds documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135177/new/ https://reviews.llvm.org/D135177 Files:

[PATCH] D135339: [clang] makes `__is_destructible` KEYALL instead of KEYMS

cjdb updated this revision to Diff 466316. cjdb retitled this revision from "[clang] makes `__is_destructible` KEYCXX instead of KEYMS" to "[clang] makes `__is_destructible` KEYALL instead of KEYMS". cjdb edited the summary of this revision. cjdb added a comment. applies feedback, rebases Repo

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 466318. cjdb retitled this revision from "[clang] adds `__reference_constructs_from_temporary` and `__reference_converts_from_temporary`" to "[clang] adds `__reference_constructs_from_temporary`". cjdb added a comment. discards work on `__reference_converts_fr

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticCommonKinds.td:397 +def err_reserved_identifier_for_future_use : Error< + "%0 is a compiler-reserved identifier for a future feature">; } erichkeane wrote: > I don't think we should dia

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

cjdb added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1071 REVERTIBLE_TYPE_TRAIT(__is_base_of); + REVERTIBLE_TYPE_TRAIT(__is_bounded_array); REVERTIBLE_TYPE_TRAIT(__is_class); erichkeane wrote: > Can you just put thi

[PATCH] D135175: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbd3f48eefc11: [clang] adds `__is_bounded_array` and `__is_unbounded_array` as builtins (authored by cjdb). Repository: rG LLVM Github Monorepo CH

[PATCH] D135177: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa089defa24dd: [clang] adds `__is_scoped_enum`, `__is_nullptr`, and `__is_referenceable` (authored by cjdb). Repository: rG LLVM Github Monorepo C

[PATCH] D135339: [clang] makes `__is_destructible` KEYALL instead of KEYMS

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG14e64cb8d594: [clang] makes `__is_destructible` KEYALL instead of KEYMS (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added a subscriber: arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The [Improving Clang's Diagnostics R

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

cjdb updated this revision to Diff 467283. cjdb added a comment. undoes an unnessecary change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135820/new/ https://reviews.llvm.org/D135820 Files: clang/include/clang/Basic/Diagnostic.td clang/inclu

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. @LegalizeAdulthood @njames93 is there anything actionable that's left for this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/new/ https://reviews.llvm.org/D128372 ___

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

cjdb added a comment. LGTM, thanks for fixing! Please be sure to have your commit message have `Fixes #59517` instead of a link to the issue, as this will close the bug upon merging. Comment at: clang-tools-extra/test/clang-tidy/checkers/bugprone/standalone-empty.cpp:586-590

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Excellent, let's wait for @denik's feedback before merging, but this LGTM. Thank you for the patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added a comment. Thanks for working on this! Needs a bit of work, but we should be able to get this in very soon methinks. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7006 +def warn_typecheck_comparison_of_function_pointers : Warning< + "comparison of fu

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< cjdb wrote: > It's v

[PATCH] D141310: [clang] add -Wcompare-function-pointers

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:7007 + "comparison of function pointers (%0 and %1)">, + InGroup, DefaultIgnore; def warn_typecheck_ordered_comparison_of_function_pointers : Warning< aaron.ballman wrote:

[PATCH] D142423: [clang-tidy] Fix segfault in bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG716469b6139a: [clang-tidy] Fix segfault in bugprone-standalone-empty (authored by denik, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 492234. cjdb retitled this revision from "[clang] teaches Clang the special ADL rules for functions in std::ranges" to "adds `__disable_adl` attribute". cjdb edited the summary of this revision. cjdb added a comment. - updates patch so that it meets what Aaron a

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:12934-12936 +// else if (!CandidateSet.empty() && CandidateSet.begin()->FoundDecl->hasAttr()) { +// return; +// } This and below need to be deleted. Repository: rG LLVM Git

[PATCH] D129951: adds `__disable_adl` attribute

cjdb updated this revision to Diff 492296. cjdb marked 6 inline comments as done. cjdb added a comment. responds to feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 Files: clang/include/clang/AS

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/AttrDocs.td:542 If a statement is marked ``nomerge`` and contains call expressions, those call -expressions inside the statement will not be merged during optimization. This +expressions inside the statement will

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping @aaron.ballman @rsmith Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D129951: adds `__disable_adl` attribute

cjdb added a comment. Ping @aaron.ballman Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129951/new/ https://reviews.llvm.org/D129951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D139570: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8effeb44f4a8: Add -Wreturn-local-addr, GCC alias for -Wreturn-stack-address (authored by adriandole, committed by cjdb). Repository: rG LLVM Githu

[PATCH] D141107: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty

This revision was automatically updated to reflect the committed changes. Closed by commit rG7910ee7d8c6d: [clang-tidy] don't warn when returning the result for bugprone-standalone-empty (authored by v1nh1shungry, committed by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf21187eb2d94: [clang][tablegen] adds human documentation to `WarningOption` (authored by cjdb). Changed prior to commit: https://reviews.llvm.org/

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added inline comments. Comment at: clang/lib/Parse/ParseExpr.cpp:1750 +#undef TRANSFORM_TYPE_TRAIT_DEF +if (NextToken().is(tok::less)) { + Tok.setKind(tok::identifier); rsmith wrote: > Here you're checking for `trait<` and treating it as an identifi

[PATCH] D109701: [clang] Emit SARIF Diagnostics: Create `clang::SarifDocumentWriter` interface

cjdb added a subscriber: abrahamcd. cjdb added a comment. I think this CL (which is quite large) might be worth just getting the functionality in, and deferring the in-tree usage to a second CL. That second CL probably should just lift the existing diagnostics so that they're in the message com

[PATCH] D128368: added clear check functionality

cjdb added a comment. A great start, thanks! I understand this CL to have been sent out a few minutes in advance, so as a note to other reviewers: maybe check back in in ~20 minutes please? Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:52-55 +

[PATCH] D128372: Clang-Tidy Empty Check

cjdb added a comment. A great start, thanks! Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:51-57 +auto Methods = MemberCall->getRecordDecl()->methods(); +auto Clear = llvm::find_if(Methods, [](const CXXMethodDecl *F) { + return F->getDe

[PATCH] D128372: Clang-Tidy Empty Check

cjdb added a comment. In D128372#3602881 , @tschuett wrote: > Just for reference: > https://reviews.llvm.org/D128267 Ack. I still think this CL is useful, given that not every library will have `[[nodiscard]]`, and because it can suggest appropriate alt

[PATCH] D128372: Clang-Tidy Empty Check

cjdb added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StandaloneEmptyCheck.cpp:61 + "ignoring the result of 'empty()', did you mean 'clear()'? "); + Builder << FixItHint::CreateReplacement(ReplacementRange, "clear"); +} -

[PATCH] D116203: [clang] adds unary type transformations as compiler built-ins

cjdb added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:5863 // FIXME: derive from "Target" ? - return WCharTy; + return IntTy; } rsmith wrote: > This change seems surprising. Can you explain what's going on here? Motivated by `__make_signed(wc

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added a project: All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Prints a list of all the warnings that Clang offers. Repository: rG LLVM Github

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. I haven't added a test because I'm not sure how we can reasonably test this without keeping a file that holds all the warnings and using FileCheck. I'm okay with that, but want to make sure it's the best thing to do. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3550848 , @MaskRay wrote: > FYI `diagtool tree` dumps the diagnostics. You can even provide -W options > and observe the differences. Is `diagtool tree` something that users widely know about? Repository: rG LLVM Git

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3551312 , @tschuett wrote: > Would a JSON dump help you for your tools? Do you think a JSON dump would be more appropriate? I was just going for something not unlike `--help` here. Repository: rG LLVM Github Monorepo

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb created this revision. cjdb added a reviewer: aaron.ballman. Herald added subscribers: usaxena95, arphaman. Herald added a project: All. cjdb requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Building on D126796

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3551834 , @tschuett wrote: > In D126796#3551781 , @cjdb wrote: > >> In D126796#3551312 , @tschuett >> wrote: >> >>> Would a JSON dump hel

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. In D126796#3551288 , @aaron.ballman wrote: > In D126796#3551280 , @MaskRay wrote: > >> In D126796#3551261 , @cjdb wrote: >> >>> In D126796#3550848 <

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb updated this revision to Diff 433823. cjdb added a comment. Herald added subscribers: sstefan1, mgrang, aheejin. Herald added a reviewer: jdoerfert. - renames flag to `-print-diagnostic-options` - adds test - adds logic to get as many options to be visible as possible I'm very unhappy with t

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added a comment. Okay, I understand why `-W` isn't being printed now, but the missing ones are still a bit baffling. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 ___ cfe-commits mailing list

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb updated this revision to Diff 433901. cjdb added a comment. - simplifies code - minimises test to only a handful of cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/Dia

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb added a comment. In D126832#3553569 , @aaron.ballman wrote: > Can you post some examples of the output from this option so we can see what > the end results look like more easily? Right now this doesn't do anything at all, except feed the document

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb updated this revision to Diff 435223. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126796/new/ https://reviews.llvm.org/D126796 Files: clang/include/clang/Driver/Options.td clang/lib/Basic/DiagnosticIDs.cpp clang/lib/Driver/Driver.cpp clang/test/Driver/print-diagnostic-opti

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

cjdb added inline comments. Comment at: clang/include/clang/Driver/Options.td:829 def Xoffload_linker : JoinedAndSeparate<["-"], "Xoffload-linker">, - HelpText<"Pass to the offload linkers or the ones idenfied by -">, + HelpText<"Pass to the offload linkers or the ones ide

[PATCH] D126796: [clang][driver] adds `-print-diagnostics`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG288c1bff96fc: [clang][driver] adds `-print-diagnostics` (authored by cjdb). Changed prior to commit: https://reviews.llvm.org/D126796?vs=435223&id

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb updated this revision to Diff 435255. cjdb marked 2 inline comments as done. cjdb added a comment. applies feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126832/new/ https://reviews.llvm.org/D126832 Files: clang/include/clang/Basic/

[PATCH] D126832: [clang][tablegen] adds human documentation to `WarningOption`

cjdb added a comment. In D126832#3567035 , @aaron.ballman wrote: > In D126832#3554816 , @cjdb wrote: > >> In D126832#3553569 , >> @aaron.ballman wrote: >> >>> Can you po

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

cjdb accepted this revision. cjdb added a comment. If there aren't any concerns from others, then LGTM! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D154366/new/ https://reviews.llvm.org/D154366 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D155610: [Clang][ExprConstant] Print integer instead of character on static assertion failure

cjdb added a comment. I think Tom's suggestion about using escapes and UCNs is great. I have no real opinion on whether the numeric values is the one that's parenthesised. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155610/new/ https://reviews.l

[PATCH] D155549: [clang] adds `conceptDecl` as an ASTMatcher

cjdb updated this revision to Diff 542706. cjdb edited the summary of this revision. cjdb added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. just trying to get CI close to green :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D155549: [clang] adds `conceptDecl` as an ASTMatcher

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG38e1c597033d: [clang] adds `conceptDecl` as an ASTMatcher (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:5690-5691 +def warn_unknown_ext : Warning<"Unknown extension kind: %0">; +def warn_cxx11_ext : Warning<"%0 is a C++11 extension">, +InGroup; +def warn_cxx14_ext : Warning<"%0 is a C++14 e

[PATCH] D155064: [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

cjdb added inline comments. Comment at: clang/test/SemaCXX/warn-constant-evaluated-constexpr.cpp:38 constexpr int fn5() { - if constexpr (__builtin_is_constant_evaluated()) // expected-warning {{'__builtin_is_constant_evaluated' will always evaluate to 'true' in a manifestly

[PATCH] D158006: [Clang][WIP]Experimental implementation of data member packs in dependent context.

cjdb added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3292 + std::string NewFieldName = + PackedField->getName().str() + "@" + std::to_string(Arg); + PackedField->setDeclName(&Context.Idents.get(NewFieldName)); -

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

cjdb added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:5930-5931 break; +case DeclaratorContext::Member: + // Expand for packed data members. case DeclaratorContext::TemplateParam: dblaikie wrote: > Perhaps a few more words here

[PATCH] D156546: [Clang][WIP]Experimental implementation of data member packs declarations

cjdb added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:3270-3339 +// Instantiate packed data members. +if (FieldDecl *Field = dyn_cast(Member); +Field && isa(Field->getType().getTypePtr())) { + QualType PatternType = Field->getType

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added a comment. In D135341#4126101 , @erichkeane wrote: > On the fence about the diagnostic at all, but definitely should not be doing > string magic to make it quoted. Otherwise this is a LGTM. Whoops, missed this comment. I'll be addressing yo

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556488. cjdb added a comment. responds to feedback: - removes diagnostic - adds documentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files: clang/docs/Langua

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added a comment. In D135341#4643712 , @erichkeane wrote: > Is the changes to cxx_status.html still relevant/current? Yeah. > Also, did we ever figure out what GCC did for a builtin here? Do they have > one yet? If not, have we encouraged them t

[PATCH] D135341: [clang] adds `__reference_constructs_from_temporary`

cjdb added a comment. Oh, I shouldn't have so much green in the status, whoops! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 ___ cfe-commits mailing list cfe

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556497. cjdb retitled this revision from "[clang] adds `__reference_constructs_from_temporary`" to "adds `__reference_constructs_from_temporary`". cjdb edited the summary of this revision. cjdb added a comment. Corrects cxx_status.html, which accidentally dupli

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556499. cjdb added a comment. I somehow made cxx_status.html worse in the previous commit, not better Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files: clang/docs

[PATCH] D135238: [clang] adds copy-constructible type-trait builtins

cjdb updated this revision to Diff 556500. cjdb added a comment. runs 'arc diff `git merge-base HEAD origin` --update D135238 ' to try and get CI happy Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135238/new/ htt

[PATCH] D135341: adds `__reference_constructs_from_temporary`

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1bfeb6bcc62: adds `__reference_constructs_from_temporary` (author

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb added a comment. Sorry, I had read @erichkeane's LGTM and taken that as actually approved. Would you like me to revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 __

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556609. cjdb marked 3 inline comments as done. cjdb added a comment. - responds to @cor3ntin's feedback - updates commit message to include `[clang]` tag and also indicate this is a revert Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:33 #include "clang/Basic/TypeTraits.h" +#include "clang/Basic/TokenKinds.h" #include "clang/Lex/Preprocessor.h" cor3ntin wrote: > Superfluous change Nice catch! Repository: rG LLVM Githu

[PATCH] D129538: [clang] adds prototype for being able to alternate diagnostic formats

cjdb abandoned this revision. cjdb added a comment. Abandoning since this design is obsolete. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129538/new/ https://reviews.llvm.org/D129538 ___ cfe-commits ma

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb added inline comments. Comment at: clang/lib/Sema/SemaExprCXX.cpp:5515 + QualType UPtr = S.BuiltinAddPointer(S.BuiltinRemoveReference(U, UnaryTransformType::RemoveCVRef, {}), {}); + return EvaluateBinaryTypeTrait(S, TypeTrait::BTT_IsConvertibleTo, UPtr, TPtr, RPa

[PATCH] D135341: adds `__reference_constructs_from_temporary`

cjdb updated this revision to Diff 556693. cjdb marked an inline comment as done. cjdb added a comment. partially reverts change and fixes typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135341/new/ https://reviews.llvm.org/D135341 Files: cla

[PATCH] D135341: adds `__reference_constructs_from_temporary`

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f3b0b417143: [clang] adds `__reference_constructs_from_temporary` (authored by cjdb). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D154366: [clang][ExprConstant] Print template arguments when describing stack frame

cjdb added a subscriber: dblaikie. cjdb added a comment. Generally in favour of this, but I wonder if we ought to have a way of suppressing it when the specialisation is known and ends up being a gargantuan name (this is a discussion, not an action item). cc @dblaikie Repository: rG LLVM Git

[PATCH] D153359: [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. Yep! Thanks for working on this :-) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153359/new/ https://reviews.llvm.org/D153359 ___ cfe-commits

[PATCH] D153623: [clang][Sema] Add fixit for scoped enum format error

cjdb added a comment. Sorry, forgot to come back and LGTM, but it did indeed LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153623/new/ https://reviews.llvm.org/D153623 ___ cfe-commits mailing list

[PATCH] D151575: [clang][diagnostics] Always show include stacks on top-level diagnostics

cjdb added a comment. In D151575#4607047 , @aaron.ballman wrote: > I am wrestling with this one because I think the status quo is unfortunate > (we silently drop relevant information in ways the user may not immediately > understand) but I think always

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4606513 , @aaron.ballman wrote: > In D157572#4604595 , @philnik wrote: > >> In D157572#4604482 , >> @aaron.ballman wrote: >> This a

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4613622 , @aaron.ballman wrote: > In D157572#4612141 , @cjdb wrote: > >> I don't dislike it, but I am a bit concerned about misuse being noisy. > > So you're concerned that a libr

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. In D157572#4617504 , @aaron.ballman wrote: > In D157572#4614561 , @cjdb wrote: > >> In D157572#4613622 , >> @aaron.ballman wrote: >> >>> In D157572

[PATCH] D157572: [clang] Add `[[clang::library_extension]]` attribute

cjdb added a comment. Started a thread: https://discourse.llvm.org/t/exposing-the-diagnostic-engine-to-c/73092 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157572/new/ https://reviews.llvm.org/D157572

[PATCH] D135820: [clang-tblgen] renames Diagnostic.Text to Diagnostic.Summary

This revision was automatically updated to reflect the committed changes. Closed by commit rGeb3f7880a272: [clang-tblgen][NFC] renames Diagnostic.Text to Diagnostic.Summary (authored by cjdb). Changed prior to commit: https://reviews.llvm.org/D135820?vs=467283&id=476793#toc Repository: rG LL

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

cjdb accepted this revision. cjdb added a comment. This revision is now accepted and ready to land. LGTM. Thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138603/new/ https://reviews.llvm.org/D138603 __

[PATCH] D138603: [Clang] Implement LWG3823 for __is_aggregate

cjdb added inline comments. Comment at: clang/test/SemaCXX/type-traits.cpp:556 static_assert(__is_aggregate(EmptyArMB), ""); static_assert(!__is_aggregate(void), ""); static_assert(!__is_aggregate(const volatile void), ""); shafik wrote: > Should this be

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb created this revision. cjdb added reviewers: aaron.ballman, erichkeane, shafik. Herald added subscribers: carlosgalvezp, kadircet, arphaman. Herald added a reviewer: njames93. Herald added projects: Flang, All. cjdb requested review of this revision. Herald added subscribers: cfe-commits, libc

[PATCH] D128372: [Clang-Tidy] Empty Check

cjdb added a comment. @njames93 if you don't have any further concerns, I am going to merge this on Friday afternoon, as it will have been four months since there has been a maintainer's input. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128372/

[PATCH] D138939: [WIP][clang] adds a way to provide user-oriented reasons

cjdb added a comment. I don't understand why `test_demangle.pass.cpp` was considered too big to upload. Here's the diff: diff --git a/libcxxabi/test/test_demangle.pass.cpp b/libcxxabi/test/test_demangle.pass.cpp index dce8e6c3..9da6fb7d2ad9 100644 --- a/libcxxabi/test/test_demangle.pa

<    1   2   3   4   5   >