[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

Dinistro added inline comments. Comment at: llvm/unittests/ProfileData/InstrProfTest.cpp:1359 auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile)); ASSERT_TRUE(InstrProfError::take(RawProfileReaderOrErr.takeError()) == instrprof_error::

[PATCH] D149361: [profiling] Improve error message for raw profile header mismatches

Dinistro added inline comments. Comment at: llvm/unittests/ProfileData/InstrProfTest.cpp:1359 auto RawProfileReaderOrErr = InstrProfReader::create(std::move(RawProfile)); ASSERT_TRUE(InstrProfError::take(RawProfileReaderOrErr.takeError()) == instrprof_error::

[PATCH] D152802: [clang-tidy] Fix crash in `modernize-use-default-member-init`

Dinistro added a comment. Thanks for fixing this issue. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152802/new/ https://reviews.llvm.org/D152802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. I'm getting a linking error by some of the files changed in this revision. ld.lld: error: undefined symbol: vtable for clang::tidy::performance::NoexceptDestructorCheck >>> referenced by NoexceptDestructorCheck.h:26 (/home/christianu/repos/llvm-project/clang-tools-

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. In D148697#4421268 , @PiotrZSL wrote: > In D148697#4420359 , @Dinistro > wrote: > >> I'm getting a linking error by some of the files changed in this revision. > > You shouldn't because

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. In D148697#4421420 , @PiotrZSL wrote: > In D148697#4421339 , @Dinistro > wrote: > >> In D148697#4421268 , @PiotrZSL >> wrote: >> >>> In D148697

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. In D148697#4421643 , @PiotrZSL wrote: > @Dinistro It compiles & links with clang 16 also (shared libs). So I'm unable > to reproduce. I used the following command to build: cmake -S/home/christianu/repos/llvm-project/llvm -

[PATCH] D148697: [clang-tidy] Add more checks for functions which should be noexcept

Dinistro added a comment. Sorry for the noise. I didn't pull in between the different runs and was still on the broken version. Thanks for fixing this issue :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148697/new/ https://reviews.llvm.org/D148