[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-11 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler closed https://github.com/llvm/llvm-project/pull/112525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-10 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/112525 >From 83104569563db9a6716aae941edf9fe15493081a Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 23 May 2023 13:16:38 +0200 Subject: [PATCH] [clangd] Consider expression statements in ExtractVariabl

[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-10 Thread Christian Kandeler via cfe-commits
ckandeler wrote: Rebased. https://github.com/llvm/llvm-project/pull/112525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-10 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/112525 >From 9993b1488c26b8296d3bb46b83e9c2f133d76c2d Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Tue, 23 May 2023 13:16:38 +0200 Subject: [PATCH] [clangd] Consider expression statements in ExtractVariabl

[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-10 Thread Christian Kandeler via cfe-commits
ckandeler wrote: Addressed review comments. https://github.com/llvm/llvm-project/pull/112525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Consider expression statements in ExtractVariable tweak (PR #112525)

2024-12-10 Thread Christian Kandeler via cfe-commits
@@ -423,8 +427,6 @@ bool childExprIsStmt(const Stmt *Outer, const Expr *Inner) { if (!Outer || !Inner) return false; // Exclude the most common places where an expr can appear but be unused. - if (llvm::isa(Outer)) ckandeler wrote: I made the comment

[clang-tools-extra] [clangd] Store full decl/def range with symbol locations (PR #118102)

2024-12-05 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/118102 >From 188cbf1a7d3e83c0a558550351a373c1c3475d4e Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Wed, 27 Nov 2024 13:47:32 +0100 Subject: [PATCH] [clangd] Store full decl/def range with symbol locations

[clang] [clang-tools-extra] [clangd] Support operators new and delete in textDocument/references (PR #135620)

2025-04-22 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler closed https://github.com/llvm/llvm-project/pull/135620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Support operators new and delete in textDocument/references (PR #135620)

2025-04-14 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler created https://github.com/llvm/llvm-project/pull/135620 None >From 6fb676cec0f907658339708ee17a9e73ea8b2cc7 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Mon, 14 Apr 2025 14:13:41 +0200 Subject: [PATCH] [clangd] Support operators new and delete in textD

[clang-tools-extra] [clangd] Store full decl/def range with symbol locations (PR #118102)

2025-02-17 Thread Christian Kandeler via cfe-commits
ckandeler wrote: *sigh* I want to use clangd for this purpose because it produces correct results particularly with non-trivial constructs, so I'm afraid that using such textual heuristics would kill that advantage. I'll give it a try, though. https://github.com/llvm/llvm-project/pull/118102

[clang-tools-extra] [clangd] Store full decl/def range with symbol locations (PR #118102)

2025-02-18 Thread Christian Kandeler via cfe-commits
ckandeler wrote: > 2. A more general musing: it would be nice to have a mechanism for storing > additional information for a subset of symbols, without incurring the > overhead of increasing the representation size of **every** symbol. If we had > such a mechanism, we could cut down the overhe

[clang-tools-extra] [clangd] Find better insertion locations in DefineOutline tweak (PR #128164)

2025-02-27 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/128164 >From cca5b5a1d7f50ea7923fdc1ba63764c0b787ef8d Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Mon, 25 Nov 2024 17:39:21 +0100 Subject: [PATCH] [clangd] Find better insertion locations in DefineOutline

[clang-tools-extra] [clangd] Store full decl/def range with symbol locations (PR #118102)

2025-02-17 Thread Christian Kandeler via cfe-commits
ckandeler wrote: My main motivation is to get DefineOutline out of the proof-of-concept stage where it just dumps the definition somewhere in the same namespace. Usually, the location that best fits the user's expectation is next to the definition of an adjacent declaration. If that adjacent d

[clang-tools-extra] [clangd] Find better insertion locations in DefineOutline tweak (PR #128164)

2025-02-21 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler created https://github.com/llvm/llvm-project/pull/128164 If possible, put the definition next to the definition of an adjacent declaration. For example: struct S { void f^oo1() {} void foo2(); void f^oo3() {} }; // S::foo1() goes here void S::foo2() {} // S:

[clang-tools-extra] [clangd] Find better insertion locations in DefineOutline tweak (PR #128164)

2025-02-25 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/128164 >From de493ea09fc685ef700bd618eeb847c631a18995 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Mon, 25 Nov 2024 17:39:21 +0100 Subject: [PATCH] [clangd] Find better insertion locations in DefineOutline

[clang-tools-extra] [clangd] Find better insertion locations in DefineOutline tweak (PR #128164)

2025-02-25 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/128164 >From da6a6e8fccf99f595d38e7ff6785b605a38401db Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Mon, 25 Nov 2024 17:39:21 +0100 Subject: [PATCH] [clangd] Find better insertion locations in DefineOutline

[clang-tools-extra] [clangd] Find better insertion locations in DefineOutline tweak (PR #128164)

2025-02-25 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/128164 >From 615acbb28d8f03f4553d18680ade62144ed44a09 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Mon, 25 Nov 2024 17:39:21 +0100 Subject: [PATCH] [clangd] Find better insertion locations in DefineOutline

[clang-tools-extra] [clangd] Find better insertion locations in DefineOutline tweak (PR #128164)

2025-02-25 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/128164 >From dcecc6815af5e71b6a9fed380c859c957961240a Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Mon, 25 Nov 2024 17:39:21 +0100 Subject: [PATCH] [clangd] Find better insertion locations in DefineOutline

<    1   2