[PATCH] D41746: Make std::get_temporary_buffer respect overaligned types when possible

ckennelly created this revision. ckennelly added reviewers: EricWF, mclow.lists. Repository: rCXX libc++ https://reviews.llvm.org/D41746 Files: include/memory test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp Index: test/std/utilities/memory/temporary.buffer/overaligned.pas

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

This revision was automatically updated to reflect the committed changes. Closed by commit rC350934: Implementation Feature Test Macros for P0722R3 (authored by ckennelly, committed by ). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://reviews.llv

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. Conditioning off of C++17 (or part C++11 and part C++17) seems reasonable, although we may want consistency with libc++ (discussion on https://reviews.llvm.org/D55840). Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. In D55741#1361040 , @jwakely wrote: > I'd be happy to restrict this to > C++17 only (which is automatically the > case when using G++ because there's no `-fdestroying-delete` to enable it, > you only get it with `-std=c++2a`,

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly created this revision. ckennelly added a reviewer: rsmith. Herald added a subscriber: cfe-commits. P1353R0, adopted in San Diego, specified an implementation feature test macro for destroying delete (P0722R3). The implementation of the feature (https://reviews.llvm.org/rL315662) is not

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly updated this revision to Diff 178423. ckennelly added a comment. Added update to cxx_status.html for partial implementation of feature test macros adopted in San Diego CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://reviews.llvm.org/D55741 Files: lib/Front

[PATCH] D55741: Implementation Feature Test Macros for P0722R3

ckennelly added a comment. Yes, I need someone to commit for me. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55741/new/ https://reviews.llvm.org/D55741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

[PATCH] D92810: [clang-tidy] Recognize single character needles for absl::StrContains.

ckennelly created this revision. ckennelly added reviewers: EricWF, ymandel, hokein. Herald added a subscriber: xazax.hun. ckennelly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Commit fbdff6f3ae0b in the Abseil tree adds an overload for

[PATCH] D92810: [clang-tidy] Recognize single character needles for absl::StrContains.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG16622d535c02: [clang-tidy] Recognize single character needles for absl::StrContains. (authored by ckennelly). Repository: rG LLVM Github Monorepo

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d2c095e5a6b: [clang-tidy] Omit std::make_unique/make_shared for d

[PATCH] D92992: [clang-tidy] Add make_unique_for_overwrite/make_shared_for_overwrite check.

ckennelly created this revision. ckennelly added reviewers: hokein, njames93, alexfh, aaron.ballman. Herald added subscribers: xazax.hun, mgorny. ckennelly requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. std::make_unique_for_overwrite and s

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 302731. ckennelly added a comment. Expand tests to cover value and default initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-tools-extra/c

[PATCH] D91009: Include std::basic_string_view in readability-redundant-string-init.

ckennelly created this revision. ckennelly added reviewers: EricWF, ymandel. Herald added a project: clang. Herald added a subscriber: cfe-commits. ckennelly requested review of this revision. std::string_view("") produces a string_view instance that compares equal to std::string_view(), but requi

[PATCH] D91015: Extend bugprone-string-constructor-check to std::string_view.

ckennelly created this revision. ckennelly added reviewers: EricWF, ymandel. Herald added a project: clang. Herald added a subscriber: cfe-commits. ckennelly requested review of this revision. This allows for matching the constructors std::string has in common with std::string_view. Repository:

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-make-shared.cpp:51 // CHECK-FIXES: std::shared_ptr P1 = std::make_shared(); + std::shared_ptr P2 = std::shared_ptr(new int); steveire wrote: > I'm a bit confu

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. njames93: Ping Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize-make-shared.cpp:51 // CHECK-FIXES: std::shared_ptr P1 = std::make_shared(); + std::shared_ptr P2 = std::shared_ptr(new int); steveire wrote: > cken

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly updated this revision to Diff 304034. ckennelly added a comment. Applied feedback from review - reduced test cases to verify functionality - updated release notes - updated docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91009/new/ ht

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly added a comment. In D91009#2381590 , @njames93 wrote: > You don't really need to duplicate every single `std::string` test. Just > enough so that it detects it, kind of like `::out::TestString`. Also can you > update the docs and release notes

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly updated this revision to Diff 305649. ckennelly added a comment. Applied review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91015/new/ https://reviews.llvm.org/D91015 Files: clang-tools-extra/clang-tidy/bugprone/StringConstr

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:65 + const auto hasStringCtorName = + hasAnyNameStdString(removeNamespaces(StringNames)); + aaron.ballman wrote: > It took me a while to realize th

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91009/new/ https://reviews.llvm.org/D91009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

ckennelly updated this revision to Diff 305652. ckennelly marked 5 inline comments as done. ckennelly added a comment. Applied review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91015/new/ https://reviews.llvm.org/D91015 Files: clang-

[PATCH] D91015: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG25f5406f0875: [clang-tidy] Extend bugprone-string-constructor-check to std::string_view. (authored by ckennelly). Repository: rG LLVM Github Monor

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 306302. ckennelly added a comment. Added option to allow rewrites for default to value initialization Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-t

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly updated this revision to Diff 306591. ckennelly marked 3 inline comments as done. ckennelly added a comment. Applied review feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91009/new/ https://reviews.llvm.org/D91009 Files: clang-

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

ckennelly added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/readability-redundant-string-init.cpp:65 +void fview() { + std::string_view a = ""; aaron.ballman wrote: > Can you also add tests for `wstring_view`? > > Also, perhaps on

[PATCH] D91009: [clang-tidy] Include std::basic_string_view in readability-redundant-string-init.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4f9b5d442a2: [clang-tidy] Include std::basic_string_view in readability-redundant-string… (authored by ckennelly). Repository: rG LLVM Github Mon

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 309934. ckennelly added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-tools-extra/clang-tidy/modernize/MakeSmartPtrCheck.cpp clan

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 309936. ckennelly edited the summary of this revision. ckennelly added a comment. updating commit message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: cla

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2436639 , @hokein wrote: > thanks, I think this patch is good, feel free to land it (and sorry for the > delay). > > As @lebedev.ri commented, would be nice to mention the motivation of the > change (`make_shared_for_

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. @njames93: Any additional comments? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly created this revision. ckennelly added reviewers: EricWF, ymandel. Herald added subscribers: cfe-commits, xazax.hun. Herald added a project: clang. ckennelly requested review of this revision. This extends the check for default initialization in arrays added in 547f89d6070 to include sca

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 301648. ckennelly added a comment. Apply feedback from ymandel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Files: clang-tools-extra/clang-tidy/modernize/MakeSma

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly updated this revision to Diff 301649. ckennelly marked 3 inline comments as done. ckennelly added a comment. Apply review feedback from njames93 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 Fil

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2362118 , @njames93 wrote: > IIUC, this is handling the case where `Ptr.reset(new int)` which is different > to `Ptr.reset(new int())` because the former doesn't initialise the int while > the latter default(zero) ini

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. In D90392#2362327 , @lebedev.ri wrote: > In D90392#2362308 , @ckennelly wrote: > >> In D90392#2362118 , @njames93 wrote: >> >>> IIUC, this is handl

[PATCH] D90392: [clang-tidy] Omit std::make_unique/make_shared for default initialization.

ckennelly added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90392/new/ https://reviews.llvm.org/D90392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D41746: Make std::get_temporary_buffer respect overaligned types when possible

ckennelly updated this revision to Diff 129698. Repository: rCXX libc++ https://reviews.llvm.org/D41746 Files: include/memory test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp Index: test/std/utilities/memory/temporary.buffer/overaligned.pass.cpp

[PATCH] D41746: Make std::get_temporary_buffer respect overaligned types when possible

ckennelly marked 2 inline comments as done. ckennelly added a comment. In https://reviews.llvm.org/D41746#973941, @EricWF wrote: > This LGTM minus nits. > > Is there a LWG issue or paper that specifies this change? or is it just a > general bug fix? This is just a general bug fix. =

[PATCH] D41746: Make std::get_temporary_buffer respect overaligned types when possible

ckennelly marked an inline comment as done. ckennelly added a comment. I don't have commit access, so can this be committed to trunk? Repository: rCXX libc++ https://reviews.llvm.org/D41746 ___ cfe-commits mailing list cfe-commits@lists.llvm.org