[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. Overall, we could eventually upgrade code in three stages, each a separate reusable check. 1. enable_if -> requires clauses 2. replace the non `_v` templates to the `_v` variants `is_same` -> `is_same_v` or the equivalent concept `same_as` 3. replace requires clause on

[PATCH] D141892: Implement modernize-use-constraints

ccotter added a comment. In D141892#4058273 , @njames93 wrote: > In D141892#4057722 , @ccotter wrote: > >> 2. replace the non `_v` templates to the `_v` variants `is_same` -> >> `is_same_v` or the equivalent conc

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 490028. ccotter marked an inline comment as done. ccotter added a comment. - fix merge Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clan

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter marked 2 inline comments as done. ccotter added a comment. Would someone with merge access mind committing this? I double checked and this diff can be applied on the latest upstream/main. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 490701. ccotter added a comment. - cleanup comments, docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/Avo

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. > What happens with code like this > > void foo(bar&& B) { > std::move(B); > } I raised https://github.com/isocpp/CppCoreGuidelines/issues/2026 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://revi

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491124. ccotter added a comment. - Fix windows, fix crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMak

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491125. ccotter added a comment. - Fix windows, fix crash Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMak

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 491127. ccotter added a comment. - Add fno-delayed-template-parsing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CM

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 491165. ccotter added a comment. - Use nested namespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/Avoid

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidCaptureDefaultWhenCapturingThisCheck.cpp:19 + +namespace clang { +namespace tidy { carlosgalvezp wrote: > We recently switche

[PATCH] D141133: [clang-tidy] Implement CppCoreGuideline F.54

ccotter updated this revision to Diff 491171. ccotter marked an inline comment as done. ccotter added a comment. - Use nested namespace in header too; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141133/new/ https://reviews.llvm.org/D141133 Files

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491186. ccotter added a comment. - Properly handle forwarding references Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-tidy/cppcore

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 491197. ccotter added a comment. - Allow move of any expr containing the parameter Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-tools-extra/clang-ti

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 491201. ccotter added a comment. - Use nested namespaces Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.tx

[PATCH] D141463: [clang-tidy] Improve rename_check.py

ccotter marked an inline comment as done. ccotter added a comment. Thanks for reviewing and merging my recent changes! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141463/new/ https://reviews.llvm.org/D141463 _

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter marked an inline comment as done. ccotter added a comment. @PiotrZSL would you mind landing this for me? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter updated this revision to Diff 549777. ccotter marked 9 inline comments as done. ccotter added a comment. - Fix docs, handle C++20 simplification Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239 Fil

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectEnableIfCheck.cpp:61-62 + + FixItHint TypenameHint = + FixItHint::CreateInsertion(ElaboratedLoc->getBeginLoc(), "typename "); + FixItHint Ty

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter marked an inline comment as done. ccotter added a comment. > Do you have plans to also detect the bugprone scenario described in the Notes > here? I didn't have plans in this review, or in the immediate future after. I did name this check broadly as "bugprone-incorrect-enable-if," so I

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545331. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-e

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 545332. ccotter added a comment. - Fix ReleaseNotes again Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.t

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter updated this revision to Diff 545379. ccotter added a comment. - Fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-too

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter updated this revision to Diff 545450. ccotter marked 5 inline comments as done. ccotter added a comment. - Improve docs, check for null/empty Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files:

[PATCH] D141892: [clang-tidy] Implement modernize-use-constraints

ccotter marked an inline comment as done. ccotter added a comment. > 3. What about boost enable_if ? Support it, or restrict check to std only. > 4. What about enable_if used as an function argument ? Support it, or add > some info to documentation that such construction is not supported. I adde

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 546991. ccotter marked an inline comment as done. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang-tid

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 546996. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp clang-t

[PATCH] D154999: [clang-tidy] Add bugprone-std-forward-type-mismatch check

ccotter added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/bugprone/std-forward-type-mismatch.rst:18 +doSomething(std::forward(base)); // Incorrect usage +doSomething(static_cast(base)); // Suggested usage + } How confident are

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, shchenz, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber:

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547061. ccotter added a comment. - Specify version Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLists.

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 547433. ccotter marked 2 inline comments as done. ccotter added a comment. - Feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 547483. ccotter added a comment. - Check nullptr - Add tests for rbegin/crbegin Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 3 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/modernize/loop-convert-basic.cpp:484 } // Tests to verify the proper use of auto where the init variable type and the PiotrZSL wro

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked an inline comment as done. ccotter added a comment. All done on my end - @PiotrZSL if you're good would you mind landing this for me? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 __

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/NoSuspendWithLockCheck.cpp:24-26 + hasType(recordDecl(hasAnyName( + "::std::unique_lock", "::std::lock_guard", +

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547573. ccotter marked 5 inline comments as done. ccotter added a comment. - Add tests, do not inspect instantiations, add option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.o

[PATCH] D157057: [clang-tidy] Implement cppcoreguidelines CP.52

ccotter updated this revision to Diff 547585. ccotter added a comment. - Use matchesAnyListedName and fix windows build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157057/new/ https://reviews.llvm.org/D157057 Files: clang-tools-extra/clang-tid

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, xazax.hun. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Detects incorre

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter updated this revision to Diff 547599. ccotter added a comment. - Edited wrong file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157239/new/ https://reviews.llvm.org/D157239 Files: clang-tools-extra/clang-tidy/bugprone/BugproneTidyModule

[PATCH] D157239: [clang-tidy] Implement bugprone-incorrect-enable-if

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/IncorrectEnableIfCheck.cpp:67 + diag(EnableIf->getBeginLoc(), "incorrect std::enable_if usage detected; use " +"'typename std::enable_if<...>::type'") + << Typen

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. @PiotrZSL - checking back, do you plan to revisit this change soon (I think there are some pending feedback and you planned some changes)? I'd like to see this in change merged in. Let me know if I can help. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Great, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144347/new/ https://reviews.llvm.org/D144347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D158665: [clang-tidy] Improve cppcoreguidelines-avoid-reference-coroutine-parameters check

ccotter accepted this revision. ccotter added a comment. This revision is now accepted and ready to land. Thanks! Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/AvoidReferenceCoroutineParametersCheck.cpp:20 + Finder->addMatcher( + functionDecl(unless(paramete

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 506339. ccotter added a comment. Herald added a subscriber: PiotrZSL. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/mod

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter added inline comments. Herald added a subscriber: PiotrZSL. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588 +: ClangTidyCheck(Name, Context), + IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", +

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 508345. ccotter marked 4 inline comments as done. ccotter added a comment. - Add more cases to swapped params - Change message, add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://r

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter marked an inline comment as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/StringConstructorCheck.cpp:70-74 + const auto CharExpr = expr(anyOf( + ignoringParenImpCasts(characterLiteral()), + declRefExpr(hasDeclaration(v

[PATCH] D146888: [clang-tidy] Flag std::forward on non-forwarding references

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commit

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 508351. ccotter marked 8 inline comments as done. ccotter added a comment. - feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang

[PATCH] D146888: [clang-tidy] Flag std::forward on non-forwarding references

ccotter abandoned this revision. ccotter added a comment. Indeed - sorry i missed that Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146888/new/ https://reviews.llvm.org/D146888 ___ cfe-commits mailing l

[PATCH] D144347: [clang-tidy] Add readability-forward-usage check

ccotter added a comment. Is it worth adding a cppcoreguidelines alias (ES.56)? Comment at: clang-tools-extra/docs/clang-tidy/checks/readability/forward-usage.rst:98 + +.. option:: DisableTypeMismatchSuggestion + Curious what others thing but I think the tool s

[PATCH] D146921: Reviewers:

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Reposit

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508441. ccotter marked 4 inline comments as done. ccotter retitled this revision from "[clang-tidy] Implement cppcoreguidelines F.19 " to "[clang-tidy] Implement cppcoreguidelines F.19". ccotter added a comment. - add tests, simplify expr, handle unevaluated

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardingReferenceParamNotForwardedCheck.cpp:83-84 + + if (!Param) +return; + PiotrZSL wrote: > I thing this can never happen Another review suggested I check the mat

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508450. ccotter added a comment. - add tests, simplify expr, handle unevaluated exprs - formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tool

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 508451. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp clang-

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 508452. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-e

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter created this revision. Herald added subscribers: PiotrZSL, carlosgalvezp, kbarton, xazax.hun, nemanjai. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commit

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter added a comment. I didn't update the release notes since this check is new. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929 ___ cfe-commits mailing list

[PATCH] D58818: [clang-tidy] added cppcoreguidelines-use-raii-locks check

ccotter added a comment. Herald added subscribers: mgehre, shchenz. Herald added projects: clang-tools-extra, All. bump - I know this is really old, but @lewmpk do you plan on finishing up the last remaining comments? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://rev

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 508474. ccotter added a comment. - fix bad rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 508476. ccotter added a comment. - alpha Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp clang-

[PATCH] D137205: [clang-tidy] Add performance-unnecessary-copy-on-last-use check

ccotter added a comment. Herald added a subscriber: PiotrZSL. @Febbe - checking in. is this still on your radar? I would love to see this merged! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137205/new/ https://reviews.llvm.org/D137205 _

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter updated this revision to Diff 508865. ccotter added a comment. - move to utility file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929 Files: clang-tools-extra/clang-tidy/bugprone/UseAfterMoveChe

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ForwardingReferenceParamNotForwardedCheck.cpp:20 + +AST_MATCHER(Expr, hasUnevaluatedContext) { + if (isa(Node) || isa(Node)) PiotrZSL wrote: > move this matcher to some ut

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 508869. ccotter marked 2 inline comments as done. ccotter added a comment. - fix docs, fix test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-e

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added a comment. In D140760#4222989 , @PiotrZSL wrote: > What about classes that doesn't have begin/end method but got cbegin/cend ? > I thing there is open issue for that. Should we handle that in a separate patch? Repository: rG LLVM Githu

[PATCH] D146929: [clang-tidy] Ignore unevaluated exprs in rvalue-reference-param-not-moved

ccotter added a comment. @PiotrZSL if you're happy with these changes, would you mind committing them for me? "Chris Cotter " Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146929/new/ https://reviews.llvm.org/D146929 _

[PATCH] D147062: [clang-tidy] Add option to ignore capture default by reference in cppcoreguidelines-avoid-capture-default-when-capturing-this

ccotter accepted this revision. ccotter added a comment. This revision is now accepted and ready to land. If https://github.com/isocpp/CppCoreGuidelines/issues/2060 is accepted to only consider `[=]`, then I assume we'd want to change the default value of IgnoreCaptureDefaultByReference to be tr

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. @dblaikie thoughts? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added a comment. Friendly ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:318 +// The returned Expr* is nullptr if any of the assumptions are not met. +static const std::tuple +getContainerExpr(const Expr *Call) { carlosgalvezp wrote:

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 500598. ccotter marked 2 inline comments as done. ccotter added a comment. - Address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-ext

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 500601. ccotter added a comment. - fix bad merge in ReleaseNotes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopC

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 500642. ccotter marked an inline comment as done. ccotter added a comment. - Add negative test case - Fix logic to only consider std:: or ADL calls Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ http

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 3 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:175 +callee(cxxMethodDecl(EndNameMatcher))), + callExpr(argumentCountIs(1), callee(functionDecl(EndNameMat

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter marked 2 inline comments as done. ccotter added a comment. I'm not sure about the false positive case. Range based for loops reduce to calls to ADL lookup begin/end (or member function calls to begin/end). I believe the same "false positive" argument (whatever that may be) would apply i

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 500645. ccotter added a comment. - Add more cases to swapped params Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files: clang-tools-extra/clang-tidy/bugprone/Str

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added a comment. Bump - anyone else have any thoughts here? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 500647. ccotter added a comment. - Add comment regarding std::begin/end Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/moderniz

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/LoopConvertCheck.cpp:142 +///e = end(container); it != e; ++it) { ... } +/// for (containerType::iterator it = std::begin(container), +///e = std::end(container); it != e; ++it) {

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter updated this revision to Diff 500648. ccotter marked an inline comment as done. ccotter added a comment. - More clean option name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 Files: clang-too

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter marked an inline comment as done. ccotter added a comment. Thanks for the name suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 ___ cfe-commit

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. I don't have commit access - could you use `Author: Chris Cotter `? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-co

[PATCH] D143877: [NFC] [clang] Forward forwarding reference

ccotter added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143877/new/ https://reviews.llvm.org/D143877 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 500995. ccotter added a comment. - update release note, rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 Files: clang/include/clang/ASTMatchers/ASTMatchers.h

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter updated this revision to Diff 500996. ccotter added a comment. fix bad 'arc diff' Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 Files: clang/docs/ReleaseNotes.rst clang/include/clang/ASTMatc

[PATCH] D140794: [ASTMatcher] Add coroutineBodyStmt matcher

ccotter added a comment. Thanks both! Assuming this passes build, would one of you mind committing this for me? `Chris Cotter ` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140794/new/ https://reviews.llvm.org/D140794 ___

[PATCH] D145138: Implement FixIts for C arrays

ccotter created this revision. Herald added a subscriber: carlosgalvezp. Herald added a reviewer: njames93. Herald added a project: All. ccotter requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Add FixIts for C arrays declared in

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:532 + // TODO: How can I get FileCheck to accept '{{}}' as a non-regex match? + FixIts.push_back(FixItHint::CreateInsertion(InitRange.getBegin(), "{ ")); + FixIt

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 501733. ccotter added a comment. - Add more tests for whitespace Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang-tidy/modernize/Avoid

[PATCH] D140760: [clang-tidy] Support begin/end free functions in modernize-loop-convert

ccotter updated this revision to Diff 501734. ccotter added a comment. - Add another test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140760/new/ https://reviews.llvm.org/D140760 Files: clang-tools-extra/clang-tidy/modernize/LoopConvertCh

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. bump. I never heard back on the case where using an rvalue reference for a big pod type as opposed to const ref. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 _

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter updated this revision to Diff 502040. ccotter added a comment. - Add option doc, remove auto Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145138/new/ https://reviews.llvm.org/D145138 Files: clang-tools-extra/clang-tidy/modernize/AvoidCA

[PATCH] D145138: [clang-tidy] Implement FixIts for C arrays

ccotter marked 2 inline comments as done. ccotter added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp:588 +: ClangTidyCheck(Name, Context), + IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", +

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Yes, I'm ready for this to be committed. I don't have commit access, but if anyone could commit this on my behalf with `Chris Cotter ` that'd be great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://rev

[PATCH] D141569: [clang-tidy] Implement CppCoreGuideline F.18

ccotter added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141569/new/ https://reviews.llvm.org/D141569 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D146921: [clang-tidy] Implement cppcoreguidelines F.19

ccotter updated this revision to Diff 509539. ccotter added a comment. - Use common function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146921/new/ https://reviews.llvm.org/D146921 Files: clang-tools-extra/clang-tidy/cppcoreguidelines/CMakeLi

[PATCH] D143971: [clang-tidy] Flag more buggy string constructor cases

ccotter updated this revision to Diff 509541. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143971/new/ https://reviews.llvm.org/D143971 Files: clang-tools-extra/clang-tidy/modernize/AvoidCArraysCheck.cpp clang-

[PATCH] D141892: Implement modernize-use-constraints

ccotter updated this revision to Diff 509543. ccotter added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141892/new/ https://reviews.llvm.org/D141892 Files: clang-tools-extra/clang-tidy/modernize/CMakeLists.txt clang-tools-e

<    1   2   3   >