[clang] 400d326 - [HLSL] Cleanup support for `this` as an l-value

Author: Chris Bieneman Date: 2023-09-05T19:38:50-05:00 New Revision: 400d3261a0da56554aee8e5a2fbc27eade9d05db URL: https://github.com/llvm/llvm-project/commit/400d3261a0da56554aee8e5a2fbc27eade9d05db DIFF: https://github.com/llvm/llvm-project/commit/400d3261a0da56554aee8e5a2fbc27eade9d05db.diff

[clang] 326c135 - [NFC] [CMake] Cleanup clang tool dependencies

Author: Chris Bieneman Date: 2023-03-10T10:56:07-06:00 New Revision: 326c13531af32df8361cb4c98d2cc1355b0f8c48 URL: https://github.com/llvm/llvm-project/commit/326c13531af32df8361cb4c98d2cc1355b0f8c48 DIFF: https://github.com/llvm/llvm-project/commit/326c13531af32df8361cb4c98d2cc1355b0f8c48.diff

[clang] c380156 - [NFC] [CMake] Add misssing dependencies

Author: Chris Bieneman Date: 2023-03-10T17:13:09-06:00 New Revision: c3801568ef2b7f923f9116f72a6b0bb382bcaa41 URL: https://github.com/llvm/llvm-project/commit/c3801568ef2b7f923f9116f72a6b0bb382bcaa41 DIFF: https://github.com/llvm/llvm-project/commit/c3801568ef2b7f923f9116f72a6b0bb382bcaa41.diff

Re: [libcxx] r286789 - Add check-cxx-abilist target when supported.

(+Bogner, I think he originally added this) My understanding is that we only did this copy step if you are building with a clang that isn't installed so that the non-installed clang could find these headers. I'm pretty sure compiler-rt finds libcxx via the sources, not the build directory. I'

[libcxx] r289963 - [CMake] Put headers relative to clang

Author: cbieneman Date: Fri Dec 16 11:30:51 2016 New Revision: 289963 URL: http://llvm.org/viewvc/llvm-project?rev=289963&view=rev Log: [CMake] Put headers relative to clang When libcxx isn't building with an installed LLVM we copy the libcxx headers into the LLVM build directory so that a clang

[libcxx] r290052 - [CMake] Fix issue reported on sanitizer bots

Author: cbieneman Date: Sat Dec 17 15:28:24 2016 New Revision: 290052 URL: http://llvm.org/viewvc/llvm-project?rev=290052&view=rev Log: [CMake] Fix issue reported on sanitizer bots This should resolve an issue reported on the commit thread that impacted sanitizer bots. Modified: libcxx/trun

Re: [libcxx] r289963 - [CMake] Put headers relative to clang

CXX_USING_INSTALLED_LLVM. >> >> HandleOutOfTreeLLVM.cmake defines LLVM_BINARY_DIR only when >> LIBCXX_USING_INSTALLED_LLVM. Is it supposed to come from the user >> cmake arguments? >> >> This broke sanitizer tests on Linux (check-tsan, check-msan). See >> add_custom_libcxx()

[PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

beanz created this revision. beanz added reviewers: ddunbar, bob.wilson. beanz added a subscriber: cfe-commits. The eprintf library was added before the general OS X builtins library existed as a place to store one builtin function. Since we have for several years had an actual mandated builtin

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

beanz updated this revision to Diff 68102. beanz added a comment. Herald added a subscriber: mehdi_amini. Updating code comment and removing unneeded braces. I'm going to sit on this for a bit before committing in case anyone comes up with a reason this is a bad idea. https://reviews.llvm.org/

Re: [PATCH] D23531: [Darwin] Stop linking libclang_rt.eprintf.a

Today, the code includes the eprintf archive on all linker invocations for i386 that include the OS X archive. Removing the eprintf library from the command and including eprintf only for i386 in the OS X archive should be equivalent to what we have today. -Chris > On Aug 16, 2016, at 8:27 AM,

r278850 - [CMake] Fixing typo in Info.plist generation

Author: cbieneman Date: Tue Aug 16 15:49:49 2016 New Revision: 278850 URL: http://llvm.org/viewvc/llvm-project?rev=278850&view=rev Log: [CMake] Fixing typo in Info.plist generation This is causing an error in the generation of the clang info plist. Modified: cfe/trunk/tools/driver/Info.plist

r278849 - [CMake] [Apple Cache] Set CLANG_VENDOR_UTI for Apple builds

Author: cbieneman Date: Tue Aug 16 15:44:58 2016 New Revision: 278849 URL: http://llvm.org/viewvc/llvm-project?rev=278849&view=rev Log: [CMake] [Apple Cache] Set CLANG_VENDOR_UTI for Apple builds This is just a minor update to the Apple packaging configuration. Modified: cfe/trunk/cmake/cach

r278862 - [CMake] Workflow improvements to PGO generation

Author: cbieneman Date: Tue Aug 16 17:16:29 2016 New Revision: 278862 URL: http://llvm.org/viewvc/llvm-project?rev=278862&view=rev Log: [CMake] Workflow improvements to PGO generation This patch adds a few new convenience options used by the PGO CMake cache to setup options on bootstrap stages.

r278987 - [CMake] Adding toolchain targets to PGO and Apple CMake caches

Author: cbieneman Date: Wed Aug 17 16:51:38 2016 New Revision: 278987 URL: http://llvm.org/viewvc/llvm-project?rev=278987&view=rev Log: [CMake] Adding toolchain targets to PGO and Apple CMake caches The Xcode toolchain targets are useful on OS X hosts because you can construct and install multip

r278988 - [Darwin] Stop linking libclang_rt.eprintf.a

Author: cbieneman Date: Wed Aug 17 16:54:30 2016 New Revision: 278988 URL: http://llvm.org/viewvc/llvm-project?rev=278988&view=rev Log: [Darwin] Stop linking libclang_rt.eprintf.a Summary: The eprintf library was added before the general OS X builtins library existed as a place to store one buil

[PATCH] D23696: [CMake] Get libcxx building under LLVM/runtimes

beanz created this revision. beanz added a reviewer: EricWF. beanz added a subscriber: cfe-commits. The new LLVM runtimes build directory requires some basic conventions across the runtime projects. These changes make libcxx build under the runtimes subdirectory. The general idea of the changes

[libcxx] r279151 - [CMake] Get libcxx building under LLVM/runtimes

Author: cbieneman Date: Thu Aug 18 16:31:51 2016 New Revision: 279151 URL: http://llvm.org/viewvc/llvm-project?rev=279151&view=rev Log: [CMake] Get libcxx building under LLVM/runtimes Summary: The new LLVM runtimes build directory requires some basic conventions across the runtime projects. Thes

[PATCH] D23699: [CMake] Be more consistent about naming targets and components

beanz created this revision. beanz added a reviewer: EricWF. beanz added a subscriber: cfe-commits. The point of this patch is to have a consistent convention for naming build, check and install targets so that the targets can be constructed from the project name. This change renames a bunch of

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Patch LGTM. https://reviews.llvm.org/D23744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/

r279559 - driver: Support checking for rlimits via cmake (when bootstrapping)

Author: cbieneman Date: Tue Aug 23 15:07:07 2016 New Revision: 279559 URL: http://llvm.org/viewvc/llvm-project?rev=279559&view=rev Log: driver: Support checking for rlimits via cmake (when bootstrapping) Summary: Add a cmake check for sys/resource.h and replace the __has_include() check with its

Re: [PATCH] D23744: driver: Support checking for rlimits via cmake (when bootstrapping)

Landed in r279559! Thanks, -Chris > On Aug 23, 2016, at 10:44 AM, Michał Górny wrote: > > mgorny added a comment. > > Thanks for the review. Could you commit it for me, please? I don't have > commit access. > > > https://reviews.llvm.org/D23744 > > >

r279673 - [Order Files] On Darwin use DTrace's oneshot probe

Author: cbieneman Date: Wed Aug 24 17:09:46 2016 New Revision: 279673 URL: http://llvm.org/viewvc/llvm-project?rev=279673&view=rev Log: [Order Files] On Darwin use DTrace's oneshot probe The oneshot probe only gets executed the first time the probe is hit in the process. For order file generatio

Re: [PATCH] D23699: [CMake] Be more consistent about naming targets and components

beanz added a comment. Ping. https://reviews.llvm.org/D23699 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] r279675 - [CMake] Be more consistent about naming targets and components

Author: cbieneman Date: Wed Aug 24 17:17:06 2016 New Revision: 279675 URL: http://llvm.org/viewvc/llvm-project?rev=279675&view=rev Log: [CMake] Be more consistent about naming targets and components Summary: The point of this patch is to have a consistent convention for naming build, check and i

Re: [libcxxabi] r279938 - [CMake] Be more consistent about naming targets and components in libc++abi

Many thanks for taking this on. I haven’t yet had a chance to look into libcxxabi, but it is next on my list of projects to get into the runtimes subdirectory. Thanks! -Chris > On Aug 28, 2016, at 11:28 AM, Eric Fiselier via cfe-commits > wrote: > > Author: ericwf > Date: Sun Aug 28 13:28:51

Re: [libcxxabi] r279938 - [CMake] Be more consistent about naming targets and components in libc++abi

And I just noticed your other commit, which I think means you did all the work there. Many thanks! -Chris > On Aug 29, 2016, at 11:09 AM, Chris Bieneman via cfe-commits > wrote: > > Many thanks for taking this on. I haven’t yet had a chance to look into > libcxxabi, but i

[PATCH] D24007: [CMake] Use -std=c++11 if supported

beanz created this revision. beanz added a reviewer: EricWF. beanz added a subscriber: cfe-commits. This patch adds a check for if -std=c++11 is a supported flag, and adds it to CMAKE_CXX_FLAGS if it is supported. https://reviews.llvm.org/D24007 Files: cmake/config-ix.cmake Index: cmake/conf

[libcxxabi] r280021 - [CMake] Use -std=c++11 if supported

Author: cbieneman Date: Mon Aug 29 17:12:21 2016 New Revision: 280021 URL: http://llvm.org/viewvc/llvm-project?rev=280021&view=rev Log: [CMake] Use -std=c++11 if supported Summary: This patch adds a check for if -std=c++11 is a supported flag, and adds it to CMAKE_CXX_FLAGS if it is supported.

[libcxxabi] r280023 - [CMake] Trying to fix the bots I broke

Author: cbieneman Date: Mon Aug 29 17:26:00 2016 New Revision: 280023 URL: http://llvm.org/viewvc/llvm-project?rev=280023&view=rev Log: [CMake] Trying to fix the bots I broke See: http://lab.llvm.org:8011/builders/libcxx-libcxxabi-x86_64-linux-ubuntu-cxx1z/builds/981/steps/build.libcxxabi/logs/s

[PATCH] D24015: [CMake] Copy headers relative to LLVM_BINARY_DIR

beanz created this revision. beanz added reviewers: bogner, EricWF. beanz added a subscriber: cfe-commits. This copy phase is only needed for in-tree builds, so we should be copying to the LLVM build directory's include dir instead of the sub-project include dir. https://reviews.llvm.org/D24015

[libcxx] r280108 - [CMake] Copy headers relative to LLVM_BINARY_DIR

Author: cbieneman Date: Tue Aug 30 11:51:34 2016 New Revision: 280108 URL: http://llvm.org/viewvc/llvm-project?rev=280108&view=rev Log: [CMake] Copy headers relative to LLVM_BINARY_DIR Summary: This copy phase is only needed for in-tree builds, so we should be copying to the LLVM build directory

[PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz created this revision. beanz added reviewers: zaks.anna, kubabrecka, bogner. beanz added a subscriber: cfe-commits. The -nodefaultlibs and -nostdlib flags suppress all the runtime libraries that the driver puts on the link line. This feels wrong. If a user specifies "-fsanitize=" I think i

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

so. "No default libs" should mean "no default libs", not "some > default libs". Maybe you're using an alternate sanitizer lib or something, > hence usage of that flag. > > Thank you, > > Filipe > > On Tuesday, 30 August 2016, Chris Bienem

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. I've sent out an additional patch that adds a warning for using -nostdlibs and -fsanitize (See: https://reviews.llvm.org/D24091) https://reviews.llvm.org/D24048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://l

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz added a comment. I can change the implementation, but that quickly falls into target specific driver code. It results in adding the warning in one place for Darwin, another for FreeBSD, and a third for GNUTools. If that is the preferred way I can work up that patch. https://reviews.llvm

[PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz created this revision. beanz added reviewers: bogner, zaks.anna, bruno, filcab. beanz added a subscriber: cfe-commits. Herald added a subscriber: emaste. The FreeBSD and GNUTools drivers support -fsanitize arguments bypassing -nodefaultlibs. With https://reviews.llvm.org/D24048, Darwin will

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. @zaks.anna, the driver behind this is supporting building libcxx with sanitizers. The drivers for GNUTools and FreeBSD already support this workflow. I have updates to the test in https://reviews.llvm.org/D24091, which also cover this code. I'll push the updated test shor

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz updated this revision to Diff 69910. beanz added a comment. Updates based on bruno's feedback. https://reviews.llvm.org/D24091 Files: include/clang/Basic/DiagnosticDriverKinds.td include/clang/Driver/SanitizerArgs.h lib/Driver/Driver.cpp lib/Driver/ToolChains.cpp lib/Driver/Tool

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

beanz updated this revision to Diff 69926. beanz added a comment. - Changed warning text based on feedback from bruno - Made the warning apply to -nostdlib as well as -nodefaultlibs based on offline discussion with Anna https://reviews.llvm.org/D24091 Files: include/clang/Basic/DiagnosticDri

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a subscriber: filcab. beanz added a comment. To address both @bogner and @gribozavr... The problem is we're wildly inconsistent on what -nodefaultlibs and -nostdlibs mean. For example, on GNUTools or FreeBSD -fsanitize *always* adds sanitizer libraries regardless of the presence of

r280394 - [CMake] Properly connecting Compiler-RT check and test-depends

Author: cbieneman Date: Thu Sep 1 13:28:49 2016 New Revision: 280394 URL: http://llvm.org/viewvc/llvm-project?rev=280394&view=rev Log: [CMake] Properly connecting Compiler-RT check and test-depends This correctly connects compiler-rt-test-depends to test-depends and check-compiler-rt to check-al

Re: [PATCH] D24091: [Driver] Warn on -nodefaultlibs and -fsanitize

If we do add a warning, we probably need to make the warning more generic than this because it also applies to the Code coverage flags. -Chris > On Sep 1, 2016, at 11:29 AM, Bruno Cardoso Lopes > wrote: > > On Wed, Aug 31, 2016 at 11:00 PM, Justin Bogner > wrote

[libcxx] r280400 - [CMake] Don't copy headers on fully standalone

Author: cbieneman Date: Thu Sep 1 13:46:53 2016 New Revision: 280400 URL: http://llvm.org/viewvc/llvm-project?rev=280400&view=rev Log: [CMake] Don't copy headers on fully standalone In r280108 I tried to make the headers copy relative to LLVM_BINARY_DIR, and the intent was that it would only ha

[libcxx] r280406 - [CMake] NFC. Fixing spelling from r280400

Author: cbieneman Date: Thu Sep 1 14:46:02 2016 New Revision: 280406 URL: http://llvm.org/viewvc/llvm-project?rev=280406&view=rev Log: [CMake] NFC. Fixing spelling from r280400 Doh! Modified: libcxx/trunk/include/CMakeLists.txt Modified: libcxx/trunk/include/CMakeLists.txt URL: http://llv

[libcxx] r280407 - [CMake] NFC. Missed the other uses in r280406

Author: cbieneman Date: Thu Sep 1 14:47:39 2016 New Revision: 280407 URL: http://llvm.org/viewvc/llvm-project?rev=280407&view=rev Log: [CMake] NFC. Missed the other uses in r280406 Doh! Obviously need to slow down. Modified: libcxx/trunk/cmake/Modules/HandleOutOfTreeLLVM.cmake Modified: li

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. @zaks.anna, changing the build system to explicitly select which sanitizer runtime to use is more complicated than it might seem. The sanitizer runtime libraries are named differently by toolchain, so correctly selecting a library would involve either duplicating complica

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz updated this revision to Diff 70624. beanz added a comment. - Added new driver flag -flink-sanitizer-runtimes which forces linking sanitizer runtimes. Additional cleanup will be required to support the GNUTools and FreeBSD drivers as well as making the Darwin behavior more consistent. I w

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz updated this revision to Diff 70709. beanz added a comment. - Updated with FreeBSD and GNUTools support for -flink-sanitizer-runtimes https://reviews.llvm.org/D24048 Files: include/clang/Driver/Options.td lib/Driver/ToolChains.cpp lib/Driver/ToolChains.h lib/Driver/Tools.cpp tes

Re: [PATCH] D24048: [Driver] [Darwin] Add sanitizer libraries even if -nodefaultlibs is passed

beanz added a comment. There are basically two solutions being debated. Either make `-fsanitize=...` bypass `-nostdlib` `-nodefaultlibs` or support a flag that explicitly bypasses it. Personally I think the flag is probably the better way to go because it is more explicit, and has less implied

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. One comment below, otherwise LGTM. Comment at: cmake/Modules/CompilerRTUtils.cmake:200 @@ -199,5 +199,3 @@ string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT ${CON

Re: [PATCH] D24005: [compiler-rt cmake] Support overriding llvm-config query results

beanz added a comment. You cannot rename the variables that start with `LLVM_*`, but the variables without the leading `LLVM` can be renamed to whatever makes sense, or left as-is. I'm fine with either way. The variables starting with `LLVM_*` are effectively public interface to the build syst

r294207 - [CMake] Add CLANG_INCLUDE_DIRS to CMake exports

Author: cbieneman Date: Mon Feb 6 12:17:23 2017 New Revision: 294207 URL: http://llvm.org/viewvc/llvm-project?rev=294207&view=rev Log: [CMake] Add CLANG_INCLUDE_DIRS to CMake exports This patch adds setting CLANG_INCLUDE_DIRS in the generated CMake package configuration files. Modified: cf

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

Historically we have supported building libcxx without llvm-config available on the system. In all likelihood the bots didn't fail because the bots do have llvm-config because we usually require an llvm build or source checkout in order to build and run the tests since tests depend on lit and g

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

We have lots of duplicated functionality across the LLVM runtime libraries to continue supporting building them without LLVM sources or installations. Despite my history of being a strong advocate for the runtimes being used without LLVM, I don't really have a horse in this race anymore. Duncan

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

beanz added inline comments. Comment at: test/lit.cfg:109 +if not llvm_shlib_dir: +lit_config.fatal('No LLVM shlib dir set!') llvm_libs_dir = getattr(config, 'llvm_libs_dir', None) Should this really be fatal? It seems to me in many cases you mig

[PATCH] D26115: [test] Correctly include build llvm_shlib_dir in stand-alone builds

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! Comment at: test/lit.cfg:109 +if not llvm_shlib_dir: +lit_config.fatal('No LLVM shlib dir set!') llvm_libs_dir = getattr(config, 'llvm_libs_dir', None) -

[PATCH] D26654: [CMake] Add Fuchsia toolchain CMake cache files

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. This looks awesome! Since it depends on your other outstanding patches can you hold off committing until those land? Repository: rL LLVM https://reviews.llvm.org/D26654 __

[PATCH] D26571: Clean up layout of ASTMerge tests

beanz accepted this revision. beanz added a comment. LGTM! Thanks for doing this Sean! Repository: rL LLVM https://reviews.llvm.org/D26571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

beanz added a comment. On Darwin you don't want to set `DARWIN_LTO_LIBRARY` on the next stage if you're intending the next stage to use lld because that sets flags that aren't supported by lld. Repository: rL LLVM https://reviews.llvm.org/D26649 __

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

beanz accepted this revision. beanz added a comment. Yep. Can we maybe add an error to that effect? I really don't want the build system ignoring invalid configurations. Otherwise LGTM! Repository: rL LLVM https://reviews.llvm.org/D26649 ___ cf

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

beanz added a comment. Failing on `-DLLVM_ENABLE_LLD=ON` and `-DLLVM_ENABLE_LTO=ON` in LLVM seems fine to me. Repository: rL LLVM https://reviews.llvm.org/D26649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D26649: [CMake] Support lld with LTO bootstrap

beanz added a comment. Yep, LGTM. Thanks! Repository: rL LLVM https://reviews.llvm.org/D26649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r287366 - [CMake] Fixing variable names that were mistyped

Author: cbieneman Date: Fri Nov 18 13:20:39 2016 New Revision: 287366 URL: http://llvm.org/viewvc/llvm-project?rev=287366&view=rev Log: [CMake] Fixing variable names that were mistyped This is a silly bug that I'm sure I caused... Modified: cfe/trunk/tools/driver/CMakeLists.txt Modified: cf

r287407 - [CMake] clang depends on intrinsics_gen

Author: cbieneman Date: Fri Nov 18 17:31:16 2016 New Revision: 287407 URL: http://llvm.org/viewvc/llvm-project?rev=287407&view=rev Log: [CMake] clang depends on intrinsics_gen cc1_main.cpp has the following include chain: llvm/LinkAllPasses.h llvm/Analysis/AliasSetTracker.h llvm/Analysis/AliasAn

r287406 - [CMake] clang-offload-bundler depends on intrinsics_gen

Author: cbieneman Date: Fri Nov 18 17:31:14 2016 New Revision: 287406 URL: http://llvm.org/viewvc/llvm-project?rev=287406&view=rev Log: [CMake] clang-offload-bundler depends on intrinsics_gen ClangOffloadBundler.cpp has the following include chain: llvm/Bitcode/BitcodeWriter.h llvm/IR/ModuleSumm

r287463 - [CMake] Fixing clang standalone build

Author: cbieneman Date: Sat Nov 19 15:14:59 2016 New Revision: 287463 URL: http://llvm.org/viewvc/llvm-project?rev=287463&view=rev Log: [CMake] Fixing clang standalone build I broke this in r287406 and r287407. Modified: cfe/trunk/tools/clang-offload-bundler/CMakeLists.txt cfe/trunk/tool

Re: Fix two-stage build on windows using DistributionExample cmake cache

This patch LGTM! Thanks! -Chris > On May 11, 2017, at 3:13 AM, Matthew Larionov wrote: > > Chris, Hi! Could you please take a look at my patch? > Or advice someone who could. > > On Wed, May 3, 2017 at 8:28 PM, Matthew Larionov > wrote: > I've added a correct comp

Re: Fix two-stage build on windows using DistributionExample cmake cache

Normally I would be happy to, but I'm actually at the airport about to board a flight and won't have reliable internet access for at least the next 24 hours. Can someone else land this for Matthew? Matthew, if nobody responds in email, try hopping onto LLVM's IRC channel. Thanks, -Chris > On M

r284443 - [CMake] Add a few default passthrough variables for bootstrap builds

Author: cbieneman Date: Mon Oct 17 19:50:20 2016 New Revision: 284443 URL: http://llvm.org/viewvc/llvm-project?rev=284443&view=rev Log: [CMake] Add a few default passthrough variables for bootstrap builds This just passes through a few missing CMake variables for multi-stage builds. Modified:

[PATCH] D23745: [cmake] Update lit search to match the one in LLVM

beanz added a comment. Is there a bug you're trying to fix here? It seems to me that the existing behavior works correctly. I'm also pretty sure from the comment in https://reviews.llvm.org/D23743 that `llvm-lit` shouldn't be in the list. https://reviews.llvm.org/D23745

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

beanz added a comment. Looking more closely at this, there is a problem that I see. The clang runtime directory only supports building compiler-rt, and is going to be replaced by the llvm runtimes directory in the (hopefully near) future. Maybe a better way to go is to define `RUNTIMES_LIBDIR_S

[PATCH] D23745: [cmake] Update lit search to match the one in LLVM

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. Gotcha. LGTM! https://reviews.llvm.org/D23745 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D25093: [libcxx] [cmake] Allow testing against installed LLVM with no sources

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D25093 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

r284646 - [CMake] Support thin LTO in PGO CMake cache

Author: cbieneman Date: Wed Oct 19 16:12:04 2016 New Revision: 284646 URL: http://llvm.org/viewvc/llvm-project?rev=284646&view=rev Log: [CMake] Support thin LTO in PGO CMake cache This allows you to set PGO_INSTRUMENT_LTO=Thin and have it work correctly. Modified: cfe/trunk/cmake/caches/PGO.

r284648 - [CMake] Add clang-bootstrap-deps target

Author: cbieneman Date: Wed Oct 19 16:18:48 2016 New Revision: 284648 URL: http://llvm.org/viewvc/llvm-project?rev=284648&view=rev Log: [CMake] Add clang-bootstrap-deps target Having this target allows other parts of the build system to add to the bootstrap dependencies without needing to be def

[PATCH] D23752: cmake: Supporting overriding runtime libdir via CLANG_LIBDIR_SUFFIX

beanz added a comment. I think doing just the suffix is the right starting point. https://reviews.llvm.org/D23752 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r285206 - [CMake] Adding example distribution CMake cache files

Author: cbieneman Date: Wed Oct 26 10:41:38 2016 New Revision: 285206 URL: http://llvm.org/viewvc/llvm-project?rev=285206&view=rev Log: [CMake] Adding example distribution CMake cache files These cache file are provided as an example of how to set up simple multi-stage CMake builds. I have a bat

[PATCH] D23754: cmake: Add CLANG_GOLD_LIBDIR_SUFFIX to specify loc of LLVMgold.so

beanz added a comment. @mgorny, I don't think LLVMgold qualifies as a runtime in the traditional sense. It more closely aligns with the tools vended by LLVM even though it is a shared library not an executable. Runtime libraries are specifically libraries that products of clang are linked agai

[PATCH] D23752: [cmake] Respect LLVM_RUNTIMES_LIBDIR_SUFFIX

beanz added a comment. This looks like it is in the direction I would expect. Please let me know once the final patch is ready. Comment at: lib/Driver/Tools.cpp:2021 std::string Plugin = - ToolChain.getDriver().Dir + "/../lib" CLANG_LIBDIR_SUFFIX "/LLVMgold.so"; +

[PATCH] D24869: [cfe] [test] Fix detecting LLVM zlib support in stand-alone builds

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D24869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D26375: [libc++] Compare to libc++ source directory for out-of-source check

beanz added a comment. This patch doesn't make sense to me. In an in-tree build `CMAKE_SOURCE_DIR` would be the LLVM source directory which shouldn't match your `CMAKE_BINARY_DIR`. In an out-of-tree build `CMAKE_SOURCE_DIR` would match the libcxx sure directory, which shouldn't match `CMAKE_BI

r247436 - [CMake] Making the bootstrap-clear target always delete the boostrap build directories.

Author: cbieneman Date: Fri Sep 11 12:38:38 2015 New Revision: 247436 URL: http://llvm.org/viewvc/llvm-project?rev=247436&view=rev Log: [CMake] Making the bootstrap-clear target always delete the boostrap build directories. Modified: cfe/trunk/CMakeLists.txt Modified: cfe/trunk/CMakeLists.t

r247467 - [CMake] [Darwin] Add support for building bootstrap builds with -flto

Author: cbieneman Date: Fri Sep 11 15:42:57 2015 New Revision: 247467 URL: http://llvm.org/viewvc/llvm-project?rev=247467&view=rev Log: [CMake] [Darwin] Add support for building bootstrap builds with -flto When building with LTO the bootstrap builds need to depend on libLTO, llvm-ar, and llvm-ra

[PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

beanz created this revision. beanz added reviewers: chandlerc, echristo. beanz added a subscriber: cfe-commits. These CMake cache scripts are my first pass at replicating Apple's packaging logic from autoconf. They can be used on any Darwin machine to approximate an Apple Clang build. The inclu

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

beanz added a comment. I had considered putting it in the LLVM repo, but this stuff actually works on standalone clang builds too, so I felt it might be better here. -Chris http://reviews.llvm.org/D12817 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D12817: [CMake] Add cache scripts for Apple-style clang builds.

beanz added a comment. Standalone as in using the base system's LLVM installation. So you don't actually have to have an llvm checkout. There's goop in the root clang CMakeLists file to support building clang as the top-level CMake tool, and all this stuff should work in that context as well.

r247726 - [CMake] Add cache scripts for Apple-style clang builds.

Author: cbieneman Date: Tue Sep 15 16:52:42 2015 New Revision: 247726 URL: http://llvm.org/viewvc/llvm-project?rev=247726&view=rev Log: [CMake] Add cache scripts for Apple-style clang builds. Summary: These CMake cache scripts are my first pass at replicating Apple's packaging logic from autocon

r247912 - [CMake] Add install-clang target to install just the clang executable

Author: cbieneman Date: Thu Sep 17 13:30:20 2015 New Revision: 247912 URL: http://llvm.org/viewvc/llvm-project?rev=247912&view=rev Log: [CMake] Add install-clang target to install just the clang executable For the llvm-tools we're generating install-${tool} targets which are very useful. We shou

r248015 - [CMake] Refactoring and cleaning up clang symlink generation.

Author: cbieneman Date: Fri Sep 18 13:09:15 2015 New Revision: 248015 URL: http://llvm.org/viewvc/llvm-project?rev=248015&view=rev Log: [CMake] Refactoring and cleaning up clang symlink generation. Generation of clang symlinks now uses add_clang_symlink macro which uses add_llvm_symlink. Also th

r248016 - [CMake] Set CLANG_LINKS_TO_CREATE in Apple-stage2.cmake so that we create cc and c++ links.

Author: cbieneman Date: Fri Sep 18 13:11:18 2015 New Revision: 248016 URL: http://llvm.org/viewvc/llvm-project?rev=248016&view=rev Log: [CMake] Set CLANG_LINKS_TO_CREATE in Apple-stage2.cmake so that we create cc and c++ links. Modified: cfe/trunk/cmake/caches/Apple-stage2.cmake Modified: c

r248025 - Revert "[CMake] Refactoring and cleaning up clang symlink generation."

Author: cbieneman Date: Fri Sep 18 14:59:51 2015 New Revision: 248025 URL: http://llvm.org/viewvc/llvm-project?rev=248025&view=rev Log: Revert "[CMake] Refactoring and cleaning up clang symlink generation." This reverts commit r248015, because it broke bots. I'll revise and recommit. Added:

r248043 - [CMake] Refactoring and cleaning up clang symlink generation.

Author: cbieneman Date: Fri Sep 18 16:15:54 2015 New Revision: 248043 URL: http://llvm.org/viewvc/llvm-project?rev=248043&view=rev Log: [CMake] Refactoring and cleaning up clang symlink generation. Generation of clang symlinks now uses add_clang_symlink macro which uses add_llvm_symlink. Also th

[PATCH] D13113: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

beanz created this revision. beanz added reviewers: bogner, bob.wilson. beanz added a subscriber: cfe-commits. This corresponds to a patch to compiler-rt (D13112). Xcode 7 doesn't support targeting iOS5 and earlier. Instead of just dropping cc_kext_ios5, I've repurposed it to cc_kext_ios, and I'

Re: [PATCH] D13113: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

> On Sep 23, 2015, at 11:51 AM, Bob Wilson wrote: > > bob.wilson accepted this revision. > bob.wilson added a comment. > This revision is now accepted and ready to land. > > Good idea. The patch looks good. It will need to be coordinated with a change > to compiler_rt build cc_kext_ios.a, thou

Re: r248221 - Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE

Random question. Is there any reason to generate clang-cl if you’re not on Windows? It may make sense to move clang-cl under the if(WIN32). -Chris > On Sep 21, 2015, at 3:44 PM, Hans Wennborg via cfe-commits > wrote: > > Author: hans > Date: Mon Sep 21 17:44:57 2015 > New Revision: 248221 >

Re: r248221 - Add msbuild-bin/cl to CLANG_LINKS_TO_CREATE

ly only makes sense on > Windows. > > Cheers, > Hans > > On Wed, Sep 23, 2015 at 1:30 PM, Chris Bieneman via cfe-commits > wrote: >> Random question. Is there any reason to generate clang-cl if you’re not on >> Windows? >> >> It may make sense to move clan

r248442 - [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios

Author: cbieneman Date: Wed Sep 23 17:52:35 2015 New Revision: 248442 URL: http://llvm.org/viewvc/llvm-project?rev=248442&view=rev Log: [darwin] [builtins] Stop generating cc_kext_ios5 and move iOS architectures out of cc_kext into cc_kext_ios Summary: This corresponds to a patch to compiler-rt

[clang-tools-extra] r249048 - [CMake] Don't include the test directories if CLANG_INCLUDE_TESTS is Off

Author: cbieneman Date: Thu Oct 1 13:16:56 2015 New Revision: 249048 URL: http://llvm.org/viewvc/llvm-project?rev=249048&view=rev Log: [CMake] Don't include the test directories if CLANG_INCLUDE_TESTS is Off This matches Clang's behavior. Modified: clang-tools-extra/trunk/CMakeLists.txt Mo

r249115 - [CMake] Fixing clang bootstrap to use LLVM_RUNTIME_OUTPUT_INTDIR instead of CMAKE_BINARY_DIR.

Author: cbieneman Date: Thu Oct 1 19:56:53 2015 New Revision: 249115 URL: http://llvm.org/viewvc/llvm-project?rev=249115&view=rev Log: [CMake] Fixing clang bootstrap to use LLVM_RUNTIME_OUTPUT_INTDIR instead of CMAKE_BINARY_DIR. This should make bootstrap builds work with multi-configuration ge

Re: [PATCH] D13421: Fix makefile build on OSX when ARM targets are not enabled

beanz accepted this revision. beanz added a comment. This revision is now accepted and ready to land. LGTM. Thanks for catching this! -Chris Repository: rL LLVM http://reviews.llvm.org/D13421 ___ cfe-commits mailing list cfe-commits@lists.llvm.

<    1   2   3   4   5   >