Yep, looks like that fixed it. Sorry for the prolonged break.
-Chris
> On Apr 29, 2016, at 10:33 PM, Chris Bieneman wrote:
>
> Took a blind stab at fixing it in r268156.
>
> -Chris
>
>> On Apr 29, 2016, at 10:10 PM, Chris Bieneman via cfe-commits
>> mailto:cfe-
Author: cbieneman
Date: Mon May 2 17:38:06 2016
New Revision: 268319
URL: http://llvm.org/viewvc/llvm-project?rev=268319&view=rev
Log:
[CMake] Adding clang-headers to the Apple-stage2 distribution
This installs the clang headers as part of the install-distribution target.
Modified:
cfe/trun
Author: cbieneman
Date: Mon May 2 17:42:09 2016
New Revision: 268320
URL: http://llvm.org/viewvc/llvm-project?rev=268320&view=rev
Log:
[CMake] Install libcxx-headers as part of the Apple-stage2 distribution
This installs the clang headers as part of the install-distribution target.
Modified:
Author: cbieneman
Date: Mon May 2 17:43:23 2016
New Revision: 268322
URL: http://llvm.org/viewvc/llvm-project?rev=268322&view=rev
Log:
[CMake] Enable LIBCXX HEADERS in Apple-Stage2.cmake
This enables installing the libcxx headers.
Modified:
cfe/trunk/cmake/caches/Apple-stage2.cmake
Modifie
Author: cbieneman
Date: Tue May 3 11:54:20 2016
New Revision: 268401
URL: http://llvm.org/viewvc/llvm-project?rev=268401&view=rev
Log:
[CMake] Fix a copy-paste error
Based on post commit feedback from Eric Fiselier.
Modified:
libcxx/trunk/include/CMakeLists.txt
Modified: libcxx/trunk/inclu
Author: cbieneman
Date: Thu May 5 11:31:28 2016
New Revision: 268642
URL: http://llvm.org/viewvc/llvm-project?rev=268642&view=rev
Log:
[CMake][Apple-stage2] Don't link with -fno-pie
On Darwin the default is to build PIC and link PIE. We shouldn't need to
override that in the Apple Clang distrib
Author: cbieneman
Date: Thu May 5 16:08:41 2016
New Revision: 268685
URL: http://llvm.org/viewvc/llvm-project?rev=268685&view=rev
Log:
[CMake] Removing LLVM_ENABLE_TIMESTAMPS from the cache files
Since the option was removed in r268670, the cache scripts should stop
referring to it.
Modified:
Author: cbieneman
Date: Tue May 10 11:10:22 2016
New Revision: 269069
URL: http://llvm.org/viewvc/llvm-project?rev=269069&view=rev
Log:
[CMake] Pass LLVM_LIBDIR_SUFFIX into Compiler-RT
Not passing this causes Compiler-RT to fail to configure on multi-lib systems.
Modified:
cfe/trunk/runtime/
Author: cbieneman
Date: Tue Mar 29 12:51:08 2016
New Revision: 264757
URL: http://llvm.org/viewvc/llvm-project?rev=264757&view=rev
Log:
[Order Files] Fix order file usage
The CMake EXISTS operator needs to have the variable expanded. Not expanding
this was causing the if statement to always be f
Author: cbieneman
Date: Fri Apr 8 17:48:18 2016
New Revision: 265864
URL: http://llvm.org/viewvc/llvm-project?rev=265864&view=rev
Log:
[Perf-Training] Reworked workflow improvements for order-file generation
This is re-landing r260742. I've reworked the conditionals so that it only hits
when ta
Author: cbieneman
Date: Wed Apr 13 12:12:56 2016
New Revision: 266213
URL: http://llvm.org/viewvc/llvm-project?rev=266213&view=rev
Log:
[OrderFiles] Don't allow lit to run dtrace multithreaded
Dtrace is implemented to try and minimize performance impact on the process
being traced. This results
beanz created this revision.
beanz added a subscriber: cfe-commits.
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html
http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html
http://reviews.llvm.org/D20823
Files:
CMakeLists
beanz created this revision.
beanz added a subscriber: cfe-commits.
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html
http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html
http://reviews.llvm.org/D20828
Files:
CMakeLists
beanz created this revision.
beanz added a subscriber: cfe-commits.
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.html
http://lists.llvm.org/pipermail/llvm-dev/2016-May/100058.html
http://reviews.llvm.org/D20829
Files:
CMakeLists
Author: cbieneman
Date: Tue May 31 15:21:52 2016
New Revision: 271329
URL: http://llvm.org/viewvc/llvm-project?rev=271329&view=rev
Log:
[CMake] Update to requiring CMake 3.4.3
Summary:
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.h
Author: cbieneman
Date: Tue May 31 15:21:53 2016
New Revision: 271330
URL: http://llvm.org/viewvc/llvm-project?rev=271330&view=rev
Log:
[CMake] Update to requiring CMake 3.4.3
Summary:
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.h
Author: cbieneman
Date: Tue May 31 15:21:38 2016
New Revision: 271326
URL: http://llvm.org/viewvc/llvm-project?rev=271326&view=rev
Log:
[CMake] Update to requiring CMake 3.4.3
Summary:
This is as per the discussions on developer lists:
http://lists.llvm.org/pipermail/llvm-dev/2016-April/098780.h
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D20883
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: cbieneman
Date: Mon Jun 6 15:18:38 2016
New Revision: 271937
URL: http://llvm.org/viewvc/llvm-project?rev=271937&view=rev
Log:
[CMake] Fixing a typo in a CMake option
CMake defines are set with -D, forgetting the D doesn’t work.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Modified:
Author: cbieneman
Date: Wed Jun 8 17:20:28 2016
New Revision: 272212
URL: http://llvm.org/viewvc/llvm-project?rev=272212&view=rev
Log:
[CMake] Cleanup uses of USES_TERMINAL
Now that we are on CMake 3.4.3 we no longer need a version check around this.
This is the libcxx side of r272211.
Modifie
Author: cbieneman
Date: Wed Jun 8 17:20:43 2016
New Revision: 272213
URL: http://llvm.org/viewvc/llvm-project?rev=272213&view=rev
Log:
[CMake] Cleanup uses of USES_TERMINAL
Now that we are on CMake 3.4.3 we no longer need a version check around this.
This is the clang side of r272211.
Modified
Author: cbieneman
Date: Thu Jun 9 11:21:10 2016
New Revision: 272275
URL: http://llvm.org/viewvc/llvm-project?rev=272275&view=rev
Log:
[CMake] Fix an issue building out-of-tree introduced in r272200
The out-of-tree build needs to read LLVM_TOOLS_INSTALL_DIR out of
TOOLS_BINARY_DIR because LLVM_
Author: cbieneman
Date: Thu Jun 9 12:24:16 2016
New Revision: 272280
URL: http://llvm.org/viewvc/llvm-project?rev=272280&view=rev
Log:
Revert "[CMake] Fix an issue building out-of-tree introduced in r272200"
This reverts r272275. This actually wasn't the right way to fix the problem.
The correc
Author: cbieneman
Date: Thu Jun 9 16:29:55 2016
New Revision: 272312
URL: http://llvm.org/viewvc/llvm-project?rev=272312&view=rev
Log:
[CMake] Cleaning up CMake feature gating on 2.8.12
CMake 2.8.12 introduced interface libraries and some related policies. This
removes the conditional block bec
Author: cbieneman
Date: Thu Jun 9 17:38:40 2016
New Revision: 272323
URL: http://llvm.org/viewvc/llvm-project?rev=272323&view=rev
Log:
[CMake] Version is aways greater than 3
We don't need any checks for this code anymore. Since CMake version is always
greater than 3 we can always generate the
Author: cbieneman
Date: Thu Jun 9 17:38:42 2016
New Revision: 272324
URL: http://llvm.org/viewvc/llvm-project?rev=272324&view=rev
Log:
[CMake] Cleaning up CMake version checks in ExternalProject calls
Now that we're on CMake 3.4.3 all the ExternalProject features we use are
supported everywhere
Patch LGTM.
-Chris
> On Jun 17, 2016, at 12:36 PM, Rafael Espíndola
> wrote:
>
> This corresponds to binutils' --enable-x86-relax-relocations.
>
> Cheers,
> Rafael
> <0001-Add-a-ENABLE_X86_RELAX_RELOCATIONS-cmake-option.patch>
___
cfe-commits maili
Author: cbieneman
Date: Fri Jun 24 15:21:12 2016
New Revision: 273714
URL: http://llvm.org/viewvc/llvm-project?rev=273714&view=rev
Log:
[CMake] Remove CLANG_APPEND_VC_REV option
I added this option in r257827 to try and add compatibility with autoconf. At
the time I misunderstood the problem.
O
beanz requested changes to this revision.
beanz added a comment.
This revision now requires changes to proceed.
It looks like @samsonov had quite a few valid review comments that are still
unresolved. I know he hasn't been active lately, but I think those points
deserve discussion.
-Chris
htt
Author: cbieneman
Date: Tue Jun 28 11:32:48 2016
New Revision: 274031
URL: http://llvm.org/viewvc/llvm-project?rev=274031&view=rev
Log:
[CMake] [Apple Clang] Enable Compiler-RT tests on stage2 builds
We want to be able to run the compiler-rt tests on stage2 build configurations
in CI. This shoul
Author: cbieneman
Date: Tue Jun 28 12:00:49 2016
New Revision: 274035
URL: http://llvm.org/viewvc/llvm-project?rev=274035&view=rev
Log:
[CMake] Pass LLVM_LIT_ARGS into compiler-rt build.
If top-level lit args are specified, you probably want that in the sub-project
too.
Modified:
cfe/trunk/
Author: cbieneman
Date: Tue Jun 28 13:32:22 2016
New Revision: 274045
URL: http://llvm.org/viewvc/llvm-project?rev=274045&view=rev
Log:
[CMake] Connect check-compiler-rt to check-all
When using the LLVM_BUILD_EXTERNAL_COMPILER_RT option with
LLVM_ENABLE_TESTS we should also bind check-compiler-rt
Author: cbieneman
Date: Tue Jun 28 15:30:52 2016
New Revision: 274056
URL: http://llvm.org/viewvc/llvm-project?rev=274056&view=rev
Log:
[CMake] Adding USES_TERMINAL to a few additional custom targets
These are all long-running commands that should be in the ninja console job
pool.
Modified:
Author: cbieneman
Date: Fri Feb 26 15:04:41 2016
New Revision: 262065
URL: http://llvm.org/viewvc/llvm-project?rev=262065&view=rev
Log:
[CMake] Add BINUTILS_INCDIR to the default passthrough list for multi-stage
builds
This is needed to build the gold plugin in multi-stage builds.
Patch by Mike
Author: cbieneman
Date: Fri Feb 26 15:23:59 2016
New Revision: 262071
URL: http://llvm.org/viewvc/llvm-project?rev=262071&view=rev
Log:
[CMake] Only configure Native target in stage 1, configure all in other stages
This patch causes the 3-stage build pipeline to only build a host compiler in
the
Author: cbieneman
Date: Tue Mar 1 18:27:15 2016
New Revision: 262429
URL: http://llvm.org/viewvc/llvm-project?rev=262429&view=rev
Log:
[CMake] Add convenience target clang-test-depends to build test dependencies.
This is useful when paired with the distribution targets to build prerequisites
fo
beanz created this revision.
beanz added reviewers: zaks.anna, bogner.
beanz added a subscriber: cfe-commits.
isTarget*() calls are order-dependent. This is because iOS Sim *is* iOS. This
means checks for the simulator version of the platform must always be ahead of
checks for the embedded platf
beanz updated this revision to Diff 50055.
beanz added a comment.
Updates based on Anna's polite and restrained feedback that didn't include the
appropriate comment "Why don't you fix your TODO?" (I did fix it this time).
http://reviews.llvm.org/D17947
Files:
lib/Driver/ToolChains.cpp
test
beanz added inline comments.
Comment at: lib/CMakeLists.txt:51
@@ -50,2 +50,3 @@
if (APPLE AND LLVM_USE_SANITIZER)
- if ("${LLVM_USE_SANITIZER}" STREQUAL "Address")
+ if ("${LLVM_USE_SANITIZER}" STREQUAL "Address" OR
+ "${LLVM_USE_SANITIZER}" STREQUAL "Address;Undefined" O
beanz created this revision.
beanz added a reviewer: bob.wilson.
beanz added a subscriber: cfe-commits.
This patch adds a new driver warning -Wincompatible-sdk which notifies the user
when they are mismatching the version min options and the sysroot.
The patch works by checking the sysroot (if p
Author: cbieneman
Date: Mon Mar 14 15:23:21 2016
New Revision: 263483
URL: http://llvm.org/viewvc/llvm-project?rev=263483&view=rev
Log:
[CMake] Updating Apple Clang CMake caches
This is a big update that gets the public configurations more in line with the
ones we're actually using internally to
beanz added a comment.
Ping.
http://reviews.llvm.org/D17947
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cbieneman
Date: Tue Mar 15 13:08:20 2016
New Revision: 263567
URL: http://llvm.org/viewvc/llvm-project?rev=263567&view=rev
Log:
[Driver] [Darwin] Fix linking libclang_rt.profile_*sim.a
Summary: isTarget*() calls are order-dependent. This is because iOS Sim *is*
iOS. This means checks for
Author: cbieneman
Date: Tue Mar 15 13:17:48 2016
New Revision: 263568
URL: http://llvm.org/viewvc/llvm-project?rev=263568&view=rev
Log:
Fix a bot I broke.
The builtin library isn't added by the driver unless it exists, so we shouldn't
check for it. I've marked this as a FIXME, because we probabl
Author: cbieneman
Date: Tue Mar 15 13:25:36 2016
New Revision: 263570
URL: http://llvm.org/viewvc/llvm-project?rev=263570&view=rev
Log:
[CMake] Defaulting CLANG_VENDOR to PACKAGE_VENDOR
LLVM r263566 adds a generic PACKAGE_VENDOR configuration which can be used to
specify the vendor for LLVM tool
Author: cbieneman
Date: Tue Mar 15 13:27:28 2016
New Revision: 263571
URL: http://llvm.org/viewvc/llvm-project?rev=263571&view=rev
Log:
[CMake] Updating Apple build configurations
This updates Apple build configurations to adapt to r263566 & r263570, which
added a PACKAGE_VENDOR variable.
Modif
Author: cbieneman
Date: Mon Mar 21 17:37:14 2016
New Revision: 263997
URL: http://llvm.org/viewvc/llvm-project?rev=263997&view=rev
Log:
[Perf-training] Adding support for tests to skip the clang driver
This patch adds a new set of substitutions to the lit run lines for order files
and PGO genera
Author: cbieneman
Date: Mon Mar 21 21:55:40 2016
New Revision: 264021
URL: http://llvm.org/viewvc/llvm-project?rev=264021&view=rev
Log:
[Perf-training] Fixing an issue with multi-threading PGO generation
When LIT parallelizes the profraw file generation we need to generate unique
temp filenames
Author: cbieneman
Date: Tue Mar 22 11:27:35 2016
New Revision: 264063
URL: http://llvm.org/viewvc/llvm-project?rev=264063&view=rev
Log:
[Perf-training] Cleanup based on feedback from Sean Silvas
Sean provided feedback based on r257934 on cfe-commits. This change addresses
that feedback.
Modifie
Sean,
All good feedback.
Using print_function was done in r257936 with some other feedback from Bogner.
The rest of your feedback I believe I have addressed in r264063.
-Chris
> On Mar 21, 2016, at 9:21 PM, Sean Silva wrote:
>
>
>
> On Fri, Jan 15, 2016 at 1:21 PM, Chris B
Author: cbieneman
Date: Tue Mar 22 11:33:23 2016
New Revision: 264064
URL: http://llvm.org/viewvc/llvm-project?rev=264064&view=rev
Log:
[Perf-training] Using os.devnull instead of a temp file
This is based on post-commit feedback from Vedant. Totally didn't know that
existed and worked on Window
I totally didn’t know python had a portable way to do that!
Updated in r264064.
Thanks!
-Chris
> On Mar 22, 2016, at 9:26 AM, Vedant Kumar wrote:
>
> I think setting `cc1_env["LLVM_PROFILE_FILE"] = os.devnull` would be simpler.
>
> vedant
>
>> On Mar 21, 20
Author: cbieneman
Date: Tue Mar 22 20:47:05 2016
New Revision: 264125
URL: http://llvm.org/viewvc/llvm-project?rev=264125&view=rev
Log:
[Apple Clang] Expose llvm-config from stage2 builds in stage1
This exposes the stage2-llvm-config target though the stage1 build
configuration.
Modified:
c
beanz added a comment.
Perhaps naming this warning 'incompatible-sdk' isn't the best name. I can see
how it would cause some confusion for Visual Studio users. On Darwin the SDK is
the collection of headers and libraries you link against, not the toolkit you
have installed.
Perhaps calling the
beanz updated this revision to Diff 51813.
beanz added a comment.
Updates based on review feedback.
http://reviews.llvm.org/D18088
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/incompatible_sysroot.c
Index: test/Driver
of LLVM. Was that
> intentional? Is there any plan to support this in more normal whole-LLVM
> builds? It seems substantially more useful for stuff like picking up
> miscompiles...
>
> -Chandler
>
> On Wed, Aug 5, 2015 at 10:39 AM Chris Bieneman <mailto:be...@apple.com
Author: cbieneman
Date: Tue Jan 5 17:51:42 2016
New Revision: 256873
URL: http://llvm.org/viewvc/llvm-project?rev=256873&view=rev
Log:
[CMake] Support a simple case for bootstrap builds to generate PGO data
Summary:
This patch adds support for the clang multi-stage bootstrapping to support PGO
Apologies for reviving a long dead thread, but I think we need to re-evalute
this change.
With CMake 3.4 I’m seeing some nasty error spew on our internal builds. The
spew can be reproduced with the following CMake invocation:
> cmake -G Ninja -DLLVM_ENABLE_PIC=Off -DLLVM_INSTALL_TOOLCHAIN_ONLY=
beanz created this revision.
beanz added reviewers: rnk, chapuni, hintonda.
beanz added a subscriber: cfe-commits.
CMake freaks out in trivial cases like:
> cmake -G Ninja -DLLVM_ENABLE_PIC=Off -DLLVM_INSTALL_TOOLCHAIN_ONLY=On ../llvm
This is a result of static ink dependencies not all being par
Author: cbieneman
Date: Thu Jan 14 16:45:12 2016
New Revision: 257827
URL: http://llvm.org/viewvc/llvm-project?rev=257827&view=rev
Log:
[CMake] Set SVN_REVISION if CLANG_APPEND_VC_REV=On
This matches autoconf's ability to put clang revisions in the clang --version
spew.
Modified:
cfe/trunk/
Author: cbieneman
Date: Thu Jan 14 16:48:45 2016
New Revision: 257828
URL: http://llvm.org/viewvc/llvm-project?rev=257828&view=rev
Log:
[CMake] Move the install logic for libclang's headers into the libclang
CMakelists
This makes it so if you disable building libclang you won't install the heade
we make that change to clang or fix it another way?
>
>> -Original Message-----
>> From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
>> Of Chris Bieneman via cfe-commits
>> Sent: 14 January 2016 22:45
>> To: cfe-commits@lists.llvm.org
>> Subj
Author: cbieneman
Date: Fri Jan 15 15:21:12 2016
New Revision: 257934
URL: http://llvm.org/viewvc/llvm-project?rev=257934&view=rev
Log:
[CMake] Support generation of linker order files using dtrace
Summary:
This patch extends the lit-based perf-training tooling supplied for PGO data
generation t
Author: cbieneman
Date: Fri Jan 15 15:30:06 2016
New Revision: 257936
URL: http://llvm.org/viewvc/llvm-project?rev=257936&view=rev
Log:
[CMake] [Order-files] Use print_function as an attempt at being forward
compatible.
Based on feedback from bogner.
Modified:
cfe/trunk/utils/perf-training/
Author: cbieneman
Date: Fri Jan 15 16:44:18 2016
New Revision: 257948
URL: http://llvm.org/viewvc/llvm-project?rev=257948&view=rev
Log:
[CMake] Fix bots broken by including order file generation in check-all
Modified:
cfe/trunk/utils/perf-training/CMakeLists.txt
Modified: cfe/trunk/utils/per
That should be fixed with r257948.
-Chris
> On Jan 15, 2016, at 3:19 PM, Renato Golin wrote:
>
> On 15 January 2016 at 21:21, Chris Bieneman via cfe-commits
> wrote:
>> Author: cbieneman
>> Date: Fri Jan 15 15:21:12 2016
>> New Revision: 257934
>>
>>
This change breaks darwin fat binary support.
> ./bin/clang++ ~/dev/scratch/hello_world.cpp -arch armv7 -arch armv7s
> -isysroot
> /Applications/Xcode.app/Contents/Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS.sdk/
fatal error:
/Applications/Xcode.app/Contents/Developer/Toolchai
+Eric,
If this patch can’t be quickly fixed, can it please be reverted?
-Chris
> On Jan 15, 2016, at 4:36 PM, Chris Bieneman via cfe-commits
> wrote:
>
> This change breaks darwin fat binary support.
>
> > ./bin/clang++ ~/dev/scratch/hello_world.cpp -arch armv7 -arch
Author: cbieneman
Date: Tue Jan 19 11:06:12 2016
New Revision: 258143
URL: http://llvm.org/viewvc/llvm-project?rev=258143&view=rev
Log:
[CMake] Properly respect the CLANG_APPEND_VC_REV option
Only set -DSVN_REVISION if CLANG_APPEND_VC_REV=On
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/
.org>> wrote:
> Thanks, that did the trick. I've removed the workaround from LLVMLinux.
>
> > -Original Message-
> > From: cbiene...@apple.com <mailto:cbiene...@apple.com>
> > [mailto:cbiene...@apple.com <mailto:cbiene...@apple.com>] On Beha
beanz abandoned this revision.
beanz added a comment.
@hintonda, your comment actually trigged something in my brain and I just
realized the problem. It is a much simpler fix. If you set LLVM_ENABLE_PIC=Off
libclang isn't built as a dylib, it is a static lib. If
LLVM_INSTALL_TOOLCHAIN_ONLY=On,
Author: cbieneman
Date: Tue Jan 19 16:41:51 2016
New Revision: 258209
URL: http://llvm.org/viewvc/llvm-project?rev=258209&view=rev
Log:
[CMake] Creating add_clang_tool macro to wrap add_clang_executable and generate
install actions and targets.
This change brings forward the LLVM convention that
Author: cbieneman
Date: Tue Jan 19 17:01:38 2016
New Revision: 258214
URL: http://llvm.org/viewvc/llvm-project?rev=258214&view=rev
Log:
[CMake] Don't apply Export set to clang tools
I can't apply export to tools without getting some strange CMake spew. The
behavior here is a bit unexpected. CMak
beanz created this revision.
beanz added reviewers: echristo, chandlerc, grosbach, bob.wilson.
beanz added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This patch is provided in preparation for removing autoconf on 1/26. The
proposal to remove autoconf on 1/26 was discussed on th
Author: cbieneman
Date: Tue Jan 26 15:31:36 2016
New Revision: 258864
URL: http://llvm.org/viewvc/llvm-project?rev=258864&view=rev
Log:
Remove autoconf support
Summary:
This patch is provided in preparation for removing autoconf on 1/26. The
proposal to remove autoconf on 1/26 was discussed on t
Author: cbieneman
Date: Wed Jan 27 09:51:56 2016
New Revision: 258935
URL: http://llvm.org/viewvc/llvm-project?rev=258935&view=rev
Log:
Adding back in a test that I inadvertently removed in r258862
Added:
cfe/trunk/test/SemaObjC/atomoic-property-synnthesis-rules.m
Added: cfe/trunk/test/SemaO
beanz added a reviewer: jroelofs.
beanz added a comment.
This looks fine to me, but looping in jroelofs as he wrote the original patch.
Repository:
rL LLVM
http://reviews.llvm.org/D14800
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
beanz created this revision.
beanz added a reviewer: bogner.
beanz added a subscriber: cfe-commits.
This code is a bit undesirable, but it gets clang to work with the autoconf and
cmake-built libclang_rt.profile libraries.
http://reviews.llvm.org/D14847
Files:
lib/Driver/ToolChains.cpp
Index
> On Nov 19, 2015, at 4:12 PM, Justin Bogner wrote:
>
> Chris Bieneman mailto:be...@apple.com>> writes:
>> beanz created this revision.
>> beanz added a reviewer: bogner.
>> beanz added a subscriber: cfe-commits.
>>
>> This code is a bit un
Author: cbieneman
Date: Thu Nov 19 18:19:21 2015
New Revision: 253625
URL: http://llvm.org/viewvc/llvm-project?rev=253625&view=rev
Log:
Support CMake's clang_rt.profile library naming scheme
Summary: This code is a bit undesirable, but it gets clang to work with the
autoconf and cmake-built libc
Author: cbieneman
Date: Fri Nov 20 12:49:02 2015
New Revision: 253693
URL: http://llvm.org/viewvc/llvm-project?rev=253693&view=rev
Log:
Honor system specific paths of MAN pages
Summary: Caught on NetBSD.
Patch by: Kamil Rytarowski (krytarowski)
Reviewers: beanz, jroelofs
Subscribers: cfe-commi
Author: cbieneman
Date: Fri Nov 20 16:09:03 2015
New Revision: 253720
URL: http://llvm.org/viewvc/llvm-project?rev=253720&view=rev
Log:
[CMake] Fix handling of passing through semi-colon separated lists.
When passing around CMake arguments as lists of arguments any arguments
containing lists nee
Author: cbieneman
Date: Fri Nov 20 16:09:06 2015
New Revision: 253721
URL: http://llvm.org/viewvc/llvm-project?rev=253721&view=rev
Log:
[CMake] Add support for specifying arguments to the bootstrap build.
This adds support for three types of argument specifications for bootstrap
builds:
(1) Arg
Good to know my spelling is at least consistently wrong :-).
I’ll fix this shortly.
-Chris
> On Nov 20, 2015, at 8:12 PM, Sean Silva wrote:
>
>
>
> On Fri, Nov 20, 2015 at 2:09 PM, Chris Bieneman via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Au
Author: cbieneman
Date: Mon Nov 23 17:34:13 2015
New Revision: 253937
URL: http://llvm.org/viewvc/llvm-project?rev=253937&view=rev
Log:
NFC. Fixing my consistently incorrect spelling.
Modified:
cfe/trunk/CMakeLists.txt
cfe/trunk/runtime/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.txt
U
beanz created this revision.
beanz added reviewers: mclow.lists, EricWF.
beanz added a subscriber: cfe-commits.
The current implementation doesn't work as intended because of CMake's caching
behavior. The CMake set command doesn't globally override cached options.
This change removes LIBCXX_OVER
beanz updated this revision to Diff 41668.
beanz added a comment.
My patch dropped one of the gating checks. This fixes that. It only needs to
apply to Darwin when installing to /usr.
http://reviews.llvm.org/D15161
Files:
CMakeLists.txt
Index: CMakeLists.txt
Author: cbieneman
Date: Thu Dec 3 12:52:54 2015
New Revision: 254628
URL: http://llvm.org/viewvc/llvm-project?rev=254628&view=rev
Log:
[CMake] If you're not installing the libcxx library, exclude it from the "all"
target so it doesn't get built when you run "ninja install"
This is just a build
Author: cbieneman
Date: Thu Dec 3 13:47:25 2015
New Revision: 254642
URL: http://llvm.org/viewvc/llvm-project?rev=254642&view=rev
Log:
[CMake] Removing an unnecessary layer of variable indirection
This prevents passthrough variables from having values.
Modified:
cfe/trunk/runtime/CMakeLists
beanz added a comment.
Mostly formatting comments. I think for the most part this is the right way to
go, but I don't really feel qualified to approve this. The one thing I'm not
sure about on this is, do we really want this to be darwin-only? I kinda think
it might be nice if we unified this b
Author: cbieneman
Date: Fri Dec 4 17:12:19 2015
New Revision: 254797
URL: http://llvm.org/viewvc/llvm-project?rev=254797&view=rev
Log:
[CMake] Don't build the libclang tests unless you're building libclang
This fixes a build issue reported by users at Apple.
Modified:
cfe/trunk/unittests/CM
beanz added inline comments.
Comment at: test/Driver/fsanitize.c:221
@@ +220,3 @@
+// RUN: %clang -target x86_64-apple-darwin10
-resource-dir=%S/Inputs/resource_dir -fsanitize=memory -fsanitize=thread,memory
%s -### 2>&1 | FileCheck %s --check-prefix=CHECK-MSAN-TSAN-MSAN-DARWIN1
Author: cbieneman
Date: Wed Dec 9 16:46:25 2015
New Revision: 255172
URL: http://llvm.org/viewvc/llvm-project?rev=255172&view=rev
Log:
[CMake] Pass CMAKE_MAKE_PROGRAM through to compiler-rt build.
This is needed if your make tool is overridden.
Modified:
cfe/trunk/runtime/CMakeLists.txt
Mo
beanz abandoned this revision.
beanz added a comment.
Short answer. I was doing something terrible and wrong in out-of-tree code, and
this was getting tripped up. I was reading the LIBCXX_INSTALL_* variables from
a higher-level CMake file. I've stopped doing that (because it was stupid), so
I'l
beanz created this revision.
beanz added reviewers: dexonsmith, silvas, friss, vsk, bogner, cmatthews.
beanz added a subscriber: cfe-commits.
This patch adds support for using LIT to drive generating PGO profile data for
clang.
This first pass implementation should work on Linux and Unix based p
beanz added a comment.
Sean,
The reason for restricting to Unix is two fold. (1) the shell script goop,
which I can replace with python and (2) I don't have a windows box to test on,
so I didn't want people to think it worked.
If I replace the shell goop with Python this will probably "Just Wo
beanz updated this revision to Diff 42761.
beanz added a comment.
Updates based on feedback from Sean and Vedant.
- Should work on Windows now
- Cleaned up lit config code
http://reviews.llvm.org/D15462
Files:
CMakeLists.txt
utils/perf-training/CMakeLists.txt
utils/perf-training/README.t
beanz updated this revision to Diff 42891.
beanz added a comment.
Cleaning up the python helper as per Sean's suggestions.
http://reviews.llvm.org/D15462
Files:
CMakeLists.txt
utils/perf-training/CMakeLists.txt
utils/perf-training/README.txt
utils/perf-training/cxx/hello_world.cpp
uti
Author: cbieneman
Date: Tue Dec 15 19:02:44 2015
New Revision: 255740
URL: http://llvm.org/viewvc/llvm-project?rev=255740&view=rev
Log:
[CMake] Add support for generating profdata for clang from training files
Summary:
This patch adds support for using LIT to drive generating PGO profile data for
Author: cbieneman
Date: Wed Dec 16 12:42:14 2015
New Revision: 255798
URL: http://llvm.org/viewvc/llvm-project?rev=255798&view=rev
Log:
[CMake] ExternalProject for compiler-rt needs to depend on llvm-config and clang
The add_dependencies call on compiler-rt-configure adds llvm-config and clang
t
301 - 400 of 965 matches
Mail list logo
