Author: cbieneman
Date: Thu Oct 1 13:16:56 2015
New Revision: 249048
URL: http://llvm.org/viewvc/llvm-project?rev=249048&view=rev
Log:
[CMake] Don't include the test directories if CLANG_INCLUDE_TESTS is Off
This matches Clang's behavior.
Modified:
clang-tools-extra/trunk/CMakeLists.txt
Mo
Author: cbieneman
Date: Thu Oct 1 19:56:53 2015
New Revision: 249115
URL: http://llvm.org/viewvc/llvm-project?rev=249115&view=rev
Log:
[CMake] Fixing clang bootstrap to use LLVM_RUNTIME_OUTPUT_INTDIR instead of
CMAKE_BINARY_DIR.
This should make bootstrap builds work with multi-configuration ge
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
Thanks for catching this!
-Chris
Repository:
rL LLVM
http://reviews.llvm.org/D13421
___
cfe-commits mailing list
cfe-commits@lists.llvm.
beanz added a comment.
I will send updated patches shortly.
Comments inline below.
Comment at: runtime/CMakeLists.txt:33
@@ -32,1 +32,3 @@
+ )
+set(cmake_3_4_USES_TERMINAL USES_TERMINAL 1)
endif()
samsonov wrote:
> Should this also be named cmake_3_
beanz updated this revision to Diff 36532.
beanz added a comment.
- Cleanup based on feedback from samsonov
http://reviews.llvm.org/D13399
Files:
runtime/CMakeLists.txt
Index: runtime/CMakeLists.txt
===
--- runtime/CMakeLists.tx
beanz added a comment.
probinson,
Not by itself, but this could be used as a step in that direction. The
`CLANG_COMPILER_RT_CMAKE_ARGS` variable can be used to configure how
compiler-rt is built with a great deal of flexibility, but the goal of this
patch is to try and closely match how compil
beanz created this revision.
beanz added reviewers: bogner, echristo.
beanz added a subscriber: cfe-commits.
The code comments in the Makefile indicate this was put in place to support
issues when building clang with GCC. Today clang's strict aliasing works, so we
shouldn't pass -fno-strict-alia
beanz updated this revision to Diff 32163.
beanz added a comment.
Should have been calling $(CC) not cc in the makefile. Oops.
http://reviews.llvm.org/D12036
Files:
CMakeLists.txt
Makefile
Index: Makefile
===
--- Makefile
+++
beanz added a comment.
dblaikie,
I've run this through check-all with no issues.
http://reviews.llvm.org/D12036
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz added a comment.
echristo,
I can move the makefile check to the autoconf check, but I think setting the
flags should stay in the clang CMakeLists/Makefile otherwise it will change
behavior. Today we only enable this flag for the clang subdirectory, not all of
LLVM.
Thoughts?
http://re
suggestion.
-Chris
> On Aug 14, 2015, at 11:14 AM, Justin Bogner wrote:
>
> Chris Bieneman writes:
>> beanz added a comment.
>>
>> dblaikie,
>>
>> I've run this through check-all with no issues.
>
> Might want to bootstrap with sanitizers or somet
beanz updated this revision to Diff 32349.
beanz added a comment.
- Adapting to r245255 which exposes a variable in autoconf for which compiler
you are building with.
- Updated the CMake to be more CMake-y
Note: This has been tested by running a check on a stage2 clang built with asan
and ubsan
Author: cbieneman
Date: Tue Aug 18 11:15:44 2015
New Revision: 245304
URL: http://llvm.org/viewvc/llvm-project?rev=245304&view=rev
Log:
We shouldn't need to pass -fno-strict-aliasing when building clang with clang.
Summary: The code comments in the Makefile indicate this was put in place to
supp
> On Aug 18, 2015, at 10:48 AM, Nico Weber wrote:
>
> On Tue, Aug 18, 2015 at 9:15 AM, Chris Bieneman via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: cbieneman
> Date: Tue Aug 18 11:15:44 2015
> New Revision: 245304
>
> URL: http:/
Author: cbieneman
Date: Tue Aug 18 16:23:44 2015
New Revision: 245359
URL: http://llvm.org/viewvc/llvm-project?rev=245359&view=rev
Log:
[autoconf] Fixing reversed logic introduced r245304.
Thanks for the catch Hal!
Modified:
cfe/trunk/Makefile
Modified: cfe/trunk/Makefile
URL:
http://llvm.
Wow! Thank you for catching that!
Fixed in r245359.
-Chris
> On Aug 18, 2015, at 2:15 PM, Hal Finkel wrote:
>
> - Original Message -
>> From: "Chris Bieneman via cfe-commits"
>> To: cfe-commits@lists.llvm.org
>> Sent: Tuesday, August 18, 2015
beanz added a comment.
The signature is:
install(TARGETS targets... [EXPORT ]
[[ARCHIVE|LIBRARY|RUNTIME|FRAMEWORK|BUNDLE|
PRIVATE_HEADER|PUBLIC_HEADER|RESOURCE]
[DESTINATION ]
[INCLUDES DESTINATION [ ...]]
[PERMISSIONS permissions...]
beanz accepted this revision.
beanz added a reviewer: beanz.
beanz added a comment.
This revision is now accepted and ready to land.
You are right, and I apparently don't know how to read documentation...
Patch LGTM as is.
http://reviews.llvm.org/D11682
__
Author: cbieneman
Date: Thu Aug 20 15:12:18 2015
New Revision: 245603
URL: http://llvm.org/viewvc/llvm-project?rev=245603&view=rev
Log:
[CMake] Exclude 'bootstrap' target from 'all' where possible.
EXCLUDE_FROM_ALL in ExternalProject is only available on CMake 3.1 and later.
Modified:
cfe/tr
Author: cbieneman
Date: Thu Aug 20 15:12:20 2015
New Revision: 245604
URL: http://llvm.org/viewvc/llvm-project?rev=245604&view=rev
Log:
[CMake] Simplifying logic for USES_TERMINAL on bootstrap targets.
In CMake variables that haven't been set are evaluated to empty strings, so we
don't need to s
beanz added a comment.
Ping?
http://reviews.llvm.org/D13399
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
LGTM.
http://reviews.llvm.org/D13453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
beanz added inline comments.
Comment at: runtime/CMakeLists.txt:41
@@ +40,3 @@
+
+ add_custom_target(compiler-rt-clear
+DEPENDS ${CMAKE_CURRENT_BINARY_DIR}/compiler-rt-cleared
samsonov wrote:
> So, that's the target that you can invoke manually to clean compi
beanz updated this revision to Diff 36897.
beanz added a comment.
Updates to fix dependency mapping.
Compiler-rt will be cleaned and rebuilt if clang changes and reconfigured if
llvm-config or clang changes.
http://reviews.llvm.org/D13399
Files:
runtime/CMakeLists.txt
Index: runtime/CMakeL
Author: cbieneman
Date: Fri Oct 9 12:45:44 2015
New Revision: 249858
URL: http://llvm.org/viewvc/llvm-project?rev=249858&view=rev
Log:
[CMake] Fixing LTO library path passed into bootstrap builds.
This just fixes a small error in constructing the path to the LTO library.
Modified:
cfe/trunk
Author: cbieneman
Date: Sun Oct 11 19:49:56 2015
New Revision: 250003
URL: http://llvm.org/viewvc/llvm-project?rev=250003&view=rev
Log:
[Darwin] Need to add -isysroot on OS X otherwise the tests will fail if you
don't have the command line tools package installed.
This mirrors how other LLVM sui
> /Eric
>
> On Sun, Oct 11, 2015 at 6:49 PM, Chris Bieneman via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: cbieneman
> Date: Sun Oct 11 19:49:56 2015
> New Revision: 250003
>
> URL: http://llvm.org/viewvc/llvm-project?rev=250003&view=re
Author: cbieneman
Date: Sun Oct 11 21:54:30 2015
New Revision: 250007
URL: http://llvm.org/viewvc/llvm-project?rev=250007&view=rev
Log:
[Darwin] Reworking r250003 to use lit.util.capture instead of subprocess.
Modified:
libcxx/trunk/test/libcxx/test/config.py
Modified: libcxx/trunk/test/libc
Updated in r250007.
-Chris
> On Oct 11, 2015, at 7:49 PM, Chris Bieneman via cfe-commits
> wrote:
>
> CMake handles doing it while building. I will update to use lit.util.*
>
> -Chris
>
>> On Oct 11, 2015, at 6:04 PM, Eric Fiselier > <mailto:e...@efcs.ca
Author: cbieneman
Date: Mon Oct 12 11:34:23 2015
New Revision: 250064
URL: http://llvm.org/viewvc/llvm-project?rev=250064&view=rev
Log:
[CMake] Bug 14109 - CMake build for compiler-rt should use just-built clang
Summary:
Many small improvements to LLVM_BUILD_EXTERNAL_COMPILER_RT.
* Works correct
Author: cbieneman
Date: Tue Oct 13 13:17:30 2015
New Revision: 250196
URL: http://llvm.org/viewvc/llvm-project?rev=250196&view=rev
Log:
[CMake] When building clang as an external project we should pass through all
variables that start with COMPILER_RT
Modified:
cfe/trunk/runtime/CMakeLists.t
Author: cbieneman
Date: Tue Oct 13 18:03:54 2015
New Revision: 250246
URL: http://llvm.org/viewvc/llvm-project?rev=250246&view=rev
Log:
[CMake]Getting rid of references to LLVM_SUBMIT_VERSION and
LLVM_SUBMIT_SUBVERSION in favor of LLVM_VERSION_MAJOR and LLVM_VERSION_MINOR.
LLVM_SUBMIT_VERSION an
Author: cbieneman
Date: Wed Oct 14 02:50:47 2015
New Revision: 250278
URL: http://llvm.org/viewvc/llvm-project?rev=250278&view=rev
Log:
[CMake] Add LLVM_VERSION_PATCH to the -current_version flag for libclang.
This is to match autoconf where LLVM_SUBMIT_SUBVERSION is usually set to
${LLVM_VERSIO
Author: cbieneman
Date: Tue Oct 20 11:39:25 2015
New Revision: 250834
URL: http://llvm.org/viewvc/llvm-project?rev=250834&view=rev
Log:
[CMake] Make external compiler-rt install scripts relative to
CMAKE_INSTALL_PREFIX.
This change makes LLVM_BUILD_EXTERNAL_COMPILER_RT work correctly when
overr
Author: cbieneman
Date: Tue Oct 20 13:12:12 2015
New Revision: 250840
URL: http://llvm.org/viewvc/llvm-project?rev=250840&view=rev
Log:
[CMake] Make clang/tools subdirectories controlled via options
Setting CLANG_TOOL_*_BUILD=Off on the CMake command line will disable inclusion
of a clang/tools
beanz added a comment.
I would prefer if installing these were optional and could be toggled on/off.
Other than that this all looks fine to me.
http://reviews.llvm.org/D14403
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
beanz accepted this revision.
This revision is now accepted and ready to land.
Comment at: tools/driver/CMakeLists.txt:58
@@ -62,1 +57,3 @@
+if(NOT MSVC)
+ add_custom_target(install-clang
Can you change this to `if(NOT CMAKE_CONFIGURATION_TYPES)`?
With that it
> On Nov 9, 2015, at 2:07 PM, Aaron Ballman wrote:
>
> aaron.ballman added inline comments.
>
>
> Comment at: tools/driver/CMakeLists.txt:58
> @@ -62,1 +57,3 @@
>
> +if(NOT MSVC)
> + add_custom_target(install-clang
>
> beanz wrote:
>> Can you change this to `
Author: cbieneman
Date: Mon Nov 9 16:43:10 2015
New Revision: 252523
URL: http://llvm.org/viewvc/llvm-project?rev=252523&view=rev
Log:
[CMake] Support passing CMAKE_VERBOSE_MAKEFILE through to bootstrap builds.
This option enables full verbosity in recursive CMake builds.
Modified:
cfe/trun
Your custom commands don’t have outputs, so ninja doesn’t know when they need
to run or not.
-Chris
> On Nov 10, 2015, at 2:14 PM, Jonathan Roelofs
> wrote:
>
>
>
> On 11/10/15 1:35 PM, Tobias Grosser wrote:
>> On 11/10/2015 09:05 PM, Jonathan Roelofs wrote:
>>>
>>>
>>> On 11/10/15 12:48
Author: cbieneman
Date: Wed Nov 11 15:53:08 2015
New Revision: 252809
URL: http://llvm.org/viewvc/llvm-project?rev=252809&view=rev
Log:
[CMake] Fixing passthrough for variables starting with COMPILER_RT
This allows COMPILER_RT_* variables to be passed from the top-level CMake into
the external p
> On Aug 5, 2015, at 3:15 PM, Justin Bogner wrote:
>
>
> Chris Bieneman writes:
>> Author: cbieneman
>> Date: Wed Aug 5 12:38:12 2015
>> New Revision: 244070
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=244070&view=rev
>> Lo
beanz added a subscriber: beanz.
beanz added a comment.
@rengolin, thank you for putting this all together. It is very well thought
out, and I really like the shape it took. I have a few minor nitpick comments
inline.
Thanks,
-Chris
Comment at: docs/Proposals/GitHub.rst:58
@@
Author: cbieneman
Date: Mon Jul 25 13:54:30 2016
New Revision: 276674
URL: http://llvm.org/viewvc/llvm-project?rev=276674&view=rev
Log:
[CMake] Cleaning up some CMake warnings
In Bootstrap builds Clang logs some warnings. These are caused because Clang
passes CLANG_STAGE and BOOTSTRAP_DEFAULT_PA
beanz added a subscriber: beanz.
beanz added a comment.
One small comment on the CMake code.
Comment at: CMakeLists.txt:210
@@ +209,3 @@
+ message(WARNING "Resetting default rtlib to use platform default")
+ set(CLANG_DEFAULT_RTLIB "")
+endif()
You'll want thi
Author: cbieneman
Date: Mon Jul 25 18:48:14 2016
New Revision: 276711
URL: http://llvm.org/viewvc/llvm-project?rev=276711&view=rev
Log:
[CMake] Pass DYLD_LIBRARY_PATH as CMake variable instead of as envar
On OS X 10.11 System Integrity Protection prevents the DYLD environment
variables from bein
beanz added inline comments.
Comment at: CMakeLists.txt:210
@@ -202,3 +209,3 @@
set(CLANG_VENDOR ${PACKAGE_VENDOR} CACHE STRING
"Vendor-specific text for showing with version information.")
Hahnfeld wrote:
> zlei wrote:
> > Hahnfeld wrote:
> > > zlei wrote:
Author: cbieneman
Date: Fri Jul 29 17:48:17 2016
New Revision: 277234
URL: http://llvm.org/viewvc/llvm-project?rev=277234&view=rev
Log:
[Perf-Helper] Add logging for dtrace commands
Logging the dtrace command into the top of the dtrace log is useful when
debugging why the order file generation i
Author: cbieneman
Date: Mon Aug 1 17:54:00 2016
New Revision: 277401
URL: http://llvm.org/viewvc/llvm-project?rev=277401&view=rev
Log:
[Order Files] Fixing an error in the perf-helper script
Dtrace probemod needs to be based on the first argument of the command, not the
first argument of the ar
Author: cbieneman
Date: Tue Aug 2 12:50:53 2016
New Revision: 277487
URL: http://llvm.org/viewvc/llvm-project?rev=277487&view=rev
Log:
[Order Files] Remove dtrace predicate
Having the dtrace predicate setup to only show probes in clang filters out
static initializers executed by dyld, which we
Author: cbieneman
Date: Tue Aug 2 13:23:56 2016
New Revision: 277492
URL: http://llvm.org/viewvc/llvm-project?rev=277492&view=rev
Log:
Revert "[Order Files] Remove dtrace predicate"
This reverts commit r277487.
Removing the probe predicate was a red herring. It results in more symbols
being pl
Author: cbieneman
Date: Wed Aug 10 19:19:51 2016
New Revision: 278306
URL: http://llvm.org/viewvc/llvm-project?rev=278306&view=rev
Log:
[Order Files] Don't use empty order files
LD64 does optimization on symbol layouts that gets disabled whenever an order
file is passed (even if it is empty). Th
Author: cbieneman
Date: Mon Aug 15 15:15:22 2016
New Revision: 278729
URL: http://llvm.org/viewvc/llvm-project?rev=278729&view=rev
Log:
[CMake] Apple stage1 doesn't need to set libcxx options
LibCXX settings are configured in stage2 so we don't need them here.
Modified:
cfe/trunk/cmake/cache
Author: cbieneman
Date: Wed Feb 3 11:16:01 2016
New Revision: 259667
URL: http://llvm.org/viewvc/llvm-project?rev=259667&view=rev
Log:
Add back the ABITest makefiles
These files are standalone and not integrated with CMake, so we probably want
them.
Added:
cfe/trunk/utils/ABITest/Makefile.
beanz created this revision.
beanz added a reviewer: bogner.
beanz added a subscriber: cfe-commits.
With this change generating clang order files using dtrace uses the following
workflow:
# Configure LLVM & Clang using any options on a system with dtrace
cmake
# Builds clang and runs the perf-
beanz updated this revision to Diff 46966.
beanz added a comment.
Gate adding the -order_file linker option on whether the linker supports it.
http://reviews.llvm.org/D16896
Files:
CMakeLists.txt
tools/driver/CMakeLists.txt
utils/perf-training/CMakeLists.txt
Index: utils/perf-training/CM
Author: cbieneman
Date: Thu Feb 4 19:22:03 2016
New Revision: 259862
URL: http://llvm.org/viewvc/llvm-project?rev=259862&view=rev
Log:
[CMake] Improve the clang order-file generation workflow
Summary:
With this change generating clang order files using dtrace uses the following
workflow:
cmake
Author: cbieneman
Date: Thu Feb 4 19:27:31 2016
New Revision: 259864
URL: http://llvm.org/viewvc/llvm-project?rev=259864&view=rev
Log:
[CMake] Trying to fix a bot failure I introduced in r259862
CMake caching behavior makes me sad.
Modified:
cfe/trunk/tools/driver/CMakeLists.txt
Modified:
e.a lib/libclangLex.a lib/libclangBasic.a lib/libLLVMCore.a
> lib/libLLVMMC.a lib/libLLVMSupport.a -lrt -ldl -ltinfo -lpthread -lz -lm
> -Wl,-rpath,"\$ORIGIN/../lib" && :
> /usr/local/google/home/richardsmith/clang-8/build/tools/clang/clang.order:
> file not recogni
Author: cbieneman
Date: Thu Feb 4 20:51:33 2016
New Revision: 259870
URL: http://llvm.org/viewvc/llvm-project?rev=259870&view=rev
Log:
[CMake] Speculative fix for linker error on Linux
I can't reproduce this locally, but I think this may fix it.
Modified:
cfe/trunk/CMakeLists.txt
Modified:
I pushed a speculative fix for this in r259870. I’m unable to reproduce
locally. There are a few bots that hit the same issue, so I’m watching them.
-Chris
> On Feb 4, 2016, at 6:44 PM, Chris Bieneman via cfe-commits
> wrote:
>
> What linker are you using and on what OS? I’m loo
Author: cbieneman
Date: Thu Feb 4 21:02:40 2016
New Revision: 259871
URL: http://llvm.org/viewvc/llvm-project?rev=259871&view=rev
Log:
[CMake] One more try to fix this.
This change will catch any bots that generated the order file that GNU ld
doesn't like and delete it before trying to generate
Actually r259871 includes the code to cleanup the “bad” order file…
-Chris
> On Feb 4, 2016, at 7:02 PM, Chris Bieneman wrote:
>
> I pushed a speculative fix for this in r259870. I’m unable to reproduce
> locally. There are a few bots that hit the same issue, so I’m watching them.
Author: cbieneman
Date: Thu Feb 4 21:40:37 2016
New Revision: 259872
URL: http://llvm.org/viewvc/llvm-project?rev=259872&view=rev
Log:
Revert "[CMake] Improve the clang order-file generation workflow"
This reverts commit r259862, and attempts to fix builder CMakeCaches.
Will try this again some
Author: cbieneman
Date: Thu Feb 4 21:59:08 2016
New Revision: 259873
URL: http://llvm.org/viewvc/llvm-project?rev=259873&view=rev
Log:
[CMake] One more try to make CMake clean up after itself
Seriously... CMake... You're on my list...
Modified:
cfe/trunk/CMakeLists.txt
cfe/trunk/tools/d
;t be able to test the fix until tomorrow, hopefully the
> bits will give you enough.
>
>> On 4 Feb 2016 7:07 p.m., "Chris Bieneman" wrote:
>> Actually r259871 includes the code to cleanup the “bad” order file…
>>
>> -Chris
>>
>>> On Feb 4,
beanz created this revision.
beanz added a reviewer: bogner.
beanz added a subscriber: cfe-commits.
This commit re-lands r259862. The underlying cause of the build breakage was an
incorrectly written capabilities test. In tools/Driver/CMakeLists.txt I was
attempting to check if a linker flag wor
Author: cbieneman
Date: Tue Feb 9 00:01:47 2016
New Revision: 260201
URL: http://llvm.org/viewvc/llvm-project?rev=260201&view=rev
Log:
[CMake] Providing a CMake cache for 3-stage builds
This cache file can be used to generate a 3-stage clang build. You can
configure using the following CMake co
ot clear what the "first two" are. Could you update
> the description there?
>
> -- Sean Silva
>
> On Mon, Feb 8, 2016 at 10:01 PM, Chris Bieneman via cfe-commits
> mailto:cfe-commits@lists.llvm.org>> wrote:
> Author: cbieneman
> Date: Tue Feb 9 00:01:47
Author: cbieneman
Date: Tue Feb 9 00:49:08 2016
New Revision: 260203
URL: http://llvm.org/viewvc/llvm-project?rev=260203&view=rev
Log:
[CMake] Updating caches README with explanations of useful cache files.
This is in response to silvas' post-commit suggestion.
Modified:
cfe/trunk/cmake/cac
beanz added a comment.
Is it correct to assume that all the test case changes are needed just to make
the tests pass if you set CLANG_DEFAULT_CXX_STDLIB=libc++?
I'm not really comfortable approving this patch because I've made all of one or
two changes ever to the driver, but I can try to peste
Author: cbieneman
Date: Tue Feb 9 19:09:56 2016
New Revision: 260340
URL: http://llvm.org/viewvc/llvm-project?rev=260340&view=rev
Log:
[CMake] Fixing the 3-stage cmake cache.
I had hoped this would work from a single cache file, but turns out there is a
bug I can't quite figure out relating to
Author: cbieneman
Date: Tue Feb 9 19:09:59 2016
New Revision: 260341
URL: http://llvm.org/viewvc/llvm-project?rev=260341&view=rev
Log:
[CMake] Pass LLVM_EXTERNAL_*_SOURCE_DIR variables to subsequent stages
For multi-stage builds we need to pass any overridden source directory
variables. Without
Author: cbieneman
Date: Tue Feb 9 20:17:21 2016
New Revision: 260350
URL: http://llvm.org/viewvc/llvm-project?rev=260350&view=rev
Log:
[CMake] For multi-stage builds to be deterministic we need to disable
timestamps.
Duh! With this change I've verified -O3 builds are deterministic.
Modified:
beanz added a comment.
Everything about this looks reasonable to me.
Can you commit the test changes in a separate commit before committing the
other changes? That way if something goes wrong the diff for the meat of the
patch is a small diff.
http://reviews.llvm.org/D15920
___
Author: cbieneman
Date: Fri Feb 12 13:06:12 2016
New Revision: 260707
URL: http://llvm.org/viewvc/llvm-project?rev=260707&view=rev
Log:
[CMake] Pass stage1 tools through to stage2 when building with LTO
This was originally a hacky if(APPLE) block. Now that we have an option for
enabling LTO, it
Author: cbieneman
Date: Fri Feb 12 15:36:55 2016
New Revision: 260742
URL: http://llvm.org/viewvc/llvm-project?rev=260742&view=rev
Log:
[CMake] Improve the clang order-file generation workflow
Summary:
This commit re-lands r259862. The underlying cause of the build breakage was an
incorrectly wr
Author: cbieneman
Date: Fri Feb 12 15:46:25 2016
New Revision: 260744
URL: http://llvm.org/viewvc/llvm-project?rev=260744&view=rev
Log:
[CMake] Fixing bots I broke.
Modified:
cfe/trunk/CMakeLists.txt
Modified: cfe/trunk/CMakeLists.txt
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/CMake
+ Mike
If you like this… Mike has been setting up a bot running it. Which is super
awesome!
-Chris
> On Feb 14, 2016, at 1:40 PM, Duncan P. N. Exon Smith
> wrote:
>
>>
>> On 2016-Feb-08, at 22:01, Chris Bieneman via cfe-commits
>> wrote:
>>
>> Auth
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Looks good to me.
http://reviews.llvm.org/D17452
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/list
Author: cbieneman
Date: Tue Feb 23 14:33:15 2016
New Revision: 261680
URL: http://llvm.org/viewvc/llvm-project?rev=261680&view=rev
Log:
[CMake] Add install-clang-format target by migrating to add_clang_tool
This change migrates clang-format to add_clang_tool which makes a
component-based install
Author: cbieneman
Date: Thu Feb 25 12:39:19 2016
New Revision: 261911
URL: http://llvm.org/viewvc/llvm-project?rev=261911&view=rev
Log:
[CMake] Fixing install-clang-headers dependencies to depend on generating the
headers.
Modified:
cfe/trunk/lib/Headers/CMakeLists.txt
Modified: cfe/trunk/l
Author: cbieneman
Date: Tue Apr 26 13:39:20 2016
New Revision: 267584
URL: http://llvm.org/viewvc/llvm-project?rev=267584&view=rev
Log:
[CMake] Use just-built clang and build iOS support when building stage2
The Apple stage2 build should include compiler-rt iOS libraries and be built
with the st
Author: cbieneman
Date: Wed Apr 27 13:52:48 2016
New Revision: 267756
URL: http://llvm.org/viewvc/llvm-project?rev=267756&view=rev
Log:
[CMake] On Darwin bootstrap LTO builds set DYLD_LIBRARY_PATH instead of using
llvm-ar
llvm-ar isn't really supported for Darwin, instead the host tools will loa
else could you open a bug report?
>
> Cheers,
> Rafael
>
>
> On 27 April 2016 at 14:52, Chris Bieneman via cfe-commits
> wrote:
>> Author: cbieneman
>> Date: Wed Apr 27 13:52:48 2016
>> New Revision: 267756
>>
>> URL: http://llvm.org/vi
beanz added a comment.
Ping?
http://reviews.llvm.org/D18088
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
beanz updated this revision to Diff 55472.
beanz added a comment.
Use llvm::sys::path::const_iterator instead of hand slicing the paths, based on
feedback from @rsmith.
Thanks,
-Chris
http://reviews.llvm.org/D18088
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.
beanz created this revision.
beanz added a reviewer: t.p.northover.
beanz added a subscriber: cfe-commits.
Herald added subscribers: rengolin, aemerson.
The Darwin armv7k ABI uses Dwarf EH, so we need to set the OS define correctly.
Without this the gcc_personality fails to build.
http://reviews
beanz added a subscriber: beanz.
beanz added a comment.
Yea… Arc seems to have done something odd with my out-of-date checkout.
I’ll make sure that gets cleaned up, and I’ll add a test.
Thanks,
-Chris
http://reviews.llvm.org/D19693
___
cfe-commits
Yea… Arc seems to have done something odd with my out-of-date checkout.
I’ll make sure that gets cleaned up, and I’ll add a test.
Thanks,
-Chris
> On Apr 28, 2016, at 3:23 PM, Tim Northover wrote:
>
> t.p.northover added a comment.
>
> The __ARM_DWARF_EH__ change looks reasonable, but it's pr
beanz updated this revision to Diff 55626.
beanz added a comment.
Adding a test case, and properly rebasing on trunk.
http://reviews.llvm.org/D19693
Files:
lib/Basic/Targets.cpp
test/Preprocessor/arm-target-features.c
Index: test/Preprocessor/arm-target-features.c
=
Author: cbieneman
Date: Fri Apr 29 12:53:00 2016
New Revision: 268078
URL: http://llvm.org/viewvc/llvm-project?rev=268078&view=rev
Log:
[Clang][Darwin] Define __ARM_DWARF_EH__ for WatchABI
Summary: The Darwin armv7k ABI uses Dwarf EH, so we need to set the OS define
correctly. Without this the g
beanz updated this revision to Diff 55652.
beanz added a comment.
Cleanup and refactoring based on feedback from @rsmith.
http://reviews.llvm.org/D18088
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/ToolChains.cpp
lib/Driver/ToolChains.h
test/Driver/incompatible_sysroot
Author: cbieneman
Date: Fri Apr 29 17:17:15 2016
New Revision: 268124
URL: http://llvm.org/viewvc/llvm-project?rev=268124&view=rev
Log:
[CMake] Create a separate install target for libcxx headers
This change doesn't impact the behavior of the install-libcxx target which
installs whichever libcxx
beanz added a comment.
Thanks!
Will commit soon.
Comment at: lib/Driver/ToolChains.cpp:733
@@ +732,3 @@
+ StringRef SDKName = SDK.slice(0, StartVer);
+ if (!SDKName.startswith(getPlatformFamily()))
+getDriver().Diag(diag::warn_incompatible_sysroot)
---
Author: cbieneman
Date: Fri Apr 29 17:28:34 2016
New Revision: 268127
URL: http://llvm.org/viewvc/llvm-project?rev=268127&view=rev
Log:
Add a new warning to notify users of mismatched SDK and deployment target
Summary:
This patch adds a new driver warning -Wincompatible-sdk which notifies the use
Author: cbieneman
Date: Fri Apr 29 17:44:33 2016
New Revision: 268128
URL: http://llvm.org/viewvc/llvm-project?rev=268128&view=rev
Log:
Fix test case for incompatible sysroot warning
r268127 broke some bots because it needs to specify a darwin target.
Modified:
cfe/trunk/test/Driver/incompat
rg:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast?numbuilds=100
>
>> On Fri, Apr 29, 2016 at 3:28 PM, Chris Bieneman via cfe-commits
>> wrote:
>> Author: cbieneman
>> Date: Fri Apr 29 17:28:34 2016
>> New Revision: 268127
>>
>> URL: http
Author: cbieneman
Date: Sat Apr 30 00:27:17 2016
New Revision: 268156
URL: http://llvm.org/viewvc/llvm-project?rev=268156&view=rev
Log:
Stab in the dark to fix the PS4 bot
r268127 is causing the PS4 bots to fail. Not sure what is causing it, but
hopefully this will fix it.
Modified:
cfe/tru
Took a blind stab at fixing it in r268156.
-Chris
> On Apr 29, 2016, at 10:10 PM, Chris Bieneman via cfe-commits
> wrote:
>
> Unless I'm reading the log wrong there doesn't seem to be any error text
> getting logged.
>
> Any idea what that is about?
>
>
201 - 300 of 965 matches
Mail list logo
