@@ -4942,18 +4942,13 @@ void
Parser::ParseMicrosoftRootSignatureAttributeArgs(ParsedAttributes &Attrs) {
// Construct our identifier
llvm-beanz wrote:
I suspect the "Microsoft" bit came from the attribute parsing syntax. HLSL
supports "Microsoft"-style att
@@ -0,0 +1,12 @@
+// RUN: %clang_dxc -T lib_6_4 -Gis %s 2>&1 -### | FileCheck -check-prefix=Gis
%s
+// RUN: %clang_dxc -T lib_6_4 %s 2>&1 -### | FileCheck -check-prefix=NO_Gis %s
+// RUN: not %clang_dxc -T lib_6_4 /Gis gibberish -### %s 2>&1 | FileCheck
-check-prefix=CHECK-ERR %
https://github.com/llvm-beanz approved this pull request.
This will have some nuanced differences from what DXC does today because of the
differences in granularity of floating point semantic controls in LLVM today vs
3.7. That said, I think this will be conservatively correct and is probably t
@@ -0,0 +1,12 @@
+// RUN: %clang_dxc -T lib_6_4 -Gis %s 2>&1 -### | FileCheck -check-prefix=Gis
%s
+// RUN: %clang_dxc -T lib_6_4 %s 2>&1 -### | FileCheck -check-prefix=NO_Gis %s
+// RUN: not %clang_dxc -T lib_6_4 /Gis gibberish -### %s 2>&1 | FileCheck
-check-prefix=CHECK-ERR %
https://github.com/llvm-beanz approved this pull request.
Sorry for the extreme delay in review. I think everyone trying to keep up with
clangd reviews has been swamped and pretty over subscribed.
The implementation here looks clean and follows existing conventions in clangd.
It is also quite
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/147806
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1001 - 1006 of 1006 matches
Mail list logo