[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-17 Thread Chris Apple via cfe-commits
@@ -194,12 +198,43 @@ Some issues with flags can be debugged using the ``verbosity=$NUM`` flag: misspelled_flag ... -Disabling -- +Disabling and suppressing +- -In some circumstances, you may want to suppress error reporting in a specif

[clang] [rtsan][NFC] Documentation of suppression flag (PR #112727)

2024-10-17 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/112727 None >From c8b2090824d19618e876051cfcc18a4fad49649d Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 17 Oct 2024 08:20:08 -0700 Subject: [PATCH] [rtsan][NFC] Documentation of suppression flag --- clang/do

[clang] [rtsan] NFC: Update docs with customizable functions (PR #117086)

2024-11-20 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/117086 These functions recently were helpful for a user, so I decided to add them to the official docs. Any feedback on wording or content appreciated as always >From 056fa6a787efb0721b30fee6e0bdea9843e303d4 Mon Sep

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-08 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/119074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] NFC: Adding links to Disabling, adding a few ` marks (PR #119075)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119075 None >From 94225043e5e60424bc10fa0b8d33a21228420866 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Sat, 7 Dec 2024 07:51:45 -0800 Subject: [PATCH] [rtsan] NFC: Very small fixes of docs, adding `, adding link

[clang] [rtsan] NFC: Adding links to Disabling, adding a few ` marks (PR #119075)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/119075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl updated https://github.com/llvm/llvm-project/pull/119074 >From 2c882a78ce82801590a6bfd217c8e8b8e4b4c6f5 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Sat, 7 Dec 2024 07:45:34 -0800 Subject: [PATCH] [rtsan] Add `verify_interceptors` to docs --- clang/docs/RealtimeS

[clang] [rtsan] Add `verify_interceptors` flag to docs (PR #119074)

2024-12-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119074 None >From 649e184e37ba94ac77b840ae4d02213a8fb77ab5 Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Sat, 7 Dec 2024 07:45:34 -0800 Subject: [PATCH] [rtsan] Add `verify_interceptors` to docs --- clang/docs/Rea

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-03 Thread Chris Apple via cfe-commits
cjappl wrote: > @devnexen in principle, I'm of course not opposed to rtsan supporting FreeBSD > - is there any motivation in particular for why you propose adding it here? > Is this the first of many patches that are needed, or is it the only one that > you can foresee? I'd like to make sure t

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
@@ -1539,6 +1543,7 @@ TEST_F(KqueueTest, KeventDiesWhenRealtime) { ExpectNonRealtimeSurvival(Func); } +#if SANITIZER_APPLE cjappl wrote: ah, fine to leave then probably. Thanks for pointing that out https://github.com/llvm/llvm-project/pull/125389

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
https://github.com/cjappl commented: Cool, much better with this version of the init! A few more smaller scale things and this is looking good https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
@@ -864,11 +864,18 @@ INTERCEPTOR(void *, pvalloc, size_t size) { #define RTSAN_MAYBE_INTERCEPT_PVALLOC #endif +#if !SANITIZER_FREEBSD +// enabling this interception on freebsd leads to infinite recursion +// on pthread lib initialization cjappl wrote: Can yo

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-07 Thread Chris Apple via cfe-commits
@@ -1539,6 +1543,7 @@ TEST_F(KqueueTest, KeventDiesWhenRealtime) { ExpectNonRealtimeSurvival(Func); } +#if SANITIZER_APPLE cjappl wrote: "Kqueue is a scalable event notification interface introduced in FreeBSD 4.1 in July 2000, also supported in NetBSD, Op

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl commented: (sorry meant to leave these comments the other day, these comments are separate from the "should we enable it" discussion) https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@l

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
@@ -43,6 +44,21 @@ static __rtsan::Context &GetContextForThisThreadImpl() { return *current_thread_context; } +#else + +// On FreeBSD, pthread api cannot be used as calloc is called under the hood +// at library initialization time. cjappl wrote: Can you el

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/125389 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] Rtsan fbsd (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
@@ -43,6 +44,21 @@ static __rtsan::Context &GetContextForThisThreadImpl() { return *current_thread_context; } +#else + +// On FreeBSD, pthread api cannot be used as calloc is called under the hood +// at library initialization time. +static __thread Context *ctx = nullptr; +

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
cjappl wrote: Thanks for the feedback @brooksdavis and @bsdimp - always hard to tell how popular or unpopular a change would be, especially from "outside the community" (aka me not knowing much about the BSD flavors :) > Sure we can keep it open for a while, still a long road before 21.x anyw

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-05 Thread Chris Apple via cfe-commits
@@ -43,6 +44,21 @@ static __rtsan::Context &GetContextForThisThreadImpl() { return *current_thread_context; } +#else + +// On FreeBSD, pthread api cannot be used as calloc is called under the hood +// at library initialization time. +static __thread Context *ctx = nullptr; +

[clang] [compiler-rt] [rtsan] Enable RealtimeSanitizer for FreeBSD (PR #125389)

2025-02-10 Thread Chris Apple via cfe-commits
@@ -864,11 +864,18 @@ INTERCEPTOR(void *, pvalloc, size_t size) { #define RTSAN_MAYBE_INTERCEPT_PVALLOC #endif +#if !SANITIZER_FREEBSD +// enabling this interception on freebsd leads to infinite recursion +// on pthread lib initialization cjappl wrote: It loo

[clang] [llvm] [LLVM][rtsan] Add module pass to initialize rtsan (PR #118989)

2024-12-12 Thread Chris Apple via cfe-commits
@@ -1024,12 +1024,14 @@ void EmitAssemblyHelper::RunOptimizationPipeline( FPM.addPass(BoundsCheckingPass()); }); -if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) +if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) { PB.registerScalarOp

[clang] [llvm] [LLVM][rtsan] Add module pass to initialize rtsan (PR #118989)

2024-12-12 Thread Chris Apple via cfe-commits
@@ -1024,12 +1024,14 @@ void EmitAssemblyHelper::RunOptimizationPipeline( FPM.addPass(BoundsCheckingPass()); }); -if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) +if (LangOpts.Sanitize.has(SanitizerKind::Realtime)) { cjappl wr

[clang] [llvm] [rtsan][llvm] Remove functional pass, only support module pass (PR #119739)

2024-12-12 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119739 As suggested by @vitalybuka on #118989 Most of the other sanitizers are now only module level passes. This moves all functionality into the module pass, and removes the function pass. >From c19f2f7da960a81e2c8

[clang] [llvm] [rtsan][llvm] Remove function pass, only support module pass (PR #119739)

2024-12-12 Thread Chris Apple via cfe-commits
cjappl wrote: > > Remove functional pass > > > > function pass? Thanks, fixed https://github.com/llvm/llvm-project/pull/119739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [rtsan][llvm] Remove function pass, only support module pass (PR #119739)

2024-12-12 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/119739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][clang] NFC: Move rtsan init to addSanitizers (PR #119904)

2024-12-13 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/119904 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [rtsan][llvm] Remove function pass, only support module pass (PR #119739)

2024-12-13 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/119739 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan][clang] NFC: Move rtsan init to addSanitizers (PR #119904)

2024-12-13 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/119904 This seems to pass tests and behaves as expected. As suggested by @vitalybuka on #118989 >From 8cfcf0461739e45716be1b3ed6700b5712b7801e Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 12 Dec 2024 10:37:1

[clang] [rtsan] NFC: Update docs with customizable functions (PR #117086)

2024-11-21 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/117086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] NFC: Update docs with suppress_equal_stacks (PR #117187)

2024-11-21 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/117187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [rtsan] NFC: Update docs with suppress_equal_stacks (PR #117187)

2024-11-21 Thread Chris Apple via cfe-commits
https://github.com/cjappl created https://github.com/llvm/llvm-project/pull/117187 None >From b5888f70bd1bbefc6a711ef2022478980ed2505f Mon Sep 17 00:00:00 2001 From: Chris Apple Date: Thu, 21 Nov 2024 08:45:33 -0800 Subject: [PATCH] [rtsan] NFC: Update docs with suppress_equal_stacks --- cla

[clang] [llvm] [LLVM][rtsan] Add module pass to initialize rtsan (PR #118989)

2024-12-06 Thread Chris Apple via cfe-commits
@@ -25,3 +25,7 @@ attributes #0 = { mustprogress noinline sanitize_realtime optnone ssp uwtable(sy ; RealtimeSanitizer pass should insert __rtsan_realtime_exit right before function return ; CHECK: call{{.*}}@__rtsan_realtime_exit ; CHECK-NEXT: ret{{.*}}void + +; RealtimeSani

[clang] [llvm] [LLVM][rtsan] Add module pass to initialize rtsan (PR #118989)

2024-12-06 Thread Chris Apple via cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/118989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3