[PATCH] D113049: [AIX] Disable tests that fail because of no 64-bit XCOFF object file support

shchenz added a comment. Look almost good! Thanks for doing this. Comment at: clang/test/ASTMerge/codegen-body/test.c:1 +// UNSUPPORTED: powerpc64-ibm-aix // RUN: %clang_cc1 -emit-pch -o %t.1.ast %S/Inputs/body1.c Jake-Egan wrote: > shchenz wrote: > > Do we st

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_plu

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz added a comment. In D99250#2650561 , @probinson wrote: > In D99250#2649507 , @Esme wrote: > >> Thx! @aprantl The motivation of the patch came from the crash of tag name >> mismatching when using DBX under A

[PATCH] D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF

shchenz created this revision. Herald added subscribers: jansvoboda11, dexonsmith, dang. shchenz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. add new tuning debugger type DBX for XCOFF DWARF. Based on this debugger typ

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz added a comment. Thanks for your comments @dblaikie @probinson . Sent out a mail to llvm-dev for continuous discussion. https://lists.llvm.org/pipermail/llvm-dev/2021-March/149446.html Welcome your comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz added inline comments. Comment at: clang/lib/CodeGen/CGDebugInfo.cpp:572 LangTag = llvm::dwarf::DW_LANG_C_plus_plus_14; -else if (LO.CPlusPlus11) +else if (LO.CPlusPlus11 && CGM.getCodeGenOpts().DwarfVersion >= 5) LangTag = llvm::dwarf::DW_LANG_C_plu

[PATCH] D99250: [DebugInfo] Fix the mismatching of C++ language tags and Dwarf versions.

shchenz accepted this revision. shchenz added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99250/new/ https://reviews.llvm.org/D99250 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbfcd21876adc: [debug-info] support new tuning debugger type DBX for XCOFF DWARF (authored by shchenz). Changed prior to commit: https://reviews.ll

[PATCH] D99400: [debug-info] support new tuning debugger type DBX for XCOFF DWARF

shchenz added inline comments. Comment at: llvm/include/llvm/Target/TargetOptions.h:112 +SCE, // Tune debug info for SCE targets (e.g. PS4). +DBX // Tune debug info for dbx. }; aprantl wrote: > Nit: It would be nice to reformat all these com

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

shchenz created this revision. shchenz added reviewers: dblaikie, aprantl, jsji, probinson, echristo, PowerPC. shchenz added a project: debug-info. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For DBX, it does not handle column i

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

This revision was automatically updated to reflect the committed changes. Closed by commit rGf026e1f52055: [debug-info][XCOFF] set `-gno-column-info` by default for DBX (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D99703?vs=334589&id=334879#toc Repository: rG LLVM

[PATCH] D99703: [debug-info][XCOFF] set `-gno-column-info` by default for DBX

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3974 + // Microsoft debuggers don't handle missing end columns well, and the AIX + // debugger DBX also doesn't handle the columns well, so it's bettre not to + // include any column info. ---

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz created this revision. shchenz added reviewers: dblaikie, aprantl, probinson, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. shchenz requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. As discussed in D99250

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2694681 , @probinson wrote: > If DBX is going to be really pedantic about not recognizing tags or > attributes that don't align with the DWARF version, maybe we're better off > with really supporting `-gstrict-dwarf`

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. Herald added subscribers: jansvoboda11, dexonsmith, dang. shchenz requested review of this revision. Herald added a project: clang. Herald added

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz added a comment. In D100630#2697732 , @dblaikie wrote: > In D100630#2697728 , @shchenz wrote: > >> In D100630#2694681 , @probinson >> wrote: >> >>> If DBX is goin

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 338695. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-rvalue-ref.cpp Index: clang/test

[PATCH] D100630: [Debug-Info][DBX] DW_TAG_rvalue_reference_type should not be generated when dwarf version is smaller than 4

shchenz updated this revision to Diff 338755. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100630/new/ https://reviews.llvm.org/D100630 Files: clang/lib/CodeGen/CGDebugInfo.cpp clang/test/CodeGenCXX/debug-info-rvalue-ref.cpp Index: clang/test

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz created this revision. shchenz added reviewers: dblaikie, probinson, aprantl, jsji, Esme, echristo, PowerPC. shchenz added a project: debug-info. Herald added a subscriber: hiraditya. shchenz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: l

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz updated this revision to Diff 338752. shchenz marked 2 inline comments as done. shchenz added a comment. address @dblaikie comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100809/new/ https://reviews.llvm.org/D100809 Files: clang/

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3973-3974 + // as true by default. + if (const Arg *A = Args.getLastArg(options::OPT_gstrict_dwarf)) +(void)checkDebugInfoOption(A, Args, D, TC); + if (Args.hasFlag(options::OPT_gstrict_dwarf,

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz added a comment. In D100826#2702135 , @dblaikie wrote: > Do you know if you're going to be using LTO with DBX? If so, to respect this > flag, it would need to be added to LLVM IR module metadata (like the Dwarf > Version and Debug Info Version f

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

shchenz added a comment. Thanks for your review! @probinson @dblaikie @aprantl Comment at: clang/docs/ClangCommandLineReference.rst:3549-3550 +Use DWARF extensions in later DWARF versions. + .. option:: -gz=, -gz (equivalent to -gz=zlib) probinson wrote: > d

[PATCH] D100809: [Debug-Info] implement -gstrict-dwarf

This revision was automatically updated to reflect the committed changes. Closed by commit rG26f138eed4af: [Debug-Info] implement -gstrict-dwarf (authored by shchenz). Changed prior to commit: https://reviews.llvm.org/D100809?vs=338752&id=339464#toc Repository: rG LLVM Github Monorepo CHANG

[PATCH] D100826: [Debug-Info][NFC] add -gstrict-dwarf support in backend

shchenz updated this revision to Diff 339470. shchenz added a comment. Herald added a subscriber: nemanjai. 1: add NFC testcases to use `-gstrict-dwarf` option Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100826/new/ https://reviews.llvm.org/D1008

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

shchenz added a comment. Thanks for working on this. Could you please help to rerun the affected cases after applying D97184 ? That patch is approved and I will deliver it soon. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[PATCH] D111169: [AIX] Disable tests failing due to assert on DWARF object writing

shchenz added a comment. In D69#3048311 , @Jake-Egan wrote: > In D69#3047761 , @shchenz wrote: > >> Thanks for working on this. >> >> Could you please help to rerun the affected cases after applying D97184

[PATCH] D111336: [AIX] Disable tests failing due to missing DWARF sections

shchenz accepted this revision. shchenz added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111336/new/ https://reviews.llvm.org/D111336

<    1   2