https://github.com/barcharcraz edited
https://github.com/llvm/llvm-project/pull/81677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
barcharcraz wrote:
@rnk @vitalybuka
This should be ready for a more in-depth review (I'll stop force-pushing)
The remaining commits here all depend on each-other in some way. Splitting off
any more commits would mean introducing bugs into main until other parts of
this are merged.
https://
barcharcraz wrote:
@vitalybuka Here's a more detailed explination on the motivations behind this
change from @amyw-msft, who is the original author of these changes on our
side. (And who I'll add as a co-author using fixup commits)
https://devblogs.microsoft.com/cppblog/msvc-address-sanitizer-
barcharcraz wrote:
> > @vitalybuka Here's a more detailed explination on the motivations behind
> > this change from @amyw-msft, who is the original author of these changes on
> > our side. (And who I'll add as a co-author using fixup commits)
> > https://devblogs.microsoft.com/cppblog/msvc-add
barcharcraz wrote:
> Is it feasible to create a migration path from the static runtime to the
> dynamic runtime? As written, this requires users to update their ASan builds
> at the same time that they take this update. Is it possible to leave the
> static runtime behind, create a migration pa
barcharcraz wrote:
> This is long description, but it does not explain WHY. Could you please add
> some explanation there?
Sure, the reason is to greatly simplify how asan works on windows, and to fix a
bunch of bugs with asan+static CRT. Before this change there was a bunch of
code that woul
barcharcraz wrote:
> I think @rnk has the deepest knowledge here.
>
> Just to double check, when you say "Eliminate the static asan runtime", you
> mean the use case it was supporting will still keep working, but in a
> different way right?
Yes. The static asan runtime didn't work very well i
barcharcraz wrote:
> > The core reasoning is that asan is a "only one allowed per process" type
> > thing (you can't have one copy of the asan runtime handling a malloc while
> > a different one handles the corresponding free).
>
> Not to distract from the direction taken here (which I do agre
barcharcraz wrote:
It occurs to me that this probably requires changes to the gyp build files.
https://github.com/llvm/llvm-project/pull/81677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
https://github.com/barcharcraz ready_for_review
https://github.com/llvm/llvm-project/pull/81677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
barcharcraz wrote:
The buildkite failure is just windows defender freaking out about one of
cmake's test exes. Presumably it'll get sorted out next time it runs.
https://github.com/llvm/llvm-project/pull/81677
___
cfe-commits mailing list
cfe-commits@
https://github.com/barcharcraz closed
https://github.com/llvm/llvm-project/pull/107899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/barcharcraz edited
https://github.com/llvm/llvm-project/pull/81677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/barcharcraz closed
https://github.com/llvm/llvm-project/pull/81677
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/barcharcraz edited
https://github.com/llvm/llvm-project/pull/93770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/barcharcraz closed
https://github.com/llvm/llvm-project/pull/93770
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -35,6 +35,9 @@
// RUN: %p/../../../../lib/sanitizer_common/sanitizer_coverage_interface.inc
\
// RUN: | grep -e "INTERFACE_\(WEAK_\)\?FUNCTION"
\
// RUN: | grep -v "__sanitizer_weak_hook"
\
+// R
barcharcraz wrote:
> This PR seems to have broken ASAN in mingw configurations. The symptoms seem
> to be that the ASAN DLL just locks up, hard, when the process is loaded. (Or
> more precisely, has entered some infinite loop.)
>
> I tried attaching to such a hung process with windbg, and it's
@@ -136,7 +160,7 @@ append_list_if(MINGW "${MINGW_LIBRARIES}" ASAN_DYNAMIC_LIBS)
add_compiler_rt_object_libraries(RTAsan_dynamic
OS ${SANITIZER_COMMON_SUPPORTED_OS}
ARCHS ${ASAN_SUPPORTED_ARCH}
- SOURCES ${ASAN_SOURCES} ${ASAN_CXX_SOURCES}
+ SOURCES ${ASAN_SOURCES}
--
19 matches
Mail list logo
