[PATCH] D72841: Add support for pragma float_control, to control precision and exception behavior at the source level

cfang added a comment. -ffast-math flag got lost in the Builder after this change. FMF.isFast() is true before updateFastMathFlags(FMF, FPFeatures), but turns false after. It seems the Builder.FMF has been correctly set before, but I am not clear what FPFeatures should be at this point: +sta

[PATCH] D120265: AMDGPU: Use the implicit kernargs for code object version 5

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdd5895cc3986: AMDGPU: Use the implicit kernargs for code object version 5 (authored by cfang). Herald added a project: clang. Herald added a subscrib

[PATCH] D134355: [AMDGPU] Emit module flag for all code object versions

cfang accepted this revision. cfang added a comment. This revision is now accepted and ready to land. LGTM Should the module flag name be amdgpu_code_object_version or amdhsa_code_object_version? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134355/new/ https://reviews.llvm.org/D13435

[PATCH] D155986: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd77c62053c94: [clang][AMDGPU]: Don't use byval for struct arguments in function ABI (authored by cfang). Herald added a project: clang. Herald added

[PATCH] D146023: [AMDGPU] Remove Code Object V2

cfang added a comment. Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:5598 return ParseDirectiveHSAMetadata(); } else { -if (IDVal == ".hsa_code_object_version") Are you sure Non-HSA does not have the four directives you deleted