[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

chandlerc added inline comments. Comment at: lib/Driver/ToolChains/Clang.cpp:592-595 + if (Arg *A = Args.getLastArg(options::OPT_fno_omit_frame_pointer, + options::OPT_fomit_frame_pointer)) +return A->getOption().matches(options::OPT_fno_omit_fr

[PATCH] D56112: [clang-offload-bundler] Added install component

chandlerc edited reviewers, added: ABataev, hfinkel; removed: chandlerc. chandlerc added a comment. Adding likely more useful reviewers... Not really interesting from a CMake perspective. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56112/new/ https://reviews.l

[PATCH] D66324: clang-misexpect: Profile Guided Validation of Performance Annotations in LLVM

chandlerc added inline comments. Comment at: compiler-rt/trunk/lib/profile/xxhash.h:41-42 + +#include "llvm/ADT/ArrayRef.h" +#include "llvm/ADT/StringRef.h" + Sorry folks, but you can't do this. You can't depend on ADT from compiler-rt currently. There are at l

[PATCH] D44883: [Sema] Extend -Wself-assign and -Wself-assign-field to warn on overloaded self-assignment (classes)

chandlerc added a comment. These kinds of improvements to warnings are awesome, but the way we are deploying them presents serious challenges to adoption which I think we need to address. I think significant new warning functionality should as a matter of course go behind some warning group at

[PATCH] D45505: [WIP] [GCC] Match a GCC version with a patch suffix without a third version component

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Definitely need tests here. But no concern w/ the idea of this. Repository: rC Clang https://reviews.llvm.org/D45505 ___ cfe-

[PATCH] D45505: [WIP] [GCC] Match a GCC version with a patch suffix without a third version component

chandlerc added a comment. In https://reviews.llvm.org/D45505#1074747, @mstorsjo wrote: > In https://reviews.llvm.org/D45505#1074744, @chandlerc wrote: > > > Definitely need tests here. > > > Do you have any suggestion on where to create them and what kind? Just a > normal test with a fake direc

[PATCH] D45505: [GCC] Match a GCC version with a patch suffix without a third version component

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D45505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D46135: [Driver, CodeGen] add options to enable/disable an FP cast optimization

chandlerc added inline comments. Comment at: docs/UsersManual.rst:1260-1265 + Enable or disable a code generation optimization that may convert a + cast of a floating-point value to integer and back to floating-point + into the equivalent of the math libary's 'trunc()' func

[PATCH] D46135: [Driver, CodeGen] add options to enable/disable an FP cast optimization

chandlerc added inline comments. Comment at: docs/UsersManual.rst:1260-1265 + Enable or disable a code generation optimization that may convert a + cast of a floating-point value to integer and back to floating-point + into the equivalent of the math libary's 'trunc()' func

[PATCH] D46135: [Driver, CodeGen] add options to enable/disable an FP cast optimization

chandlerc added a comment. In https://reviews.llvm.org/D46135#1080108, @spatel wrote: > 3. Remove the 'no' version of the flag. Given the change in the default, this > seems more natural to me, and it simplifies the patch/tests...but I might > have been too pessimistic before and this is too op

[PATCH] D46135: [Driver, CodeGen] add options to enable/disable an FP cast optimization

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, thanks so much! https://reviews.llvm.org/D46135 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[PATCH] D48617: [Builtins][Attributes][X86] Tag all X86 builtins with their required vector width. Add a min_vector_width function attribute and tag all x86 instrinsics with it.

chandlerc added a comment. FWIW, I looked at an early version of this patch and am generally happy with the target-specific / IR-specific behavior aspects of it. Totally leaving the detailed review of the attribute stuff to you Aaron, as you're already doing an amazing job there. Minor clarific

[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

chandlerc resigned from this revision. chandlerc added a comment. I don't have any problem with this patch's code in theory but: 1. The question of whether this macro approach is better or worse than FreeBSD's or MUSL's seems a question for libc++ maintainers, not me. 2. The question of whether

[PATCH] D68535: Fix loop unrolling initialization in the new pass manager

chandlerc accepted this revision. chandlerc added a reviewer: asbirlea. chandlerc added a comment. This revision is now accepted and ready to land. Adding Alina so she is aware of the change and can comment if she spots anything I'm missing... I think this is fine to go in as-is to fix the immed

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

chandlerc created this revision. chandlerc added a reviewer: klimek. Herald added a subscriber: mcrosier. Herald added a project: clang. Working with Meike and others to improve the wording in this document. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D69351 Files: clang/w

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

chandlerc updated this revision to Diff 226174. chandlerc marked 3 inline comments as done. chandlerc added a comment. More fixes from Manuel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69351/new/ https://reviews.llvm.org/D69351 Files: clang/

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

chandlerc updated this revision to Diff 226171. chandlerc marked an inline comment as done. chandlerc added a comment. Address feedback from Manuel. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69351/new/ https://reviews.llvm.org/D69351 Files:

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

chandlerc marked 2 inline comments as done. chandlerc added a comment. Thanks, updated. Comment at: clang/www/get_involved.html:113 + + A high-quality implementation: The implementation must fit well into + Clang's architecture, follow LLVM's coding conventions, and meet Clan

[PATCH] D69351: Improve Clang's getting involved document and make it more inclusive in wording.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdc1499b90dc4: Improve Clang's getting involved document and make it more inclusive in wording. (authored by chandlerc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc created this revision. Herald added subscribers: cfe-commits, mcrosier. Herald added a project: clang. No idea if this is 'correct' or the right way to fix this, so just sending this mostly as an FYI. Someone who works more closely on the sanitizers might need to take it over and figure

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

chandlerc accepted this revision. chandlerc added a comment. Cool, thanks and LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71687/new/ https://reviews.llvm.org/D71687 ___ cfe-commits mailing list

[PATCH] D75936: Add a Pass to X86 that builds a Condensed CFG for Load Value Injection (LVI) Gadgets [4/6]

chandlerc added inline comments. Comment at: llvm/lib/Target/X86/ImmutableGraph.h:46-56 + using NodeValueT = _NodeValueT; + using EdgeValueT = _EdgeValueT; + using size_type = _SizeT; + class Node; + class Edge { +friend class ImmutableGraph; +template friend class

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

chandlerc added a comment. Really like the approach now. Pretty minor code nits below only. =D Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +&CGAM.getResult(*C, CG); +ResultFAMCP->updateFAM(FAM);

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

chandlerc added a comment. Wooot about finally having a test case! (Sorry for nit picking it a bit ) Comment at: llvm/test/Transforms/LoopUnroll/FullUnroll.ll:4-6 +; We don't end up deleting the loop, but we remove everything inside of it so checking for any +; reasonable

[PATCH] D72893: [NewPassManager] Add assertions when getting statefull cached analysis.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM other than two nits here, this is really awesome! Comment at: llvm/include/llvm/Analysis/CGSCCPassManager.h:856-858 +auto *ResultFAMCP = +&CGAM

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

chandlerc added inline comments. Comment at: clang/test/Misc/loop-opt-setup.c:12 +// Check br i1 to make sure that the loop is fully unrolled // CHECK-NOT: br i1 This is dead now that you have different prefixes... Comment at: clang/test/Mis

[PATCH] D66988: [NewPM][Sancov] Make Sancov a Module Pass instead of 2 Passes

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM This also makes sense to me why it would OOM. I suspect we're building a massive list, and at best we get lucky and they get de-duped later. At worst, this is actually fixing a ser

[PATCH] D67323: [NewPM][Sancov] Create the Sancov Pass after building the pipelines

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM to fix folks broken by this. That said, we should look for a way to test this in a follow up patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D36562: [Bitfield] Make the bitfield a separate location if it has width of legal integer type and its bit offset is naturally aligned for the type

chandlerc added a comment. I'm really not a fan of the degree of complexity and subtlety that this introduces into the frontend, all to allow particular backend optimizations. I feel like this is Clang working around a fundamental deficiency in LLVM and we should instead find a way to fix this

[PATCH] D87837: [Driver] Remove the deprecation warning for -fuse-ld=/abs/path

chandlerc added a comment. FWIW, I would like to see *something* like this (both in the release and on trunk) but not sure this is actually the patch we want... Clang typically uses `FIXME` comments, and doesn't leave commented out code... I feel like this should be an off-by-default warning, w

[PATCH] D87837: [Driver] Add disabled-by-default -Wuse-ld-path for the deprecation warning for -fuse-ld=/abs/path

chandlerc added a comment. Good to confirm with Dave of course, but this looks pretty great to me, and thanks so much! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87837/new/ https://reviews.llvm.org/D87837 __

[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

chandlerc added a comment. In D88789#2310967 , @efriedma wrote: > In D88789#2310606 , @chandlerc wrote: > >> FWIW, I still very much feel that this is the correct canonicalization, and >> that downstream problems *

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc added a reviewer: vitalybuka. chandlerc marked an inline comment as done. chandlerc added a comment. Ping (and adding some sanitizer folks)? I'd really love to stop building with this local patch Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:754 + i

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc added a comment. In D80488#2341009 , @vitalybuka wrote: > LGTM, but it could be better with a test Thanks, added test and landing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80488/new/ https://reviews.llvm.org/D80488 _

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

chandlerc updated this revision to Diff 300842. chandlerc marked an inline comment as done. chandlerc added a comment. Update with a regression test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80488/new/ https://reviews.llvm.org/D80488 Files: clang/lib/Driver/ToolChains/CommonArgs

[PATCH] D80488: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when adding C++ standard libraries.

This revision was automatically updated to reflect the committed changes. Closed by commit rGaaf7ffd4e1aa: Teach `-fsanitize=fuzzer` to respect `-static` and `-static-libstdc++` when… (authored by chandlerc). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:1059 +#undef strcasecmp +#undef strncasecmp + thakis wrote: > Why do we need this with bazel but not with other windows builds? I don't know how this never was hit by other builde

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc updated this revision to Diff 383634. chandlerc marked 5 inline comments as done. chandlerc edited the summary of this revision. chandlerc added a reviewer: rnk. chandlerc added a comment. Major update to better fix some of the issues here. No longer requires any changes outside of Baze

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc requested review of this revision. chandlerc added a comment. PTAL, and thanks for feedback so far! Comment at: clang/include/clang/Basic/Builtins.def:1059 +#undef strcasecmp +#undef strncasecmp + rnk wrote: > thakis wrote: > > GMNGeoffrey wrote: > >

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc created this revision. chandlerc added reviewers: GMNGeoffrey, dblaikie. Herald added a subscriber: mcrosier. chandlerc requested review of this revision. Sadly, these are necessary AFAICT. There is a file `lib/AST/CXXABI.h`. On case insensitive file systems like macOS this will collide

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1fdd745d510: Re-introduce `copts` hacks for lib/AST includes. (authored by chandlerc). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc added a comment. In D112883#3101645 , @GMNGeoffrey wrote: > :-( Did you try the separate library with `strip_include_prefix`? I can add a separate library to do that. It would still expose all consumers to `Opcodes.inc` instead of only ex

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc added a comment. Thanks, making suggested changes and then landing! Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:364 +# Clang-specific define on non-Windows platforms. +"CLANG_HAVE_RLIMITS=1", +], GMNG

[PATCH] D112883: [bazel] Re-introduce `copts` hacks for lib/AST includes.

chandlerc added a comment. In D112883#3101685 , @GMNGeoffrey wrote: >> Is this breaking actual users? I wouldn't expect it to break unless they >> depend on this target. > > I don't know :-) I just know that people have sent me patches to remove the >

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

chandlerc added inline comments. Comment at: utils/bazel/llvm-project-overlay/clang/BUILD.bazel:1828 ], -copts = [ -"-Wno-uninitialized", -], +copts = select({ +"@bazel_tools//src/conditions:windows": [], rnk wrote: > Enabling war

[PATCH] D112399: Get Bazel building `//clang` on Windows with clang-cl.

This revision was automatically updated to reflect the committed changes. Closed by commit rG0198d76e1e76: [Bazel] Get `//clang` building on Windows with clang-cl. (authored by chandlerc). Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Changed prior to commit: https://re

[PATCH] D157188: [clang-tidy] Add bugprone-new-bool-conversion

chandlerc added a comment. In D157188#4563143 , @Eugene.Zelenko wrote: > In D157188#4563139 , @PiotrZSL > wrote: > >> In D157188#4563105 , >> @Eugene.Zelenko wrote: >>

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a reviewer: chandlerc. chandlerc added a comment. Thanks for sending this out! I've made a minor comment on the flag structure, but my bigger question would be: can you summarize the performance hit and code size hit you've seen across some benchmarks? SPEC and the LLVM test sui

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a comment. (Just a reminder that we need to have both performance and code size numbers for this patch. And given that there are a few options, may need a few examples.) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new/ https://reviews.llvm.org/D70157 ___

[PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Minor nits around redundant predicates for SROA. With thouse fixed, LGTM. I'd really love to find a way to make TCO debuggable so that we don't lose that. I'm particularly worried about

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a comment. I'm seeing lots of updates to fix bugs, but no movement for many days on both my meta comments and (in some ways more importantly) James's meta comments. (And thanks Philip for chiming in too!) Meanwhile, we really, really need to get this functionality in place. The

[PATCH] D70157: Align branches within 32-Byte boundary

chandlerc added a comment. Just wanted to say thanks for the performance data! I know it was hard to get, but it is really, really useful to help folks evaluate these kinds of changes with actual data around the options available. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70157/new

[PATCH] D71687: Fix full loop unrolling initialization in new pass manager

chandlerc added a comment. Can we add an LLVM test w/ the metadata so that we have an entirely LLVM test flow that ensures the pass builder DTRT? (I still would include the Clang side test which is also very useful to test integrating Clang w/ different flows through the pass manager.) Reposi

[PATCH] D43871: [modules] No longer include stdlib.h from mm_malloc.h.

chandlerc resigned from this revision. chandlerc added a comment. I think this is more a question for Richard... Add me back to the reviewers if there is a specific need for my input here. Repository: rC Clang https://reviews.llvm.org/D43871 ___

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. Just a question really. Comment at: clang/CMakeLists.txt:215 +set(ENABLE_EXPERIMENTAL_NEW_PASS_MANAGER FALSE CACHE BOOL + "Enable the experimental new pass

[PATCH] D42787: clang-format: do not add extra indent when wrapping last parameter

chandlerc resigned from this revision. chandlerc added a comment. Since this seems not going anywhere, removing it from my review dashboard. Repository: rC Clang https://reviews.llvm.org/D42787 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D45289: Disable -fmerge-all-constants as default.

chandlerc accepted this revision. chandlerc added a comment. Just wanted to explicitly say +1 to this default change (with the adjustment Richard suggested). Also, John already said +1 to this default change on the bug. Repository: rC Clang https://reviews.llvm.org/D45289 ___

[PATCH] D44330: CMake option to allow enabling experimental new pass manager by default

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. Meh, I think this is fine as-is. Repository: rC Clang https://reviews.llvm.org/D44330 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D38824: [X86] Synchronize the existing CPU predefined macros with the cases that gcc defines them

chandlerc added a comment. So, doing research to understand the impact of this has convinced me we *really* need to stop doing this. Multiple libraries are actually trying to enumerate every CPU that has feature X for some feature X. =[[[ This, combined with the fundamental pattern of defining

[PATCH] D39349: [X86] Make -march=i686 an alias of -march=pentiumpro

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, nice. https://reviews.llvm.org/D39349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/l

[PATCH] D38824: [X86] Synchronize the existing CPU predefined macros with the cases that gcc defines them

chandlerc added a comment. In https://reviews.llvm.org/D38824#908540, @RKSimon wrote: > Where is the best place to document this policy so people have a chance of > understanding it going forward? Given the (apparent) amount of confusion here, I'd suggest a dedicated document in Clang's docum

[PATCH] D40007: [NewPassManager] Pass the -fdebug-pass-manager flag setting into the Analysis managers to match what we do in opt

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM, nice catch! Maybe update one of the new PM tests to check that this debug printing is available? =D https://reviews.llvm.org/D40007 ___

[PATCH] D26530: Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290159: Fix the spelling of 'bitfield' in diagnostics to be consistently 'bit-field'. (authored by chandlerc). Changed prior to commit: https://reviews.llvm.org/D26530?vs=81008&id=82055#toc Repository:

[PATCH] D28047: Remove the '-disable-llvm-passes' flag (which I didn't even know existed, and I suspect many others aren't aware of either) and strength '-disable-llvm-optzns' to do the same thing.

chandlerc created this revision. chandlerc added reviewers: rsmith, mehdi_amini. chandlerc added a subscriber: cfe-commits. Herald added a subscriber: mcrosier. Much to my surprise, '-disable-llvm-optzns' which I thought was the magical flag I wanted to get at the raw LLVM IR coming out of Clang d

[PATCH] D28053: Cleanup the handling of noinline function attributes, -fno-inline, -fno-inline-functions, -O0, and optnone.

chandlerc created this revision. chandlerc added reviewers: rsmith, rnk, mehdi_amini. chandlerc added a subscriber: cfe-commits. chandlerc added a dependency: D28047: Remove the '-disable-llvm-passes' flag (which I didn't even know existed, and I suspect many others aren't aware of either) and st

[PATCH] D28047: Remove the '-disable-llvm-passes' flag (which I didn't even know existed, and I suspect many others aren't aware of either) and strength '-disable-llvm-optzns' to do the same thing.

chandlerc added a comment. In https://reviews.llvm.org/D28047#629824, @mehdi_amini wrote: > In https://reviews.llvm.org/D28047#629746, @rnk wrote: > > > How about standardizing on -disable-llvm-passes instead of > > -disable-llvm-optzns? I never liked "optzns" and can't remember how to > > spel

[PATCH] D28053: Cleanup the handling of noinline function attributes, -fno-inline, -fno-inline-functions, -O0, and optnone.

chandlerc added a comment. In https://reviews.llvm.org/D28053#629830, @mehdi_amini wrote: > > It would be awesome if attribute sets were a bit more FileCheck friendly, > > but oh well. > > I've been wondering about that, what's the point of attribute sets in the > textual IR? > I understand th

[PATCH] D28053: Cleanup the handling of noinline function attributes, -fno-inline, -fno-inline-functions, -O0, and optnone.

chandlerc updated this revision to Diff 82356. chandlerc added a comment. Herald added a subscriber: wdng. Fix an thinko found in review, clean up comments, and clean up pass pipeline selection as that actually needs to happen in this patch as well. Also update one test using -O1 and observing th

[PATCH] D28053: Cleanup the handling of noinline function attributes, -fno-inline, -fno-inline-functions, -O0, and optnone.

chandlerc added a comment. In https://reviews.llvm.org/D28053#629834, @mehdi_amini wrote: > In https://reviews.llvm.org/D28053#629768, @rnk wrote: > > > The big change here is that `clang -O0` now applies the noinline attribute > > everywhere. I can see why someone might expect things to work th

[PATCH] D28047: Remove the '-disable-llvm-passes' flag (which I didn't even know existed, and I suspect many others aren't aware of either) and strength '-disable-llvm-optzns' to do the same thing.

chandlerc added a comment. In https://reviews.llvm.org/D28047#629892, @mehdi_amini wrote: > LGTM, but please wait for @rnk to confirm :) > > Also any opinion about a driver option -emit-raw-llvm as @joerg suggested? I like the idea generally, but I don't have an immediate use case and would d

[PATCH] D28047: Remove the '-disable-llvm-passes' flag (which I didn't even know existed, and I suspect many others aren't aware of either) and strength '-disable-llvm-optzns' to do the same thing.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290392: Make '-disable-llvm-optzns' an alias for '-disable-llvm-passes'. (authored by chandlerc). Changed prior to commit: https://reviews.llvm.org/D28047?vs=82313&id=82383#toc Repository: rL LLVM h

[PATCH] D28053: Cleanup the handling of noinline function attributes, -fno-inline, -fno-inline-functions, -O0, and optnone.

This revision was automatically updated to reflect the committed changes. Closed by commit rL290398: Cleanup the handling of noinline function attributes, -fno-inline, (authored by chandlerc). Changed prior to commit: https://reviews.llvm.org/D28053?vs=82356&id=82390#toc Repository: rL LLVM

[PATCH] D28077: [PM] Introduce options to enable the (still experimental) new pass manager, and a code path to use it.

chandlerc created this revision. chandlerc added reviewers: rsmith, mehdi_amini. chandlerc added a subscriber: cfe-commits. chandlerc added a dependency: D28076: [PM] Add support for building a default AA pipeline to the PassBuilder.. Herald added a subscriber: mcrosier. The option is actually a

[PATCH] D28077: [PM] Introduce options to enable the (still experimental) new pass manager, and a code path to use it.

chandlerc marked 4 inline comments as done. chandlerc added a comment. Thanks for the review, will land shortly with suggested fixes. Comment at: lib/CodeGen/BackendUtil.cpp:757 + setCommandLineOpts(); + cl::PrintOptionValues(); + mehdi_amini wrote: > This is

[PATCH] D28077: [PM] Introduce options to enable the (still experimental) new pass manager, and a code path to use it.

This revision was automatically updated to reflect the committed changes. chandlerc marked 4 inline comments as done. Closed by commit rL290450: [PM] Introduce options to enable the (still experimental) new pass (authored by chandlerc). Changed prior to commit: https://reviews.llvm.org/D28077?v

[PATCH] D28385: Add a cc1 option to force disabling lifetime-markers emission from clang

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

chandlerc added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntime.cpp:760-762 Fn->removeFnAttr(llvm::Attribute::NoInline); + Fn->removeFnAttr(llvm::Attribute::OptimizeNone); Fn->addFnAttr(llvm::Attribute::AlwaysInline); At point where we are i

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

chandlerc added inline comments. Comment at: clang/lib/CodeGen/CodeGenModule.cpp:910-912 // OptimizeNone wins over OptimizeForSize and MinSize. F->removeFnAttr(llvm::Attribute::OptimizeForSize); F->removeFnAttr(llvm::Attribute::MinSize); mehdi_amin

[PATCH] D26244: [Driver] Prefer libraries installed next to Clang over those from GCC

chandlerc requested changes to this revision. chandlerc added a comment. This revision now requires changes to proceed. There are some issues with this patch currently. At a basic level, it needs well crafted test cases. You can find out how to write them by looking at other Driver tests. But a

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

chandlerc added a comment. In https://reviews.llvm.org/D28404#640862, @probinson wrote: > In https://reviews.llvm.org/D28404#640682, @mehdi_amini wrote: > > > > I'm now thinking along the lines of a `-foptimize-off` flag (bikesheds > > > welcome) which would set the default for the pragma to 'of

[PATCH] D26244: [Driver] Prefer libraries installed next to Clang over those from GCC

chandlerc added a comment. In https://reviews.llvm.org/D26244#641076, @Hahnfeld wrote: > This change doesn't break existing tests but maybe I should extend > `linux-ld.c` and so on? > > About the impact: Which libraries are there next to clang that could conflict > with the system? When I look

[PATCH] D28404: IRGen: Add optnone attribute on function during O0

chandlerc added a comment. In https://reviews.llvm.org/D28404#641696, @mehdi_amini wrote: > In https://reviews.llvm.org/D28404#641632, @probinson wrote: > > > In https://reviews.llvm.org/D28404#641606, @mehdi_amini wrote: > > > > > If we want to support `-O0 -flto` and `optnone` it the way to con

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

chandlerc added a comment. Ping? https://reviews.llvm.org/D30806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

chandlerc added inline comments. Comment at: include/clang/AST/ASTContext.h:1868 + bool *OverrideNonnullReturn = nullptr, + unsigned *OverrideNonnullArgs = nullptr, unsigned *IntegerConstantArgs = nullpt

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

chandlerc marked an inline comment as done. chandlerc added a comment. Function argument order fixed. https://reviews.llvm.org/D30806 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30806: [nonnull] Teach Clang to attach the nonnull LLVM attribute to declarations and calls instead of just definitions, and then teach it to *not* attach such attributes even if the source c

chandlerc updated this revision to Diff 92245. chandlerc added a comment. Update with fixes suggested in review. https://reviews.llvm.org/D30806 Files: include/clang/AST/ASTContext.h include/clang/Basic/Builtins.def lib/AST/ASTContext.cpp lib/CodeGen/CGCall.cpp test/CodeGen/nonnull.c

[PATCH] D28478: Check for musl-libc's max_align_t in addition to other variants.

chandlerc added a reviewer: EricWF. chandlerc added a comment. This seems good to me. Check with Eric to see if we try to test this any any specific way? https://reviews.llvm.org/D28478 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc added inline comments. Comment at: include/clang/Format/Format.h:993 + /// inside ``IncludeCategories``. + bool IncludeRegexCaseInsensitive; + djasper wrote: > Do we really need a flag here? Shouldn't we just always do this? I have no opinion one way

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added inline comments. Comment at: clang/lib/CodeGen/BackendUtil.cpp:804-807 + case 0: +return PassBuilder::O0; + case 1: Why is this change needed? Comment at: clang/lib/CodeGen/BackendUtil.cpp:885-886 if (CodeGenOpts.Op

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added inline comments. Comment at: llvm/test/Other/new-pm-thinlto-defaults.ll:157 ; CHECK-PRELINK-O-NEXT: Running pass: GlobalOptPass -; CHECK-PRELINK-O-NEXT: Running pass: NameAnonGlobalPass ; CHECK-POSTLINK-O-NEXT: Running pass: PassManager<{{.*}}Module{{.*}}> -

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc updated this revision to Diff 104471. chandlerc added a comment. Update based an Daniel's feedback. https://reviews.llvm.org/D33932 Files: include/clang/Format/Format.h lib/Format/Format.cpp unittests/Format/SortIncludesTest.cpp Index: unittests/Format/SortIncludesTest.cpp ===

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

chandlerc added a comment. In https://reviews.llvm.org/D33932#793994, @djasper wrote: > Just make clang-format always do this. I don't think anyone is relying on the > current behavior. Done, PTAL. https://reviews.llvm.org/D33932 ___ cfe-commits

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc accepted this revision. chandlerc added a comment. This revision is now accepted and ready to land. LGTM as well. https://reviews.llvm.org/D34728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D34790: [NewPM] Add a flag -fexperimental-new-pass-manager=on/off/debug for printing debug output.

chandlerc added inline comments. Comment at: clang/include/clang/Driver/Options.td:971-973 +def fexperimental_new_pass_manager_EQ : Joined<["-"], "fexperimental-new-pass-manager=">, + Group, Flags<[CC1Option]>, + HelpText<"Enables an experimental new pass manager in LLVM.">,

[PATCH] D34790: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for printing debug information.

chandlerc added a comment. This looks great to me with a CC1-layer flag. But check that others are happy as well, thanks! https://reviews.llvm.org/D34790 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/

[PATCH] D34728: [ThinkLTO] Invoke build(Thin)?LTOPreLinkDefaultPipeline.

chandlerc added a comment. Already said LGTM, please go ahead and submit. If tehre are further requsets, we can always amke follow-up changes. Repository: rL LLVM https://reviews.llvm.org/D34728 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D34721: [PM] Add support for sample PGO in the new pass manager (clang-side)

chandlerc accepted this revision. chandlerc added a comment. LGTM too, but no need to wait for me to land this. =D https://reviews.llvm.org/D34721 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D33932: [clang-format] Add support for case-insensitive header matching and use it to improve support for LLVM-style include sorting.

This revision was automatically updated to reflect the committed changes. Closed by commit rL306759: [clang-format] Switch to case-insensitive header matching and use it to (authored by chandlerc). Repository: rL LLVM https://reviews.llvm.org/D33932 Files: cfe/trunk/include/clang/Format/For

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

chandlerc created this revision. Herald added subscribers: mcrosier, sanjoy, rengolin. Given the long time for which this path has been unused, off by default, and unnecessary this completely removes the flags. If users are deeply concerned about the commandline compatibility, they can be added ba

[PATCH] D34846: Remove Clang support for '-fvectorize-slp-aggressive' which used LLVM's basic block vectorizer. This vectorizer has had no known users for many, many years and is completely surpassed

chandlerc updated this revision to Diff 104775. chandlerc added a comment. Remove the rest of the flag handling that I missed the first time grepping through... https://reviews.llvm.org/D34846 Files: include/clang/Driver/CC1Options.td include/clang/Driver/Options.td include/clang/Fronten

<    1   2   3   >