r244049 - Officially end my reign as owner of the driver.

McCall E: rjmcc...@apple.com D: Clang LLVM IR generation -N: Chad Rosier -E: mcros...@codeaurora.org -D: Compiler driver - N: Richard Smith E: rich...@metafoo.co.uk D: All parts of Clang not covered by someone else ___ cfe-commits mailing list cfe-commit

RE: r244049 - Officially end my reign as owner of the driver.

0:53 AM To: Chad Rosier Cc: cfe-commits Subject: Re: r244049 - Officially end my reign as owner of the driver. On Wed, Aug 5, 2015 at 10:52 AM, Chad Rosier wrote: > Author: mcrosier > Date: Wed Aug 5 09:52:01 2015 > New Revision: 244049 > > URL: http://llvm.org/viewvc/llvm-project?

RE: r244049 - Officially end my reign as owner of the driver.

Thanks, Ted!! -Original Message- From: Ted kremenek [mailto:kreme...@apple.com] Sent: Wednesday, August 05, 2015 12:40 PM To: Chad Rosier Cc: cfe-commits@lists.llvm.org Subject: Re: r244049 - Officially end my reign as owner of the driver. Thanks for all your work on it, Chad. >

Re: [PATCH] D11766: "Claim" the arguments belonging to 'clang_ignored_gcc_optimization_f_Group'

mcrosier added a subscriber: mcrosier. mcrosier accepted this revision. mcrosier added a reviewer: mcrosier. mcrosier added a comment. This revision is now accepted and ready to land. LGTM. http://reviews.llvm.org/D11766 ___ cfe-commits mailing list

Re: Patch to Bugzilla 31373

Hi Erik, You might consider posting your patch to Phabricator.  You'll likely get more feedback/traction there.. https://llvm.org/docs/Phabricator.html  Chad On 10/6/2017 8:15 AM, Erik Viktorsson via cfe-commits wrote: Committing a patch to Bugzilla 31373

r319323 - [Driver] Turns out the GNU assembler does support falkor/saphira.

Author: mcrosier Date: Wed Nov 29 08:42:44 2017 New Revision: 319323 URL: http://llvm.org/viewvc/llvm-project?rev=319323&view=rev Log: [Driver] Turns out the GNU assembler does support falkor/saphira. Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp cfe/trunk/test/Driver/as-mcpu.c Modif

r311660 - [Driver][AArch64] Add tests for RDM feature.

Author: mcrosier Date: Thu Aug 24 07:32:55 2017 New Revision: 311660 URL: http://llvm.org/viewvc/llvm-project?rev=311660&view=rev Log: [Driver][AArch64] Add tests for RDM feature. Differential Revision: https://reviews.llvm.org/D37106 Added: cfe/trunk/test/Driver/aarch64-rdm.c Added: cfe/tr

r329754 - [Driver] Handle the default case missed in r329748.

Author: mcrosier Date: Tue Apr 10 13:30:16 2018 New Revision: 329754 URL: http://llvm.org/viewvc/llvm-project?rev=329754&view=rev Log: [Driver] Handle the default case missed in r329748. Differential Revision: https://reviews.llvm.org/D45499 Modified: cfe/trunk/lib/Driver/ToolChains/NaCl.cpp

r329810 - [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking

Author: mcrosier Date: Wed Apr 11 07:20:37 2018 New Revision: 329810 URL: http://llvm.org/viewvc/llvm-project?rev=329810&view=rev Log: [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking Differential Revision: https://reviews.llvm.org/D45092 Modified: cfe/t

r291574 - [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

Author: mcrosier Date: Tue Jan 10 11:20:28 2017 New Revision: 291574 URL: http://llvm.org/viewvc/llvm-project?rev=291574&view=rev Log: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific. Differential Revision: https://reviews.llvm.org/D28400 Modified: cfe/trunk/lib/Code

r291582 - [ARM] Use generic bitreverse intrinsic, rather than ARM specific rbit.

Author: mcrosier Date: Tue Jan 10 12:55:11 2017 New Revision: 291582 URL: http://llvm.org/viewvc/llvm-project?rev=291582&view=rev Log: [ARM] Use generic bitreverse intrinsic, rather than ARM specific rbit. The backend already supports lowering this intrinsic to a rbit instruction. Modified:

[PATCH] D26674: [AArch64] Add driver tests for Qualcomm's Falkor CPU

mcrosier created this revision. mcrosier added reviewers: rengolin, t.p.northover. mcrosier added a subscriber: cfe-commits. Herald added a subscriber: aemerson. LLVM implementation here: https://reviews.llvm.org/D26673. Chad https://reviews.llvm.org/D26674 Files: test/Driver/aarch64-cpus.c

r287037 - [AArch64] Add driver tests for Qualcomm's Falkor CPU.

Author: mcrosier Date: Tue Nov 15 15:34:31 2016 New Revision: 287037 URL: http://llvm.org/viewvc/llvm-project?rev=287037&view=rev Log: [AArch64] Add driver tests for Qualcomm's Falkor CPU. Differential Revision: https://reviews.llvm.org/D26674 Modified: cfe/trunk/test/Driver/aarch64-cpus.c

[PATCH] D26674: [AArch64] Add driver tests for Qualcomm's Falkor CPU

This revision was automatically updated to reflect the committed changes. Closed by commit rL287037: [AArch64] Add driver tests for Qualcomm's Falkor CPU. (authored by mcrosier). Changed prior to commit: https://reviews.llvm.org/D26674?vs=78002&id=78070#toc Repository: rL LLVM https://revie

Re: [PATCH] D13304: Avoid inlining in throw statement

mcrosier added a comment. FWIW, a llvm based solution was discussed in http://reviews.llvm.org/D12979, but the clang solution is obviously more robust and easier to implement. Comment at: lib/CodeGen/CodeGenFunction.h:287 @@ +286,3 @@ + // True if the current insertion point i

Re: [PATCH] D13304: Avoid inlining in throw statement

mcrosier added a comment. @chandlerc: Adding Chandler in case he has an opinion on how to move forward or how we could go about tuning the cold threshold. http://reviews.llvm.org/D13304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

Re: [PATCH] D16966: Make -fno-math-builtin a cc1 option

mcrosier accepted this revision. mcrosier added a comment. This revision is now accepted and ready to land. LGTM. Thanks, Frank. http://reviews.llvm.org/D16966 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

Re: [PATCH] D17124: Add driver support for Qualcomm Kryo cpu.

mcrosier added a comment. In http://reviews.llvm.org/D17124#350130, @rengolin wrote: > I'm assuming you also have the LLVM counterpart? Yes, but I haven't made them public just yet. http://reviews.llvm.org/D17122 http://reviews.llvm.org/D17119 http://reviews.llvm.org/D17124 __

r260555 - [Driver] Add support for Qualcomm's Kryo CPU.

Author: mcrosier Date: Thu Feb 11 12:09:31 2016 New Revision: 260555 URL: http://llvm.org/viewvc/llvm-project?rev=260555&view=rev Log: [Driver] Add support for Qualcomm's Kryo CPU. http://reviews.llvm.org/D17124 Modified: cfe/trunk/lib/Basic/Targets.cpp cfe/trunk/lib/Driver/Tools.cpp

Re: [PATCH] D17124: Add driver support for Qualcomm Kryo cpu.

mcrosier closed this revision. mcrosier added a comment. Committed r260555. http://reviews.llvm.org/D17124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D19827: Do not disable completely loop unroll according to optimization level.

mcrosier added a subscriber: mcrosier. mcrosier added a comment. I believe the LLVM blog post is in error. Loop vectorization commonly generates two versions of the loop: vectorized and scalar. The scalar loop is necessary to handle the case where the trip count isn't evenly divisible by the

Re: [PATCH] D19827: Do not disable completely loop unroll according to optimization level.

mcrosier added a comment. In http://reviews.llvm.org/D19827#419870, @mamai wrote: > I think the blog comment is right. The pragma should make the loop unroll > even in /Os. I think it is essential to allow the user to optimize some > specific loops even if he generally wants to optimize for siz

r274766 - Revert "[AArch64] Change the preferred alignment for char and short to word alignment"

Author: mcrosier Date: Thu Jul 7 11:37:19 2016 New Revision: 274766 URL: http://llvm.org/viewvc/llvm-project?rev=274766&view=rev Log: Revert "[AArch64] Change the preferred alignment for char and short to word alignment" This reverts commit r273280 as the change was not properly approved. Modi

r274767 - Revert "[aarch64] Update datalayout for aarch64 tests"

Author: mcrosier Date: Thu Jul 7 11:37:21 2016 New Revision: 274767 URL: http://llvm.org/viewvc/llvm-project?rev=274767&view=rev Log: Revert "[aarch64] Update datalayout for aarch64 tests" This reverts commit r273289, which was a follow to r273280, which was reverted because the change was not p

r274791 - [AArch64] Change the preferred alignment for char and short.

Author: mcrosier Date: Thu Jul 7 15:02:25 2016 New Revision: 274791 URL: http://llvm.org/viewvc/llvm-project?rev=274791&view=rev Log: [AArch64] Change the preferred alignment for char and short. This reinstates commits r273280 and r273289. Original Review: http://reviews.llvm.org/D21414. Modif

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. Ping. http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r256937 - [Driver] Add support for -fno-builtin-foo options.

Author: mcrosier Date: Wed Jan 6 08:35:46 2016 New Revision: 256937 URL: http://llvm.org/viewvc/llvm-project?rev=256937&view=rev Log: [Driver] Add support for -fno-builtin-foo options. Addresses PR4941 and rdar://6756912. http://reviews.llvm.org/D15195 Modified: cfe/trunk/include/clang/Basi

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier closed this revision. mcrosier added a comment. Committed in r256937. Thanks, Bob. http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

mcrosier added a subscriber: mcrosier. mcrosier added a comment. Would it make sense to include an additional test (in test/Driver) that shows the -fprofile-ir-instr option being passed from the driver to the frontend? Such a test case would land in clang_f_opt.c, which has many examples.

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

mcrosier added inline comments. Comment at: lib/Driver/Tools.cpp:3279 @@ -3278,1 +3278,3 @@ + + Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr); } silvas wrote: > xur wrote: > > mcrosier wrote: > > > I don't think AddAllArgs is what you really want. Wh

r258813 - [Driver] Update FIXME comment now that PR4941 has been addressed.

Author: mcrosier Date: Tue Jan 26 09:46:29 2016 New Revision: 258813 URL: http://llvm.org/viewvc/llvm-project?rev=258813&view=rev Log: [Driver] Update FIXME comment now that PR4941 has been addressed. The actual fix should be addressed by someone who can test on Darwin. Modified: cfe/trunk/l

r258814 - [Driver] Make sure -fno-math-builtin option is being passed by the driver.

Author: mcrosier Date: Tue Jan 26 09:52:05 2016 New Revision: 258814 URL: http://llvm.org/viewvc/llvm-project?rev=258814&view=rev Log: [Driver] Make sure -fno-math-builtin option is being passed by the driver. Support for the -fno-math-builtin option was added in r186899. The codegen side is bei

r258815 - Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver."

Author: mcrosier Date: Tue Jan 26 10:16:53 2016 New Revision: 258815 URL: http://llvm.org/viewvc/llvm-project?rev=258815&view=rev Log: Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver." This reverts commit r258814. Modified: cfe/trunk/lib/Driver/Tools.cpp

Re: r258815 - Revert "[Driver] Make sure -fno-math-builtin option is being passed by the driver."

All, In r258814 I upgraded the -fno-math-builtin option from a cc1 only option to a full blown compiler option. However, after a bit of searching I can't seem to find documentation of this actually being a supported option by gcc. Therefore, I reverted the change. I can see the potential utility

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added a subscriber: mcrosier. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">,

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, + Help

Re: [PATCH] D16559: [CUDA] Add -fcuda-allow-variadic-functions.

mcrosier added inline comments. Comment at: cfe/trunk/include/clang/Driver/CC1Options.td:681 @@ -680,1 +680,3 @@ HelpText<"Enable function overloads based on CUDA target attributes.">; +def fcuda_allow_variadic_functions : Flag<["-"], "fcuda-allow-variadic-functions">, + Help

r253914 - Fix a warning about commas at the end of enumerator lists.

Author: mcrosier Date: Mon Nov 23 15:05:04 2015 New Revision: 253914 URL: http://llvm.org/viewvc/llvm-project?rev=253914&view=rev Log: Fix a warning about commas at the end of enumerator lists. Modified: cfe/trunk/include/clang-c/Index.h Modified: cfe/trunk/include/clang-c/Index.h URL: http

[PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier created this revision. mcrosier added reviewers: majnemer, doug.gregor, ddunbar, chandlerc, bob.wilson, rnk, krememek. mcrosier added a subscriber: cfe-commits. The changes adds support for -fno-builtin-foo options. This addresses PR4941 and rdar://6756912. Please take a look. Chad

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. Ping. http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. In http://reviews.llvm.org/D15195#307136, @hfinkel wrote: > Can you use a StringSet instead of a vector and avoid all (most) of the code > iterating over the vector of builtins being disabled? Hi Hal, I began converting the code to use StringSets, but I soon realized

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier updated this revision to Diff 42854. mcrosier added a comment. Remove the FIXME, per Hal and Bob's request. I confirmed that gcc does not warn for invalid -fno-builtin-foo options. Also, pass the vector by reference and insert, rather than making an unnecessary copy on the return in Co

r255915 - [x86] Filecheck is case sensitive. Capitalize directives.

Author: mcrosier Date: Thu Dec 17 12:54:42 2015 New Revision: 255915 URL: http://llvm.org/viewvc/llvm-project?rev=255915&view=rev Log: [x86] Filecheck is case sensitive. Capitalize directives. Modified: cfe/trunk/test/CodeGen/avx512er-builtins.c Modified: cfe/trunk/test/CodeGen/avx512er-bui

r255916 - [x86] Filecheck is case sensitive. Capitalize directives.

Author: mcrosier Date: Thu Dec 17 13:01:55 2015 New Revision: 255916 URL: http://llvm.org/viewvc/llvm-project?rev=255916&view=rev Log: [x86] Filecheck is case sensitive. Capitalize directives. Modified: cfe/trunk/test/CodeGen/avx512f-builtins.c Modified: cfe/trunk/test/CodeGen/avx512f-built

r256023 - Fix an unused variable warning from r256012.

Author: mcrosier Date: Fri Dec 18 14:08:40 2015 New Revision: 256023 URL: http://llvm.org/viewvc/llvm-project?rev=256023&view=rev Log: Fix an unused variable warning from r256012. Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp Modified: cfe/trunk/lib/CodeGen/CGDebugInfo.cpp URL: http://llv

Re: [PATCH] D15195: PR4941: Add support for -fno-builtin-foo options.

mcrosier added a comment. Ping. I promise this is fairly straight forward. :) http://reviews.llvm.org/D15195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15749: [X86][ms-inline asm] Test case for adding support for memory operands that include structs

mcrosier accepted this revision. mcrosier added a comment. This revision is now accepted and ready to land. LGTM. Repository: rL LLVM http://reviews.llvm.org/D15749 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi

[PATCH] D38863: Typos in tutorial

mcrosier closed this revision. mcrosier added a comment. Committed in r315652. https://reviews.llvm.org/D38863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D45109: Remove -cc1 option "-backend-option"

mcrosier accepted this revision. mcrosier added a comment. SGTM! Repository: rC Clang https://reviews.llvm.org/D45109 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

mcrosier added a comment. Am I correct in assuming this is going to be a problem for Falkor and Saphira as well? If so, can you add solutions for those as well? Cortex-a57 should be good enough for those targets as well. https://reviews.llvm.org/D40476

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

mcrosier added a comment. In https://reviews.llvm.org/D40476#936372, @pirama wrote: > Thanks for the review. Now let's just hope the windows bots stay happy :) Actually, I just checked and it looks like falkor and saphira were both added as of a few weeks ago. I'll revert this part of the pa

[PATCH] D40476: Switch kryo to use -mcpu=cortex-a57 when invoking the assembler

mcrosier added a comment. In https://reviews.llvm.org/D40476#936700, @mcrosier wrote: > In https://reviews.llvm.org/D40476#936372, @pirama wrote: > > > Thanks for the review. Now let's just hope the windows bots stay happy :) > > > Actually, I just checked and it looks like falkor and saphira we

[PATCH] D36238: Use "foo-12345.o" instead of "foo.o-12345" as temporary file name.

mcrosier added a comment. Seems reasonable to me as well.. https://reviews.llvm.org/D36238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

mcrosier created this revision. Herald added subscribers: kristof.beyls, javed.absar, rengolin, aemerson. Clang side of https://reviews.llvm.org/D37081. Chad https://reviews.llvm.org/D37106 Files: test/Driver/aarch64-rdm.c Index: test/Driver/aarch64-rdm.c ==

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

This revision was automatically updated to reflect the committed changes. Closed by commit rL311660: [Driver][AArch64] Add tests for RDM feature. (authored by mcrosier). Changed prior to commit: https://reviews.llvm.org/D37106?vs=112543&id=112559#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D37106: [Driver][AArch64] Tests for rdm feature.

mcrosier added a comment. In https://reviews.llvm.org/D37106#851441, @SjoerdMeijer wrote: > Thanks for fixing this. np! Thanks for the review! Repository: rL LLVM https://reviews.llvm.org/D37106 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D45499: [Driver] Handle the default case

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rC329754: [Driver] Handle the default case missed in r329748. (authored by mcrosier, committed by ). Changed prior to commi

[PATCH] D45092: [Driver] Don't forward -m[no-]unaligned-access options to GCC when assembling/linking

This revision was automatically updated to reflect the committed changes. Closed by commit rC329810: [Driver] Don't forward -m[no-]unaligned-access options to GCC when… (authored by mcrosier, committed by ). Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

mcrosier added inline comments. Comment at: include/clang/Driver/Options.td:1731 def mno_pie_copy_relocations : Flag<["-"], "mno-pie-copy-relocations">, Group; +def mfentry : Flag<["-"], "mfentry">, HelpText<"insert calls to fentry at function entry">, Flags<[CC1Option]>, Grou

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

mcrosier added inline comments. Comment at: test/CodeGen/fentry.c:11 + +//HAS: attributes #{{[0-9]+}} = { {{.*}}"fentry-call"="true"{{.*}} } +//NOHAS-NOT: attributes #{{[0-9]+}} = { {{.*}}"fentry-call"{{.*}} } mcrosier wrote: > I'd prefer we stick with the defaul

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

mcrosier created this revision. mcrosier added reviewers: jmolloy, t.p.northover, gberry, RKSimon, rengolin. mcrosier added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Per the title, this patch replaces the target-specific intrinsic with a target-independent equivalent. This

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

mcrosier added inline comments. Comment at: test/CodeGen/arm_acle.c:247 // ARM-LABEL: test_rbit // AArch32: call i32 @llvm.arm.rbit +// AArch64: call i32 @llvm.bitreverse.i32 RKSimon wrote: > Since you're here is it worth dealing with the AARCH32 case as well?

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

This revision was automatically updated to reflect the committed changes. Closed by commit rL291574: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific. (authored by mcrosier). Changed prior to commit: https://reviews.llvm.org/D28400?vs=83367&id=83817#toc Repository: rL

[PATCH] D35465: [clang] Remove redundant check-prefix=CHECK from tests. NFC.

mcrosier accepted this revision. mcrosier added a comment. LGTM. https://reviews.llvm.org/D35465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. What exactly is the difference between -fno-jump-tables, -fno-switch-tables, and -fno-lookup-tables? https://reviews.llvm.org/D35578 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mai

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35578#813548, @sgundapa wrote: > The switch-case statements generate two kinds of tables. > > 1. Jump tables > 2. Lookup tables. > > While the general assumption is that switch-case statements generate jump > tables, the below case generat

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35578#813629, @Quuxplusone wrote: > If the goal is fine-grained control over the heuristics for compiling switch > statements, perhaps one should enumerate all the possible ways to lower > switch statements --- jump-tables, lookup-tables, i

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35578#814817, @sgundapa wrote: > > Wouldn't the fix be to make the backend deal with this, then? Either by > > putting the table with the function text, or or opting out of lookup > > tables? It seems that might be a better experience for t

[PATCH] D35578: Add -fswitch-tables and -fno-switch-tables flags

mcrosier added reviewers: echristo, ddunbar. mcrosier added subscribers: echristo, ddunbar. mcrosier added a comment. Adding @echristo and @ddunbar who have been the primary owners of the driver for the past decade or so. https://reviews.llvm.org/D35578 __

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

mcrosier added subscribers: echristo, ddunbar, mcrosier. mcrosier added reviewers: echristo, ddunbar. mcrosier added a comment. Adding @echristo and @ddunbar who have been the primary owners of the driver for the past decade or so. https://reviews.llvm.org/D35577

[PATCH] D35577: Add -flookup-tables and -fno-lookup-tables flags

mcrosier added a comment. In https://reviews.llvm.org/D35577#818936, @kparzysz wrote: > In https://reviews.llvm.org/D35577#817944, @echristo wrote: > > > "Should this just be part of the tuning for the hexagon backend and not > > options at all" > > > > > I don't think we need separate options