Caslyn created this revision.
Herald added subscribers: PiotrZSL, carlosgalvezp, abrachet, phosek, xazax.hun.
Herald added a reviewer: njames93.
Herald added a project: All.
Caslyn updated this revision to Diff 531489.
Caslyn added a comment.
Caslyn updated this revision to Diff 531932.
Caslyn upda
Caslyn updated this revision to Diff 533832.
Caslyn marked 4 inline comments as done.
Caslyn added a comment.
Fixes from review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152953/new/
https://reviews.llvm.org/D152953
Files:
clang-tools-extra/
Caslyn added a comment.
Thanks for the review @PiotrZSL, I’m new to this space and appreciate the
comments. I have a few questions around some of them and would greatly
appreciate any guidance you can give.
The intent of this patch is to upstream a generic version of the google style
check (ap
Caslyn updated this revision to Diff 535546.
Caslyn marked 12 inline comments as done.
Caslyn added a comment.
Changes per review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152953/new/
https://reviews.llvm.org/D152953
Files:
clang-tools-extr
Caslyn added a comment.
Hi Piotr - I'm sorry for the delay in getting back to you. Thank you again for
your review comments. I did my best trying to get the right combination of
matchers that limit the candidates and allow the exceptions that we want. I
wasn't successful in figuring out a way t
Caslyn updated this revision to Diff 535845.
Caslyn added a comment.
correct reference in test
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D152953/new/
https://reviews.llvm.org/D152953
Files:
clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt
