[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-01 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97367. CaseyCarter added a comment. Fix missing indent in msvc_stdlib_force_include.hpp https://reviews.llvm.org/D32671 Files: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp test/std/utilities/variant/variant.variant/variant

[PATCH] D32778: [libcxx] [test] Conditionally workaround C1XX/EDG bugs

2017-05-02 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter created this revision. Test support machinery changes needed to parse with EDG and compile with C1XX's /Za flag that disables MS extensions. I try to make changes to `` and the `optional`/`variant` tests simultaneously in the MS STL and in libc++, which realistically requires that I

[PATCH] D32778: [libcxx] [test] Conditionally workaround C1XX/EDG bugs

2017-05-02 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added inline comments. Comment at: test/support/archetypes.hpp:20 protected: +#endif // !TEST_WORKAROUND_C1XX_BROKEN_ZA_CTOR_CHECK NullBase() = default; STL_MSFT wrote: > I think that this comment doesn't match the ifndef check, but it's a style

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-03 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97768. CaseyCarter added a comment. Fix typos in test/std/utilities/variant/variant.variant/variant.assign/move.pass.cpp. https://reviews.llvm.org/D32671 Files: test/std/utilities/variant/variant.variant/variant.assign/copy.pass.cpp test/std/utilit

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

2017-05-03 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97769. CaseyCarter added a comment. Polish: clarify `static_assert` messages, DeMorgan a clause so it more precisely reflects the `static_assert` message. https://reviews.llvm.org/D32385 Files: include/optional test/libcxx/utilities/optional/option

[PATCH] D32671: [libcxx] [test] variant: test coverage for P0602 extension

2017-05-04 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 97834. CaseyCarter added a comment. The constexpr variant tests were enabled separate commit (https://reviews.llvm.org/rL302158). This differential now contains only the fine-grained SMF triviality extension test. https://reviews.llvm.org/D32671 Files

[PATCH] D32385: [libcxx] optional: Implement LWG 2900 and P0602

2017-05-04 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter added a comment. In https://reviews.llvm.org/D32385#745771, @EricWF wrote: > So Itanium ABI has this quirk where trivial types are passed using different > conventions than non-trivial types. This means changing the triviality of > `std::optional` for any instantiation is potentiall

[PATCH] D32510: [libcxx] Fix C1XX implementation of DoNotOptimize

2017-05-04 Thread Casey Carter via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL302162: [test] Name the local variable in the C1XX implementation of DoNotOptmize (authored by CaseyCarter). Changed prior to commit: https://reviews.llvm.org/D32510?vs=96648&id=97837#toc Repository:

[PATCH] D32778: [libcxx] [test] Conditionally workaround C1XX/EDG bugs

2017-05-10 Thread Casey Carter via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL302707: [test] support machinery changes for EDG & C1XX /Za (authored by CaseyCarter). Changed prior to commit: https://reviews.llvm.org/D32778?vs=97530&id=98503#toc Repository: rL LLVM https://revi

[PATCH] D33214: [libcxx] [test] Workaround C1XX bug in uses_allocator_types.hpp

2017-05-15 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter created this revision. Needed by IIRC allocator.adaptor\allocator.adaptor.members\construct_pair.pass.cpp. https://reviews.llvm.org/D33214 Files: test/support/test.workarounds/c1xx_empty_parameter_pack_expansion.pass.cpp test/support/test_workarounds.h test/support/uses_alloc

[PATCH] D33214: [libcxx] [test] Workaround C1XX bug in uses_allocator_types.hpp

2017-05-15 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 99086. CaseyCarter edited the summary of this revision. CaseyCarter added a comment. Silence warnings. https://reviews.llvm.org/D33214 Files: test/std/utilities/allocator.adaptor/allocator.adaptor.members/construct_pair.pass.cpp test/support/test.w

[PATCH] D33290: [libcxx] [test] Remove workaround for C1XX conversion-to-nullptr bug

2017-05-17 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter created this revision. VSO#391542 "Types can't be convertible to nullptr_t," which will be fixed in the next release of Visual C++. Also put internal bug numbers on the workarounds in test_workarounds.h for ease of correlation. https://reviews.llvm.org/D33290 Files: test/suppor

[PATCH] D33290: [libcxx] [test] Remove workaround for C1XX conversion-to-nullptr bug

2017-05-17 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter updated this revision to Diff 99336. CaseyCarter added a comment. Commit the change to the affected test code as well. https://reviews.llvm.org/D33290 Files: test/support/poisoned_hash_helper.hpp test/support/test.workarounds/c1xx_broken_nullptr_conversion_operator.pass.cpp te

[PATCH] D33290: [libcxx] [test] Remove workaround for C1XX conversion-to-nullptr bug

2017-05-17 Thread Casey Carter via Phabricator via cfe-commits
CaseyCarter marked an inline comment as done. CaseyCarter added inline comments. Comment at: test/support/test_workarounds.h:21 #if defined(TEST_COMPILER_C1XX) -# define TEST_WORKAROUND_C1XX_BROKEN_NULLPTR_CONVERSION_OPERATOR -# define TEST_WORKAROUND_C1XX_BROKEN_IS_TRIVIALLY_CO

<    1   2