carlo.bertolli added a comment.
Hi Alexey
Thanks for your comment. The suggested change will not work as I intended in my
patch when using the host as a device. This happens when you select the
following options:
-fomptargets=powerpc64le-ibm-linux-gnu -fopenmp-is-device
In this case we generat
carlo.bertolli updated this revision to Diff 51285.
carlo.bertolli added a comment.
To make clear my comment I an updating the patch following Alexey's comment and
modifying it to make it work.
You can see that now we have the following check:
CGM.getTarget().getTriple().getArch() == llvm::Triple
carlo.bertolli added a comment.
Hi Jonas
Thanks for your comment. That scheme would not work for #parallel on the gpu in
case we do not want to inline the parallel region.
There are patches coming in which that is going to happen so I think that we
really need to distinguish between different p
carlo.bertolli added a comment.
Hi
Thinking more carefully, I believe you are right - no, it is not. I guess we
would not call at all shouldEmitInlinedTeamsDirective for the case of paralle.
Thanks!
Repository:
rL LLVM
http://reviews.llvm.org/D18286
_
carlo.bertolli created this revision.
carlo.bertolli added reviewers: ABataev, sfantao, Hahnfeld.
carlo.bertolli added subscribers: arpith-jacob, caomhin, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
This patch fixes a bug in code generation of the correct OpenMP ru
carlo.bertolli added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:4257
@@ +4256,3 @@
+hasEnclosingTeams(const Stmt *TargetBody) {
+ if(auto *TeamsDir = dyn_cast(TargetBody)) return TeamsDir;
+
sfantao wrote:
> I think that this can be simplified t
carlo.bertolli updated this revision to Diff 51676.
carlo.bertolli added a comment.
Simplify the search function and generalize by using a template.
Repository:
rL LLVM
http://reviews.llvm.org/D18474
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
test/OpenMP/teams_codegen.cpp
Index: test/OpenMP
carlo.bertolli updated this revision to Diff 44012.
carlo.bertolli marked an inline comment as done.
carlo.bertolli added a comment.
Update to dist_schedule patch, as requested: show whole context and add ast
print regression test.
Repository:
rL LLVM
http://reviews.llvm.org/D15220
Files:
carlo.bertolli updated this revision to Diff 44912.
carlo.bertolli added a comment.
Remove duplicated error-messages and replace with error-messages2 and 3
Repository:
rL LLVM
http://reviews.llvm.org/D15220
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
Author: cbertol
Date: Fri Jan 15 12:50:31 2016
New Revision: 257917
URL: http://llvm.org/viewvc/llvm-project?rev=257917&view=rev
Log:
Add OpenMP dist_schedule clause to distribute directive and related regression
tests.
Added:
cfe/trunk/test/OpenMP/distribute_dist_schedule_ast_print.cpp
carlo.bertolli added a comment.
Committed revision 257917.
Repository:
rL LLVM
http://reviews.llvm.org/D15220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
Please notify of any issues.
Repository:
rL LLVM
http://reviews.llvm.org/D15220
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
Author: cbertol
Date: Tue Jan 19 10:53:55 2016
New Revision: 258140
URL: http://llvm.org/viewvc/llvm-project?rev=258140&view=rev
Log:
Activate OpenMP private clause for target construct and a regression test.
Added:
cfe/trunk/test/OpenMP/target_private_messages.cpp
Modified:
cfe/trunk/inc
carlo.bertolli created this revision.
carlo.bertolli added reviewers: hfinkel, ABataev, rjmccall.
carlo.bertolli added subscribers: sfantao, cfe-commits.
carlo.bertolli set the repository for this revision to rL LLVM.
This patch includes parsing and semantic analysis for 'omp distribute'
directiv
carlo.bertolli added inline comments.
Comment at: include/clang/AST/OpenMPClause.h:667
@@ -666,3 +666,3 @@
OpenMPScheduleClauseKind Kind;
- /// \brief Start location of the schedule ind in source code.
+ /// \brief Start location of the schedule kind in source code.
Source
carlo.bertolli updated this revision to Diff 41712.
carlo.bertolli marked 15 inline comments as done.
carlo.bertolli added a comment.
Thanks very much for your kind comments and patience at some trivial errors on
my side.
This new version of the patch addresses all your concerns and it removes
carlo.bertolli updated this revision to Diff 41980.
carlo.bertolli marked 7 inline comments as done.
carlo.bertolli added a comment.
This updated patch includes taskloop simd changes form the trunk and it
addresses the second round of comments.
Repository:
rL LLVM
http://reviews.llvm.org/D15
carlo.bertolli added inline comments.
Comment at: lib/Basic/OpenMPKinds.cpp:460
@@ -449,4 +459,3 @@
DKind == OMPD_single || DKind == OMPD_parallel_for ||
- DKind == OMPD_parallel_for_simd ||
- DKind == OMPD_parallel_sections; // TODO add next directives.
carlo.bertolli updated this revision to Diff 41983.
carlo.bertolli added a comment.
Update dist_schedule patch to reflect changes in distribute directive patch.
Repository:
rL LLVM
http://reviews.llvm.org/D15220
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisito
carlo.bertolli updated this revision to Diff 42070.
carlo.bertolli added a comment.
Added regression test.
Repository:
rL LLVM
http://reviews.llvm.org/D15220
Files:
include/clang/AST/OpenMPClause.h
include/clang/AST/RecursiveASTVisitor.h
include/clang/Basic/OpenMPKinds.def
include/cl
Author: cbertol
Date: Mon Dec 7 22:21:03 2015
New Revision: 255001
URL: http://llvm.org/viewvc/llvm-project?rev=255001&view=rev
Log:
Add parse and sema for OpenMP distribute directive and all its clauses
excluding dist_schedule.
Added:
cfe/trunk/test/OpenMP/distribute_ast_print.cpp
cfe/
carlo.bertolli closed this revision.
carlo.bertolli added a comment.
This was committed in r255001.
Many thanks for all your help.
Repository:
rL LLVM
http://reviews.llvm.org/D15125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://
Author: cbertol
Date: Mon Dec 14 08:51:25 2015
New Revision: 255498
URL: http://llvm.org/viewvc/llvm-project?rev=255498&view=rev
Log:
Add parse and sema of OpenMP distribute directive with all clauses except
dist_schedule
Added:
cfe/trunk/test/OpenMP/distribute_ast_print.cpp
cfe/trunk/te
carlo.bertolli added a comment.
Resubmitted at rev255498
Repository:
rL LLVM
http://reviews.llvm.org/D15125
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 124 of 124 matches
Mail list logo
