[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

riccibruno updated this revision to Diff 234317. riccibruno edited the summary of this revision. riccibruno added a comment. Rebased on top of current master. No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/new/ https://reviews.llvm.org

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

riccibruno updated this revision to Diff 234320. riccibruno added a comment. Rebased on top of current master and D57659 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/new/ https://reviews.llvm.org/D

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

riccibruno updated this revision to Diff 234322. riccibruno added a comment. Rebased on top of current master and D57747 . No need to look at it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58297/new/ https://reviews.llvm.org/D

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno updated this revision to Diff 234323. riccibruno added a comment. Rebased on top of current master and D58297 . Friendly ping ! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58579/new/ https://reviews.llvm.org/D58579

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 234326. riccibruno edited the summary of this revision. riccibruno added a comment. I have factored out various NFCs which were present in this patch. This should make review easier. Also addressed some inline comments. Repository: rC Clang CHANGES SI

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. In D58579#1788164 , @riccibruno wrote: > In D58579#1788125 , @xbolva00 wrote: > > > Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the > > whole patch stack. > > > I

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno added a comment. Note that I am not entirely sure that the implementation in `getMemoryLocation`/`MemoryLocation` is the right way to do this; I think that this patch should be considered a work-in-progress. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. In D58579#1788125 , @xbolva00 wrote: > Maybe @aaron.ballman / @rsmith could take a look? This patch blocks the whole > patch stack. I rebased it on top of the others already accepted patches. I just need to get back +w acces

[PATCH] D57660: [Sema] SequenceChecker: Handle references, members and structured bindings.

riccibruno updated this revision to Diff 234627. riccibruno added a comment. Add missing patch context Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57660/new/ https://reviews.llvm.org/D57660 Files: clang/include/clang/Basic/DiagnosticSemaKinds.

[PATCH] D71714: [Sema] Fix -Warray-bounds false negative when casting an out-of-bounds array item

riccibruno added a comment. These are not the only AST nodes representing cast expressions (there is also `CXXFunctionalCastExpr`, ...). What about replacing the `IgnoreParenImpCasts()` above by `IgnoreParenCasts()` ? Incidentally doing this uncovers another test (`Parser/cxx-ambig-decl-expr.cp

[PATCH] D58579: [Sema] SequenceChecker: C++17 sequencing rule for call expressions.

riccibruno added a comment. @rsmith Could you take a look at this patch when you have some time? This is the last C++17 sequencing rule which is missing from `SequenceChecker` and is very similar to the other already accepted patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D57659: [Sema] SequenceChecker: Add some comments + related small NFCs in preparation of the following patches

This revision was automatically updated to reflect the committed changes. Closed by commit rGb6eba3129291: [Sema] SequenceChecker: Add some comments + related small NFCs (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57659/ne

[PATCH] D57747: [Sema] SequenceChecker: Fix handling of operator ||, && and ?:

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a571538dff6: [Sema] SequenceChecker: Fix handling of operator ||, && and ?: (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57747/ne

[PATCH] D58297: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, .*, ->*, =, op=

This revision was automatically updated to reflect the committed changes. Closed by commit rG7394c15178ed: [Sema] SequenceChecker: C++17 sequencing rules for built-in operators <<, >>, . (authored by riccibruno). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

riccibruno added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.cpp:25 + .bind("match"), + this); +} Will this match `my_namespace::cin`? Comment at: clang-tools-extra/clang-tidy/

[PATCH] D99646: [clang-tidy] misc-std-stream-objects-outside-main: a new check

riccibruno added inline comments. Comment at: clang-tools-extra/clang-tidy/misc/StdStreamObjectsOutsideMainCheck.cpp:25 + .bind("match"), + this); +} mgartmann wrote: > mgartmann wrote: > > riccibruno wrote: > > > Will this match `my_namespace::cin

<    2   3   4   5   6   7