r264808 - [CrashReproducer] Cleanup and move functionality around in ModuleDependencyCollector. NFC

Author: bruno Date: Tue Mar 29 18:47:40 2016 New Revision: 264808 URL: http://llvm.org/viewvc/llvm-project?rev=264808&view=rev Log: [CrashReproducer] Cleanup and move functionality around in ModuleDependencyCollector. NFC - Make ModuleDependencyCollector use the DependencyCollector interface - M

[PATCH] D18585: [CrashReproducer] Add a module map callback for added headers

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added a subscriber: cfe-commits. The current ModuleDependencyCollector has a AST listener to collect header files present in loaded modules, but this isn't enough to collect all headers needed in the crash reproducer. On

r264813 - [Driver] Quote clang full version in dwarf producer when invoking cc1as

Author: bruno Date: Tue Mar 29 19:25:57 2016 New Revision: 264813 URL: http://llvm.org/viewvc/llvm-project?rev=264813&view=rev Log: [Driver] Quote clang full version in dwarf producer when invoking cc1as Convenience to allow easy copy-n-paste from clang -v output when reproducing cc1as comandline

r264970 - [VFS] Handle empty entries in directory traversal

Author: bruno Date: Wed Mar 30 18:54:00 2016 New Revision: 264970 URL: http://llvm.org/viewvc/llvm-project?rev=264970&view=rev Log: [VFS] Handle empty entries in directory traversal The VFS YAML files contain empty directory entries to describe that it's returning from a subdirectory before descr

r264971 - [CrashReproducer] Add a module map callback for added headers

Author: bruno Date: Wed Mar 30 18:54:25 2016 New Revision: 264971 URL: http://llvm.org/viewvc/llvm-project?rev=264971&view=rev Log: [CrashReproducer] Add a module map callback for added headers The current ModuleDependencyCollector has a AST listener to collect header files present in loaded modu

r264987 - [DarwinDriver] Increase the number of valid digits for ld64 version string.

Author: bruno Date: Wed Mar 30 21:45:46 2016 New Revision: 264987 URL: http://llvm.org/viewvc/llvm-project?rev=264987&view=rev Log: [DarwinDriver] Increase the number of valid digits for ld64 version string. Previously only 3 digits were valid. Increase it to 5. Differential Revision: http://rev

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Committed r264987! Comment at: lib/Driver/Driver.cpp:2549-2550 @@ +2548,4 @@ + unsigned CurDigit = 0; + unsigned MaxDigits = Digits.size(); + while (CurDigit < MaxDigits) { +unsigned Digit = (unsigned)strtol(Str, &End, 10); rnk wrot

r265162 - [CrashReproducer] Add -fmodule-cache-path to reproducer script

Author: bruno Date: Fri Apr 1 12:39:08 2016 New Revision: 265162 URL: http://llvm.org/viewvc/llvm-project?rev=265162&view=rev Log: [CrashReproducer] Add -fmodule-cache-path to reproducer script The cc1 invocation in the reproducer script should contain a valid path in -fmodule-cache-path; for th

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

bruno added a subscriber: bruno. bruno added a comment. Hi Andrey, Comment at: include/clang/Driver/Options.td:1281 @@ -1280,1 +1280,3 @@ +def miamcu : Flag<["-"], "miamcu">, Group, Flags<[DriverOption, CoreOption]>, + HelpText<"Use Intel MCU ABI.">; def malign_functions_EQ :

r265343 - [CrashReproducer] Pass -I, -F and -resource-dir to the reproducer script when using modules/vfs

Author: bruno Date: Mon Apr 4 15:26:57 2016 New Revision: 265343 URL: http://llvm.org/viewvc/llvm-project?rev=265343&view=rev Log: [CrashReproducer] Pass -I, -F and -resource-dir to the reproducer script when using modules/vfs The reproducer should use -I/-F/-resource-dir in the same way as the

r265621 - [CrashReproducer] Move ModuleDependencyCollector method around. NFC

Author: bruno Date: Wed Apr 6 19:00:42 2016 New Revision: 265621 URL: http://llvm.org/viewvc/llvm-project?rev=265621&view=rev Log: [CrashReproducer] Move ModuleDependencyCollector method around. NFC Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Modified: cfe/trunk/lib/Front

r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Author: bruno Date: Wed Apr 6 19:00:57 2016 New Revision: 265622 URL: http://llvm.org/viewvc/llvm-project?rev=265622&view=rev Log: [CrashReproducer] Setup 'case-sensitive' in YAML files. The crash reproducer was not setting up case sensitivity in the VFS yaml files, which defaults to true. Make

[PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno created this revision. bruno added reviewers: rsmith, benlangmuir, klimek. bruno added subscribers: aprantl, dexonsmith, cfe-commits. The reproducer script (generated by the crash reproducer) invokes clang and tries to rebuild modules using the headers in the .cache/vfs directory. Depending

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Thanks Hans, taking a look! On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg wrote: > On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits > wrote: > > Author: bruno > > Date: Wed Apr 6 19:00:57 2016 > > New Revision: 265622 > > > > URL: htt

r265630 - [CrashReproducer] Change std::toupper to ::toupper

Author: bruno Date: Wed Apr 6 20:04:09 2016 New Revision: 265630 URL: http://llvm.org/viewvc/llvm-project?rev=265630&view=rev Log: [CrashReproducer] Change std::toupper to ::toupper Attempt to fix windows bots Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Modified: cfe/tru

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Attempt to fix in r265630. On Wed, Apr 6, 2016 at 5:51 PM, Bruno Cardoso Lopes wrote: > Thanks Hans, taking a look! > > On Wed, Apr 6, 2016 at 5:49 PM, Hans Wennborg wrote: > >> On Wed, Apr 6, 2016 at 5:00 PM, Bruno Cardoso Lopes via cfe-commits >> wrote: >> >

r265632 - [CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h

Author: bruno Date: Wed Apr 6 20:12:18 2016 New Revision: 265632 URL: http://llvm.org/viewvc/llvm-project?rev=265632&view=rev Log: [CrashReproducer] Use toUppercase from include/clang/Basic/CharInfo.h Use toUppercase instead of ::toupper() Modified: cfe/trunk/lib/Frontend/ModuleDependencyCo

Re: r265630 - [CrashReproducer] Change std::toupper to ::toupper

Better yet. Committed r265632 Thanks Sean, On Wed, Apr 6, 2016 at 6:11 PM, Sean Silva wrote: > We also have toUppercase in include/clang/Basic/CharInfo.h > > -- Sean Silva > > On Wed, Apr 6, 2016 at 6:04 PM, Bruno Cardoso Lopes via cfe-commits < > cfe-commits@lists.llvm.or

Re: r265622 - [CrashReproducer] Setup 'case-sensitive' in YAML files.

Didn't notice that yield an error, thanks again Sean! On Wed, Apr 6, 2016 at 7:04 PM, Sean Silva wrote: > > > On Wed, Apr 6, 2016 at 6:56 PM, Sean Silva wrote: > >> >> >> On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits < >> cfe-c

Re: r263686 - Reapply [2]: [VFS] Add support for handling path traversals

Sure, I'll tackle this soon! On Wed, Apr 6, 2016 at 6:59 PM, Sean Silva wrote: > > > On Wed, Mar 16, 2016 at 7:20 PM, Bruno Cardoso Lopes via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: bruno >> Date: Wed Mar 16 21:20:43 2016 &

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno added a comment. Ping! http://reviews.llvm.org/D18849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno created this revision. bruno added a reviewer: doug.gregor. bruno added subscribers: manmanren, dexonsmith, cfe-commits. Under certain conditions clang currently fails to properly diagnostic ObjectC parameter list when type args and protocols are mixed in the same list. This happens when the

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno updated this revision to Diff 53363. bruno added a comment. Hi Richard & Ben, Thanks for the review! I've attached a new patch and changed the approach: made findUsableModuleForHeader receive a FileName instead of FileEntry. Answering the questions below: FileManager::getFile returns th

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno added a comment. Hi Manman, Comment at: lib/Parse/ParseObjc.cpp:1697 @@ -1696,3 +1696,3 @@ // We syntactically matched a type argument, so commit to parsing - // type arguments. + // type arguments. Finding protocol arguments after here is an error.

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno added a comment. Hi Ben, Comment at: lib/Basic/FileManager.cpp:221-223 @@ -220,2 +220,5 @@ // See if there is already an entry in the map. + // FIXME: Note that when first requested, the returned file name equals to the + // requested path. This is not true when retu

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno updated this revision to Diff 53470. bruno added a comment. New patch after Manman's review. http://reviews.llvm.org/D18997 Files: include/clang/Sema/Sema.h lib/Parse/ParseObjc.cpp lib/Sema/SemaDeclObjC.cpp test/SemaObjC/parameterized_classes.m Index: test/SemaObjC/parameterized_

Re: [PATCH] D18849: [modules] Avoid module relocation error when building modules from VFS

bruno abandoned this revision. bruno added a comment. Hi Ben, Comment at: lib/Basic/FileManager.cpp:221-223 @@ -220,2 +220,5 @@ // See if there is already an entry in the map. + // FIXME: Note that when first requested, the returned file name equals to the + // requested p

r266235 - [CrashReproducer] Add test to run the reproducer script + modules

Author: bruno Date: Wed Apr 13 14:28:24 2016 New Revision: 266235 URL: http://llvm.org/viewvc/llvm-project?rev=266235&view=rev Log: [CrashReproducer] Add test to run the reproducer script + modules Now that we have basic support in place, make sure the reproducer script works with modules for a s

r266234 - [CrashReproducer] Setup 'use-external-names' in YAML files.

Author: bruno Date: Wed Apr 13 14:28:21 2016 New Revision: 266234 URL: http://llvm.org/viewvc/llvm-project?rev=266234&view=rev Log: [CrashReproducer] Setup 'use-external-names' in YAML files. Hide the real paths when rebuilding from VFS by setting up the crash reproducer to use 'use-external-name

r266233 - [VFS] Move default values to in-class member initialization. NFC

Author: bruno Date: Wed Apr 13 14:28:16 2016 New Revision: 266233 URL: http://llvm.org/viewvc/llvm-project?rev=266233&view=rev Log: [VFS] Move default values to in-class member initialization. NFC Modified: cfe/trunk/lib/Basic/VirtualFileSystem.cpp Modified: cfe/trunk/lib/Basic/VirtualFileSy

r266245 - [SemaObjC] Properly handle mix between type arguments and protocols.

Author: bruno Date: Wed Apr 13 15:59:07 2016 New Revision: 266245 URL: http://llvm.org/viewvc/llvm-project?rev=266245&view=rev Log: [SemaObjC] Properly handle mix between type arguments and protocols. Under certain conditions clang currently fails to properly diagnostic ObjectC parameter list whe

Re: [PATCH] D18997: [SemaObjC] Properly diagnose type arguments and protocols mix in parameterized classes

bruno closed this revision. bruno added a comment. Committed r266245 http://reviews.llvm.org/D18997 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18398: Compilation for Intel MCU (Part 1/3)

bruno added a comment. LGTM http://reviews.llvm.org/D18398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno added a comment. Ping! http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno added a comment. Ping! http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

bruno added a subscriber: bruno. bruno added a comment. Hi Cameron, Can you add a testcase? Repository: rL LLVM http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

Re: [PATCH] D20243: [PCH] Disable inclusion of timestamps when generating pch files on windows.

bruno added a subscriber: bruno. bruno added a comment. Hi Pierre, Comment at: test/PCH/pragma-once-timestamp.cpp:17 @@ +16,3 @@ + +// REQUIRES: system-windows + Can you move this to the beginning of the file? It makes it easier to spot that this is windows onl

Re: r269769 - [PCH] Fixed bug with preamble invalidation when overridden files change

Ping on the testcase :-) On Tue, May 17, 2016 at 9:36 AM, Nico Weber via cfe-commits wrote: > Is it possible to write a test for this? > > On Tue, May 17, 2016 at 10:34 AM, Cameron Desrochers via cfe-commits > wrote: >> >> Author: cameron314 >> Date: Tue May 17 09:34:53 2016 >> New Revision: 269

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added a comment. Hi, Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + Taking a look at this again I don't think there's

Re: [PATCH] D20338: [PCH] Fixed overridden files always invalidating preamble even when unchanged

bruno added a comment. You can probably find a way to test this by taking a look at unittests/Basic/VirtualFileSystemTest.cpp Repository: rL LLVM http://reviews.llvm.org/D20338 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno added inline comments. Comment at: lib/Driver/Tools.cpp:3657 @@ +3656,3 @@ + if (IsIAMCU && types::isCXX(Input.getType())) +D.Diag(diag::err_drv_cxx_not_supported) << getToolChain().getTriple().str(); + aturetsk wrote: > bruno wrote: > > Taking a look

Re: [PATCH] D20675: Compilation for Intel MCU (Part 3/3)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. LGTM http://reviews.llvm.org/D20675 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno added a comment. Ping! http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno added a comment. Ping! http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r271042 - [Driver] Fix driver support for color diagnostics

Author: bruno Date: Fri May 27 15:43:00 2016 New Revision: 271042 URL: http://llvm.org/viewvc/llvm-project?rev=271042&view=rev Log: [Driver] Fix driver support for color diagnostics Diagnostics that happen during driver time do not have color output support unless -fcolor-diagonostic is explicitl

r271314 - [Parser] Fix look ahead after EOF while parsing objc message and lambdas

Author: bruno Date: Tue May 31 13:46:31 2016 New Revision: 271314 URL: http://llvm.org/viewvc/llvm-project?rev=271314&view=rev Log: [Parser] Fix look ahead after EOF while parsing objc message and lambdas If a closing ')' isn't found for a macro instantiation inside a '[', the next token is EOF,

Re: [PATCH] D20451: [Parser] Fix look ahead after EOF while parsing objc message and lambdas

bruno closed this revision. bruno added a comment. Thanks Doug! Committed r271314 http://reviews.llvm.org/D20451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18585: [CrashReproducer] Add a module map callback for added headers

bruno closed this revision. bruno added a comment. Committed in r264971 http://reviews.llvm.org/D18585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20266: [Modules] Use vfs for (recursive) directory iteration

bruno closed this revision. bruno added a comment. Committed in r269661 http://reviews.llvm.org/D20266 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

bruno closed this revision. bruno added a comment. Committed in r271042 http://reviews.llvm.org/D20404 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

bruno added inline comments. Comment at: test/PCH/include-timestamp.cpp:5 @@ +4,3 @@ +// Check timestamp is included by default. +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %S/Inputs/include-timestamp-pch.h +// RUN: touch %S/Inputs/include-timestamp.h Can y

[PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno created this revision. bruno added a reviewer: benlangmuir. bruno added subscribers: cfe-commits, dexonsmith. This is currently used by clang to lock access to modules; improve the error message so that clang can use better output messages from locking error issues. http://reviews.llvm.or

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno added a subscriber: llvm-commits. bruno added a comment. Adding the right list for this +llvm-commits http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

I think this should be reverted until we figure out how to solve it. Moreover, it looks expensive to check for each file if it's within a system path. I would really like to measure compile time for this change before it goes definitely in. On Fri, Jun 3, 2016 at 4:53 PM, Justin Bogner via cfe-com

Re: [PATCH] D20942: [LockFileManager] Improve error output by adding error messages

bruno closed this revision. bruno added a comment. Applied your suggestions and committed in r271755! Thanks http://reviews.llvm.org/D20942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

r271758 - [Modules] Improve diagnostics for LockFileManager errors

Author: bruno Date: Fri Jun 3 20:13:22 2016 New Revision: 271758 URL: http://llvm.org/viewvc/llvm-project?rev=271758&view=rev Log: [Modules] Improve diagnostics for LockFileManager errors Uses error message now provided by LockFileManager in LLVM r271755. rdar://problem/26529101 Modified:

Re: r271708 - Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

> The information about whether the file is in a system path is already being > computed, so it would incur no extra overhead. I'm not sure that's the right > fix. You are more than welcome to revert the (clang) commit while we think > of the right fix. I'm not sure what the right fix is either, b

Re: [PATCH] D20867: [PCH] Fix timestamp check on windows hosts.

bruno added inline comments. Comment at: test/PCH/include-timestamp.cpp:8 @@ +7,3 @@ +// RUN: sleep 1 +// RUN: not %clang_cc1 -include-pch %t %s 2>&1 | FileCheck -check-prefix=CHECK-TIMESTAMP %s + pgousseau wrote: > Without the sleep the test fails for me, as it

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added a comment. Before this goes in again, I want to double check that this doesn't affect compile time on darwin + frameworks. Will get back to you asap. Comment at: lib/Lex/PPDirectives.cpp:218 @@ +217,3 @@ + SmallString<32> LowerInclude{Include}; + for (char& Ch : L

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added inline comments. Comment at: lib/Lex/PPDirectives.cpp:179 @@ +178,3 @@ +"exception", "iterator", "random", "strstream", "vector", +"forward_list", "limits", "ratio", "system_error", + Applying your patch reveled a bunch of ^M (carriage-return)

Re: [PATCH] D19843: Use the name of the file on disk to issue a new diagnostic about non-portable #include and #import paths.

bruno added a comment. FTR, I finally test it out for compile time and could not notice any difference besides noise. Thanks Eric! http://reviews.llvm.org/D19843 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/

Re: [PATCH] D19274: Compilation for Intel MCU (Part 2/3)

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Sure! LGTM http://reviews.llvm.org/D19274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cf

Re: [PATCH] D21338: cc1_main: Do not print statistics in -disable_free mode.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Assuming that it's guaranteed that the other path would always print out the statistics, LGTM Repository: rL LLVM http://reviews.llvm.org/D21338 __

Re: r273147 - [X86] Add -mno-iamcu option.

Hi Andrey, On Mon, Jun 20, 2016 at 3:31 AM, Andrey Turetskiy via cfe-commits wrote: > Author: aturetsk > Date: Mon Jun 20 05:31:39 2016 > New Revision: 273147 > > URL: http://llvm.org/viewvc/llvm-project?rev=273147&view=rev > Log: > [X86] Add -mno-iamcu option. > > Add -mno-iamcu option to: > 1

[PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno created this revision. bruno added reviewers: rnk, rsmith. bruno added a subscriber: cfe-commits. Before r266366, clang used to support constructs like: typedef __attribute__((vector_size(8))) double float64x1_t; typedef __attribute__((vector_size(16))) double float64x2_t; float64x1_t

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno added a comment. Ping! http://reviews.llvm.org/D21700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D21641: Use ArgList::hasFlag to check if -miamcu/-mno-iamcu is passed. NFC.

bruno accepted this revision. bruno added a comment. This revision is now accepted and ready to land. Cool, thanks! LGTM http://reviews.llvm.org/D21641 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno added a comment. In http://reviews.llvm.org/D21700#470103, @rnk wrote: > After writing r266366, we discovered that GCC accepts none of the code in > that test case, so we should consider turning -flax-vector-conversions off by > default. Makes sense, specially given the non obvious sema

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno updated this revision to Diff 62802. bruno added a comment. Update patch after Reid's suggestions. http://reviews.llvm.org/D21700 Files: lib/Sema/SemaExpr.cpp test/Sema/vector-cast.c Index: test/Sema/vector-cast.c === --

r274646 - [SemaExpr] Support assignments from vector to scalars with same size

Author: bruno Date: Wed Jul 6 13:05:23 2016 New Revision: 274646 URL: http://llvm.org/viewvc/llvm-project?rev=274646&view=rev Log: [SemaExpr] Support assignments from vector to scalars with same size Before r266366, clang used to support constructs like: typedef __attribute__((vector_size(8))

Re: [PATCH] D21700: [SemaExpr] Support lax conversions in assignments with vector and scalars with same size

bruno closed this revision. bruno added a comment. Thanks Reid, Committed r274646. http://reviews.llvm.org/D21700 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno created this revision. bruno added reviewers: manmanren, doug.gregor. bruno added a subscriber: cfe-commits. Calls to TransformExpr for NSDictionary elements (keys and values) in TransformObjCDictionaryLiteral might fail to obtain TypoCorrections. This is OK, but the early exits with ExprErr

[PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno created this revision. bruno added reviewers: bob.wilson, doug.gregor, krememek. bruno added subscribers: cfe-commits, dexonsmith. Give incompatible pointer warning for function pointers its own diagnostic group while leaving it as a subgroup of incompatible-pointer-types. This is in prepa

Re: [PATCH] D22248: [Sema] Create a separate group for incompatible function pointer warning

bruno added a comment. Ping! https://reviews.llvm.org/D22248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22183: [SemObjC] Fix TypoExpr handling in TransformObjCDictionaryLiteral

bruno updated this revision to Diff 64162. bruno added a comment. Thanks for the review Manman, I found a much better approach. Updated the patch to reflect that! https://reviews.llvm.org/D22183 Files: lib/Parse/ParseObjc.cpp test/SemaObjC/objc-array-literal.m test/SemaObjC/objc-dictiona

r263617 - Reapply: [VFS] Add support for handling path traversals

Author: bruno Date: Tue Mar 15 23:39:38 2016 New Revision: 263617 URL: http://llvm.org/viewvc/llvm-project?rev=263617&view=rev Log: Reapply: [VFS] Add support for handling path traversals This is originally r261551, reverted because of windows bots failing on unittests. Change the current behavio

Re: [PATCH] D17104: [VFS] Drop path traversal assertion

Thanks! On Wed, Mar 16, 2016 at 5:35 AM, NAKAMURA Takumi wrote: > chapuni added a subscriber: chapuni. > chapuni added a comment. > > Excuse me, I have reverted it in r263636. > > > > Comment at: lib/Frontend/ModuleDependencyCollector.cpp:65 > @@ +64,3 @@ > +static bool real_path

r263686 - Reapply [2]: [VFS] Add support for handling path traversals

Author: bruno Date: Wed Mar 16 21:20:43 2016 New Revision: 263686 URL: http://llvm.org/viewvc/llvm-project?rev=263686&view=rev Log: Reapply [2]: [VFS] Add support for handling path traversals This was applied twice r261551 and 263617 and later reverted because: (1) Windows bot failing on unittes

r263691 - [VFS] Remove wrong header include

Author: bruno Date: Wed Mar 16 23:59:52 2016 New Revision: 263691 URL: http://llvm.org/viewvc/llvm-project?rev=263691&view=rev Log: [VFS] Remove wrong header include Follow up from r263686. Forgot to remove the wrong header file. Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp

r263748 - Reapply [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Thu Mar 17 16:11:23 2016 New Revision: 263748 URL: http://llvm.org/viewvc/llvm-project?rev=263748&view=rev Log: Reapply [VFS] Add 'overlay-relative' field to YAML files This reapplies r261552. The VFS overlay mapping between virtual paths and real paths is done through the 'e

[PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno created this revision. bruno added a reviewer: rsmith. bruno added subscribers: cfe-commits, dexonsmith. Improve invalid format string specifier handling by printing out invalid specifiers characters with \x, \u and \U. Previously clang would print gargabe whenever the character is unprint

r263893 - Reapply [2] [VFS] Add 'overlay-relative' field to YAML files

Author: bruno Date: Sat Mar 19 21:08:48 2016 New Revision: 263893 URL: http://llvm.org/viewvc/llvm-project?rev=263893&view=rev Log: Reapply [2] [VFS] Add 'overlay-relative' field to YAML files This reapplies r261552 and r263748. Fixed testcase to reapply. The VFS overlay mapping between virtual

r263750 - Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files"

Author: bruno Date: Thu Mar 17 16:30:55 2016 New Revision: 263750 URL: http://llvm.org/viewvc/llvm-project?rev=263750&view=rev Log: Revert "Reapply [VFS] Add 'overlay-relative' field to YAML files" Tests failing on http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/46102 This reverts comm

Re: r263718 - Use a simpler set of mock headers for the vfs+modules crash recovery tests.

Nice! Thanks Benjamin On Thu, Mar 17, 2016 at 9:19 AM, Benjamin Kramer via cfe-commits wrote: > Author: d0k > Date: Thu Mar 17 11:19:51 2016 > New Revision: 263718 > > URL: http://llvm.org/viewvc/llvm-project?rev=263718&view=rev > Log: > Use a simpler set of mock headers for the vfs+modules crash

r263912 - [VFS] Fix test to use more restrict set of headers

Author: bruno Date: Sun Mar 20 13:08:32 2016 New Revision: 263912 URL: http://llvm.org/viewvc/llvm-project?rev=263912&view=rev Log: [VFS] Fix test to use more restrict set of headers Modified: cfe/trunk/test/Modules/crash-vfs-relative-overlay.m Modified: cfe/trunk/test/Modules/crash-vfs-rela

Re: r263893 - Reapply [2] [VFS] Add 'overlay-relative' field to YAML files

>> // RUN: not env FORCE_CLANG_DIAGNOSTICS_CRASH= TMPDIR=%t TEMP=%t TMP=%t \ >> -// RUN: %clang -fsyntax-only %s -I %S/Inputs/crash-recovery -isysroot >> %/t/i/\ >> +// RUN: %clang -fsyntax-only %s -I %S/Inputs/System -isysroot %/t/i/\ > > Is this an intentional revert? Test fails for me

[PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno created this revision. bruno added reviewers: bob.wilson, dexonsmith. bruno added a subscriber: cfe-commits. Previously only 3 digits were valid. Increase it to 5. http://reviews.llvm.org/D18304 Files: include/clang/Driver/Driver.h lib/Driver/Driver.cpp lib/Driver/Tools.cpp test/Dr

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Ping! http://reviews.llvm.org/D18304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno added a comment. Ping! http://reviews.llvm.org/D18296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno added a comment. Ping :-) http://reviews.llvm.org/D18304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno added a comment. Ping :-) http://reviews.llvm.org/D18296 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D18304: [DarwinDriver] Increase the number of valid digits for ld version string

bruno updated this revision to Diff 51828. bruno added a comment. Thanks Reid. The original idea was to have MaxDigits despite the size of the input array (but bounded by its size). But since there are no other users up to this point, your suggestion seems better, updated the patch to reflect it

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno added a comment. In http://reviews.llvm.org/D18296#384766, @rsmith wrote: > This patch builds a length-1 `ConversionSpecifier` but includes the complete > code point in the length of the overall format specifier, which is > inconsistent. Please either treat the trailing bytes as part of t

Re: [PATCH] D18296: [Sema] Handle UTF-8 invalid format string specifiers

bruno updated this revision to Diff 51859. bruno added a comment. Update after Richard's review. - Handle scanf - Properly update `ConversionSpecifier` http://reviews.llvm.org/D18296 Files: include/clang/Analysis/Analyses/FormatString.h lib/Analysis/FormatString.cpp lib/Analysis/FormatSt

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 44180. bruno added a comment. Hi Richard, Thanks for the comments. Updated the patch! In http://reviews.llvm.org/D15173#313235, @rsmith wrote: > I think that this will leave us with a broken token stream. In your example, > the cached token stream starts as

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 44306. bruno added a comment. Hi Richard, Thanks for the detailed explanation, it now makes sense to me. I updated the patch with another approach! Let me know if it's the right direction. http://reviews.llvm.org/D15173 Files: include/clang/Lex/Preprocess

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno added a comment. Ping! http://reviews.llvm.org/D15173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Ping :-) On Mon, Jan 11, 2016 at 8:49 AM, Bruno Cardoso Lopes wrote: > bruno added a comment. > > Ping! > > > http://reviews.llvm.org/D15173 > > > -- Bruno Cardoso Lopes http://www.brunocardoso.cc ___ cfe-commits mailing list cfe-commits@lists.llvm.

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

Hi Richard, >> + // The advance from '>>' to '>' in a ObjectiveC template argument list >> needs >> + // to be properly reflected in the token cache to allow correct >> interaction >> + // between annotation and backtracking. >> + if (ObjCGenericList && PrevTok.getKind() == tok::greatergreater

Re: [PATCH] D15173: [Preprocessor] Fix assertion in AnnotatePreviousCachedTokens

bruno updated this revision to Diff 45421. bruno added a comment. Update patch after Richard comments http://reviews.llvm.org/D15173 Files: include/clang/Lex/Preprocessor.h lib/Lex/PPCaching.cpp lib/Parse/ParseTemplate.cpp test/Parser/objcxx11-protocol-in-template.mm Index: test/Parser

<    1   2   3   4   5   6   7   >