Author: bruno
Date: Thu Oct 27 21:37:04 2016
New Revision: 285378
URL: http://llvm.org/viewvc/llvm-project?rev=285378&view=rev
Log:
[Modules] Make test from r285377 darwin specific
Appease buildbots:
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/55876
Modified:
cfe/trunk/test/Mod
Author: bruno
Date: Fri Oct 28 11:32:10 2016
New Revision: 285411
URL: http://llvm.org/viewvc/llvm-project?rev=285411&view=rev
Log:
[Preprocessor] Support for '-dI' flag
Implement the -dI as supported by GCC: Output ‘#include’ directives in addition
to the result of preprocessing.
This change ai
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285411: [Preprocessor] Support for '-dI' flag (authored by
bruno).
Changed prior to commit:
https://reviews.llvm.org/D25153?vs=75351&id=76210#toc
Repository:
rL LLVM
https://reviews.llvm.org/D25153
Author: bruno
Date: Fri Oct 28 12:02:10 2016
New Revision: 285416
URL: http://llvm.org/viewvc/llvm-project?rev=285416&view=rev
Log:
Revert "[Preprocessor] Support for '-dI' flag"
This reverts r285411. Tests failing on
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/141
Remove
bruno added a comment.
The test is failing on windows:
http://lab.llvm.org:8011/builders/clang-x86-windows-msvc2015/builds/141
I reverted the patch for now in r285416, can you take a look?
Repository:
rL LLVM
https://reviews.llvm.org/D25153
___
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, manmanren.
After r284797 builins are treated like textual includes. When compiling for
ObjC++, the in-memory header file generated for the modules is composed only of
#import's instead of includes.
bruno marked an inline comment as done.
bruno added a comment.
In https://reviews.llvm.org/D26267#586971, @v.g.vassilev wrote:
> Could you include more context when creating the diff eg. git diff -U, or
> equivalent.
I did, -U9 actually, not sure why you're not getting it...
===
bruno updated this revision to Diff 76931.
bruno marked an inline comment as done.
bruno added a comment.
Update patch after Vassil's comments!
https://reviews.llvm.org/D26267
Files:
include/clang/Lex/ModuleMap.h
lib/Frontend/FrontendActions.cpp
lib/Lex/ModuleMap.cpp
test/Modules/Inputs
bruno created this revision.
bruno added a reviewer: dexonsmith.
bruno added subscribers: cfe-commits, kledzik, bob.wilson.
bruno set the repository for this revision to rL LLVM.
Usually, when using LTO with a clang installation newer than the system one,
there's a libLTO.dylib version mismatch a
bruno updated this revision to Diff 35664.
bruno added a comment.
Added test per Duncan's comment.
Repository:
rL LLVM
http://reviews.llvm.org/D13117
Files:
include/clang/Basic/DiagnosticDriverKinds.td
lib/Driver/Tools.cpp
test/Driver/darwin-ld.c
Index: test/Driver/darwin-ld.c
===
Author: bruno
Date: Wed Sep 30 14:55:07 2015
New Revision: 248932
URL: http://llvm.org/viewvc/llvm-project?rev=248932&view=rev
Log:
[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib
Usually, when using LTO with a clang installation newer than the
system's one, there's a libLTO.
Author: bruno
Date: Wed Sep 30 15:11:02 2015
New Revision: 248935
URL: http://llvm.org/viewvc/llvm-project?rev=248935&view=rev
Log:
Revert "[DarwinDriver] Use -lto_library to specify the path for libLTO.dylib"
Revert r248932. Bots complaining about new warnings where they shouldn't.
Modified:
Author: bruno
Date: Fri Oct 2 10:10:33 2015
New Revision: 249143
URL: http://llvm.org/viewvc/llvm-project?rev=249143&view=rev
Log:
[DarwinDriver] Reapply: Use -lto_library to specify the path for libLTO.dylib
Reapply r248935.
Usually, when using LTO with a clang installation newer than the
syst
bruno added a subscriber: bruno.
bruno added a comment.
Hi,
Can you provide more details on what the build issues are? It seems that the
line you introduce is covered in the ifdef below, wonder why it's not
triggering in your build?
Repository:
rL LLVM
https://reviews.llvm.org/D22200
__
bruno added a subscriber: bruno.
bruno accepted this revision.
bruno added a reviewer: bruno.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM with one small fix, see below.
Comment at: lib/Driver/Tools.cpp:6379
@@ +6378,3 @@
+void ClangAs::AddX86Targ
bruno added a subscriber: bruno.
Comment at: lib/Headers/cpuid.h:114
@@ -109,2 +113,3 @@
#define bit_AVX 0x1000
+#define bit_F16C0x2000
#define bit_RDRND 0x4000
Isn't this one also meant for gcc compat?
https://reviews.llvm.or
bruno created this revision.
bruno added reviewers: rsmith, doug.gregor.
bruno added subscribers: cfe-commits, dexonsmith.
C++ static destructors can be problematic in multi-threaded environment. Some
of the issues users often complain about include:
1. Teardown ordering: crashes when one thread
Author: bruno
Date: Mon Jul 18 15:37:06 2016
New Revision: 275907
URL: http://llvm.org/viewvc/llvm-project?rev=275907&view=rev
Log:
[Sema] Create a separate group for incompatible function pointer warning
Give incompatible function pointer warning its own diagnostic group
but still leave it as a
bruno closed this revision.
bruno added a comment.
Thanks, r275907.
https://reviews.llvm.org/D22248
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping!
https://reviews.llvm.org/D22183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added a reviewer: zaks.anna.
bruno added a subscriber: cfe-commits.
For memset (and others) we can get diagnostics like:
struct stat { int x; };
void foo(struct stat *stamps) {
memset(stamps, 0, sizeof(stamps));
}
t.c:7:28: warning: 'memset' call op
Author: bruno
Date: Tue Jul 19 15:21:18 2016
New Revision: 276020
URL: http://llvm.org/viewvc/llvm-project?rev=276020&view=rev
Log:
[SemaObjC] Improve ObjCDictionaryLiteral and ObjCArryLiteral diagnostics
Sema actions on ObjCDictionaryLiteral and ObjCArryLiteral are currently
done as a side-effec
bruno closed this revision.
bruno added a comment.
Thanks Manman, Committed r276020
https://reviews.llvm.org/D22183
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hi Nirav,
This test is failing on darwin:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26574
Can you take a look?
On Wed, Jul 27, 2016 at 12:57 PM, Nirav Dave via cfe-commits
wrote:
> Author: niravd
> Date: Wed Jul 27 14:57:40 2016
> New Revision: 276907
>
> URL: h
Hi Artem,
This broke
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/26856,
can you take a look?
Thanks,
On Tue, Aug 2, 2016 at 4:12 PM, Artem Belevich via cfe-commits
wrote:
> Author: tra
> Date: Tue Aug 2 18:12:51 2016
> New Revision: 277542
>
> URL: http://llvm.o
Hi Eric,
After we upgraded our green dragon bots to El Captain (10.11), the
test below started to fail on some of our machines:
--
test/std/experimental/filesystem/fs.op.funcs/fs.op.hard_lk_ct/hard_link_count.pass.cpp
TEST_CASE(hard_link_count_for_directory)
{
uintmax_t DirExpect = 3;
Author: bruno
Date: Thu Aug 4 18:55:22 2016
New Revision: 277787
URL: http://llvm.org/viewvc/llvm-project?rev=277787&view=rev
Log:
[Sema] Add sizeof diagnostics for bzero
For memset (and others) we can get diagnostics like:
struct stat { int x; };
void foo(struct stat *stamps) {
bzero(s
bruno closed this revision.
bruno added a comment.
Thanks! Committed in r277787
https://reviews.llvm.org/D22525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Fri Aug 5 11:41:00 2016
New Revision: 277830
URL: http://llvm.org/viewvc/llvm-project?rev=277830&view=rev
Log:
Revert "[Sema] Add sizeof diagnostics for bzero"
This reverts commit r277787, which caused PR28870.
Modified:
cfe/trunk/lib/AST/Decl.cpp
cfe/trunk/lib/Sema/
regards,
> Gabor Ballabas
>
>
> On 08/05/2016 01:55 AM, Bruno Cardoso Lopes via cfe-commits wrote:
>>
>> Author: bruno
>> Date: Thu Aug 4 18:55:22 2016
>> New Revision: 277787
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=277787&vie
Ping!
On Thu, Aug 4, 2016 at 8:03 AM, Adrian Prantl wrote:
>
>> On Aug 3, 2016, at 1:56 PM, Bruno Cardoso Lopes
>> wrote:
>>
>> Hi Eric,
>>
>> After we upgraded our green dragon bots to El Captain (10.11), the
>> test below started to fail on some of our machines:
>>
>> --
>> test/std/experime
Thanks Matthias!
On Tue, Aug 9, 2016 at 6:02 PM, Matthias Braun via cfe-commits
wrote:
> Author: matze
> Date: Tue Aug 9 20:02:28 2016
> New Revision: 278191
>
> URL: http://llvm.org/viewvc/llvm-project?rev=278191&view=rev
> Log:
> test/hard_link_count(): Fix test on darwin
>
> The hard link cou
Author: bruno
Date: Wed Aug 10 13:34:47 2016
New Revision: 278264
URL: http://llvm.org/viewvc/llvm-project?rev=278264&view=rev
Log:
Reapply [Sema] Add sizeof diagnostics for bzero
Reapply r277787. For memset (and others) we can get diagnostics like:
struct stat { int x; };
void foo(struct st
This typo was exactly the reason why, r278264. Thanks
On Fri, Aug 5, 2016 at 10:09 AM, David Majnemer
wrote:
>
>
> On Thu, Aug 4, 2016 at 4:55 PM, Bruno Cardoso Lopes via cfe-commits
> wrote:
>>
>> Author: bruno
>> Date: Thu Aug 4 18:55:22 2016
>>
Hi Joerg,
> Given that bzero is pretty much non-standard at this point, I strongly
> dislike the approach of checking only the function name.
Thanks for the feedback. bzero it's widely used though, I think it's a
usability win to perform a diagnostic here, despite bzero being
non-standard.
Is th
bruno added inline comments.
Comment at: lib/Frontend/CompilerInstance.cpp:1438-1450
@@ -1437,3 +1437,15 @@
// Search for a module with the given name.
Module = PP->getHeaderSearchInfo().lookupModule(ModuleName);
-if (!Module) {
+HeaderSearchOptions &HSOpts =
+
Author: bruno
Date: Thu Aug 11 13:33:15 2016
New Revision: 278379
URL: http://llvm.org/viewvc/llvm-project?rev=278379&view=rev
Log:
[Sema] Add more strict check for sizeof diagnostics for bzero
Follow-up from r278264 after Joerg's feedback.
Since bzero is not standard, be more strict: also check
On Thu, Aug 11, 2016 at 5:43 AM, Joerg Sonnenberger via cfe-commits
wrote:
>
> On Wed, Aug 10, 2016 at 02:36:01PM -0700, Bruno Cardoso Lopes wrote:
> > Hi Joerg,
> >
> > > Given that bzero is pretty much non-standard at this point, I strongly
> > > dislike the approach of checking only the functio
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path
obtained via 'external-contents' should cause iteration on the VFS to stop.
If 'true', the VFS should ignore the entr
Author: bruno
Date: Thu Aug 11 20:50:53 2016
New Revision: 278456
URL: http://llvm.org/viewvc/llvm-project?rev=278456&view=rev
Log:
[VFS] Add 'ignore-non-existent-contents' field to YAML files
Add 'ignore-non-existent-contents' to tell the VFS whether an invalid path
obtained via 'external-conten
Author: bruno
Date: Thu Aug 11 20:51:04 2016
New Revision: 278457
URL: http://llvm.org/viewvc/llvm-project?rev=278457&view=rev
Log:
[VFS] Skip non existent files from the VFS tree
When the VFS uses a YAML file, the real file path for a
virtual file is described in the "external-contents" field. E
bruno accepted this revision.
bruno added a reviewer: bruno.
bruno added a comment.
This revision is now accepted and ready to land.
Applied your comments, and committed in r278456!
Thanks
https://reviews.llvm.org/D23422
___
cfe-commits mailing lis
Author: bruno
Date: Thu Aug 11 21:17:26 2016
New Revision: 278459
URL: http://llvm.org/viewvc/llvm-project?rev=278459&view=rev
Log:
Revert "[VFS] Skip non existent files from the VFS tree"
Breaking bots:
http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-incremental_check/27281/
This rever
Author: bruno
Date: Fri Aug 12 13:18:24 2016
New Revision: 278543
URL: http://llvm.org/viewvc/llvm-project?rev=278543&view=rev
Log:
Reapply [VFS] Skip non existent files from the VFS tree
Reapply r278457 with test fixed to not abouse fs case sensitivity.
When the VFS uses a YAML file, the real f
bruno created this revision.
bruno added reviewers: rsmith, doug.gregor, akyrtzi.
bruno added subscribers: cfe-commits, dexonsmith.
In the context where we break one tok::greatergreater into two tok::greater in
order to correctly update the cached tokens; update the CachedTokens with two
tok::gr
Author: bruno
Date: Fri Feb 5 13:36:39 2016
New Revision: 259910
URL: http://llvm.org/viewvc/llvm-project?rev=259910&view=rev
Log:
[Parser] Perform CachedTokens update dependent on token consumption
In the context where we break one tok::greatergreater into two
tok::greater in order to correctly
bruno closed this revision.
bruno added a comment.
Committed r259910
http://reviews.llvm.org/D16906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: bogner, benlangmuir.
bruno added subscribers: cfe-commits, dexonsmith.
This patch removes the path traversals check/assertion related with the
presence of ".." in paths.
The rationale is that if source and destination paths in the YAML file con
bruno added a comment.
In http://reviews.llvm.org/D17104#349141, @benlangmuir wrote:
> Please clarify what you mean here:
>
> > The rationale is that if source and destination paths in the YAML file
> > contain ".." this is enough
>
> > for the file manager to retrieve the right file, meaning t
bruno added a comment.
> I don't think this is the right approach. If we don't canonicalize the
> source path then:
>
> - looking up the path *without* the .. won't work, which means anything that
> looks up a realpath will fail
If we canonicalize, then it needs to be done in two places:
bruno added a comment.
> Your two-path solution seems like it's on the right track but I don't like
> that it brings us back to having ".." in the source path.
Given the two-path solution, another thing we could do in the first path, is to
default to the remove_dots() version for the source, i
bruno added a comment.
> I'm not sure I understand how the 2nd path would cover the realpath case. It
> is just an entry for the realpath itself; that doesn't help if the client
> looks up "/install-dir/lib/clang/3.8.0" directly (not just from removing dots
> from bin/..).
What I was suggest
bruno updated this revision to Diff 48397.
bruno added a comment.
Updated the patch, with the following changes:
Handle ".", ".." and "./" with trailing slashes while collecting files
to be dumped into the vfs overlay directory.
Include the support for symlinks into components. Given the
bruno created this revision.
bruno added reviewers: benlangmuir, bogner.
bruno added subscribers: cfe-commits, dexonsmith.
The VFS overlay mapping between virtual paths and real paths is done through
the 'external-contents' entries in YAML files, which contains hardcoded paths
to the real files.
Author: bruno
Date: Mon Feb 22 12:41:01 2016
New Revision: 261551
URL: http://llvm.org/viewvc/llvm-project?rev=261551&view=rev
Log:
[VFS] Add support for handling path traversals
Handle ".", ".." and "./" with trailing slashes while collecting files
to be dumped into the vfs overlay directory.
I
Author: bruno
Date: Mon Feb 22 12:41:09 2016
New Revision: 261552
URL: http://llvm.org/viewvc/llvm-project?rev=261552&view=rev
Log:
[VFS] Add 'overlay-relative' field to YAML files
The VFS overlay mapping between virtual paths and real paths is done through
the 'external-contents' entries in YAML
Author: bruno
Date: Mon Feb 22 13:02:27 2016
New Revision: 261556
URL: http://llvm.org/viewvc/llvm-project?rev=261556&view=rev
Log:
[VFS] Fix call to getVFSFromYAML in unittests
Follow up from r261552
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittest
bruno closed this revision.
bruno added a comment.
Committed r261551
http://reviews.llvm.org/D17104
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno closed this revision.
bruno added a comment.
Committed r261552 / r261556
http://reviews.llvm.org/D17457
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits
> wrote:
>>
>> Author: bruno
>> Date: Mon Feb 22 12:41:09 2016
>> New Revision: 261552
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=261552&view=rev
>> Log:
>> [VFS] Add &#x
;
>> This is hopefully fixed in r261556.
>>
>> On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva wrote:
>> > This or r261551 seem to be causing a build failure:
>> >
>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/buil
Author: bruno
Date: Tue Feb 23 01:06:12 2016
New Revision: 261613
URL: http://llvm.org/viewvc/llvm-project?rev=261613&view=rev
Log:
Revert "[VFS] Add 'overlay-relative' field to YAML files" and "[VFS] Fix call
to getVFSFromYAML in unittests"
This reverts commit r261552 and r261556 because of fai
ixed in r261556.
>>>
>>> On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva wrote:
>>> > This or r261551 seem to be causing a build failure:
>>> >
>>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527
>&g
Author: bruno
Date: Tue Feb 23 11:06:50 2016
New Revision: 261654
URL: http://llvm.org/viewvc/llvm-project?rev=261654&view=rev
Log:
Revert "[VFS] Add support for handling path traversals"
This reverts commit r261551 due to failing tests in windows bots:
http://lab.llvm.org:8011/builders/clang-x6
Sean Silva wrote:
>>>> > This or r261551 seem to be causing a build failure:
>>>> >
>>>> > http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527
>>>> >
>>>> > -- Sean SIlva
>>>>
bruno added a subscriber: bruno.
bruno added a reviewer: bruno.
bruno added a comment.
Hi Andrey,
What about the code / tests that check for this flags?
http://reviews.llvm.org/D19658
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://l
Author: bruno
Date: Mon May 2 15:20:49 2016
New Revision: 268297
URL: http://llvm.org/viewvc/llvm-project?rev=268297&view=rev
Log:
Revert "[Driver] Quote clang full version in dwarf producer when invoking cc1as"
This reverts commit r264813 / 6484b95d634f53dd929c75265ef3c4decf397584.
While using
Author: bruno
Date: Fri May 6 18:21:57 2016
New Revision: 268820
URL: http://llvm.org/viewvc/llvm-project?rev=268820&view=rev
Log:
[VFS] Add dump methods to the VFS overlay tree
Useful when debugging issues within the VFS overlay.
Modified:
cfe/trunk/lib/Basic/VirtualFileSystem.cpp
Modifie
Author: bruno
Date: Fri May 6 18:21:50 2016
New Revision: 268819
URL: http://llvm.org/viewvc/llvm-project?rev=268819&view=rev
Log:
[CrashReproducer] Change module map callback signature. NFC
Use a StringRef instead of a FileEntry in the moduleMapAddHeader
callback to allow more flexibility on wh
Author: bruno
Date: Fri May 6 18:58:58 2016
New Revision: 268825
URL: http://llvm.org/viewvc/llvm-project?rev=268825&view=rev
Log:
[CrashReproducer] Always use realpath for destination
When running reproducer scripts we need that original symlinks from the
source filesystem are reproduced in the
Author: bruno
Date: Tue May 10 13:43:00 2016
New Revision: 269100
URL: http://llvm.org/viewvc/llvm-project?rev=269100&view=rev
Log:
[VFS] Reconstruct the VFS overlay tree for more accurate lookup
The way we currently build the internal VFS overlay representation leads
to inefficient path search a
Author: bruno
Date: Tue May 10 15:20:55 2016
New Revision: 269108
URL: http://llvm.org/viewvc/llvm-project?rev=269108&view=rev
Log:
[VFS] Change unittest to try appeasing win10 buildbot
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5103
Follow up from r
Author: bruno
Date: Tue May 10 17:30:01 2016
New Revision: 269133
URL: http://llvm.org/viewvc/llvm-project?rev=269133&view=rev
Log:
[VFS] One more unittest change to fix win10 buildbot
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/5110
Follow up from r2
; Changes to this VFS code seem to have a trend of breaking on windows. Any
> idea why that is? I can understand things breaking on windows when writing
> low-level parts of an FS abstraction, but this patch seems fairly
> high-level. Is there a missing layering or something?
>
> -
Hi Sean,
> So sorry! It had gone quiet for a few hours and I wanted to avoid leaving it
> red any longer.
No problem, the priority is to get bot greens!
> Does any platform define a guaranteed directory iteration order? I feel like
> depending on it in the first place is unwise (or maybe I'm mis
bruno added a comment.
Hi,
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:154
@@ -153,1 +153,3 @@
+def err_drv_cxx_not_supported : Error<
+ "C++ is not supported for target '%0'">;
Are you sure there's no equivalente for this already? I'm surprised!
> I'm glad to help, but it makes me uneasy to have somebody working on a
> filesystem abstraction that does not have ready access to test and debug
> their changes across the major host platforms that LLVM supports (linux,
> mac, windows). Is there any way you can get access? I don't think that
> w
Author: bruno
Date: Wed May 11 15:58:47 2016
New Revision: 269234
URL: http://llvm.org/viewvc/llvm-project?rev=269234&view=rev
Log:
[VFS][Unittests] Make dir iteration tests depend only on content
Do not rely on any specific order while comparing the results of
directory iteration.
Modified:
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
(1) Collect headers under inner frameworks (frameworks inside other
other frameworks).
(2) Make sure we also collect the right header files inside them.
More info on (2):
Consider a dummy fra
> What are the platform-specifics for crash reproducing? Shouldn't it
> basically be saving some files and storing some data for reconstructing?
Feature-wise the crash reproducer for modules could "just" work for
windows, there should not be anything platform-specific, I never
tested it on windows
Author: bruno
Date: Wed May 11 22:23:36 2016
New Revision: 269270
URL: http://llvm.org/viewvc/llvm-project?rev=269270&view=rev
Log:
[VFS] Reapply r269100: Reconstruct the VFS overlay tree for more accurate lookup
The way we currently build the internal VFS overlay representation leads
to ineffici
Author: bruno
Date: Wed May 11 23:43:27 2016
New Revision: 269276
URL: http://llvm.org/viewvc/llvm-project?rev=269276&view=rev
Log:
Revert "[VFS] Reapply r269100: Reconstruct the VFS overlay tree for more
accurate lookup"
Reverts r269270, buildbots still failing:
http://lab.llvm.org:8011/builder
12:29 PM Bruno Cardoso Lopes via cfe-commits
> wrote:
>>
>> Author: bruno
>> Date: Wed May 11 22:23:36 2016
>> New Revision: 269270
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=269270&view=rev
>> Log:
>> [VFS] Reapply r269100: Reconstruct the V
Author: bruno
Date: Thu May 12 14:13:04 2016
New Revision: 269326
URL: http://llvm.org/viewvc/llvm-project?rev=269326&view=rev
Log:
[Unittests] Reverse the order of arguments for correct debug output
Modified:
cfe/trunk/unittests/Basic/VirtualFileSystemTest.cpp
Modified: cfe/trunk/unittests/
Author: bruno
Date: Thu May 12 14:13:07 2016
New Revision: 269327
URL: http://llvm.org/viewvc/llvm-project?rev=269327&view=rev
Log:
[VFS] Reapply #2: Reconstruct the VFS overlay tree for more accurate lookup
Reapply r269100 and r269270, reverted due to
https://llvm.org/bugs/show_bug.cgi?id=27725.
bruno updated this revision to Diff 57263.
bruno added a comment.
Updated after Ben's suggestions!
http://reviews.llvm.org/D20194
Files:
include/clang/Lex/ModuleMap.h
lib/Frontend/ModuleDependencyCollector.cpp
lib/Lex/ModuleMap.cpp
test/Modules/Inputs/crash-recovery/Frameworks/A.framewo
Author: bruno
Date: Fri May 13 17:21:51 2016
New Revision: 269502
URL: http://llvm.org/viewvc/llvm-project?rev=269502&view=rev
Log:
[ModuleMap][CrashReproducer] Collect headers from inner frameworks
(1) Collect headers under inner frameworks (frameworks inside other
other frameworks).
(2) Make su
bruno closed this revision.
bruno added a comment.
Thanks Ben!
Committed r269502
http://reviews.llvm.org/D20194
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: bruno
Date: Fri May 13 19:00:18 2016
New Revision: 269520
URL: http://llvm.org/viewvc/llvm-project?rev=269520&view=rev
Log:
[VFS] Add level() method to vfs::recursive_directory_iterator
Unlike sys::fs::recursive_directory_iterator,
vfs::recursive_directory_iterator does not implement the
bruno created this revision.
bruno added a reviewer: benlangmuir.
bruno added a subscriber: cfe-commits.
Clang performs directory walk while searching headers inside modules by
using the ::sys::fs instead of ::vfs. This prevents any code that uses
the VFS (e.g, reproducer scripts) to actually find
Author: bruno
Date: Mon May 16 11:46:01 2016
New Revision: 269661
URL: http://llvm.org/viewvc/llvm-project?rev=269661&view=rev
Log:
[Modules] Use vfs for (recursive) directory iteration
Clang performs directory walk while searching headers inside modules by
using the ::sys::fs instead of ::vfs. T
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, dexonsmith.
Diagnostics that happen during driver time do not have color output
support unless -fcolor-diagonostic is explicitly passed into the driver.
OTOH, it works great for cc1 mode since dianos
bruno added a subscriber: bruno.
bruno added a comment.
Hi Manman,
Comment at: lib/Serialization/ASTWriter.cpp:2191
@@ -2191,1 +2190,3 @@
+// We write out exported module macros for PCH as well.
+if (true) {
auto Leafs = PP.getLeafModuleMacros(Name);
-
bruno created this revision.
bruno added reviewers: doug.gregor, rsmith.
bruno added a subscriber: cfe-commits.
If a closing ')' isn't found for a macro instantiation inside a '[',
the next token is EOF, this leads to crashes if we try to look ahead of
that. This could be triggered whenever trying
bruno added reviewers: dexonsmith, silvas.
bruno removed subscribers: silvas, dexonsmith.
bruno updated this revision to Diff 57993.
bruno added a comment.
Great idea Duncan, attached a new patch!
http://reviews.llvm.org/D20404
Files:
include/clang/Frontend/CompilerInvocation.h
lib/Driver/T
Author: bruno
Date: Tue Mar 29 12:35:02 2016
New Revision: 264752
URL: http://llvm.org/viewvc/llvm-project?rev=264752&view=rev
Log:
[Sema] Handle UTF-8 invalid format string specifiers
Improve invalid format string specifier handling by printing out
invalid specifiers characters with \x, \u and \
bruno closed this revision.
bruno added a comment.
Thanks Richard. Applied your last comments and committed in r264752
http://reviews.llvm.org/D18296
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
Author: bruno
Date: Tue Mar 29 13:38:44 2016
New Revision: 264765
URL: http://llvm.org/viewvc/llvm-project?rev=264765&view=rev
Log:
[Sema] Attempt to fix tests for utf-8 invalid format string specifiers
Followup from r264752.
Attempt to appease buildbots:
http://lab.llvm.org:8011/builders/clang
Author: bruno
Date: Tue Mar 29 15:47:09 2016
New Revision: 264784
URL: http://llvm.org/viewvc/llvm-project?rev=264784&view=rev
Log:
[Sema] Attempt [2] to fix tests for utf-8 invalid format string specifiers
Some buildbots still complain. Followup from r264752 and 264765.
Modified:
cfe/trunk/
Author: bruno
Date: Tue Mar 29 16:30:58 2016
New Revision: 264788
URL: http://llvm.org/viewvc/llvm-project?rev=264788&view=rev
Log:
[Sema] Attempt [3] to fix tests for utf-8 invalid format string specifiers
Make the tests darwin only. The bots complaining already output UTF-8
invalid specifiers,
301 - 400 of 670 matches
Mail list logo
