bruno added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
vbyakovlcl wrote:
> bruno wrote:
> > Besides `__ext_vector_typ
bruno added a reviewer: vsk.
bruno added a comment.
Ping!!
https://reviews.llvm.org/D24516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno updated this revision to Diff 74185.
bruno added a comment.
Update after Vedant's review!
https://reviews.llvm.org/D24516
Files:
include/clang/Frontend/CompilerInvocation.h
lib/Frontend/CompilerInvocation.cpp
test/Driver/show-option-names.c
Index: test/Driver/show-option-names.c
=
Author: bruno
Date: Mon Oct 10 19:01:22 2016
New Revision: 283827
URL: http://llvm.org/viewvc/llvm-project?rev=283827&view=rev
Log:
[Driver][Diagnostics] Make 'show option names' default for driver warnings
Currently, driver level warnings do not show option names (e.g. warning:
complain about fo
bruno closed this revision.
bruno added a comment.
Committed r283827
Comment at: test/Driver/show-option-names.c:4
+// RUN: %clang -c -target i386-apple-darwin10 -fno-diagnostics-show-option
-isysroot /FOO %s 2>&1 | FileCheck --check-prefix=CHECK-NO-SHOW-OPTION-NAMES %s
+// CH
Thanks Renato!
On Tue, Oct 11, 2016 at 3:36 AM, Renato Golin wrote:
> On 11 October 2016 at 10:14, Renato Golin wrote:
>> clang-4.0: warning: no such sysroot directory: '/FOO' [-Wmissing-sysroot]
>> error: unable to create target: 'No available targets are compatible
>> with this triple.'
>> 1 e
bruno added inline comments.
Comment at: llvm/tools/clang/lib/Sema/SemaExpr.cpp:8787
}
+if (!S.LangOpts.OpenCL && !S.LangOpts.ZVector) {
+ const BuiltinType *LHSBT = LHSEleType->getAs();
vbyakovlcl wrote:
> bruno wrote:
> > vbyakovlcl wrote:
> > > b
On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin wrote:
> On 11 October 2016 at 16:34, Bruno Cardoso Lopes
> wrote:
>> Thanks Renato!
>
> So, Daniel Jasper did a trick on r283853 (clang || true) to make it
> not fail when it returns on error. However, I wasn't able to make it
> return anything but
Author: bruno
Date: Tue Oct 11 13:21:26 2016
New Revision: 283913
URL: http://llvm.org/viewvc/llvm-project?rev=283913&view=rev
Log:
Reapply [Driver][Diagnostics] Make 'show option names' default for driver
warnings
Reapply r283827 by fixing the tests to not be target specific
Currently, driver
Let's see how it goes: Committed r283913
On Tue, Oct 11, 2016 at 11:13 AM, Bruno Cardoso Lopes
wrote:
> On Tue, Oct 11, 2016 at 10:09 AM, Renato Golin
> wrote:
>> On 11 October 2016 at 16:34, Bruno Cardoso Lopes
>> wrote:
>>> Thanks Renato!
>>
>> So, Daniel Jasper did a trick on r283853 (clang
Author: bruno
Date: Tue Oct 11 13:31:45 2016
New Revision: 283915
URL: http://llvm.org/viewvc/llvm-project?rev=283915&view=rev
Log:
[Driver] Fix test from r283913 to unbreak bots
Followup from r283913 & r283827
http://bb.pgr.jp/builders/cmake-clang-x86_64-linux/builds/55135
Modified:
cfe/tr
Author: bruno
Date: Tue Oct 11 13:38:33 2016
New Revision: 283917
URL: http://llvm.org/viewvc/llvm-project?rev=283917&view=rev
Log:
[Driver] Use -fsyntax-only in test/Driver/show-option-names.c
Make the test less expensive, follow up from r283915.
Modified:
cfe/trunk/test/Driver/show-option-
Hi Richard,
I have a patch on top of your suggested patch from a year ago, that
break the cyclic dependency we're seeing, with this (and a few changes
to the SDK) we can bootstrap clang with submodule local visibility on
darwin. I've attached the patch with a reduced, standalone testcase
that does
bruno added a comment.
One possible reason: remove_dots is called upon a path with a leading "..",
which then gets appended in front of another path to form the absolute path.
I'm taking a look right now to try to figure out if there's any code path that
might lead to this.
https://reviews.ll
bruno added a comment.
Krzysztof, do you have a backtrace that you can paste here or point me to the
buidbot stderr log? There's no point in looking for relative paths inside the
VFS, it would be nice if we fix the root cause here.
https://reviews.llvm.org/D25597
___
bruno added a comment.
Looks that somehow the current directory doesn't exit anymore OR it's non empty
but only contains spaces or something like that. Besides the snippet below,
RedirectingFileSystem::lookupPath(llvm::Twine const&) also calls `makeAbsolute`
before `remove_dots`. Can you try to
Author: Bruno Cardoso Lopes
Date: 2022-09-09T16:20:04-07:00
New Revision: f4a13c9c0a049d40e0365477c58c2a5369eda6dc
URL:
https://github.com/llvm/llvm-project/commit/f4a13c9c0a049d40e0365477c58c2a5369eda6dc
DIFF:
https://github.com/llvm/llvm-project/commit/f4a13c9c0a049d40e0365477c58c2a5369eda6dc
https://github.com/bcardosolopes commented:
Can you please add a testcase?
https://github.com/llvm/llvm-project/pull/70801
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcardosolopes wrote:
I'm not 100% confident here but the fix makes sense and seems good (nice
testcase!).
https://github.com/llvm/llvm-project/pull/72346
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/bcardosolopes commented:
Thanks for improving this! I haven't looked at your previous review of this PR,
but I like the simplicity of this one.
https://github.com/llvm/llvm-project/pull/70973
___
cfe-commits mailing list
cfe-commit
@@ -1965,9 +1965,15 @@ bool Sema::buildCoroutineParameterMoves(SourceLocation
Loc) {
if (PD->getType()->isDependentType())
continue;
+// Preserve the referenced state for unused parameter diagnostics.
+bool DeclReferenced = PD->isReferenced();
+
ExprRes
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/70973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/70973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1965,9 +1965,15 @@ bool Sema::buildCoroutineParameterMoves(SourceLocation
Loc) {
if (PD->getType()->isDependentType())
continue;
+// Preserve the referenced state for unused parameter diagnostics.
+bool DeclReferenced = PD->isReferenced();
+
ExprRes
https://github.com/bcardosolopes approved this pull request.
LGTM. @ChuanqiXu9 should give the final blessing though.
https://github.com/llvm/llvm-project/pull/70973
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
@@ -1342,6 +1342,15 @@ def err_opencl_logical_exclusive_or : Error<
def err_openclcxx_virtual_function : Error<
"virtual functions are not supported in C++ for OpenCL">;
+// OpenACC Support.
+def warn_pragma_acc_ignored : Warning<
+ "unexpected '#pragma acc ...' in program"
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/70234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes commented:
The changes in this patch looks pretty straightforward! Left some inline
comments.
https://github.com/llvm/llvm-project/pull/70234
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
@@ -0,0 +1,14 @@
+// RUN: %clang -S -### -fopenacc %s 2>&1 | FileCheck %s
--check-prefix=CHECK-DRIVER
+// CHECK-DRIVER: "-cc1" {{.*}} "-fopenacc"
bcardosolopes wrote:
How does the interaction between using both `-fopenmp` and `-fopenacc` at the
same time should
@@ -605,6 +605,17 @@ static void InitializeStandardPredefinedMacros(const
TargetInfo &TI,
Builder.defineMacro("HIP_API_PER_THREAD_DEFAULT_STREAM");
}
}
+
+ if (LangOpts.OpenACC) {
+// FIXME: When we have full support for OpenACC, we should set this to the
+
@@ -7584,11 +7584,22 @@ static void
visitLifetimeBoundArguments(IndirectLocalPath &Path, Expr *Call,
if (ObjectArg && implicitObjectParamIsLifetimeBound(Callee))
VisitLifetimeBoundArg(Callee, ObjectArg);
-
+ bool checkCoroCall = false;
+ if (const auto *RD = Callee->g
@@ -0,0 +1,14 @@
+// RUN: %clang -S -### -fopenacc %s 2>&1 | FileCheck %s
--check-prefix=CHECK-DRIVER
+// CHECK-DRIVER: "-cc1" {{.*}} "-fopenacc"
bcardosolopes wrote:
Thanks for the explanation!
https://github.com/llvm/llvm-project/pull/70234
__
Author: bruno
Date: Thu Aug 29 16:14:08 2019
New Revision: 370422
URL: http://llvm.org/viewvc/llvm-project?rev=370422&view=rev
Log:
[Modules] Make ReadModuleMapFileBlock errors reliable
This prevents a crash when an error should be emitted instead.
During implicit module builds, there are cases
Author: bruno
Date: Tue Aug 1 12:05:25 2017
New Revision: 309722
URL: http://llvm.org/viewvc/llvm-project?rev=309722&view=rev
Log:
[Sema] Fix lax conversion between non ext vectors
r282968 introduced a regression due to the lack of proper testing.
Re-add lax conversion support between non ext ve
Author: bruno
Date: Tue Aug 1 15:10:36 2017
New Revision: 309752
URL: http://llvm.org/viewvc/llvm-project?rev=309752&view=rev
Log:
[Headers][Darwin] Allow #include_next to work on Darwin prior to 10.7
This fixes PR31504 and it's a follow up from adding #include_next
for Darwin in r289018.
rdar:
gh for you to see it? or next
>> time is something I can do to make your life easier?
Cool, thanks again!
>> Thanks,
>>
>> On Tue, Aug 1, 2017 at 3:10 PM, Bruno Cardoso Lopes via cfe-commits
>> wrote:
>>> Author: bruno
>>> Date: Tue Aug 1 15:10:36 201
Author: bruno
Date: Thu Aug 10 08:16:24 2017
New Revision: 310605
URL: http://llvm.org/viewvc/llvm-project?rev=310605&view=rev
Log:
[Modules] Prevent #import to reenter header if not building a module.
When non-modular headers are imported while not building a module but
in -fmodules mode, be con
Hi Hans, can we please get this merged into 5.0?
Thanks,
On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits
wrote:
> Author: bruno
> Date: Thu Aug 10 08:16:24 2017
> New Revision: 310605
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310605&view=re
ote:
>> > Hi Hans, can we please get this merged into 5.0?
>> >
>> > Thanks,
>> >
>> > On Thu, Aug 10, 2017 at 12:16 PM, Bruno Cardoso Lopes via cfe-commits
>> > wrote:
>> >> Author: bruno
>> >> Date: Thu Aug
Hi Alex,
On Fri, Aug 11, 2017 at 9:06 AM, Alex Lorenz via cfe-commits
wrote:
> Author: arphaman
> Date: Fri Aug 11 05:06:52 2017
> New Revision: 310706
>
> URL: http://llvm.org/viewvc/llvm-project?rev=310706&view=rev
> Log:
> [modules] Set the lexical DC for dummy tag decls that refer to hidden
>
Author: bruno
Date: Fri Aug 11 18:38:26 2017
New Revision: 310775
URL: http://llvm.org/viewvc/llvm-project?rev=310775&view=rev
Log:
Revert "[Modules] Prevent #import to reenter header if not building a module."
This reverts commit r310605. Richard pointed out a better way to achieve
this, which I
On Fri, Aug 11, 2017 at 9:27 PM, Richard Smith wrote:
> On 11 August 2017 at 16:51, Bruno Cardoso Lopes via cfe-commits
> wrote:
>>
>> On Thu, Aug 10, 2017 at 5:36 PM, Richard Smith
>> wrote:
>> > On 10 August 2017 at 10:42, Hans Wennborg via cfe-commits
>&g
Author: Bruno Cardoso Lopes
Date: 2020-10-12T16:48:50-07:00
New Revision: cffb0dd54d41d8e249d2009467c4beb5b681ba26
URL:
https://github.com/llvm/llvm-project/commit/cffb0dd54d41d8e249d2009467c4beb5b681ba26
DIFF:
https://github.com/llvm/llvm-project/commit/cffb0dd54d41d8e249d2009467c4beb5b681ba26
Author: Bruno Cardoso Lopes
Date: 2021-06-22T17:26:05-07:00
New Revision: c9aaf34b8db884faa3d3ced4d2fb88fd45697408
URL:
https://github.com/llvm/llvm-project/commit/c9aaf34b8db884faa3d3ced4d2fb88fd45697408
DIFF:
https://github.com/llvm/llvm-project/commit/c9aaf34b8db884faa3d3ced4d2fb88fd45697408
Author: Bruno Cardoso Lopes
Date: 2023-02-03T15:37:29-08:00
New Revision: 0b8daee028a87ab8a6f8fe54d2eb2d5b5c2babd4
URL:
https://github.com/llvm/llvm-project/commit/0b8daee028a87ab8a6f8fe54d2eb2d5b5c2babd4
DIFF:
https://github.com/llvm/llvm-project/commit/0b8daee028a87ab8a6f8fe54d2eb2d5b5c2babd4
Author: Bruno Cardoso Lopes
Date: 2022-05-26T11:05:15-07:00
New Revision: ce54b22657f01d1c40de4941ceb6e7119848aecf
URL:
https://github.com/llvm/llvm-project/commit/ce54b22657f01d1c40de4941ceb6e7119848aecf
DIFF:
https://github.com/llvm/llvm-project/commit/ce54b22657f01d1c40de4941ceb6e7119848aecf
Author: Bruno Cardoso Lopes
Date: 2022-06-08T23:13:39-07:00
New Revision: e6a76a49356efd11f5f36690181f0f60cecb2e01
URL:
https://github.com/llvm/llvm-project/commit/e6a76a49356efd11f5f36690181f0f60cecb2e01
DIFF:
https://github.com/llvm/llvm-project/commit/e6a76a49356efd11f5f36690181f0f60cecb2e01
https://github.com/bcardosolopes created
https://github.com/llvm/llvm-project/pull/66706
When dealing with short-circuiting coroutines (e.g. `expected`), the deferred
calls that resolve the `get_return_object` are currently being emitted *after*
we delete the coroutine frame.
This was caught
bcardosolopes wrote:
Thanks for the fast reply @ChuanqiXu9
> I remember that there is a defect that we may place the GRO on the coroutine
> frame.
Can you point me to such defect? I had no luck searching for it.
> And my instinct reaction is that would this patch be covered by forcing GRO
>
https://github.com/bcardosolopes updated
https://github.com/llvm/llvm-project/pull/66706
>From f9d54b81d4c3c10c3dd26193d9bef52785826f21 Mon Sep 17 00:00:00 2001
From: Bruno Cardoso Lopes
Date: Fri, 15 Sep 2023 15:40:20 -0700
Subject: [PATCH 1/2] [Clang][Coroutines] Improve GRO handling to bette
https://github.com/bcardosolopes updated
https://github.com/llvm/llvm-project/pull/66706
>From f9d54b81d4c3c10c3dd26193d9bef52785826f21 Mon Sep 17 00:00:00 2001
From: Bruno Cardoso Lopes
Date: Fri, 15 Sep 2023 15:40:20 -0700
Subject: [PATCH 1/3] [Clang][Coroutines] Improve GRO handling to bette
bcardosolopes wrote:
Updated the patch to account for failing libcxx tests, and to not change
current codegen when GRO allocas are not involved.
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/bcardosolopes updated
https://github.com/llvm/llvm-project/pull/66706
>From 6312dd56ed3a2f47e7291ae32ca044622a317259 Mon Sep 17 00:00:00 2001
From: Bruno Cardoso Lopes
Date: Wed, 20 Sep 2023 15:00:06 -0700
Subject: [PATCH] [Clang][LLVM][Coroutines] Prevent __coro_gro from out
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes edited
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcardosolopes wrote:
Thanks for the clarifications
> By forcing the GRO not living on the coroutine frames, it shouldn't be a
> problem if the lifetime of `__coro_gro` outlives the `__promise`. The only
> limit is that the initialization of `__coro_gro` should be in the lifetime of
> `__promi
https://github.com/bcardosolopes updated
https://github.com/llvm/llvm-project/pull/66706
>From 6312dd56ed3a2f47e7291ae32ca044622a317259 Mon Sep 17 00:00:00 2001
From: Bruno Cardoso Lopes
Date: Wed, 20 Sep 2023 15:00:06 -0700
Subject: [PATCH 1/2] [Clang][LLVM][Coroutines] Prevent __coro_gro from
@@ -6691,6 +6691,22 @@ sections that the user does not want removed after
linking.
...
!0 = !{}
+'``coro.outside.frame``' Metadata
+^^
+
+``coro.outside.frame`` metadata may be attached to an alloca instruction to
+to signify that it shouldn't be promo
https://github.com/bcardosolopes resolved
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -104,3 +105,5 @@ invoker g() {
// CHECK: call void
@_ZN7invoker15invoker_promise17get_return_objectEv({{.*}} %[[AggRes]]
co_return;
}
+
+// CHECK: ![[OutFrameMetadata]] = !{}
bcardosolopes wrote:
Done
https://github.com/llvm/llvm-project/pull/66706
__
https://github.com/bcardosolopes resolved
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bcardosolopes wrote:
Applied suggested changes and updated PR.
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bcardosolopes closed
https://github.com/llvm/llvm-project/pull/66706
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Bruno Cardoso Lopes
Date: 2019-11-14T18:32:27-08:00
New Revision: 3466cebe94ba461b296bb1314e76118cc2823dfb
URL:
https://github.com/llvm/llvm-project/commit/3466cebe94ba461b296bb1314e76118cc2823dfb
DIFF:
https://github.com/llvm/llvm-project/commit/3466cebe94ba461b296bb1314e76118cc2823dfb
Author: Bruno Cardoso Lopes
Date: 2020-01-22T13:33:17-08:00
New Revision: 90f58eaeff5f1d5017e7b689fac79180cdfa0160
URL:
https://github.com/llvm/llvm-project/commit/90f58eaeff5f1d5017e7b689fac79180cdfa0160
DIFF:
https://github.com/llvm/llvm-project/commit/90f58eaeff5f1d5017e7b689fac79180cdfa0160
Author: bruno
Date: Tue Mar 20 15:36:39 2018
New Revision: 328053
URL: http://llvm.org/viewvc/llvm-project?rev=328053&view=rev
Log:
[Modules] Honor -fmodule-name when handling private framework modules
When skipping building the module for a private framework module,
LangOpts.CurrentModule isn't
Author: bruno
Date: Thu Mar 29 22:17:58 2018
New Revision: 328857
URL: http://llvm.org/viewvc/llvm-project?rev=328857&view=rev
Log:
[Modules] Improve fixit for framework private module maps
The wrong source range was being provided in some case, fix that to get
a better fixit.
rdar://problem/385
Thanks Nico!
On Tue, Apr 10, 2018 at 6:39 AM, Nico Weber via Phabricator
wrote:
> thakis added a comment.
>
> r329698, thanks!
>
>
> https://reviews.llvm.org/D45165
>
>
>
--
Bruno Cardoso Lopes
http://www.brunocardoso.cc
___
cfe-commits mailing list
Author: bruno
Date: Thu Nov 16 19:24:11 2017
New Revision: 318503
URL: http://llvm.org/viewvc/llvm-project?rev=318503&view=rev
Log:
[PCH+Modules] Improve diagnosticts to help out users pass an extra header
search path
When mixing PCH and Implicit Modules, missing a header search path
can lead to
Author: bruno
Date: Thu Nov 16 20:26:07 2017
New Revision: 318507
URL: http://llvm.org/viewvc/llvm-project?rev=318507&view=rev
Log:
Change path used in a test from r318503 to work on windows
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/13565
Modified:
Author: Bruno Cardoso Lopes
Date: 2023-03-21T21:42:25-07:00
New Revision: 43f5085fa80f716acf93870618b1d93ec85c1d01
URL:
https://github.com/llvm/llvm-project/commit/43f5085fa80f716acf93870618b1d93ec85c1d01
DIFF:
https://github.com/llvm/llvm-project/commit/43f5085fa80f716acf93870618b1d93ec85c1d01
Author: Bruno Cardoso Lopes
Date: 2023-03-21T21:42:31-07:00
New Revision: fa0d4e1f12a3f69dd0afb07c0928c867ab921537
URL:
https://github.com/llvm/llvm-project/commit/fa0d4e1f12a3f69dd0afb07c0928c867ab921537
DIFF:
https://github.com/llvm/llvm-project/commit/fa0d4e1f12a3f69dd0afb07c0928c867ab921537
Author: Bruno Cardoso Lopes
Date: 2023-03-23T16:35:30-07:00
New Revision: 07ef7b1ff21e8e3faaf8279b8ec6a7f0ac252fad
URL:
https://github.com/llvm/llvm-project/commit/07ef7b1ff21e8e3faaf8279b8ec6a7f0ac252fad
DIFF:
https://github.com/llvm/llvm-project/commit/07ef7b1ff21e8e3faaf8279b8ec6a7f0ac252fad
Hi Chuanqi,
I know the warning mentions it to be removed in clang-17, but a heads
up "landing in a week" or so would have been great :)
I understand that the name "coroutines-ts" isn't meaningful these
days, but it also sounds like this commit does more than remove the
flag, it caps useful functi
> I understand that the name "coroutines-ts" isn't meaningful these
> days, but it also sounds like this commit does more than remove the
> flag, it caps useful functionality. How are users supposed to use
> c++17 with coroutines now? It's very common in our codebase and we
> have users relying on
Makes total sense, thank you for the clarification.
On Mon, Feb 27, 2023 at 6:24 PM chuanqi.xcq wrote:
>
> Hi Bruno,
>
> We talked about removing `-fcoroutines-ts` in
> https://github.com/llvm/llvm-project/issues/59110
> and https://reviews.llvm.org/D108697. I raised the example you used her
Author: Bruno Cardoso Lopes
Date: 2023-03-09T14:18:26-08:00
New Revision: 54225c457a336b1609c6d064b2b606a9238a28b9
URL:
https://github.com/llvm/llvm-project/commit/54225c457a336b1609c6d064b2b606a9238a28b9
DIFF:
https://github.com/llvm/llvm-project/commit/54225c457a336b1609c6d064b2b606a9238a28b9
Author: bruno
Date: Mon Dec 19 15:06:06 2016
New Revision: 290134
URL: http://llvm.org/viewvc/llvm-project?rev=290134&view=rev
Log:
[ASTReader] Sort RawComments before merging
`RawComments` are sorted by comparing underlying `SourceLocation`'s. This is
done by comparing `FileID` and `Offset`; whe
Author: bruno
Date: Thu Dec 22 01:06:03 2016
New Revision: 290326
URL: http://llvm.org/viewvc/llvm-project?rev=290326&view=rev
Log:
[CrashReproducer] Add support for merging -ivfsoverlay
Merge all VFS mapped files inside -ivfsoverlay inputs into the vfs
overlay provided by the crash reproducer. T
Author: bruno
Date: Mon Jan 9 13:21:48 2017
New Revision: 291466
URL: http://llvm.org/viewvc/llvm-project?rev=291466&view=rev
Log:
[Chrono][Darwin] Make steady_clock use CLOCK_UPTIME_RAW
Use CLOCK_UPTIME_RAW in case clock_gettime is available on Darwin.
On Apple platforms only CLOCK_UPTIME_RAW
Author: bruno
Date: Mon Jan 9 18:51:02 2017
New Revision: 291517
URL: http://llvm.org/viewvc/llvm-project?rev=291517&view=rev
Log:
[Chrono][Darwin] Include header for gettimeofday
Followup on r291466 and include the proper header. This fixes:
https://build.chromium.org/p/chromium.fyi/builders/Cl
ly -mmacosx-version-min=10.11. Any
> thoughts on what's going wrong?
>
> On Mon, Jan 9, 2017 at 11:21 AM, Bruno Cardoso Lopes via cfe-commits
> wrote:
>>
>> Author: bruno
>> Date: Mon Jan 9 13:21:48 2017
>> New Revision: 291466
>>
>> URL:
Author: bruno
Date: Tue Jan 10 20:14:51 2017
New Revision: 291644
URL: http://llvm.org/viewvc/llvm-project?rev=291644&view=rev
Log:
[Modules] Support #import when entering files with modules
Textual headers and builtins that are #import'd from different
modules should get re-entered when these mo
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added a subscriber: cfe-commits.
Give appropriate warnings with -Wdocumentation for @param comments
that refer to function aliases defined with 'using'. Very similar
to typedef's behavior. Support for TypeAliasTemplateDecl comes ne
Author: bruno
Date: Mon Aug 22 16:50:22 2016
New Revision: 279481
URL: http://llvm.org/viewvc/llvm-project?rev=279481&view=rev
Log:
[SemaObjC] Do not RebuildObjCMessageExpr without valid method decl
Fix crash-on-invalid in ObjC Sema by avoiding to rebuild a message
expression to a 'super' class i
bruno added a comment.
Hi Olivier,
Can you add a test? Can you also include some context to the patch?
Thanks,
https://reviews.llvm.org/D23837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/c
bruno created this revision.
bruno added a reviewer: doug.gregor.
bruno added subscribers: cfe-commits, manmanren.
Fix a crash-on-invalid.
When parsing type arguments and protocols, ParseTypeName() tries to find
matching tokens for '[', '(', etc whenever they appear among potential
type names. If
Author: bruno
Date: Wed Aug 24 16:11:43 2016
New Revision: 279662
URL: http://llvm.org/viewvc/llvm-project?rev=279662&view=rev
Log:
[Sema][Comments] Support @param with c++ 'using' keyword
Give appropriate warnings with -Wdocumentation for @param comments
that refer to function aliases defined wi
bruno closed this revision.
bruno added a comment.
r279662
https://reviews.llvm.org/D23783
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: rsmith, echristo.
bruno added subscribers: cfe-commits, friss.
Herald added a subscriber: mehdi_amini.
When building with -fno-gnu-inline-asm and -fmodules on Darwin, the compilation
might fail if some of the implicit modules try to use gnu asm
Author: bruno
Date: Wed Aug 24 19:22:08 2016
New Revision: 279691
URL: http://llvm.org/viewvc/llvm-project?rev=279691&view=rev
Log:
[Sema][Comments] Factor out function type loc logic. NFCI
This is in prepatation for @param TypeAliasTemplate support.
Modified:
cfe/trunk/lib/AST/Comment.cpp
bruno created this revision.
bruno added a reviewer: gribozavr.
bruno added a subscriber: cfe-commits.
Emit proper diagnostics when -Wdocumentation is used with constructs such as:
template
using fn = int(T aaa, int ccc);
Previously clang wouldn't recognize the function and complain with
'co
Author: bruno
Date: Thu Aug 25 12:09:33 2016
New Revision: 279754
URL: http://llvm.org/viewvc/llvm-project?rev=279754&view=rev
Log:
[Sema][Comments] Add support for TypeAliasTemplate
Emit proper diagnostics when -Wdocumentation is used with constructs such as:
template
using fn = int(T aaa,
bruno closed this revision.
bruno added a comment.
Applied your suggestions and committed r279754. Thanks!
https://reviews.llvm.org/D23860
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
bruno created this revision.
bruno added a reviewer: rsmith.
bruno added subscribers: cfe-commits, eladcohen.
This adds support for modules that require (no-)gnu-inline-asm
environment, such as the compiler builtin cpuid submodule.
This is the gnu-inline-asm variant of https://reviews.llvm.org/D2
bruno abandoned this revision.
bruno added a comment.
Abandon in favor of https://reviews.llvm.org/D23905
https://reviews.llvm.org/D23859
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
On Thu, Aug 25, 2016 at 9:52 PM, Richard Smith wrote:
> On 25 Aug 2016 7:37 p.m., "Bruno Cardoso Lopes"
> wrote:
>
> bruno created this revision.
> bruno added a reviewer: rsmith.
> bruno added subscribers: cfe-commits, eladcohen.
>
> This adds support for modules that require (no-)gnu-inline-asm
bruno updated this revision to Diff 69392.
bruno added a comment.
Update patch after Richard's comment
https://reviews.llvm.org/D23905
Files:
docs/Modules.rst
lib/Basic/Module.cpp
lib/Headers/module.modulemap
test/Modules/Inputs/GNUAsm/NeedsGNUInlineAsm.framework/Headers/NeedsGNUInline
bruno updated the summary for this revision.
bruno updated this revision to Diff 69456.
bruno added a comment.
Updated patch and changed approach after Doug's comment.
https://reviews.llvm.org/D23852
Files:
lib/Parse/ParseDecl.cpp
lib/Parse/ParseObjc.cpp
lib/Parse/Parser.cpp
test/SemaOb
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM
https://reviews.llvm.org/D23837
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
101 - 200 of 670 matches
Mail list logo
