bruno added a comment.
Hi Alex,
Comment at: lib/Sema/SemaDeclObjC.cpp:4312
+ for (const ParmVarDecl *P : Method->parameters()) {
+if (P->getType()->isVectorType()) {
+ Loc = P->getLocStart();
Assuming objc/c++ can pass/return these, the current check
bruno added a comment.
Hi Juergen,
Thanks for working on this.
Comment at: include/clang/Basic/VirtualFileSystem.h:164
EC = Impl->increment();
-if (EC || !Impl->CurrentEntry.isStatusKnown())
+if (!Impl->CurrentEntry.isStatusKnown())
Impl.reset(); // Normali
bruno added a comment.
Please attach a testcase!
https://reviews.llvm.org/D27810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Hi Alex,
Thanks for taking a look a this. LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D30183
___
cfe-commits mailing list
cfe-commits@lis
bruno accepted this revision.
bruno added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Basic/VirtualFileSystem.cpp:1873
vfs::directory_iterator I = FS->dir_begin(State->top()->getName(), EC);
-if (EC)
+if (EC && EC != std::errc::n
bruno added a reviewer: bruno.
bruno added a comment.
Hi JinGu,
I just read the discussion on cfe-dev, some comments:
> My colleague and I are implementing a transformation pass between LLVM IR and
> another IR and we want to keep the 3-component vector types in our target IR
Why can't you go
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Hi Pete, thanks for working on this!
LGTM with the minor comments below.
Comment at: include/clang/Lex/PPCallbacks.h:264
+ virtual void HasInclude(SourceLocation Loc, const F
bruno added a comment.
Hi Pete,
Comment at: lib/Frontend/DependencyFile.cpp:191
+ const Token &FilenameTok,
+ SrcMgr::CharacteristicKind FileType) override;
+
Is there any `FileSkipped` callback invocation that might trigger
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Comment at: lib/Frontend/CompilerInvocation.cpp:1434
+
+ // Canonicalize -fmodules-cache-path before storing it.
+ SmallString<128> P(Args.getLastArgValue(OPT_fmodules_c
bruno added inline comments.
Comment at: lib/Basic/TargetInfo.cpp:229
switch (BitWidth) {
- case 96:
+ case 80:
if (&getLongDoubleFormat() == &llvm::APFloat::x87DoubleExtended)
The change makes sense but I believe there's some historical reason why this
bruno added a comment.
Hi Alex, thanks for working on this
Comment at: lib/Parse/ParseObjc.cpp:2877
+if (GetLookAheadToken(1).is(tok::l_brace) &&
+ExprStatementTokLoc == AtLoc) {
char ch = Tok.getIdentifierInfo()->getNameStart()[0];
--
bruno added inline comments.
Comment at: lib/Sema/SemaExpr.cpp:8064
+ ScalarCast = CK_FloatingCast;
+} else if (ScalarTy->isIntegralType(S.Context)) {
+ // Determine if the integer constant can be expressed as a floating point
sdardis wrote:
> bruno
bruno added a comment.
@rsmith ping!
https://reviews.llvm.org/D26267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks for the explanation, LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
bruno added inline comments.
Comment at: lib/Frontend/FrontendActions.cpp:227
+IsBuiltin = true;
+ addHeaderInclude(H.NameAsWritten, Includes, LangOpts, Module->IsExternC,
+ IsBuiltin /*AlwaysInclude*/);
rsmith wrote:
> I don't
bruno accepted this revision.
bruno added a comment.
LGTM!
Repository:
rL LLVM
https://reviews.llvm.org/D27298
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Hi Alex, thanks for following up with this!
Comment at: lib/Sema/SemaDecl.cpp:11819
+ // Warn if K&R function is defined without previous declaration
+ // declaration. This warning is issued only if the difinition itself
+ // does not
bruno added a comment.
> The right thing to do would be to track the set of headers whose #import /
> #include-with-#pragma-once is
> visible, and only skip inclusions if there is a *visible* #import /
> #include-with-#pragma-once of that header.
This makes sense, but the situation is a bit mo
bruno created this revision.
bruno added reviewers: mclow.lists, dexonsmith, EricWF.
bruno added a subscriber: cfe-commits.
CLOCK_MONOTONIC is only defined on Darwin on libc versions >= 1133 and its
behaviour differs from Linux. CLOCK_UPTIME on Darwin actually matches
CLOCK_MONOTONIC on Linux, du
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D16533
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
bruno created this revision.
bruno added reviewers: manmanren, akyrtzi, rsmith.
bruno added a subscriber: cfe-commits.
`RawComments` are sorted by comparing underlying `SourceLocation`'s. This is
done by comparing `FileID` and `Offset`; when the `FileID` is the same it means
the locations are wit
bruno added a comment.
Any thoughts on this @rsmith ?
https://reviews.llvm.org/D26267
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
bruno added reviewers: rsmith, v.g.vassilev.
bruno added subscribers: cfe-commits, mehdi_amini.
One way to currently test the reproducers is to setup
"FORCE_CLANG_DIAGNOSTICS_CRASH=1" before invoking clang. This simulates
a crash and produces the same contents needed b
bruno added a comment.
> I am wondering if there is clearer name than `-gen-reproducer`.
Probably, I'm open to suggestions :-)
> IIUC, the goal is to extract all environment (system) dependent pieces,
> copying them to a folder where the compiler can be chroot-ed (via
> `-isysroot`).
It doe
bruno updated this revision to Diff 80981.
bruno added a comment.
Update after Mehdi's review!
https://reviews.llvm.org/D27604
Files:
docs/UsersManual.rst
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Driver.h
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
bruno added inline comments.
Comment at: include/clang/Driver/Driver.h:287
+ const std::string &getConfigFile() const { return ConfigFile; }
+ void setConfigFile(StringRef x, unsigned N) {
+ConfigFile = x;
x -> FileName
Comment at: lib/Dr
bruno added a comment.
Ping!
https://reviews.llvm.org/D27546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno marked 6 inline comments as done.
bruno added inline comments.
Comment at: lib/Parse/ParseDecl.cpp:4236-4237
Sema::SkipBodyInfo SkipBody;
+ Sema::CheckCompatTagInfo CheckCompatTag;
if (!Name && TUK == Sema::TUK_Definition && Tok.is(tok::l_brace) &&
bruno updated this revision to Diff 96080.
bruno marked 2 inline comments as done.
bruno added a comment.
Update the patch after Richard's suggestions
https://reviews.llvm.org/D31778
Files:
include/clang/AST/ASTStructuralEquivalence.h
include/clang/Basic/DiagnosticASTKinds.td
include/clan
bruno added a comment.
Ping!
https://reviews.llvm.org/D31269
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
Ping
https://reviews.llvm.org/D28832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno added a comment.
@rsmith ping!
https://reviews.llvm.org/D31778
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bruno created this revision.
One of the -Wincomplete-umbrella warnings diagnoses when a header is present in
the directory but it's not present in the umbrella header. Currently, this
warning only happens on top level modules; any submodule using an umbrella
header does not get this warning. Fi
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks Alex. LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D28670
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks for your patience! LGTM with a minor comment below.
Comment at: test/Sema/vector-gcc-compat.c:101
+
+ v2i64_r = v2i64_a && 1; // expected-error {{invalid vector operand
This revision was automatically updated to reflect the committed changes.
Closed by commit rL301597: [Modules] Improve diagnostics for incomplete
umbrella (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D32576?vs=96857&id=97007#toc
Repository:
rL LLVM
https://reviews.
bruno created this revision.
We currenltly assert when want to diagnose a missing import and the decl in
question is already visible. It turns out that the decl in question might be
visible because another decl from the same module actually made the module
visible in a previous error diagnostic
bruno accepted this revision.
bruno added a comment.
Hi Sean,
LGTM! One comment below.
Comment at: tools/clang-import-test/clang-import-test.cpp:263
+AddExternalSource(*CI, Imports);
+ }
No need for the curly braces here
https://reviews.llvm.org/D3298
This revision was automatically updated to reflect the committed changes.
Closed by commit rL302765: [Sema] Improve redefinition errors pointing to the
same header (authored by bruno).
Changed prior to commit:
https://reviews.llvm.org/D28832?vs=95369&id=98584#toc
Repository:
rL LLVM
https:/
bruno added a comment.
Hi Vassil,
In which case specifically this trigger for you? I'm curious because we're
sometimes hitting non-deterministic crashes in ComputeLineNumbers, wonder if
it's related.
Any chance you can come up with a testcase?
https://reviews.llvm.org/D33275
__
bruno marked 3 inline comments as done.
bruno added a comment.
> I think the problem is that we don't take module visibility into account when
> doing redefinition checking for enumerators. Instead of passing through this
> flag, we should probably just ignore hidden declarations when checking f
bruno updated this revision to Diff 99585.
bruno added a comment.
Update the patch to address @rsmith comments and rebase
https://reviews.llvm.org/D31778
Files:
include/clang/AST/ASTStructuralEquivalence.h
include/clang/Basic/DiagnosticASTKinds.td
include/clang/Parse/Parser.h
include/cl
bruno added a comment.
Any idea why we're hitting this issue in the first place? The error that gets
cleaned up is reported at some point before? Seems to me that we're going to
fail to update the timestamp but continue as nothing happened, I wonder how
many other issues this might trigger...
bruno updated this revision to Diff 100016.
bruno added a comment.
Updated the patch after Richard's comments. Removed the assertion but bail out
early if the module is already visible.
https://reviews.llvm.org/D32828
Files:
lib/Sema/SemaDecl.cpp
lib/Sema/SemaLookup.cpp
test/Modules/Inpu
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118004/new/
https://reviews.llvm.org/D118004
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D118005/new/
https://reviews.llvm.org/D118005
bruno requested changes to this revision.
bruno added a comment.
This revision now requires changes to proceed.
Herald added a project: All.
> It would be nice to have some mechanism to notify developers that includes
> are still performed regardless of requires
I'd like to see a module remark f
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
This is the same as https://reviews.llvm.org/D80172, right? LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100914/new/
https://reviews.llvm.o
bruno added a comment.
Hi Xun, great to see more improvements in this area.
Comment at: clang/lib/CodeGen/CGCoroutine.cpp:221
CGF.EmitBlock(RealSuspendBlock);
+ } else if (ForcestackStart) {
+Builder.CreateCall(
ChuanqiXu wrote:
> lxfind wrote:
> > Ch
bruno updated this revision to Diff 332823.
bruno edited the summary of this revision.
bruno added a comment.
@jfb sure!
Also fix test failures.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98995/new/
https://reviews.llvm.org/D98995
Files:
clang/lib/CodeGen/CGAtomic.cpp
clang/tes
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG431e3138a1f3: [CGAtomic] Lift stronger requirements on
cmpxch and support acquire failure mode (authored by bruno).
Herald added a project: clang.
R
bruno accepted this revision.
bruno added a comment.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100129/new/
https://reviews.llvm.org/D100129
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
bruno added a comment.
Hi Nathan, thanks for implementing this. Besides formatting nitpicks, few other
comments/questions:
- Update needed in cxx_status.html
- Should we support this as an extension for earlier C++ versions? This is a
very handy feature. In clang terms,
`warn_cxx17_compat_cons
bruno added a comment.
Overall looks great but there are some test failures, looks like you also need
to update line 223?
--
Traceback (most recent call last):
File "/var/lib/buildkite-agent/builds/llvm-project/build/bin/hmaptool",
line 296, in
main()
File "/var/lib/buildkite
401 - 454 of 454 matches
Mail list logo
