[PATCH] D73835: [IRBuilder] Virtualize IRBuilder

modocache added inline comments. Comment at: llvm/include/llvm/IR/IRBuilder.h:137 + + Value *Insert(Value *V, const Twine& = "") const { +if (Instruction *I = dyn_cast(V)) I experienced a tiny regression after applying this patch, and I think this line migh

[PATCH] D71903: [Coroutines][6/6] Clang schedules new passes

modocache updated this revision to Diff 239437. modocache added a comment. Rebase past D72547 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71903/new/ https://reviews.llvm.org/D71903 Files: clang/lib/CodeGen/Ba

[PATCH] D44915: [coroutines] Fix invalid source range in co_await call expressions.

modocache added a comment. Excellent, thank you! I think this might fix PR34982 ? Repository: rC Clang https://reviews.llvm.org/D44915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D37115: [coroutines] Do not attempt to typo-correct when coroutine is looking for required members

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Excellent, thanks! https://reviews.llvm.org/D37115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D45120: [coroutines] Add __builtin_coro_noop => llvm.coro.noop

modocache accepted this revision. modocache added a comment. This revision is now accepted and ready to land. Great, thanks! https://reviews.llvm.org/D45120 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailma

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

This revision was automatically updated to reflect the committed changes. Closed by commit rC328949: [Coroutines] Find custom allocators in class scope (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D44552?vs=138663&id=140600#toc Repository: rC Clan

[PATCH] D44552: [Coroutines] Find custom allocators in class scope

modocache marked 2 inline comments as done. modocache added a comment. Thanks for the review, @GorNishanov! I adopted your suggestions and made the commit. Repository: rC Clang https://reviews.llvm.org/D44552 ___ cfe-commits mailing list cfe-com

[PATCH] D43927: [Coroutines] Schedule coro-split before asan

This revision was automatically updated to reflect the committed changes. Closed by commit rC328951: [Coroutines] Schedule coro-split before asan (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D43927?vs=136463&id=140603#toc Repository: rC Clang htt

[PATCH] D34865: [ORE] Use LLVM's "diagnostics hotness" spelling

modocache created this revision. Depends on https://reviews.llvm.org/D34864. To unify Clang and LLVM's spelling of "diagnostic[s] hotness", use the new "diagnostics hotness" spelling in LLVM, which was added in https://reviews.llvm.org/D34864. https://reviews.llvm.org/D34865 Files: lib/CodeG

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

modocache created this revision. Herald added a subscriber: fhahn. Depends on https://reviews.llvm.org/D34867. Add a Clang frontend option to enable optimization remark hotness thresholds, which were added to LLVM in https://reviews.llvm.org/D34867. This prevents diagnostics that do not meet a mi

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

modocache updated this revision to Diff 104964. modocache marked 4 inline comments as done. modocache added a comment. Address comments, for the most part. As for the documentation: I think this is OK for now, but there are definitely a few more options that I'd like to document, and those will

[PATCH] D34868: [Driver] Add -fdiagnostics-hotness-threshold

modocache added a comment. Awesome, thank you for all the reviews! https://reviews.llvm.org/D34868 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34928: Add docs for -foptimization-record-file=

modocache created this revision. The Clang option was previously not included in the User's Manual. https://reviews.llvm.org/D34928 Files: docs/UsersManual.rst Index: docs/UsersManual.rst === --- docs/UsersManual.rst +++ docs/U

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache created this revision. Herald added a subscriber: mgorny. When searching for Git version control information, libBasic's CMake checks for the path '.git/logs/HEAD'. However, when LLVM is included as a Git submodule, this path does not exist. Instead, it contains a '.git' file with the fo

[PATCH] D34928: Add docs for -foptimization-record-file=

modocache added a comment. Thanks for the review, Hal! :) https://reviews.llvm.org/D34928 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache planned changes to this revision. modocache added a comment. Oh, nice catch @jordan_rose, you're absolutely right. I just tried updating my Git submodule reference for Clang and rebuilding my project, but the commit hash shown for Clang didn't change accordingly. I'll need to find a f

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache updated this revision to Diff 105673. modocache added a comment. Use submodule's .git directory. https://reviews.llvm.org/D34955 Files: lib/Basic/CMakeLists.txt Index: lib/Basic/CMakeLists.txt === --- lib/Basic/CMakeL

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache updated this revision to Diff 105674. modocache edited the summary of this revision. modocache removed a subscriber: pcc. modocache added a comment. Update commit message. https://reviews.llvm.org/D34955 Files: lib/Basic/CMakeLists.txt Index: lib/Basic/CMakeLists.txt =

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache updated this revision to Diff 106367. modocache added a comment. Use CMAKE_MATCH_0 instead of using REGEX REPLACE. Thanks for the suggestion! https://reviews.llvm.org/D34955 Files: lib/Basic/CMakeLists.txt Index: lib/Basic/CMakeLists.txt ===

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache added a comment. Friendly ping! I'm pretty excited about this change, it helps a pet project of mine, which builds Clang and LLVM checked out as submodules, display correct revision information. Let me know if I can modify this change at all, to make it easier to accept. https://rev

[PATCH] D34955: [Basic] Detect Git submodule version in CMake

modocache added a comment. Awesome, thanks @jordan_rose! https://reviews.llvm.org/D34955 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

modocache created this revision. modocache added reviewers: pcc, aprantl, mehdi_amini. Herald added a subscriber: a.sidorin. Add tests for the improved stream type detection added to `llvm-bcanalyzer` in https://reviews.llvm.org/D41979. Test Plan: `check-clang` Repository: rC Clang https://r

[PATCH] D41980: Add tests for llvm-bcanalyzer stream types

modocache added inline comments. Comment at: test/PCH/include-stream-type.cpp:7 +// RUN: cp %S/Inputs/pragma-once2.h %t-dir +// RUN: %clang_cc1 -x c++-header -emit-pch -o %t %t-dir/pragma-once2-pch.h +// RUN: llvm-bcanalyzer -dump %t | FileCheck %s aprantl wrote:

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

modocache created this revision. modocache added reviewers: v.g.vassilev, bruno. In https://reviews.llvm.org/D41733, the driver was modified such that, when a user provided a mispelled option such as `-hel`, it would suggest a valid option with a nearby edit distance: "did you mean '-help'?". Add

[PATCH] D42004: [Driver] Suggest valid integrated tools

modocache created this revision. modocache added reviewers: sepavloff, bkramer, phosek. There are only two valid integrated Clang driver tools: `-cc1` and `-cc1as`. If a user asks for an unknown tool, such as `-cc1asphalt`, an error message is displayed to indicate that there is no such tool, but

[PATCH] D42005: [docs] Use monospace for PCH option flags

modocache created this revision. modocache added reviewers: sepavloff, aaron.ballman. Use monospace for option flags in the PCH section, instead of the italics that were being used previously. I believe these used to be links, for which single backticks would have been appropriate, but since they

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

This revision was automatically updated to reflect the committed changes. Closed by commit rL322445: [Driver] Add "did you mean?" suggestions to -cc1as (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D42001 Files:

[PATCH] D42001: [Driver] Add "did you mean?" suggestions to -cc1as

modocache added a comment. Thanks, @v.g.vassilev! Repository: rL LLVM https://reviews.llvm.org/D42001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42005: [docs] Use monospace for PCH option flags

This revision was automatically updated to reflect the committed changes. Closed by commit rC322447: [docs] Use monospace for PCH option flags (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42005?vs=129675&id=129768#toc Repository: rC Clang https:

[PATCH] D42005: [docs] Use monospace for PCH option flags

modocache added a comment. Great, thanks for the review, @aaron.ballman! Repository: rC Clang https://reviews.llvm.org/D42005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

modocache updated this revision to Diff 129785. modocache added a comment. Thanks for the great review, @GorNishanov! You were exactly right, I had to remove the assert. I've taken all of your other suggestions as well. Let me know if anything else stands out at you. Also, thanks for the questio

[PATCH] D42004: [Driver] Suggest valid integrated tools

This revision was automatically updated to reflect the committed changes. Closed by commit rC322517: [Driver] Suggest valid integrated tools (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42004?vs=129668&id=129902#toc Repository: rC Clang https://

[PATCH] D42004: [Driver] Suggest valid integrated tools

modocache added a comment. Great, thanks for the review @bkramer! Repository: rC Clang https://reviews.llvm.org/D42004 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rC323381: [coroutines] Pass coro func args to promise ctor (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D41820?vs=129785&id=131351#toc Repository: rC Clang

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

This revision was automatically updated to reflect the committed changes. Closed by commit rL323381: [coroutines] Pass coro func args to promise ctor (authored by modocache, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.org/D41820 Files: c

[PATCH] D41820: [coroutines] Pass coro func args to promise ctor

modocache added a comment. Great, thanks for the reviews! Repository: rC Clang https://reviews.llvm.org/D41820 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D42605: [Sema] Toggle diags when finding allocators (NFCI)

modocache created this revision. modocache added reviewers: rsmith, GorNishanov, eric_niebler. Many methods in Sema take a `bool Diagnose` parameter. Examples of such methods include `Sema::FindDeallocationFunction` and `Sema::SpecialMemberIsTrivial`. Calling these methods with `Diagnose = false`

[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache created this revision. modocache added reviewers: rsmith, GorNishanov, eric_niebler. Herald added a subscriber: EricWF. Depends on https://reviews.llvm.org/D42605. An implementation of the behavior described in `[dcl.fct.def.coroutine]/7`: when a promise type overloads `operator new` us

[PATCH] D42605: [Sema] Toggle diags when finding allocators (NFCI)

modocache updated this revision to Diff 131728. modocache added a comment. Prevent note diagnostics from being emitted for arity mismatch. Repository: rC Clang https://reviews.llvm.org/D42605 Files: include/clang/Sema/Sema.h lib/Sema/SemaExprCXX.cpp Index: lib/Sema/SemaExprCXX.cpp =

[PATCH] D42606: [Coroutines] Use allocator overload when available

modocache updated this revision to Diff 131729. modocache added a comment. Add some diagnostics tests to SemaCXX/coroutines.cpp. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/CodeGen/CGCoroutine.cpp lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp te

<    1   2   3